|
I achieved this (see attached screenshot) by making the following changes:
Added a new config: $g_bug_move_status = '%bug_submit_status%';
File: bug_actiongroup_page
case 'MOVE' :
$t_question_title = lang_get( 'move_bugs_conf_msg' );
$t_button_title = lang_get( 'move_group_bugs_button' );
$t_form = 'project_id';
$t_question_title2 = lang_get( 'assign_bugs_conf_msg' );
$t_form2 = 'assign';
$t_question_title3 = lang_get( 'status_bugs_conf_msg' );
$t_form3 = 'status';
break;
...
<?php
if ( isset( $t_question_title2 ) ) {
switch ( $f_action ) {
case 'RESOLVE':
$t_show_product_version = ( ON == config_get( 'show_product_version' ) )
|| ( ( AUTO == config_get( 'show_product_version' ) )
&& ( count( version_get_all_rows( $t_project_id ) ) > 0 ) );
if ( $t_show_product_version ) {
?>
<tr class="row-2">
<td class="category">
<?php echo $t_question_title2 ?>
</td>
<td>
<select name="<?php echo $t_form2 ?>">
<?php print_version_option_list( '', null, VERSION_ALL );?>
</select>
</td>
</tr>
<?php
}
break;
case 'MOVE':
?>
<tr class="row-2">
<td class="category">
<?php echo $t_question_title2 ?>
</td>
<td>
<select name="<?php echo $t_form2 ?>">
<option value="0"></option>
<?php print_assign_to_option_list( '', ALL_PROJECTS );?>
</select>
</td>
</tr>
<?php
break;
}
}
if ( isset( $t_question_title3 ) ) {
switch ( $f_action ) {
case 'MOVE':
?>
<tr class="row-2">
<td class="category">
<?php echo $t_question_title3 ?>
</td>
<td>
<select name="<?php echo $t_form3 ?>">
<?php print_enum_string_option_list( 'status', config_get( 'bug_move_status' ) );?>
</select>
</td>
</tr>
<?php
break;
}
}
?>
File: bug_actiongroup
Instead of a switch statement checking for the value of $f_action, change this into seperate if ( $f_action == xxx ) statements. This way, you can execute the same logic for multiple actions:
if ( $f_action == 'ASSIGN' || $f_action == 'MOVE' ) {
$f_assign = gpc_get_int( 'assign' );
if ( $f_assign == NO_USER ) {
bug_assign( $t_bug_id, $f_assign, $f_bug_notetext, $f_bug_noteprivate );
} else {
if ( ON == config_get( 'auto_set_status_to_assigned' ) ) {
$t_assign_status = config_get( 'bug_assigned_status' );
} else {
$t_assign_status = $t_status;
}
check that new handler has rights to handle the issue, and
# that current user has rights to assign the issue
$t_target_project = bug_get_field( $t_bug_id, 'project_id' );
if ( $f_action == 'MOVE' ) {
$t_target_project = gpc_get_int( 'project_id' );
}
$t_threshold = access_get_status_threshold( $t_assign_status, $t_target_project );
if ( access_has_bug_level( $t_threshold , $t_bug_id, $f_assign ) &&
access_has_bug_level( config_get( 'update_bug_assign_threshold', config_get( 'update_bug_threshold' ) ), $t_bug_id ) &&
bug_check_workflow($t_status, $t_assign_status ) ) {
/* @todo we need to issue a helper_call_custom_function( 'issue_update_validate', array( $t_bug_id, $t_bug_data, $f_bugnote_text ) ); /
bug_assign( $t_bug_id, $f_assign, $f_bug_notetext, $f_bug_noteprivate );
helper_call_custom_function( 'issue_update_notify', array( $t_bug_id ) );
} else {
if ( bug_check_workflow($t_status, $t_assign_status ) ) {
$t_failed_ids[$t_bug_id] = lang_get( 'bug_actiongroup_access' );
} else {
$t_failed_ids[$t_bug_id] = lang_get( 'bug_actiongroup_status' );
}
}
}
}
...
if ( $f_action == 'UP_STATUS' || $f_action == 'MOVE' ) {
$f_status = gpc_get_int( 'status' );
$t_project = bug_get_field( $t_bug_id, 'project_id' );
if ( $f_action == 'MOVE' ) {
$t_project = gpc_get_int( 'project_id' );
}
if ( access_has_bug_level( access_get_status_threshold( $f_status, $t_project ), $t_bug_id ) ) {
if ( TRUE == bug_check_workflow($t_status, $f_status ) ) {
/* @todo we need to issue a helper_call_custom_function( 'issue_update_validate', array( $t_bug_id, $t_bug_data, $f_bugnote_text ) ); /
bug_set_field( $t_bug_id, 'status', $f_status );
# Add bugnote if supplied
if ( !is_blank( $f_bug_notetext ) ) {
bugnote_add( $t_bug_id, $f_bug_notetext, null, $f_bug_noteprivate );
}
helper_call_custom_function( 'issue_update_notify', array( $t_bug_id ) );
} else {
$t_failed_ids[$t_bug_id] = lang_get( 'bug_actiongroup_status' );
}
} else {
$t_failed_ids[$t_bug_id] = lang_get( 'bug_actiongroup_access' );
}
}
I would like to change this logic so it's more generic: instead of using
"$t_question_title2", "$t_question_title3" etc, use an array instead and add the corresponding input fields that way.
Would be great to see this added... has to be tested of course. All access checks should still be in place (eg if you try to assign the moved project to a handler who has no rights on the project it is moved to). |
