View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0020142 | mantisbt | performance | public | 2015-09-27 14:15 | 2016-08-26 01:04 |
Reporter | cproensa | Assigned To | community | ||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Target Version | 1.3.0-rc.2 | Fixed in Version | 1.3.0-rc.2 | ||
Summary | 0020142: performance loading bug view with many attachments | ||||
Description | The same issue reported here: print_api.php A new token is created for each attachment link showed. | ||||
Tags | No tags attached. | ||||
MantisBT: master 90c17a52 2016-02-19 02:09 Committer: dregad Details Diff |
Don't generate separate delete token for each attachment Added optional $p_security_token param to form_security_param() in form_api.php, just as with form_security_field(), to allow passing only the security token, and not the pregenerated form_security_param() string (suggested by @cproensa). Fixes 0020142 Signed-off-by: Damien Regad <dregad@mantisbt.org> |
Affected Issues 0020142 |
|
mod - core/form_api.php | Diff File | ||
mod - core/print_api.php | Diff File | ||
MantisBT: master 9e532d6b 2016-03-06 12:45 Committer: dregad Details Diff |
Dont use serialization for Session variables There is no need to serialize data inserted in $_SESSION, as php does it at the end of script This is a performance hit when a session key is used multiple times (eg: 'form_security_tokens') Additionally, we use a new identifier for the session key (by adding a version number to it). Since we changed the format of the stored data, this will ignore older session data to avoid errors for users having active sessions during the transition. Fixes 0020142, 0018016 Signed-off-by: Damien Regad <dregad@mantisbt.org> Squashed original commits and reworded commit message |
Affected Issues 0018016, 0020142 |
|
mod - core/session_api.php | Diff File | ||
MantisBT: master-1.3.x f160663f 2016-08-14 14:25 Committer: vboctor Details Diff |
Revert multiple tokens for attachement delete links Revert the logic introduced by fix for Issue 0020142, in which one single form security token is used for all action links. The side effect is that only one of those actions can be performed from the specific originating page. This is especially a drawback when the actions are links that can be open in new browsers tabs. Reverting to separate tokens allows to perform all the actions without having to reload the originating page. Note, the original performance issue was solved at the session layer with 8092c3d. Fixes: 0021610 |
Affected Issues 0020142, 0021610 |
|
mod - core/print_api.php | Diff File |