View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0020837 | mantisbt | mentions | public | 2016-04-21 02:35 | 2019-06-14 06:40 |
Reporter | vboctor | Assigned To | vboctor | ||
Priority | normal | Severity | feature | Reproducibility | N/A |
Status | closed | Resolution | fixed | ||
Product Version | 1.3.0-rc.1 | ||||
Target Version | 1.3.0-rc.2 | Fixed in Version | 1.3.0-rc.2 | ||
Summary | 0020837: Support @ mentions | ||||
Description | It would be useful to support @ mentions as a feature that gradually replaces reminders and provided similar behavior to @ mentions in github. To start with we should do the following:
| ||||
Tags | No tags attached. | ||||
@ mentioned users should not be added to the monitor list of the issue. The functionality of @ mentioning is similar to what we have with "Send a reminder". |
|
Regarding reminders, I would like to drop it. Was thinking we can either drop it right away, or have the page provide an explanation of using @ mentions. The addition to the monitor list was just a starting point that is consistent with send reminders to some extent. However, we can consider the following approach:
In the future, we can also add an @ mentions table, similar to monitor table. Eventually this can power features like issues where I'm mentioned (may also include contributed on as reporter, commenter or handler). How about going with option 1? |
|
My worry though is the following:
That is why reminders had this feature where mentioned users were added to the monitor list, but it was behind a configuration option. |
|
|
|
Good point. so I'll implement Option 1. Let me know if that addresses your concerns. |
|
|
|
For the record:
Reminders, in their current implementation, DO add the recipients to the monitoring list, so Victor's approach would not change the system's behavior.
I am not opposed to removing this feature, but please keep in mind that today sending a reminder is slightly different than the system sending a "normal" notification:
In other words, reminders allows authorized users to send a message to someone, even if they chose not to receive notifications from Mantis. We need to think about whether we want to keep this ability or not. |
|
I am aware of it.
Good point, that's a reason to keep reminders or at least this functionality. Maybe offer the same functionality via |
|
MantisBT: master 59970d87 2016-04-20 22:47 Details Diff |
Support @ mentions This provides the basic support for @ mentions. We can grow this feature further over time. Fixes 0020837 |
Affected Issues 0020837 |
|
mod - config_defaults_inc.php | Diff File | ||
mod - core/bug_api.php | Diff File | ||
mod - core/bugnote_api.php | Diff File | ||
add - core/mention_api.php | Diff File | ||
mod - docbook/Admin_Guide/en-US/config/misc.xml | Diff File | ||
mod - plugins/MantisCoreFormatting/MantisCoreFormatting.php | Diff File | ||
mod - tests/Mantis/AllTests.php | Diff File | ||
add - tests/Mantis/MentionTest.php | Diff File | ||
mod - tests/TestConfig.php | Diff File | ||
MantisBT: master 9c66d394 2019-06-02 06:05 Details Diff |
Revert maintenance mode in TestConfig.php For an unknown reason, commit 59970d8735dd06975c3aeabbd9ce8ba0d7593b16 (part of issue 0020837) set MANTIS_MAINTENANCE_MODE. As a consequence, it is not possible to use any database function as as part of unit tests. Since the tests added in the above-mentioned commit are also successful without maintenance mode, it makes sense to revert this change. |
Affected Issues 0020837 |
|
mod - tests/TestConfig.php | Diff File |