View Issue Details

IDProjectCategoryView StatusLast Update
0022661mantisbtauthorizationpublic2017-04-15 10:24
Reportermantisiator Assigned Toatrol  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionno change required 
Summary0022661: bug_is_closed design problem when adding new status
Description

Hi all,
I have added new status Status 1, Status 2... (following the recommandations in the documentation) with values greater than the CLOSED (90) value. I am also using the CLOSED (90) status as final status for my issues.
While testing my implementation and reviewing the coode, it appeared that the bug_is_closed function considers the bug as CLOSED as soon as its status has a value >= CLOSED (90).
Does this mean that the new status have to be added with values <= 90 ?

Note that bug_closed_status_threshold is set to CLOSED.

Thanks a lot for your comments !

TagsNo tags attached.

Activities

mantisiator

mantisiator

2017-04-04 05:11

reporter   ~0056364

In my opinion, the "CLOSED" status -if considered as final - should imply that the fucntion bug_is_closed should return true if status is = to closed_threshold and not if >=CLOSED.

mantisiator

mantisiator

2017-04-04 05:35

reporter   ~0056365

Mantis version used is 2.0.0

atrol

atrol

2017-04-04 08:30

developer   ~0056370

should return true if status is = to closed_threshold and not if >=CLOSED.

This would be wrong as bug_closed_status_threshold is not a single status (in this case, the name would be bug_closed_status), but a threshold.

Issues having status >= the threshold are treated in a special way, e.g. there are some additional right needed to change them, they are displayed in a special way, ...

Does this mean that the new status have to be added with values <= 90 ?

No,
new status values have to be added with value >= bug_closed_status_threshold if you want this special handling for the status.
New status have to be added with value < bug_closed_status_threshold if you don't want this special handling.

mantisiator

mantisiator

2017-04-04 16:44

reporter   ~0056380

Thank you very much for your answer.
I am indeed using the second use case.
I think it would be very useful to complete the admin Guide - section "Customizing Status Values" with your last statement.