0023705: `trigger_error()` should use `E_USER_ERROR` instead of `E_ERROR` - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update

0023705	mantisbt	code cleanup	public	2017-12-07 01:46	2017-12-08 21:58

Reporter	vboctor	Assigned To	vboctor
Priority	normal	Severity	minor	Reproducibility	N/A
Status	closed	Resolution	no change required
Product Version	2.9.0

Summary	0023705: `trigger_error()` should use `E_USER_ERROR` instead of `E_ERROR`
Description	Based on PHP documentation the `trigger_error()` calls should use `E_USER_ERROR`, `E_USER_WARNING`, `E_USER_DEPRECATED`, etc. We often use the error types that are reserved for the PHP runtime like `E_ERROR`, `E_WARNING`, `E_DEPRECATED`.
Tags	No tags attached.

dregad 2017-12-07 04:34 developer ~0058335 Last edited: 2017-12-07 04:35	We often use the error types that are reserved for the PHP runtime like E_ERROR, E_WARNING, E_DEPRECATED. I don't think we do... Where did you see that ? Typically, trigger_error() is called with MantisBT-specific constant `ERROR`, which maps to `E_USER_ERROR`, not `E_ERROR` [1] [1] https://github.com/mantisbt/mantisbt/blob/master/core/constant_inc.php#L50-L54

vboctor 2017-12-08 21:58 manager ~0058367	You are right. I got confused thinking that ERROR is E_ERROR.