From a039351ac2857424e4a890192d5ce96b48709ec2 Mon Sep 17 00:00:00 2001 From: Victor Boctor Date: Wed, 4 Nov 2009 19:33:20 -0800 Subject: [PATCH] Fixes #11124: The 'sticky_issues' value stored in the mantis_filter_table is not always stored correctly. --- core/filter_api.php | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/core/filter_api.php b/core/filter_api.php index 503643c..0194aa9 100644 --- a/core/filter_api.php +++ b/core/filter_api.php @@ -459,7 +459,7 @@ function filter_ensure_valid_filter( $p_filter_arr ) { $p_filter_arr[FILTER_PROPERTY_HIGHLIGHT_CHANGED] = config_get( 'default_show_changed' ); } if( !isset( $p_filter_arr[FILTER_PROPERTY_SHOW_STICKY_ISSUES] ) ) { - $p_filter_arr[FILTER_PROPERTY_SHOW_STICKY_ISSUES] = config_get( 'show_sticky_issues' ); + $p_filter_arr[FILTER_PROPERTY_SHOW_STICKY_ISSUES] = gpc_string_to_bool( config_get( 'show_sticky_issues' ) ); } if( !isset( $p_filter_arr[FILTER_PROPERTY_SORT_FIELD_NAME] ) ) { $p_filter_arr[FILTER_PROPERTY_SORT_FIELD_NAME] = "last_updated"; @@ -899,7 +899,7 @@ function filter_get_query_sort_data( &$p_filter, $p_show_sticky, $p_query_clause $t_sort_fields = explode( ',', $p_filter[FILTER_PROPERTY_SORT_FIELD_NAME] ); $t_dir_fields = explode( ',', $p_filter[FILTER_PROPERTY_SORT_DIRECTION] ); - if(( 'on' == $p_filter[FILTER_PROPERTY_SHOW_STICKY_ISSUES] ) && ( NULL !== $p_show_sticky ) ) { + if ( gpc_string_to_bool( $p_filter[FILTER_PROPERTY_SHOW_STICKY_ISSUES] ) && ( NULL !== $p_show_sticky ) ) { $p_query_clauses['order'][] = "sticky DESC"; } @@ -3722,7 +3722,7 @@ function print_filter_view_state() { function print_filter_sticky_issues() { global $t_filter; ?> - /> + />