--- install.php.orig 2011-08-29 14:51:53.730166000 +0200 +++ install.php 2011-08-29 15:27:50.870287000 +0200 @@ -165,7 +165,14 @@ if( 0 == $t_install_state ) { print_test( 'Setting Database Type', '' !== $f_db_type, true, 'database type is blank?' ); - print_test( 'Checking Database connection settings exist', ( $f_dsn !== '' || ( $f_database_name !== '' && $f_db_username !== '' && $f_hostname !== '' ) ), true, 'database connection settings do not exist?' ); + # Oracle supports binding in two ways: + # - hostname, username/password and database name + # - tns name (insert into hostname field) and username/password, database name is still empty + if ( $f_db_type == 'oci8' ) { + print_test( 'Checking Database connection settings exist', ( $f_dsn !== '' || ( $f_database_name !== '' && $f_db_username !== '' && $f_hostname !== '' ) || ( $f_database_name == '' && $f_db_username !== '' && $f_hostname !== '' ) ), true, 'database connection settings do not exist?' ); + } else { + print_test( 'Checking Database connection settings exist', ( $f_dsn !== '' || ( $f_database_name !== '' && $f_db_username !== '' && $f_hostname !== '' ) ), true, 'database connection settings do not exist?' ); + } print_test( 'Checking PHP support for database type', db_check_database_support( $f_db_type ), true, 'database is not supported by PHP. Check that it has been compiled into your server.' ); }