Search Changesets
MantisBT: master 1e6605ff 2020-12-30 00:39 Details Diff |
Merge branch 'i27796-notice-install' PR https://github.com/mantisbt/mantisbt/pull/1719 |
||
mod - admin/install.php | Diff File | ||
mod - core.php | Diff File | ||
mod - core/error_api.php | Diff File | ||
MantisBT: master 2db996b5 2020-12-30 00:36 Details Diff |
Merge remote-tracking branch 'origin/master-2.24' | ||
mod - bug_update.php | Diff File | ||
MantisBT: master 5b897ece 2020-12-29 12:51 Details Diff |
Use extract() on Revision data Makes code easier to read by using regular variables instead of multiple array dereferencings. |
||
mod - bug_revision_view_page.php | Diff File | ||
MantisBT: master 44f32dd1 2020-12-29 09:50 Details Diff |
Remove "Delete Category" button from "Edit Project Category" page Fixes 0027808 |
Affected Issues 0027808 |
|
mod - manage_proj_cat_edit_page.php | Diff File | ||
MantisBT: master 9322c8c9 2020-12-29 05:02 Details Diff |
Per-project cache of view_bug_threshold As suggested by @vboctor during review, the threshold can be different in each project, so we need to check them individually. Fixes 0027727 |
Affected Issues 0027727 |
|
mod - bug_actiongroup_page.php | Diff File | ||
MantisBT: master 35fdf034 2020-12-29 04:33 Details Diff |
Only lookup the version when changed As suggested by @vboctor during review, there is no point in checking the version if it has not been modified. Issue 0027363 |
Affected Issues 0027363 |
|
mod - bug_update.php | Diff File | ||
MantisBT: master 515b9bd3 2020-12-28 23:21 Details Diff |
Perf: move function call out of for loop | ||
mod - core/print_api.php | Diff File | ||
MantisBT: master b1bc2211 2020-12-28 21:55 translatewiki.net Details Diff |
Localisation updates from https://translatewiki.net. | ||
mod - lang/strings_afrikaans.txt | Diff File | ||
mod - lang/strings_amharic.txt | Diff File | ||
mod - lang/strings_arabic.txt | Diff File | ||
mod - lang/strings_arabicegyptianspoken.txt | Diff File | ||
mod - lang/strings_belarusian_tarask.txt | Diff File | ||
mod - lang/strings_breton.txt | Diff File | ||
mod - lang/strings_bulgarian.txt | Diff File | ||
mod - lang/strings_catalan.txt | Diff File | ||
mod - lang/strings_chinese_simplified.txt | Diff File | ||
mod - lang/strings_chinese_traditional.txt | Diff File | ||
mod - lang/strings_czech.txt | Diff File | ||
mod - lang/strings_danish.txt | Diff File | ||
mod - lang/strings_dutch.txt | Diff File | ||
mod - lang/strings_estonian.txt | Diff File | ||
mod - lang/strings_finnish.txt | Diff File | ||
mod - lang/strings_french.txt | Diff File | ||
mod - lang/strings_galician.txt | Diff File | ||
mod - lang/strings_georgian.txt | Diff File | ||
mod - lang/strings_german.txt | Diff File | ||
mod - lang/strings_greek.txt | Diff File | ||
mod - lang/strings_hebrew.txt | Diff File | ||
mod - lang/strings_hungarian.txt | Diff File | ||
mod - lang/strings_icelandic.txt | Diff File | ||
mod - lang/strings_interlingua.txt | Diff File | ||
mod - lang/strings_italian.txt | Diff File | ||
mod - lang/strings_japanese.txt | Diff File | ||
mod - lang/strings_korean.txt | Diff File | ||
mod - lang/strings_lithuanian.txt | Diff File | ||
mod - lang/strings_macedonian.txt | Diff File | ||
mod - lang/strings_norwegian_bokmal.txt | Diff File | ||
mod - lang/strings_occitan.txt | Diff File | ||
mod - lang/strings_persian.txt | Diff File | ||
mod - lang/strings_polish.txt | Diff File | ||
mod - lang/strings_portuguese_brazil.txt | Diff File | ||
mod - lang/strings_portuguese_standard.txt | Diff File | ||
mod - lang/strings_ripoarisch.txt | Diff File | ||
mod - lang/strings_romanian.txt | Diff File | ||
mod - lang/strings_russian.txt | Diff File | ||
mod - lang/strings_serbian.txt | Diff File | ||
mod - lang/strings_serbian_latin.txt | Diff File | ||
mod - lang/strings_slovak.txt | Diff File | ||
mod - lang/strings_spanish.txt | Diff File | ||
mod - lang/strings_swedish.txt | Diff File | ||
mod - lang/strings_swissgerman.txt | Diff File | ||
mod - lang/strings_tagalog.txt | Diff File | ||
mod - lang/strings_turkish.txt | Diff File | ||
mod - lang/strings_ukrainian.txt | Diff File | ||
mod - lang/strings_vietnamese.txt | Diff File | ||
mod - plugins/XmlImportExport/lang/strings_italian.txt | Diff File | ||
MantisBT: master e5a44f81 2020-12-28 14:22 Details Diff |
BugData::_set() handle eta as int The eta field was not included in the switch, so was dealt with by the default case and treated as string while it is in fact an enum and should be handled as int. Issue 0027351 |
Affected Issues 0027351 |
|
mod - core/bug_api.php | Diff File | ||
MantisBT: master-2.24 65567e0d 2020-12-28 13:41 Details Diff |
Properly check access level when updating issues Commit bf1f02f71a85bd4e05cd2a627b3c25e79f96d5a0 (issues 0021393, 0022093) introduced a bug in the access level check, as it passed the threshold as a string to access_ensure_bug_level() instead of its actual value. This seemed to work in PHP < 8.0, because string comparisons behaved differently [[1]], but in reality there was no actual access check, as the strings were evaluated to 0 (ANYBODY). Adding the missing config_get() call to fix the access level check. Fixes 0027806 [1]: https://www.php.net/releases/8.0/en.php#consistent-type-errors-for-internal-functions |
Affected Issues 0021393, 0022093, 0027806 |
|
mod - bug_update.php | Diff File | ||
MantisBT: master 8845afba 2020-12-27 03:17 Details Diff |
Remove Project Info page and associated configuration option Fixes 0027802 |
Affected Issues 0027802 |
|
mod - config_defaults_inc.php | Diff File | ||
mod - lang/strings_english.txt | Diff File | ||
rm - project_page.php | Diff | ||
MantisBT: master 793fb027 2020-12-24 06:48 Details Diff |
Code cleanup: fix PHPStorm warnings core.php - undeclared variables - include file not found - function argument matching default value install.php - Undeclared variables - Missing labels for HTML form input elements - Variable always true |
||
mod - admin/install.php | Diff File | ||
mod - core.php | Diff File | ||
MantisBT: master a2628c71 2020-12-24 05:28 Details Diff |
Properly deal with "no-op" (null) upgrade steps The current code throws SYSTEM WARNINGs when processing them, as it tries to dereference the schema step as an array while its value is actually null. Fixes 0027800 |
Affected Issues 0027800 |
|
mod - admin/install.php | Diff File | ||
MantisBT: master-2.24 4795a394 2020-12-24 05:28 Details Diff |
Properly deal with "no-op" (null) upgrade steps The current code throws SYSTEM WARNINGs when processing them, as it tries to dereference the schema step as an array while its value is actually null. Fixes 0027800 (cherry picked from commit a2628c71c9d50d45eb0da54f8bee48af2358bb11) |
Affected Issues 0027800 |
|
mod - admin/install.php | Diff File | ||
MantisBT: master 328f2208 2020-12-24 05:10 Details Diff |
Prevent system warning when creating config_inc.php Due to the same root cause as issue 0027796, the `@` operator does not suppress the error. Instead of suppressing the error, check whether the parent directory is writable before calling fopen(). |
Affected Issues 0027796 |
|
mod - admin/install.php | Diff File | ||
MantisBT: master-2.24 a0566d03 2020-12-24 03:34 Details Diff |
PHP8-compatible check for suppressed errors Update error_handler() to correctly deal with `@` operator, as per https://www.php.net/manual/en/migration80.incompatible.php Fixes 0027799 (cherry picked from commit 67e707ea72277dfcedeacf065d450e8c99810f95) |
Affected Issues 0027799 |
|
mod - core/error_api.php | Diff File | ||
MantisBT: master 67e707ea 2020-12-24 03:34 Details Diff |
PHP8-compatible check for suppressed errors Update error_handler() to correctly deal with `@` operator, as per https://www.php.net/manual/en/migration80.incompatible.php Fixes 0027799 |
Affected Issues 0027799 |
|
mod - core/error_api.php | Diff File | ||
MantisBT: master de1679d5 2020-12-23 07:57 Details Diff |
Improve timezone setting logic Previously, core.php tried to set the default timezone to the value stored in global configuration, with error suppression. Due to [[1]], this does not actually prevent the notice from appearing with PHP 8. Refactored the code to get the system's default time zone if it is not defined in configuration. A PHP notice is still thrown if the specified timezone is not valid, as documented in the code. Also, since PHP 5.4, date_default_timezone_get() no longer throws a warning so the '@' operator is not needed anymore. Fixes 0027796 [1]: https://bugs.php.net/bug.php?id=80548 |
Affected Issues 0027796 |
|
mod - core.php | Diff File | ||
MantisBT: master 702488e6 2020-12-22 02:59 translatewiki.net Details Diff |
Localisation updates from https://translatewiki.net. | ||
mod - lang/strings_arabic.txt | Diff File | ||
mod - lang/strings_arabicegyptianspoken.txt | Diff File | ||
mod - lang/strings_breton.txt | Diff File | ||
mod - lang/strings_catalan.txt | Diff File | ||
mod - lang/strings_chinese_simplified.txt | Diff File | ||
mod - lang/strings_chinese_traditional.txt | Diff File | ||
mod - lang/strings_czech.txt | Diff File | ||
mod - lang/strings_french.txt | Diff File | ||
mod - lang/strings_hebrew.txt | Diff File | ||
mod - lang/strings_luxembourgish.txt | Diff File | ||
mod - lang/strings_macedonian.txt | Diff File | ||
mod - lang/strings_persian.txt | Diff File | ||
mod - lang/strings_qqq.txt | Diff File | ||
mod - lang/strings_russian.txt | Diff File | ||
mod - lang/strings_swissgerman.txt | Diff File | ||
mod - lang/strings_turkish.txt | Diff File | ||
MantisBT: master-2.24 5d737c63 2020-12-19 07:52 Details Diff |
Removed unused 's_in_project' language string | ||
mod - lang/strings_afrikaans.txt | Diff File | ||
mod - lang/strings_arabic.txt | Diff File | ||
mod - lang/strings_arabicegyptianspoken.txt | Diff File | ||
mod - lang/strings_asturian.txt | Diff File | ||
mod - lang/strings_basque.txt | Diff File | ||
mod - lang/strings_belarusian_tarask.txt | Diff File | ||
mod - lang/strings_breton.txt | Diff File | ||
mod - lang/strings_bulgarian.txt | Diff File | ||
mod - lang/strings_catalan.txt | Diff File | ||
mod - lang/strings_chinese_simplified.txt | Diff File | ||
mod - lang/strings_chinese_traditional.txt | Diff File | ||
mod - lang/strings_czech.txt | Diff File | ||
mod - lang/strings_danish.txt | Diff File | ||
mod - lang/strings_dutch.txt | Diff File | ||
mod - lang/strings_eo.txt | Diff File | ||
mod - lang/strings_estonian.txt | Diff File | ||
mod - lang/strings_finnish.txt | Diff File | ||
mod - lang/strings_french.txt | Diff File | ||
mod - lang/strings_galician.txt | Diff File | ||
mod - lang/strings_georgian.txt | Diff File | ||
mod - lang/strings_german.txt | Diff File | ||
mod - lang/strings_greek.txt | Diff File | ||
mod - lang/strings_hebrew.txt | Diff File | ||
mod - lang/strings_hungarian.txt | Diff File | ||
mod - lang/strings_icelandic.txt | Diff File | ||
mod - lang/strings_interlingua.txt | Diff File | ||
mod - lang/strings_italian.txt | Diff File | ||
mod - lang/strings_japanese.txt | Diff File | ||
mod - lang/strings_korean.txt | Diff File | ||
mod - lang/strings_lithuanian.txt | Diff File | ||
mod - lang/strings_luxembourgish.txt | Diff File | ||
mod - lang/strings_macedonian.txt | Diff File | ||
mod - lang/strings_norwegian_bokmal.txt | Diff File | ||
mod - lang/strings_occitan.txt | Diff File | ||
mod - lang/strings_persian.txt | Diff File | ||
mod - lang/strings_polish.txt | Diff File | ||
mod - lang/strings_portuguese_brazil.txt | Diff File | ||
mod - lang/strings_portuguese_standard.txt | Diff File | ||
mod - lang/strings_ripoarisch.txt | Diff File | ||
mod - lang/strings_romanian.txt | Diff File | ||
mod - lang/strings_russian.txt | Diff File | ||
mod - lang/strings_serbian.txt | Diff File | ||
mod - lang/strings_serbian_latin.txt | Diff File | ||
mod - lang/strings_skr-arab.txt | Diff File | ||
mod - lang/strings_slovak.txt | Diff File | ||
mod - lang/strings_spanish.txt | Diff File | ||
mod - lang/strings_swedish.txt | Diff File | ||
mod - lang/strings_swissgerman.txt | Diff File | ||
mod - lang/strings_tagalog.txt | Diff File | ||
mod - lang/strings_turkish.txt | Diff File | ||
mod - lang/strings_ukrainian.txt | Diff File | ||
mod - lang/strings_urdu.txt | Diff File | ||
mod - lang/strings_vietnamese.txt | Diff File | ||
mod - lang/strings_volapuk.txt | Diff File | ||
MantisBT: master-2.24 6c3482d0 2020-12-19 07:50 Details Diff |
Use parameterized string for confirmation messages Previously, the confirmation message was built manually in several places throughout the code, concatenating strings with variables. We now use a string with parameters, which is fed to sprintf prior to display. This gives translators more control to over the final message, and allows removing now-unused $s_in_project string. Updated strings: - $s_confirm_custom_field_deletion - $s_confirm_used_custom_field_deletion - $s_confirm_custom_field_unlinking - $s_config_delete_sure - $s_confirm_file_delete_msg - $s_delete_account_sure_msg - $s_query_delete_msg - $s_remove_user_sure_msg - $s_version_delete_sure Issue 0027779 |
Affected Issues 0027779 |
|
mod - lang/strings_english.txt | Diff File | ||
mod - manage_config_revert.php | Diff File | ||
mod - manage_custom_field_delete.php | Diff File | ||
mod - manage_filter_delete.php | Diff File | ||
mod - manage_proj_custom_field_remove.php | Diff File | ||
mod - manage_proj_user_remove.php | Diff File | ||
mod - manage_proj_ver_delete.php | Diff File | ||
mod - manage_user_delete.php | Diff File | ||
mod - manage_user_proj_delete.php | Diff File | ||
mod - proj_doc_delete.php | Diff File | ||
MantisBT: master f6502be6 2020-12-19 07:27 Details Diff |
Prevent XSS in helper_ensure_confirmed() calls When the confirmation message references user-provided data, it needs to be escaped prior to calling the function. Fixes 0027779, CVE-2020-35571 |
Affected Issues 0027779 |
|
mod - manage_config_revert.php | Diff File | ||
mod - manage_custom_field_update.php | Diff File | ||
mod - manage_filter_delete.php | Diff File | ||
mod - manage_proj_user_remove.php | Diff File | ||
mod - manage_user_delete.php | Diff File | ||
mod - manage_user_proj_delete.php | Diff File | ||
MantisBT: master-2.24 f6502be6 2020-12-19 07:27 Details Diff |
Prevent XSS in helper_ensure_confirmed() calls When the confirmation message references user-provided data, it needs to be escaped prior to calling the function. Fixes 0027779, CVE-2020-35571 |
Affected Issues 0027779 |
|
mod - manage_config_revert.php | Diff File | ||
mod - manage_custom_field_update.php | Diff File | ||
mod - manage_filter_delete.php | Diff File | ||
mod - manage_proj_user_remove.php | Diff File | ||
mod - manage_user_delete.php | Diff File | ||
mod - manage_user_proj_delete.php | Diff File | ||
MantisBT: master 100c3d58 2020-12-19 07:06 Details Diff |
Improve Project delete confirmation message The 'project_delete_msg' string now includes the bug count in addition to the Project's name. New Project API function project_get_bug_count() returns the number of issues associated to the given project. Fixes 0027768 |
Affected Issues 0027768 |
|
mod - core/project_api.php | Diff File | ||
mod - lang/strings_english.txt | Diff File | ||
mod - manage_proj_delete.php | Diff File | ||
MantisBT: master 09886c87 2020-12-19 05:30 Details Diff |
Removed unused variables | ||
mod - bug_revision_view_page.php | Diff File |