View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0024441 | mantisbt | tagging | public | 2018-05-17 11:21 | 2019-08-25 12:36 |
Reporter | intuity | Assigned To | dregad | ||
Priority | normal | Severity | major | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 2.14.0 | ||||
Target Version | 2.22.0 | Fixed in Version | 2.22.0 | ||
Summary | 0024441: Report issue doesn't support multiple new tags | ||||
Description | When reporting an issue, if you provide multiple new tags within the tag field separated by commas the bug will be created but an error will be displayed and the tags won't be attached. However, if using the tag field in the bug view multiple tags can be added without issue. This seems to come down to the fact that tags added retrospectively use the TagAttachCommand, whilst tags added during bug creation use code inline in the IssueAddCommand that is fair less capable. I would suggest updating IssueAddCommand at line 333 onwards to the following code:
Other changes need to be made to support this. In
And
NOTE: Even though an error is displayed and no tags were attached, the issue is still created as the bug is created first - then tagged. Perhaps there needs to be some additional checking to ensure tags can be assigned before creating the issue. | ||||
Steps To Reproduce |
Bug is created, bug tag attachment fails, so error message displayed. | ||||
Tags | No tags attached. | ||||
@intuity thanks for the detailed bug report and proposed fix. I noticed this is not the first time (0024437) that you suggest code changes via the bugtracker like this. To make it easier for us to review, test and merge such changes, would you consider submitting your patches as pull requests via Github instead ?
You're absolutely right. For the record, the same problem exists also when adding attachments fails for any reason - see 0003759. As per the discussion there, the solution is not as simple as adding some checks. |
|
@dregad will do - I'll try to build a patch for the above and make a request on GitHub. |
|
MantisBT: master 38a067f2 2019-08-24 17:32 Details Diff |
Print 'separate by' on tag attach form Issue 0024441 |
Affected Issues 0024441 |
|
mod - core/print_api.php | Diff File | ||
MantisBT: master 1e5e25a8 2019-08-24 17:35 Details Diff |
TODO: replace mci_tag_set_for_issue() with TagAttachCommand As suggested in issue 0024441 |
Affected Issues 0024441 |
|
mod - core/commands/IssueAddCommand.php | Diff File | ||
MantisBT: master 6b774eac 2019-08-24 17:58 Details Diff |
IssueAddCommand fixes This addresses several issues with the Command and the REST API: - 0025996 - Missing tag name in error message when creating issue via REST API - 0025997 - Invalid JSON response when creating issue with tag by name via REST API - 0026076 - Adding issue via REST API should fail if requested tags can't be attached - 0026077 - create tag specified by name if they do not exist Additionally, this also fixes 0024441. Merge PR https://github.com/mantisbt/mantisbt/pull/1542 |
Affected Issues 0024441 |
|
mod - api/soap/mc_tag_api.php | Diff File | ||
mod - bug_report.php | Diff File | ||
mod - core/commands/IssueAddCommand.php | Diff File |