Changesets: MantisBT

Search Browse Back to Index

master 7e76c6b7

2024-02-21 18:37

dregad


Details Diff		 Fix assertObjectHasAttribute() is deprecated

Replace usage by assertObjectHasProperty().

Same thing for assertObjectNotHasAttribute(), replaced by
assertObjectNotHasProperty()
mod - tests/soap/FilterTest.php Diff File
mod - tests/soap/RelationshipTest.php Diff File

master 7d187adc

2024-02-21 18:33

dregad


Details Diff		 Fix assertRegExp() is deprecated

Replace usage by assertMatchesRegularExpression().
mod - tests/soap/AttachmentTest.php Diff File
mod - tests/soap/LoginTest.php Diff File

master 981d8d99

2024-02-21 18:23

dregad


Details Diff		 Fix Expecting E_ERROR and E_USER_ERROR is deprecated

Expecting E_ERROR and E_USER_ERROR is deprecated and will no longer be
possible in PHPUnit 10.

helper_array_transpose() now throws a ClientException instead of calling
trigger_error() when detecting a non-bidimensional array.

Adapt HelperTest::testArrayTransposeInvalid() to handle the exception
instead of E_USER_ERROR.
mod - core/helper_api.php Diff File
mod - tests/Mantis/HelperTest.php Diff File

master ee5194fe

2024-02-21 17:48

dregad


Details Diff		 Fix PHPUnit deprecation warnings

- Abstract test case classes with "Test" suffix are deprecated
- Test case class not matching filename is deprecated
mod - tests/Mantis/ConfigParserTest.php Diff File
mod - tests/Mantis/HelperTest.php Diff File
mv - tests/Mantis/EnumTest.php → tests/Mantis/MantisEnumTest.php Diff File
mod - tests/Mantis/PluginTest.php Diff File
mod - tests/Mantis/PrepareTest.php Diff File
mod - tests/Mantis/StringTest.php Diff File
mv - tests/Mantis/UserTest.php → tests/Mantis/UserApiTest.php Diff File
mod - tests/rest/RestImpersonateUserTest.php Diff File
mod - tests/rest/RestUserTest.php Diff File

master e238195e

2024-02-21 17:05

dregad


Details Diff		 Composer update

Running `composer update -W phpunit/phpunit`

- Removing phpunit/php-token-stream (4.0.4)
- Upgrading sebastian/version (2.0.1 => 3.0.2)
- Upgrading sebastian/type (1.1.4 => 3.2.1)
- Upgrading sebastian/resource-operations (2.0.2 => 3.0.3)
- Upgrading sebastian/recursion-context (3.0.1 => 4.0.5)
- Upgrading sebastian/object-reflector (1.1.2 => 2.0.4)
- Upgrading sebastian/object-enumerator (3.0.4 => 4.0.4)
- Upgrading sebastian/global-state (3.0.3 => 5.0.6)
- Upgrading sebastian/exporter (3.1.5 => 4.0.5)
- Upgrading sebastian/environment (4.2.4 => 5.1.5)
- Upgrading sebastian/diff (3.0.4 => 4.0.5)
- Upgrading sebastian/comparator (3.0.5 => 4.0.8)
- Installing sebastian/code-unit (1.0.8)
- Installing sebastian/cli-parser (1.0.1)
- Upgrading phpunit/php-timer (2.1.3 => 5.0.3)
- Upgrading phpunit/php-text-template (1.2.1 => 2.0.4)
- Installing phpunit/php-invoker (3.1.1)
- Upgrading phpunit/php-file-iterator (2.0.5 => 3.0.6)
- Upgrading theseer/tokenizer (1.2.1 => 1.2.2)
- Installing nikic/php-parser (v5.0.1)
- Installing sebastian/lines-of-code (1.0.4)
- Installing sebastian/complexity (2.0.3)
- Upgrading sebastian/code-unit-reverse-lookup (1.0.2 => 2.0.3)
- Upgrading phpunit/php-code-coverage (7.0.15 => 9.2.30)
- Upgrading phpunit/phpunit (8.5.34 => 9.6.16)
mod - composer.lock Diff File

master d58e13d3

2024-02-20 19:34

dregad


Details Diff		 Merge branch 'master-2.26'
mod - build/travis_before_script.sh Diff File

master-2.26 0e4e6e3c

2024-02-20 19:30

dregad


Details Diff		 Travis: fix builds timing out

Since merge of GHSA-mcqj-7p29-9528 (7055731d09ff12b2781410a372f790172e279744),
the builds are timing out during travis_before_script.sh "MantisBT
Installation" step, because curl is not returning any output.

This is due to to introduction of the new path parameter.

Setting it to the actual URL `http://$HOSTNAME:$PORT/` does not work, so
we use a blank path.

Fixes 0033791

(cherry picked from commit cd2cf5b3f99b67668bba667e7f918c7a49f04969)		 Affected Issues
0033791
mod - build/travis_before_script.sh Diff File

master 4024da02

2024-02-20 16:25

dregad


Details Diff		 Merge tag 'release-2.26.1'

Stable release 2.26.1

# Conflicts:
# config_defaults_inc.php
# core/constant_inc.php
mod - admin/check/check_paths_inc.php Diff File
mod - admin/install.php Diff File
mod - config_defaults_inc.php Diff File
mod - core.php Diff File
mod - doc/CREDITS Diff File
mod - docbook/Admin_Guide/en-US/config/path.xml Diff File
mod - js/install.js Diff File
mod - lang/strings_english.txt Diff File
mod - login_page.php Diff File

release-2.26.1 b8778103

2024-02-20 16:14

dregad


Details Diff		 Bump version to 5.26.1
mod - core/constant_inc.php Diff File

release-2.26.1 ba4e14ce

2024-02-20 16:13

dregad


Details Diff		 Update Credits
mod - doc/CREDITS Diff File

master-2.26 7055731d

2024-02-20 16:10

dregad

Committer: community


Details Diff		 Merge pull request from GHSA-mcqj-7p29-9528

* Address host header injection vulnerability

$g_path is empty by default, and should be defined in config_inc.php.
Not doing so is a security risk, as the path will then be set based on
headers from the HTTP request, exposing the system to Host Header
injection attacks.

Document the risk in PHPDoc and Admin Guide.

Move the code that initializes $g_path's default value from
config_defaults_inc.php to a function in core.php.

Detect if $g_path was defaulted, and if yes alert the user in:
- Login Page (if $g_admin_checks == ON)
- Admin Checks

Fixes 0019381, CVE-2024-23830, GHSA-mcqj-7p29-9528

* Remove dead code

* Use OWASP as reference for host header injection

* Link to OWASP reference page from admin guide

* Invalid $g_path at install time is a hard fail

Empty $g_path remains just a warning about the security risk.
Request and set $g_path at install time

This is an improvement on the original patch for CVE-2024-23830.

The admin is now able to set $g_path when installing MantisBT. A default
value is provided, based on the URL used to perform the installation
(using the same logic that is applied when $g_path is empty).

A check of the provided URL is performed during install stage 2, and an
error is reported if it is invalid. If an empty $g_path is given, then
we only display a warning about the security risk.

The URL is then stored as $g_path in the generated config_inc.php file
at stage 5.

This greatly reduces the risk of the admin forgetting to set $g_path
manually, while still allowing them to set it to empty should they want
to.

Fixes 0019381

* Add Reset button to path input

Reuse the existing functionality implemented for database prefix/suffix,
with the following changes

- Rename `reset-prefix` selector class to `reset` to be more generic
- Add Reset functionality markup to path input including default value
- Add title attribute to Reset buttons
- Adapt initialization logic to only set the default value for the
table-prefix fields		 Affected Issues
0019381
mod - admin/check/check_paths_inc.php Diff File
mod - admin/install.php Diff File
mod - config_defaults_inc.php Diff File
mod - core.php Diff File
mod - docbook/Admin_Guide/en-US/config/path.xml Diff File
mod - js/install.js Diff File
mod - lang/strings_english.txt Diff File
mod - login_page.php Diff File

master a254b244

2024-02-19 19:08

atrol

Committer: community


Details Diff		 Revert unrelated changes to prevent a regression

Changes for issue 0033521 introduce a regression.
Without undoing, we will get again issue 0032459.		 Affected Issues
0032459, 0033521
mod - plugins/MantisGraph/MantisGraph.php Diff File

master a16fa867

2024-02-19 18:30

dregad


Details Diff		 Always consider Category 0 as enabled

Fixes a regression introduced by e3f572c0f9dd8e1820d76df23281a99e07636bea.

APPLICATION ERROR 1502 (Category not found) prevents editing an issue
without a category.

Issue 0031017		 Affected Issues
0031017
mod - core/category_api.php Diff File

master 0ed7aec5

2024-02-19 17:41

dregad


Details Diff		 Merge branch 'master-2.26'
mod - core/commands/MonitorAddCommand.php Diff File

master-2.26 2e1c8148

2024-02-19 17:39

atrol

Committer: community


Details Diff		 Fix add monitor regressions

Fixes 0033404		 Affected Issues
0033404
mod - core/commands/MonitorAddCommand.php Diff File

master 4a4c7527

2024-02-19 07:08

translatewiki.net


Details Diff		 Localisation updates from https://translatewiki.net. [skip ci]
mod - plugins/MantisGraph/lang/strings_chinese_traditional.txt Diff File
mod - plugins/MantisGraph/lang/strings_french.txt Diff File
mod - plugins/MantisGraph/lang/strings_macedonian.txt Diff File

master c03fa0c8

2024-02-18 18:36

dregad


Details Diff		 Fix active tab following change of default graph

Before introduction of the By Projects graphs, the Graphs menu was
opening the By Developers graph by default.

Since the default was changed to By Projects, it needs to be reflected
in all graph scripts to ensure the Graphs tab is shown as active.

Fixes 0033521		 Affected Issues
0033521
mod - plugins/MantisGraph/pages/category_graph.php Diff File
mod - plugins/MantisGraph/pages/developer_graph.php Diff File
mod - plugins/MantisGraph/pages/issues_trend_graph.php Diff File
mod - plugins/MantisGraph/pages/priority_graph.php Diff File
mod - plugins/MantisGraph/pages/project_graph.php Diff File
mod - plugins/MantisGraph/pages/reporter_graph.php Diff File
mod - plugins/MantisGraph/pages/resolution_graph.php Diff File
mod - plugins/MantisGraph/pages/severity_graph.php Diff File
mod - plugins/MantisGraph/pages/status_graph.php Diff File

master c0ac7ecf

2024-02-18 17:46

dregad


Details Diff		 Allow disabling Categories

PR https://github.com/mantisbt/mantisbt/pull/1853
mod - admin/schema.php Diff File
mod - api/soap/mantisconnect.wsdl Diff File
mod - api/soap/mc_api.php Diff File
mod - api/soap/mc_project_api.php Diff File
mod - bug_actiongroup_page.php Diff File
mod - bug_report_page.php Diff File
mod - bug_update_page.php Diff File
mod - bug_view_inc.php Diff File
mod - core/category_api.php Diff File
mod - core/constant_inc.php Diff File
mod - core/install_helper_functions_api.php Diff File
mod - core/print_api.php Diff File
mod - lang/strings_arabic.txt Diff File
mod - lang/strings_belarusian_tarask.txt Diff File
mod - lang/strings_breton.txt Diff File
mod - lang/strings_bulgarian.txt Diff File
mod - lang/strings_catalan.txt Diff File
mod - lang/strings_chinese_simplified.txt Diff File
mod - lang/strings_chinese_traditional.txt Diff File
mod - lang/strings_czech.txt Diff File
mod - lang/strings_danish.txt Diff File
mod - lang/strings_dutch.txt Diff File
mod - lang/strings_english.txt Diff File
mod - lang/strings_french.txt Diff File
mod - lang/strings_galician.txt Diff File
mod - lang/strings_german.txt Diff File
mod - lang/strings_hebrew.txt Diff File
mod - lang/strings_hungarian.txt Diff File
mod - lang/strings_icelandic.txt Diff File
mod - lang/strings_interlingua.txt Diff File
mod - lang/strings_italian.txt Diff File
mod - lang/strings_japanese.txt Diff File
mod - lang/strings_korean.txt Diff File
mod - lang/strings_lithuanian.txt Diff File
mod - lang/strings_macedonian.txt Diff File
mod - lang/strings_norwegian_bokmal.txt Diff File
mod - lang/strings_occitan.txt Diff File
mod - lang/strings_polish.txt Diff File
mod - lang/strings_portuguese_brazil.txt Diff File
mod - lang/strings_portuguese_standard.txt Diff File
mod - lang/strings_romanian.txt Diff File
mod - lang/strings_russian.txt Diff File
mod - lang/strings_serbian.txt Diff File
mod - lang/strings_serbian_latin.txt Diff File
mod - lang/strings_slovak.txt Diff File
mod - lang/strings_spanish.txt Diff File
mod - lang/strings_swedish.txt Diff File
mod - lang/strings_swissgerman.txt Diff File
mod - lang/strings_tagalog.txt Diff File
mod - lang/strings_turkish.txt Diff File
mod - lang/strings_ukrainian.txt Diff File
mod - lang/strings_vietnamese.txt Diff File
mod - manage_proj_cat_edit_page.php Diff File
mod - manage_proj_cat_update.php Diff File
mod - manage_proj_edit_page.php Diff File
mod - manage_proj_page.php Diff File
mod - plugins/XmlImportExport/pages/import.php Diff File

master 7abd1309

2024-02-18 17:24

dregad


Details Diff		 Refactor mc_project_api.php

- Improve PHPDoc
- Fix static analysis warnings
- Introduce new functions to avoid code duplication
- mci_project_get_row()
- mci_project_get_versions()
- mci_project_initial_checks()

Fixes 0033774, PR https://github.com/mantisbt/mantisbt/pull/1970		 Affected Issues
0033774
mod - api/soap/mc_api.php Diff File
mod - api/soap/mc_project_api.php Diff File

master 4dc35ad5

2024-02-18 11:40

dregad


Details Diff		 Merge branch 'master-2.26'
mod - admin/install.php Diff File
mod - core.php Diff File
mod - css/ace-mantis.css Diff File

master-2.26 e50fb20d

2024-02-18 11:31

dregad


Details Diff		 Fix overflowing text in sidebar menu

Addresses 2 distinct issues:
- collapsed menu
- expanded menu with resolutions < 992px

Fixes 0033651, PR https://github.com/mantisbt/mantisbt/pull/1969		 Affected Issues
0033651
mod - css/ace-mantis.css Diff File

master-2.26 1f1c88d7

2024-02-18 06:20

dregad


Details Diff		 Fix overflowing text in expanded sidebar menu

Use `min-width` attribute instead of `width` for non-minimized .sidebar
in resolutions < 992px.
mod - css/ace-mantis.css Diff File

master-2.26 4b54f872

2024-02-18 06:04

dregad


Details Diff		 Move menu-text overflow fix out of @media section

This way the change also applies in responsive mode for smaller
resolutions.
mod - css/ace-mantis.css Diff File

master-2.26 e1396d1c

2024-02-18 06:03

dregad


Details Diff		 Remove min-width
mod - css/ace-mantis.css Diff File

master-2.26 fe630faf

2024-02-18 04:07

dregad


Details Diff		 Install: reset button does not work at stage 2

This was caused by the install.js scripts only being loaded at stage 1.

Fixes 0026664		 Affected Issues
0026664, 0033773
mod - admin/install.php Diff File
 First  Prev  1 2 3 4 5 6 7 ... 70 ... 140 ... 210 ... 280 ... 350 ... 420 ... 490 ... 560 ... 630 ... 700 ... 704 705 706  Next  Last