Source Control Integration

MantisBT: master 9697d175 2015-11-11 08:50:51 atrol Details Diff	Remove unused parameter $p_user from function string_get_bug_report_url	Attach Issues:
	mod - core/string_api.php	Diff File
MantisBT: master ba521a9f 2015-11-11 08:41:55 atrol Details Diff	Remove unused parameter $p_user from function string_get_bug_report_page	Attach Issues:
	mod - core/string_api.php	Diff File
MantisBT: master 104fee71 2015-11-10 16:47:55 atrol Details Diff	Remove unused local variables	Attach Issues:
	mod - core/html_api.php	Diff File
	mod - core/print_api.php	Diff File
MantisBT: master a0c0645a 2015-11-10 15:21:30 atrol Details Diff	Remove unused parameter $p_user_id from function string_get_bug_view_link	Attach Issues:
	mod - core/print_api.php	Diff File
	mod - core/string_api.php	Diff File
MantisBT: master c4724f65 2015-11-10 15:10:19 atrol Details Diff	Remove unused parameter $p_user_id from function string_get_bug_page	Attach Issues:
	mod - core/string_api.php	Diff File
MantisBT: master 38474adc 2015-11-10 14:58:20 atrol Details Diff	Remove unused parameter $p_password from function email_signup	Attach Issues:
	mod - core/email_api.php	Diff File
	mod - core/user_api.php	Diff File
MantisBT: master 8cec63bf 2015-11-10 14:53:12 atrol Details Diff	Remove unused local variables	Attach Issues:
	mod - api/soap/mc_filter_api.php	Diff File
	mod - api/soap/mc_issue_api.php	Diff File
	mod - api/soap/mc_project_api.php	Diff File
	mod - core/bug_group_action_api.php	Diff File
	mod - core/file_api.php	Diff File
MantisBT: master fddd8313 2015-11-10 14:20:15 atrol Details Diff	Correct wrong call of function mci_issue_data_as_header_array	Attach Issues:
	mod - api/soap/mc_issue_api.php	Diff File
MantisBT: master 455c4993 2015-11-08 18:06:44 dregad Details Diff	Add filename + line number info to inline errors Fixes 0020554	Affected Issues 0020554
	mod - core/error_api.php	Diff File
MantisBT: master 7f997e87 2015-11-05 15:03:40 cproensa Details Diff	Cache reporter user data in view_all_bug_page Add the reporter id to the array of users to be cached from the bug filter result. This saves later individual sql queries from user_cache_row() Changed the temporary arrays to be associative indexed by id, so we don't need to call 'array_unqiue' later. Fixes 0020258 Signed-off-by: Damien Regad <dregad@mantisbt.org>	Affected Issues 0020258
	mod - view_all_bug_page.php	Diff File
MantisBT: master f82565ae 2015-11-04 16:52:59 cproensa Details Diff	Dont use token for manage_proj_edit_page The destination page does not verify form tokens, so call print_button() with the token parameter OFF. Issue 0020242	Affected Issues 0020242
	mod - manage_proj_edit_page.php	Diff File
MantisBT: master c596d45b 2015-11-04 16:39:31 cproensa Details Diff	Dont create multiple tokens for buttons Call print_button() with a previously created token which is reutilized for all buttons. Previously, for each button a new token was created, which is a expensive operation that read/writes session variables repeated times. Issue 0020242	Affected Issues 0020242
	mod - manage_proj_edit_page.php	Diff File
MantisBT: master b499d5c8 2015-11-04 15:24:21 cproensa Details Diff	Remove call to project_includes_user project_includes_user() is called once for every user that is displayed in project manage page, to check if user is directly assigned to the project and print the "remove" button. This function performs a db query for each user, which degrades performance as user count grows, and is especilally severe on public projects. Instead, fetch all local user at once and compare against the saved array if user is directly assigned to the project. Fixes 0020242	Affected Issues 0020242
	mod - manage_proj_edit_page.php	Diff File
MantisBT: master 9eb915c3 2015-11-03 18:48:21 cproensa Details Diff	Check workflow prior to reopening bug Add a check to access_can_reopen_bug() to ensure the reopen status is reachable by the current workflow configuration. If not, return false. Previously, the reopen operation would fail anyway when the status is changed. With this early check, failure is detected before the action is made. A direct benefit from this is that the "reopen" button is not shown to the user if the action is not possible. Fixes 0020256 Signed-off-by: Damien Regad <dregad@mantisbt.org>	Affected Issues 0020256
	mod - core/access_api.php	Diff File
MantisBT: master 557c1d76 2015-11-03 15:51:15 atrol Details Diff	remove unused parameters in string_get_bugnote_view_url_with_fqdn call	Attach Issues:
	mod - core/string_api.php	Diff File
MantisBT: master 8ea40421 2015-11-03 15:50:01 atrol Details Diff	remove unused parameters in string_get_bug_view_url_with_fqdn calls	Attach Issues:
	mod - core/email_api.php	Diff File
	mod - core/string_api.php	Diff File
MantisBT: master ffd78e0a 2015-11-03 15:42:38 atrol Details Diff	Remove unused parameter $p_user_id	Attach Issues:
	mod - core/string_api.php	Diff File
MantisBT: master 7c7fa974 2015-11-03 15:34:53 atrol Details Diff	Correct wrong call of function print_info_row	Attach Issues:
	mod - admin/index.php	Diff File
MantisBT: master 14bf1e9c 2015-11-03 15:31:24 atrol Details Diff	Remove unused parameters in email_generic_to_recipients calls	Attach Issues:
	mod - core/email_api.php	Diff File
MantisBT: master 1f53923b 2015-11-03 15:27:46 atrol Details Diff	Remove unused parameters in plugin_pop_current calls	Attach Issues:
	mod - core/plugin_api.php	Diff File
MantisBT: master 878db3d0 2015-11-03 15:21:49 atrol Details Diff	Remove unused parameters in string_get_bugnote_view_url calls	Attach Issues:
	mod - core/string_api.php	Diff File
MantisBT: master cd340536 2015-11-03 15:16:44 atrol Details Diff	Remove unused parameters in string_get_bug_view_url calls	Attach Issues:
	mod - core/print_api.php	Diff File
	mod - core/string_api.php	Diff File
MantisBT: master 576fd772 2015-11-03 14:24:56 cproensa Details Diff	Fix resetting of access level when updating workflow This is the same fix as 63bbb19393c3a2b9bdc7e159992c160561a7ce09, and addresses the incorrect behavior for the fields - Who can change workflow - Who can change access levels by applying the same mechanism used to detect a change in the status to the access level, i.e. comparing the updated access level with the parent and not the current value. Fixes 0016771 Signed-off-by: Damien Regad <dregad@mantisbt.org> Original commit message reworded	Affected Issues 0016771
	mod - manage_config_workflow_set.php	Diff File
MantisBT: master b649c9c9 2015-11-03 08:23:50 dregad Details Diff	Fix 0017870: XSS in adm_config_report.php This is the real correct fix for this issue (i.e. using string_attribute() to escape the variable), which was supposed to have been fixed in commit 1a49a780a7881b6eb7a2384a432db072a5c6db79. Unfortunately, for some reason I somehow ended up redoing the same mistake of using string_display_line() again instead (see original fix b509ab380f91e84d9683dbfdb02206b88a9b86fb, reverted in b02557d88a2094330249dc06c2990184d2696372). It is worth mentioning that string_display_line() does protect against the XSS attack vector, provided that the relevant MantisBT Formatting plugin configuration (text processing) is set to ON. Thanks to Patrice Morineau for pointing this out.	Affected Issues 0017870
	mod - adm_config_report.php	Diff File
MantisBT: master 3f093388 2015-11-01 19:03:15 dregad Details Diff	Adjust CSS / HTML of Workflow Transitions page A few minor adjustments to improve page layout - new CSS class (.form-container .footer), similar to .submit-button but without centered text - use <h2> tag for section titles instead of a table row - move "who can change" selects within the corresponding sections - display form submit button centered - delete button within a section of its own Note: the 2 buttons are not displayed within a single section because it would generate invalid HTML (closing the main form within an open div or require nested forms).	Attach Issues:
	mod - css/default.css	Diff File
	mod - manage_config_workflow_page.php	Diff File

Search Changesets