Search Changesets

MantisBT: master a55cb58c

2016-04-23 08:00:11

dregad

Details Diff
Add test cases to cover various error cases

- syntax error
- extra tokens (both ignore and error)
- invalid token
- undefined constant

More exceptions handling test cases
Attach Issues:
mod - tests/Mantis/ConfigParserTest.php Diff File

MantisBT: master db05b481

2016-04-23 07:48:16

dregad

Details Diff
Remove redundant assertion

It is not necessary to test against both the 1st parsing result and the
reference array, since we already know they are equal.
Attach Issues:
mod - tests/Mantis/ConfigParserTest.php Diff File

MantisBT: master b942dff6

2016-04-23 07:46:17

dregad

Details Diff
Export the parsed array, not the result of eval()

Bug in cproensa's original commit.
Attach Issues:
mod - tests/Mantis/ConfigParserTest.php Diff File

MantisBT: master ff2eb166

2016-04-23 07:43:56

dregad

Details Diff
Put all array test code in a single method
Attach Issues:
mod - tests/Mantis/ConfigParserTest.php Diff File

MantisBT: master 58d74b34

2016-04-23 07:39:03

dregad

Details Diff
Use method to generate 'original input' message
Attach Issues:
mod - tests/Mantis/ConfigParserTest.php Diff File

MantisBT: master 03513dd2

2016-04-23 07:37:06

dregad

Details Diff
No need for json and serialize test assertions

Since the parser gives us a native PHP variable, it is not necessary
to perform assertions with json_encode() and serialize().
Attach Issues:
mod - tests/Mantis/ConfigParserTest.php Diff File

MantisBT: master dc96f5a4

2016-04-23 07:27:39

dregad

Details Diff
Add and improve test cases

- scalar types
- multidimentional arrays
- use of constants
- whitespace other than space (tab, cr, lf)

Reorder and regroup tests cases, add comments.
Attach Issues:
mod - tests/Mantis/ConfigParserTest.php Diff File

MantisBT: master d95a0976

2016-04-23 07:04:57

dregad

Details Diff
Uncomment tests marked as failing in TODOs
Attach Issues:
mod - tests/Mantis/ConfigParserTest.php Diff File

MantisBT: master 21d6b020

2016-04-23 07:02:51

dregad

Details Diff
Update test case template comment
Attach Issues:
mod - tests/Mantis/ConfigParserTest.php Diff File

MantisBT: master 3ba1a743

2016-04-23 07:01:36

dregad

Details Diff
Move test cases initialization to dedicated method

Makes code easier to read, moving all the init code to the bottom of the
file.

Also call parent class' constructor.
Attach Issues:
mod - tests/Mantis/ConfigParserTest.php Diff File

MantisBT: master 584537ae

2016-04-23 06:54:35

dregad

Details Diff
Use new addCase() method

Also rename 'test_correct_syntax' property to 'cases'.
Attach Issues:
mod - tests/Mantis/ConfigParserTest.php Diff File

MantisBT: master 3304c32b

2016-04-23 06:49:15

dregad

Details Diff
Fix cproensa's unit tests to use ConfigParser class
Attach Issues:
mod - tests/Mantis/ConfigParserTest.php Diff File

MantisBT: master 8d8e4804

2016-04-23 05:33:08

dregad

Details Diff
Remove debugging code
Attach Issues:
mod - adm_config_set.php Diff File
mod - core/classes/ConfigParser.class.php Diff File

MantisBT: master 4569bdc7

2016-04-23 05:25:58

dregad

Details Diff
Use parse() method for scalar types

Avoids direct calls to constant_replace().
Attach Issues:
mod - adm_config_set.php Diff File

MantisBT: master 22b3a684

2016-04-23 05:08:54

dregad

Details Diff
Improve error messages
Attach Issues:
mod - core/classes/ConfigParser.class.php Diff File
mod - core/classes/Tokenizer.class.php Diff File
mod - lang/strings_english.txt Diff File

MantisBT: master fa8ed997

2016-04-23 05:06:29

dregad

Details Diff
ConfigParser: add option to ignore extra tokens

Prior to this, parse() method would always throw an exception when
additional code is found after the first token.
Attach Issues:
mod - adm_config_set.php Diff File
mod - core/classes/ConfigParser.class.php Diff File

MantisBT: master dabb160e

2016-04-23 00:19:27

vboctor

Details Diff
Move mentions settings to reminders section
Attach Issues:
mod - config_defaults_inc.php Diff File
mod - docbook/Admin_Guide/en-US/config/misc.xml Diff File
mod - docbook/Admin_Guide/en-US/config/reminders.xml Diff File

MantisBT: master 3bb856ef

2016-04-22 13:25:08

dregad

Details Diff
Move constant_replace() to ConfigParser class as static method
Attach Issues:
mod - adm_config_set.php Diff File
mod - core/classes/ConfigParser.class.php Diff File

MantisBT: master 9d782478

2016-04-22 13:08:03

dregad

Details Diff
Move Tokenizer and Parser to core class files
Attach Issues:
mod - adm_config_set.php Diff File
add - core/classes/ConfigParser.class.php Diff File
add - core/classes/Tokenizer.class.php Diff File

MantisBT: master da3d2be7

2016-04-22 12:45:23

cproensa

Details Diff
Only cache visible plugin columns

On issues view/print/export, a call is made to all MantisColumn plugin
objects to cache the list of issues.

This call is now done only for those columns that are part of the
user column selection.

Fixes 0020854

Signed-off-by: Damien Regad <dregad@mantisbt.org>
Affected Issues
0020854
mod - core/columns_api.php Diff File
mod - csv_export.php Diff File
mod - excel_xml_export.php Diff File
mod - print_all_bug_page.php Diff File
mod - view_all_inc.php Diff File

MantisBT: master 040cde62

2016-04-22 07:19:20

Alexander Ishmuradov

Details Diff
Add email notifications for users assigned to categories

Users who are assigned to categories can now receive email
notifications. This is configurable via E-mail Notifications page,
on a per-project basis.

A common use case:
- A user was assigned to some category;
- When new issue is submitted to this category and "Assigned To" field
is empty, this issue is assigned to Category Owner (who receives a
notification);
- If we then re-assign issue to someone else, the Category Owner will no
longer receive notifications.

This commit makes it possible for category owners receiving
notifications in this case as well.

Fixes 0020876

Signed-off-by: Damien Regad <dregad@mantisbt.org>

Original commit amended to default the new flag to ON as per [1].
Reworded and formatted commit message.

[1] https://github.com/mantisbt/mantisbt/pull/762#issuecomment-217280123
Affected Issues
0020876
mod - config_defaults_inc.php Diff File
mod - core/email_api.php Diff File
mod - docbook/Admin_Guide/en-US/Customizing.xml Diff File
mod - docbook/Admin_Guide/en-US/config/email.xml Diff File
mod - lang/strings_english.txt Diff File
mod - manage_config_email_page.php Diff File
mod - manage_config_email_set.php Diff File

MantisBT: master 8107ea50

2016-04-22 07:04:58

dregad

Details Diff
Parse complex configs using PHP tokenizer

Implements 2 classes to parse 'complex' config options in admin
Configuration Report page using PHP tokenizer instead of relying on
regular expressions.

- Tokenizer calls token_get_all() to build a list of tokens from the
given code
- Parser uses a Tokenizer object to convert the code (string) to an
actual PHP array variable

TODO: Move classes to an API and write automated tests

Fixes 0020787, 0020812, 0020813, 0020850, 0020851
Affected Issues
0020787, 0020812, 0020813, 0020850, 0020851
mod - adm_config_set.php Diff File
mod - core/constant_inc.php Diff File
mod - lang/strings_english.txt Diff File

MantisBT: master 7335fdde

2016-04-22 06:18:52

dregad

Details Diff
Removed one more hr_size/hr_width reference

Forgot to run 'git add' before committing the previous change...
Attach Issues:
mod - config_defaults_inc.php Diff File

MantisBT: master c1b463e6

2016-04-22 06:11:27

dregad

Details Diff
Remove unused $g_hr_size and $g_hr_width config options

These 2 configs were removed from the code several years ago (see commit
6a0714fec0426d7dfb44c3978b91e96d0103c740), but their definition remained
in config_defaults_inc.php and the documentation (admin guide).
Attach Issues:
mod - config_defaults_inc.php Diff File
mod - core/obsolete.php Diff File
mod - docbook/Admin_Guide/en-US/config/html.xml Diff File

MantisBT: master 4853bd12

2016-04-21 22:49:39

vboctor

Details Diff
Re-use user exists check when rendering avatars
Attach Issues:
mod - core/classes/Avatar.class.php Diff File
 First  Prev  1 2 3 ... 70 ... 117 118 119 120 121 122 123 ... 140 ... 210 ... 280 ... 350 ... 420 ... 490 ... 560 ... 630 ... 659 660 661  Next  Last