Search Changesets

MantisBT: master b36e56ab

2015-10-30 12:40:13

dregad

Details Diff
Fix warning 'config option "threshold_xxx" not found'

The original fix prepended 'threshold_' to $t_threshold, which
is incorrect (maybe a copy/paste error ?).

The 'threshold_' prefix is used to determine the name of the
corresponding GPC variable's name; $t_threshold already contains the
correct config option's name.

Fixes 0019970, 0016771
Affected Issues
0016771, 0019970
mod - manage_config_workflow_set.php Diff File

MantisBT: master b954cc5b

2015-10-29 13:36:57

dregad

Details Diff
Ensure FILTER_MATCH_TYPE property is an int

This prevents APPLICATION ERROR 26 (Data Type mismatch) when applying a
filter built based on a saved filter which (for legacy reasons) had the
criteria stored as a string instead of an integer.

Fixes 0020105
Affected Issues
0020105
mod - core/filter_api.php Diff File

MantisBT: master 5a496d80

2015-10-29 13:34:36

dregad

Details Diff
Revert "Add 'Match type' to list of filter properties to validate"

This reverts commit 5e12bf9819d923e00020e11083426355f7a3d5f0 which
caused a regression (system notice when displaying the match type filter
criteria, or application error 203 when trying to apply the filter).

The change made match_type a multivalue property, which caused it to be
converted to an array by filter_ensure_valid_filter().

Issue 0020105
Affected Issues
0020105
mod - core/filter_api.php Diff File

MantisBT: master 2c0b2a59

2015-10-29 07:32:36

cproensa

Details Diff
Revert 738272f and reimplement hide graph link

commit 738272f23900243de35b5f0ce29564274bad3090 to hide Mantisgraph link
introduced a regression: failing at login when anonymous login is
disabled.

Here that change is reverted and the access level check is now placed in
the callback function, instead of the hook initialization

Fixes 0020217

Signed-off-by: Damien Regad <dregad@mantisbt.org>
Affected Issues
0020217
mod - plugins/MantisGraph/MantisGraph.php Diff File

MantisBT: master 931c5cc6

2015-10-27 10:16:57

dregad

Details Diff
Adjust spacing between collapse icon and search div

This is an ugly hack... The right way to do this would require messing
with HTML and CSS of the filter-box div, which is not worth the time and
effort right now considering that the collapse_api is likely to be
refactored soon, not to mention the upcoming modern UI, both of which
would make this obsolete.
Attach Issues:
mod - css/default.css Diff File
mod - javascript/common.js Diff File

MantisBT: master eac11116

2015-10-27 10:05:54

dregad

Details Diff
collapse_api: hide icon and remove extra spaces

When javascript is disabled, it does not make sense to display the
collapse icon. This commit hides it by default, and lets the JS show it.

Also remove the   after the icon, replace it with CSS padding, and
adjust the generated HTML so that it does not generate extra spaces.

Note: a   was added to filter_draw_selection_area2(), as a hack to
ensure the filter div is high enough to fit the search field and
buttons.
Attach Issues:
mod - billing_inc.php Diff File
mod - bug_file_upload_inc.php Diff File
mod - bug_monitor_list_view_inc.php Diff File
mod - bug_report_page.php Diff File
mod - bug_sponsorship_list_view_inc.php Diff File
mod - bugnote_add_inc.php Diff File
mod - bugnote_stats_inc.php Diff File
mod - bugnote_view_inc.php Diff File
mod - core/collapse_api.php Diff File
mod - core/filter_api.php Diff File
mod - core/relationship_api.php Diff File
mod - css/default.css Diff File
mod - history_inc.php Diff File
mod - javascript/common.js Diff File

MantisBT: master 5a16d0e7

2015-10-27 07:25:56

dregad

Details Diff
collapse_api: code cleanup

- Remove useless output buffering in collapse_api
The obsolescence of $g_use_javascript setting (see commit
75be0f4c15ec6aa2379c3a6504733bb28dc1b259) makes the various ob_* calls
unnecessary since the generated output is displayed in every case.
- phpDoc changes (revise references to javascript disabled)
- remove useless function call
- use a variable for collapse status class to improve readability
Attach Issues:
mod - core/collapse_api.php Diff File

MantisBT: master 75150168

2015-10-27 07:18:56

dregad

Details Diff
Remove href on collapse-link when JS is disabled

When JS is disabled, the collapsible section is always shown open; the
'+' icon is therefore useless, and it does not make sense to turn it
into a hyperlink.

The href attribute has been removed (the existing javascript handles
adding the hyperlink when enabled), and the cursor is set to 'pointer'
via javascript.
Attach Issues:
mod - core/collapse_api.php Diff File
mod - javascript/common.js Diff File

MantisBT: master e8ff7b99

2015-10-25 01:13:30

vboctor

Details Diff
Remove reference to mantisbt-announce

Remove reference to mantisbt-announce and mention that announcements will be sent to
users registered on our official bugtracker.

Fixes 0019378
Affected Issues
0019378
mod - docbook/Admin_Guide/en-US/About.xml Diff File

MantisBT: master-1.2.x 0683d7d0

2015-10-24 20:10:05

dregad

Details Diff
Fix docbook build error
Attach Issues:
mod - docbook/developers/en/event-reference-output.sgml Diff File

MantisBT: master-1.2.x ecd1a4c7

2015-10-24 19:58:05

dregad

Details Diff
Change comments for method types

Parameters are not always String, e.g. EVENT_UPDATE_BUG_DATA

Backport from ac63e6baa01052dde8bc40aee11b74ff0c023842
Conflicts:
core/event_api.php
Attach Issues:
mod - core/event_api.php Diff File

MantisBT: master-1.2.x cfea887b

2015-10-24 19:53:46

dregad

Details Diff
Remove unused parameter in event calls

Undocumented and no longer needed.
Should have been removed by issue 0010890

This is a manual backport from bc613264adc1091abf399667151f72748f22de64
Affected Issues
0010890
mod - bug_update_advanced_page.php Diff File

MantisBT: master-1.2.x 35a89d88

2015-10-24 19:38:12

dregad

Details Diff
Documentation and code clean up for plugin events

After my question in issue 0020183, here is some clean up for the events
documentation:

- Added doc for missing parameters:
- EVENT_LOG
- EVENT_DISPLAY_FORMATTED
- EVENT_MENU_ISSUE
- EVENT_VIEW_BUG_ATTACHMENT
- EVENT_MANAGE_OVERVIEW_INFO
- Missing documentation for event EVENT_DISPLAY_EMAIL_BUILD_SUBJECT
- Code clean up on usage of events:
- EVENT_UPDATE_BUG_FORM
- EVENT_UPDATE_BUG_FORM_TOP
- Change comments to reflect actual types for function event_type_chain()
- Apply consistent formating to documentation

Backported from master 9fcdd066f78ad22f2b644a3fe7d08b4bea77187d
Affected Issues
0020183
mod - bug_update_advanced_page.php Diff File
mod - core/event_api.php Diff File
mod - docbook/developers/en/event-reference-manage.sgml Diff File
mod - docbook/developers/en/event-reference-output.sgml Diff File
mod - docbook/developers/en/event-reference.sgml Diff File

MantisBT: master 9fcdd066

2015-10-24 19:38:12

dregad

Details Diff
Documentation and code clean up for plugin events

After my question in issue 0020183, here is some clean up for the events
documentation:

- Added doc for missing parameters:
- EVENT_LOG
- EVENT_DISPLAY_FORMATTED
- EVENT_MENU_ISSUE
- EVENT_VIEW_BUG_ATTACHMENT
- EVENT_MANAGE_OVERVIEW_INFO
- Missing documentation for event EVENT_DISPLAY_EMAIL_BUILD_SUBJECT
- Code clean up on usage of events:
- EVENT_UPDATE_BUG_FORM
- EVENT_UPDATE_BUG_FORM_TOP
- Change comments to reflect actual types for function event_type_chain()
- Apply consistent formating to documentation
Affected Issues
0020183
mod - bug_update_page.php Diff File
mod - core/event_api.php Diff File
mod - docbook/Developers_Guide/en-US/Events_Reference.xml Diff File
mod - docbook/Developers_Guide/en-US/Events_Reference_Manage.xml Diff File
mod - docbook/Developers_Guide/en-US/Events_Reference_Output.xml Diff File

MantisBT: master 73e5f8ca

2015-10-24 18:42:51

dregad

Details Diff
Fix dynamic CSS script for status color

Avoids problem with spaces in custom status enum.
- CSS class is now named based on enum value
- code cleanup and optimization
Attach Issues:
mod - core/html_api.php Diff File
mod - css/status_config.php Diff File

MantisBT: master b8dcb52a

2015-10-23 16:19:17

cproensa

Details Diff
print_enum_string_option_list() accepts array of values

This function was originally defined to accept an integer as current
value for the option list, so it gets defaulted. However, some places
(e.g. filter fields) were calling the function with this parameter set
as an array of one integer (or more, for multiselection option lists).

Changed parameter to accept array, since the check_selected() function
already accepts an array of values to check.

Adding a check for the case $p_val is a single value to cast it to an
int, because check_select() should be called in strict mode for enum
keys anyways, and some callers may still pass a number as string.

In the case of "array of int", the caller must ensure values are proper
int type.

Fixes 0019978

Reworded original commit message.

Signed-off-by: Damien Regad <dregad@mantisbt.org>
Affected Issues
0019978
mod - core/print_api.php Diff File

MantisBT: master 9674df6c

2015-10-23 12:45:01

cproensa

Details Diff
CSS: Hide collapsed sections when JS is disabled

What is wrong with the collapse_api semantics:
JS writes the collapse state in a cookie; the server retrieves it to
display each section in the proper state. The classes 'collapse_closed'
and 'collapse_open' may be reversed, causing a collapsed section to have
class 'collapse_open'... wtf?

This commit fixes the problem by creating a new class to identify which
section is the collapsed one. This new class is not affected by
javascript, and hidden by default using CSS.

Fixes 0019508

Signed-off-by: Damien Regad <dregad@mantisbt.org>

Changes from cproensa's original commits:
- squashed
- commit message reworded
- CSS rule on a single line
Affected Issues
0019508
mod - core/collapse_api.php Diff File
mod - css/default.css Diff File

MantisBT: master 738272f2

2015-10-23 07:59:41

cproensa

Details Diff
Don't show MantisGraph link for users without access

fixes 0020217

Signed-off-by: Damien Regad <dregad@mantisbt.org>
Affected Issues
0020217
mod - plugins/MantisGraph/MantisGraph.php Diff File

MantisBT: master-1.2.x be0fcf42

2015-10-23 04:46:19

cproensa

Details Diff
Documentation for plugin events. Typos, rephrasing
Attach Issues:
mod - docbook/developers/en/event-reference-output.sgml Diff File

MantisBT: master 58203ae2

2015-10-23 04:46:19

cproensa

Details Diff
Documentation for plugin events. Typos, rephrasing
Attach Issues:
mod - docbook/Developers_Guide/en-US/Events_Reference_Output.xml Diff File

MantisBT: master e7bc61f1

2015-10-23 02:05:36

atrol

Details Diff
Fix typos in developers guide

Fixes 0020214
Affected Issues
0020214
mod - docbook/Developers_Guide/en-US/Events_Reference_Account.xml Diff File

MantisBT: master-1.2.x 5a0899c7

2015-10-22 18:53:43

cproensa

Details Diff
Documentation. Format consistency
Attach Issues:
mod - docbook/developers/en/event-reference-output.sgml Diff File

MantisBT: master 33534c39

2015-10-22 18:53:43

cproensa

Details Diff
Documentation. Format consistency
Attach Issues:
mod - docbook/Developers_Guide/en-US/Events_Reference_Output.xml Diff File

MantisBT: master ac63e6ba

2015-10-22 18:45:09

cproensa

Details Diff
Change comments for method types

Parameters are not always String, e.g. EVENT_UPDATE_BUG_DATA
Attach Issues:
mod - core/event_api.php Diff File

MantisBT: master-1.2.x 0ff5bfd3

2015-10-22 18:27:58

cproensa

Details Diff
Added documentation for EVENT_DISPLAY_EMAIL_BUILD_SUBJECT
Attach Issues:
mod - docbook/developers/en/event-reference-output.sgml Diff File
 First  Prev  1 2 3 ... 70 ... 137 138 139 140 141 142 143 ... 210 ... 280 ... 350 ... 420 ... 490 ... 560 ... 630 ... 664 665 666  Next  Last