Search Changesets

MantisBT: master 220ace7d

2019-06-13 14:15:15

translatewiki.net

Details Diff
Localisation updates from https://translatewiki.net.
Attach Issues:
mod - lang/strings_persian.txt Diff File

MantisBT: master ea4f2607

2019-06-11 04:25:35

dregad

Details Diff
Use prepare_email_link() in print_email_link_with_subject()

Refactoring as part of issue 0025686.
Affected Issues
0025686
mod - core/print_api.php Diff File

MantisBT: master 0448ce68

2019-06-10 20:27:26

dregad

Details Diff
Fix testEmailLink for PHP 5.5

For an unknown reason, PHP 5.5 test fails when we don't specifically
login. The problem does not occur with later versions.
Attach Issues:
mod - tests/Mantis/PrepareTest.php Diff File

MantisBT: master dc37aa0b

2019-06-10 20:24:08

dregad

Details Diff
PHPUnit tests: new MantisCoreBase class

To be used as a base, inherited by MantisBT core API test units.

Provides a couple of helper methods
- dbConnect() (re)opens DB connection, as PHPUnit appears to kill it
after each test case execution. This allows test cases that need the
DB to reopen it easily.
- login() performs a "script login" based on the configured test suite
user (as defined in bootstrap file), falls back to anonymous user if
not defined, and asserts that user is successfully logged in.
Attach Issues:
mod - tests/Mantis/ConfigParserTest.php Diff File
mod - tests/Mantis/EnumTest.php Diff File
mod - tests/Mantis/HelperTest.php Diff File
add - tests/Mantis/MantisCoreBase.php Diff File
mod - tests/Mantis/MentionParsingTest.php Diff File
mod - tests/Mantis/PluginTest.php Diff File
mod - tests/Mantis/PrepareTest.php Diff File
mod - tests/Mantis/StringTest.php Diff File

MantisBT: master-2.21 bcb1334f

2019-06-10 16:13:19

atrol

Details Diff
Disable Dropzone timeout

Fixes 0025763
Affected Issues
0025763
mod - js/common.js Diff File

MantisBT: master 435bef4f

2019-06-10 14:31:41

translatewiki.net

Details Diff
Localisation updates from https://translatewiki.net.
Attach Issues:
mod - lang/strings_persian.txt Diff File
mod - lang/strings_portuguese_standard.txt Diff File
mod - lang/strings_russian.txt Diff File

MantisBT: master 99c8a042

2019-06-10 11:02:21

dregad

Details Diff
PHPUnit test for prepare_email_link()
Attach Issues:
mod - tests/Mantis/PrepareTest.php Diff File

MantisBT: master 2cee661c

2019-06-10 10:11:40

dregad

Details Diff
Fix PHP Notice in user_cache_row()

If the function receives an invalid user ID, it will issue an Undefined
offset notice, as it does not check for actual existence of the ID in
the users' cache after calling user_cache_array_rows().

PHPDoc does state that a valid user ID is expected, but since the
function includes error handling code, it makes sense to account for
this case, unlikely as it may be.

Fixes 0025850
Affected Issues
0025850
mod - core/user_api.php Diff File

MantisBT: master 0d2b817f

2019-06-10 10:08:05

dregad

Details Diff
Fix user_pref_cache_array_rows if fetch_all fails

DbQuery::fetch_all() can return false if the query execution fails. In
that case, the foreach triggers a PHP "Invalid argument supplied for
foreach()" warning.

Also, improve code readability by storing the user ID in a variable to
avoid repeated typecasts.

Fixes 0025850
Affected Issues
0025850
mod - core/user_pref_api.php Diff File

MantisBT: master 7ed1892d

2019-06-06 12:05:12

translatewiki.net

Details Diff
Localisation updates from https://translatewiki.net.
Attach Issues:
mod - lang/strings_arabic.txt Diff File
mod - lang/strings_belarusian_tarask.txt Diff File
mod - lang/strings_german.txt Diff File
mod - lang/strings_macedonian.txt Diff File
mod - lang/strings_portuguese_brazil.txt Diff File
mod - lang/strings_russian.txt Diff File
mod - plugins/MantisGraph/lang/strings_eo.txt Diff File

MantisBT: master d975045e

2019-06-05 12:40:27

dregad

Details Diff
Add newline after <textarea> tags

The HTML 5 specification states that "Newlines at the start of textarea
elements are ignored as an authoring convenience." [1]

To avoid altering user data (e.g. issue description, steps to reproduce,
etc.) having leading newline(s) when editing and saving, the markup of
all pages displaying user content in textarea tags has been modified to
add a newline after the opening tag.

Fixes 0025839

[1]: https://www.w3.org/TR/html52/syntax.html#the-in-body-insertion-mode
Affected Issues
0025839
mod - account_prof_edit_page.php Diff File
mod - bug_report_page.php Diff File
mod - bug_update_page.php Diff File
mod - manage_columns_inc.php Diff File
mod - manage_custom_field_edit_page.php Diff File
mod - manage_proj_edit_page.php Diff File
mod - manage_proj_ver_edit_page.php Diff File
mod - news_edit_page.php Diff File
mod - proj_doc_edit_page.php Diff File
mod - tag_update_page.php Diff File

MantisBT: master 5039c7b8

2019-06-05 05:15:19

dregad

Details Diff
Fix mc_project_version_delete() return value

The function's return type does not match the WSDL definition.

This is a regression introduced by a80f447687722b52160d00c96c21a5be5f4329e1
which changed version_delete()'s return type from true (bool) to void
Since mc_project_version_delete() actually returned that, it causes a
side effect because void == NULL == false.

To avoid an unnecessary and potentially breaking change in the WSDL, the
function now returns true.

Fixes 0025470
Affected Issues
0025470
mod - api/soap/mc_project_api.php Diff File

MantisBT: master-1.3.x 404e3df8

2019-06-05 05:15:19

dregad

Details Diff
Fix mc_project_version_delete() return value

The function's return type does not match the WSDL definition.

This is a regression introduced by a80f447687722b52160d00c96c21a5be5f4329e1
which changed version_delete()'s return type from true (bool) to void
Since mc_project_version_delete() actually returned that, it causes a
side effect because void == NULL == false.

To avoid an unnecessary and potentially breaking change in the WSDL, the
function now returns true.

Fixes 0025856

(cherry picked from commit 5039c7b86a21f41a64c904e3eb16e0eb25ac2cb0)
Affected Issues
0025856
mod - api/soap/mc_project_api.php Diff File

MantisBT: master a309d0ab

2019-06-05 04:59:47

dregad

Details Diff
Fix mc_project_version_update() return value

The function's return type does not match the WSDL definition.

This is a regression introduced by a80f447687722b52160d00c96c21a5be5f4329e1
which changed version_update()'s return type from true (bool) to void
Since mc_project_version_update() actually returned that, it causes a
side effect because void == NULL == false.

To avoid an unnecessary and potentially breaking change in the WSDL, the
function now returns true.

Fixes 0025470
Affected Issues
0025470
mod - api/soap/mc_project_api.php Diff File

MantisBT: master-1.3.x 7b06ee38

2019-06-05 04:59:47

dregad

Details Diff
Fix mc_project_version_update() return value

The function's return type does not match the WSDL definition.

This is a regression introduced by a80f447687722b52160d00c96c21a5be5f4329e1
which changed version_update()'s return type from true (bool) to void
Since mc_project_version_update() actually returned that, it causes a
side effect because void == NULL == false.

To avoid an unnecessary and potentially breaking change in the WSDL, the
function now returns true.

Fixes 0025856

(cherry picked from commit a309d0ab758bec99bc42643981545e730b3f6a81)
Affected Issues
0025856
mod - api/soap/mc_project_api.php Diff File

MantisBT: master 3536f696

2019-06-03 11:38:13

translatewiki.net

Details Diff
Localisation updates from https://translatewiki.net.
Attach Issues:
mod - lang/strings_belarusian_tarask.txt Diff File
mod - lang/strings_chinese_traditional.txt Diff File
mod - lang/strings_french.txt Diff File
mod - lang/strings_hebrew.txt Diff File
mod - lang/strings_hungarian.txt Diff File
mod - plugins/MantisCoreFormatting/lang/strings_eo.txt Diff File
mod - plugins/XmlImportExport/lang/strings_eo.txt Diff File

MantisBT: master 9c66d394

2019-06-02 10:05:29

dregad

Details Diff
Revert maintenance mode in TestConfig.php

For an unknown reason, commit 59970d8735dd06975c3aeabbd9ce8ba0d7593b16
(part of issue 0020837) set MANTIS_MAINTENANCE_MODE.

As a consequence, it is not possible to use any database function as
as part of unit tests.

Since the tests added in the above-mentioned commit are also successful
without maintenance mode, it makes sense to revert this change.
Affected Issues
0020837
mod - tests/TestConfig.php Diff File

MantisBT: master 8f9c386d

2019-05-31 18:50:54

dregad

Details Diff
Merge remote-tracking branch 'cproensa/0025742_summary_by_date_add'
Attach Issues:
mod - core/summary_api.php Diff File

MantisBT: master afb40dca

2019-05-31 17:20:33

dregad

Details Diff
Improve Admin Guide/PHPDoc for monitors thresholds

Add recommendation to set $g_monitor_add_others_bug_threshold and
$g_monitor_delete_others_bug_threshold to a value not be lower than
$g_show_monitor_list_threshold.

Add missing entry for $g_show_monitor_list_threshold in Misc config
section.

Fixes 0025827
Affected Issues
0025827
mod - config_defaults_inc.php Diff File
mod - docbook/Admin_Guide/en-US/config/misc.xml Diff File

MantisBT: master 83dae420

2019-05-31 17:19:15

dregad

Details Diff
Reorder declaration of $g_show_monitor_list_threshold

Regroup it with other monitors-related configs.

Fixes 0025827
Affected Issues
0025827
mod - config_defaults_inc.php Diff File

MantisBT: master 1a730577

2019-05-31 17:00:49

dregad

Details Diff
Add missing configs in manage workflow thresholds

The add/remove monitors thresholds (monitor_add_others_bug_threshold,
monitor_add_others_bug_threshold) were not configurable via
manage_config_work_threshold_page.php

Fixes 0025826
Affected Issues
0025826
mod - docbook/Admin_Guide/en-US/Page_Descriptions.xml Diff File
mod - lang/strings_english.txt Diff File
mod - manage_config_work_threshold_page.php Diff File
mod - manage_config_work_threshold_set.php Diff File

MantisBT: master 1ef47af5

2019-05-30 12:52:21

dregad

Details Diff
Remove extra space in <a> tag
Attach Issues:
mod - core/prepare_api.php Diff File

MantisBT: master e5a8ca4a

2019-05-30 12:50:13

dregad

Details Diff
Let users add monitors even if they can't see them

In view.php, the 'Users monitoring this issue' box is only displayed
if the user has $g_show_monitor_list_threshold. If the same user had
$g_monitor_add_others_bug_threshold, they would not be able to adding
new monitors.

This is an uncommon situation, as monitor_add_others_bug_threshold is
expected to be >= show_monitor_list_threshold. Still it makes sense to
fix that since the configuration allows such setup.

With this change, an 'Access Denied' message is displayed instead of the
users' list if access level is below show_monitor_list_threshold and
>= monitor_add_others_bug_threshold, and the form to add new monitors is
shown.

If user's access level is lower than both thresholds, then the behavior
is unchanged, i.e. the whole box is hidden.

Fixes 0025815
Affected Issues
0025815
mod - bug_monitor_list_view_inc.php Diff File

MantisBT: master 49539f33

2019-05-30 06:04:18

cproensa

Details Diff
Fix mssql summary error

When computing SUM & AVG functions, sqlserver uses the column
datatype, which is INT. This datatype can be overflowed when a big
number of issues are included, since we are adding the total number
of seconds.

In that case, use an explicit cast to BIGINT to avoid that error.
Other databases are not affected because they use a runtime data
type allowing bigger integers.

The stats array is initialized to zero, to return a properly formatted
value array when there aren't any issues.

Fixes 0025781
PR https://github.com/mantisbt/mantisbt/pull/1516
Affected Issues
0025781
mod - core/summary_api.php Diff File

MantisBT: master-2.21 5bade1d5

2019-05-30 06:04:18

cproensa

Details Diff
Fix mssql summary error

When computing SUM & AVG functions, sqlserver uses the column
datatype, which is INT. This datatype can be overflowed when a big
number of issues are included, since we are adding the total number
of seconds.

In that case, use an explicit cast to BIGINT to avoid that error.
Other databases are not affected because they use a runtime data
type allowing bigger integers.

The stats array is initialized to zero, to return a properly formatted
value array when there aren't any issues.

Fixes 0025781
PR https://github.com/mantisbt/mantisbt/pull/1516
Affected Issues
0025781
mod - core/summary_api.php Diff File
 First  Prev  1 2 3 4 5 ... 70 ... 140 ... 210 ... 280 ... 350 ... 420 ... 490 ... 560 ... 630 ... 648 649 650  Next  Last