Search Changesets

MantisBT: master-2.0.x fd9ff728

2013-09-28 02:12

Paul Richards


Details Diff
Fix php format strings
mod - core/email_api.php Diff File
mod - manage/config_email_page.php Diff File
mod - manage/plugin_page.php Diff File
mod - my_view_inc.php Diff File

MantisBT: master-2.0.x ed6c90bd

2013-09-28 02:10

Paul Richards


Details Diff
fix sprintf format strings
mod - bug_revision_view_page.php Diff File
mod - bug_sponsorship_list_view_inc.php Diff File
mod - bugnote_view_inc.php Diff File
mod - core/print_api.php Diff File
mod - manage/config_workflow_page.php Diff File
mod - manage/config_workflow_set.php Diff File
mod - manage/plugin_page.php Diff File
mod - manage/proj_cat_delete.php Diff File
mod - manage/tags_page.php Diff File
mod - tag_update_page.php Diff File
mod - tag_view_page.php Diff File

MantisBT: master-2.0.x e935cd7e

2013-09-28 02:00

Paul Richards


Details Diff
fix sprintf statements
mod - bug_actiongroup_page.php Diff File
mod - bugnote_view_inc.php Diff File
mod - core/columns_api.php Diff File
mod - core/email_api.php Diff File
mod - core/html_api.php Diff File
mod - core/print_api.php Diff File
mod - roadmap_page.php Diff File
mod - tag_update_page.php Diff File
mod - tag_view_page.php Diff File

MantisBT: master f0b98c1d

2013-09-27 02:13

dregad


Details Diff
Use extract() function instead of manual assignment
mod - core/history_api.php Diff File

MantisBT: master 54630069

2013-09-26 13:05

dregad


Details Diff
Merge branch 'master' into 13x

Conflicts:
core/print_api.php
mod - .travis.yml Diff File
mod - api/soap/mc_tag_api.php Diff File
mod - core/config_api.php Diff File
mod - core/form_api.php Diff File
mod - core/html_api.php Diff File
mod - core/tag_api.php Diff File
mod - manage_config_email_page.php Diff File
mod - manage_config_work_threshold_page.php Diff File
mod - manage_config_workflow_page.php Diff File
mod - manage_tags_page.php Diff File
mod - plugins/MantisCoreFormatting/MantisCoreFormatting.php Diff File

MantisBT: master-1.2.x d67d9bd1

2013-09-26 08:24

dregad


Details Diff
Display blank instead of 'user0' in Assigned to field

When a user lacking the 'update_bug_assign_threshold' privilege (e.g.
updater) tries to edit an issue that has no handler, the 'Assigned to'
field shows 'user0' instead of a blank field as expected.

Fixes 0012480
Affected Issues
0012480
mod - bug_update_advanced_page.php Diff File

MantisBT: master 42d19a11

2013-09-26 08:24

dregad


Details Diff
Display blank instead of 'user0' in Assigned to field

When a user lacking the 'update_bug_assign_threshold' privilege (e.g.
updater) tries to edit an issue that has no handler, the 'Assigned to'
field shows 'user0' instead of a blank field as expected.

Fixes 0012480
Affected Issues
0012480
mod - bug_update_advanced_page.php Diff File

MantisBT: master cf72f3d5

2013-09-26 06:31

dregad


Details Diff
Workflow thresholds page: hide delete button when not needed

The button is now displayed only when there are overrides specific to
the current project.

Fixes 0016412
Affected Issues
0016412
mod - manage_config_work_threshold_page.php Diff File

MantisBT: master 2ecfefa0

2013-09-26 06:19

dregad


Details Diff
Workflow thresholds page: add color highlight for 'who can alter'

Normally on this page, all changes versus system / global defaults are
highlighted in color. This did not work for the access level threshold
of 'Who can alter this value', which are never color-coded regardless of
the actual value.

This commit introduces a new function print_who_can_change() to remove
code duplication.

Fixes 0016411
Affected Issues
0016411
mod - manage_config_work_threshold_page.php Diff File

MantisBT: master f64db453

2013-09-26 05:57

dregad


Details Diff
Workflow thresholds page: improve html layout

Adding newlines and tabs to make the generated HTML more readable.
mod - manage_config_work_threshold_page.php Diff File

MantisBT: master 33db5208

2013-09-26 05:35

dregad


Details Diff
Workflow thresholds page: new set_color() function

Simplify program by moving duplicated code into a new function.

And sorry for the Brits but it's 'color', not 'colour' ;)
mod - manage_config_work_threshold_page.php Diff File

MantisBT: master 223dd63d

2013-09-26 05:23

dregad


Details Diff
Fix whitespace
mod - manage_config_work_threshold_page.php Diff File

MantisBT: master-1.2.x f4a4e903

2013-09-26 05:14

dregad


Details Diff
Coding guidelines
mod - core/config_api.php Diff File

MantisBT: master-1.2.x 281fa5ef

2013-09-26 04:57

dregad


Details Diff
Workflow thresholds page: fix display of 'who can alter'

When the current project is 'All projects' and the admin changes the
'Who can alter value' threshold (e.g. to 'manager'), the changes are saved
in the config table as expected, but not displayed back properly -
mantis shows the default value of 'administrator' (admin_site_threshold)
instead, giving the impression that the settings have not been saved;
another update will then overwrite the previously saved threshold back
to default.

The projects list in config_get_access() was not properly initialized,
set to an empty array when current project is ALL_PROJECTS.

Fixes 0010071
Affected Issues
0010071
mod - core/config_api.php Diff File

MantisBT: master d3833a0d

2013-09-26 04:57

dregad


Details Diff
Workflow thresholds page: fix display of 'who can alter'

When the current project is 'All projects' and the admin changes the
'Who can alter value' threshold (e.g. to 'manager'), the changes are saved
in the config table as expected, but not displayed back properly -
mantis shows the default value of 'administrator' (admin_site_threshold)
instead, giving the impression that the settings have not been saved;
another update will then overwrite the previously saved threshold back
to default.

The projects list in config_get_access() was not properly initialized,
set to an empty array when current project is ALL_PROJECTS.

Fixes 0010071
Affected Issues
0010071
mod - core/config_api.php Diff File

MantisBT: master-1.2.x 4666befc

2013-09-26 04:55

siebrand


Details Diff
Localisation updates from http://translatewiki.net.
mod - lang/strings_danish.txt Diff File
mod - lang/strings_dutch.txt Diff File

MantisBT: master 033a5045

2013-09-25 23:57

dregad


Details Diff
Prevent XSS issues relating to PHP_SELF

Selectively porting the security fixes for issue 0013191 from dhx's
original commit e679a1c02978ba1b811959dedc358598fc595458, following the
reintroduction of the form_action_self() function in master branch to
fix issue 0016410.
Affected Issues
0013191, 0016410
mod - core/form_api.php Diff File
mod - manage_config_email_page.php Diff File
mod - manage_config_work_threshold_page.php Diff File
mod - manage_config_workflow_page.php Diff File

MantisBT: master 8d7b8400

2013-09-25 23:45

dregad


Details Diff
Reintroduce form_action_self() api

This is a partial revert of 38b0212651d368b85858a3820ddbc0150ae32a42.

There are some cases, specifically in the manage_config_* pages, where
form_action_self() is not used directly as a form's action, but passed
to another script to be used for redirections.

Using '' instead of $_SERVER['PHP_SELF'] in this context results in
incorrect redirection (i.e. Mantis will redirect to the user's default
page).

Fixes 0016410
Affected Issues
0016410
mod - core/form_api.php Diff File
mod - manage_config_email_page.php Diff File
mod - manage_config_work_threshold_page.php Diff File
mod - manage_config_workflow_page.php Diff File

MantisBT: master 548d69d0

2013-09-25 20:32

dregad


Details Diff
Fix application error 0 in print_project_option_list()

This was due to missing type cast when calling check_selected().

Fixes 0016407
Affected Issues
0016407
mod - core/print_api.php Diff File

MantisBT: master-1.2.x 1ac581e4

2013-09-25 15:56

vboctor


Details Diff
Fixes 0016408: config_eval() fails on configs that reference array values

The $g_update_bug_assign_threshold is set to '%handle_bug_threshold%'.
If the value of $g_handle_bug_threshold is set to an array instead of a string/int, a system notice is generated that array to string conversion is done in config_eval().

The fix is to detect the direct assignment case and not use a string replace,
but use normal assignment. This will make it work for complex types like
arrays.

We still don't support $g_x = '%y%_aaa' where $g_y is not a string or int,
but that shouldn't be an issue.
Affected Issues
0016408
mod - core/config_api.php Diff File

MantisBT: master 4bf99262

2013-09-25 15:56

vboctor


Details Diff
Fixes 0016408: config_eval() fails on configs that reference array values

The $g_update_bug_assign_threshold is set to '%handle_bug_threshold%'.
If the value of $g_handle_bug_threshold is set to an array instead of a string/int, a system notice is generated that array to string conversion is done in config_eval().

The fix is to detect the direct assignment case and not use a string replace,
but use normal assignment. This will make it work for complex types like
arrays.

We still don't support $g_x = '%y%_aaa' where $g_y is not a string or int,
but that shouldn't be an issue.

Signed-off-by: Damien Regad <dregad@mantisbt.org>

Cherry-pick of 1ac581e46e2970475fdbe6434a9ac18a252e9048; Victor's
original commit was amended to follow coding guidelines.
Affected Issues
0016408
mod - core/config_api.php Diff File

MantisBT: master 7da5e185

2013-09-25 14:32

dregad


Details Diff
Fix application error 0 in print_project_option_list()

This was due to missing type cast when calling check_selected().

Fixes 0016407
Affected Issues
0016407
mod - core/print_api.php Diff File

MantisBT: master-2.0.x 7bca308d

2013-09-21 09:00

Paul Richards


Details Diff
Move sponsorship details url to a config setting instead of a language string for more flexibility
mod - bug_sponsorship_list_view_inc.php Diff File
mod - config_defaults_inc.php Diff File

MantisBT: master-2.0.x af8c421f

2013-09-21 08:50

Paul Richards


Details Diff
use %s modifier for string
mod - manage/plugin_uninstall.php Diff File

MantisBT: master-2.0.x 5ab9a70b

2013-09-19 12:20

Paul Richards


Details Diff
Remove remaining references to wingraphviz
mod - core/graphviz_api.php Diff File
mod - core/relationship_graph_api.php Diff File
 First  Prev  1 2 3 ... 70 ... 140 ... 210 ... 280 ... 296 297 298 299 300 301 302 ... 350 ... 420 ... 490 ... 560 ... 630 ... 700 ... 743 744 745  Next  Last