Search Changesets

MantisBT: master 0bf66447

2010-01-19 02:06:10

dhx

Details Diff
Fix 0011413: Product version field string not localised in history Affected Issues
0011413
mod - core/history_api.php Diff File

MantisBT: master 370303cc

2010-01-17 23:35:57

dhx

Details Diff
Allow configuration values to be rearranged in config_defaults

Within config_defaults_inc.php, the following syntax doesn't allow for
configuration values to be rearranged within the file:
$g_some_value = $g_something_else

Instead we should use the following syntax where references to other
values (anywhere in the file, even if not declared yet) are resolved
after the entire config_defaults_inc.php file is loaded:
$g_some_value = '%something_else%'
Attach Issues:
mod - config_defaults_inc.php Diff File

MantisBT: master e0064ff8

2010-01-17 23:33:18

dhx

Details Diff
Use the word "Issue" instead of "Bug" for revision history message
Attach Issues:
mod - lang/strings_english.txt Diff File

MantisBT: master 592f4d7f

2010-01-17 13:37:32

siebrand

Details Diff
We have issues and notes. "bugs" and "bugnotes" are nonos!
Attach Issues:
mod - lang/strings_english.txt Diff File

MantisBT: master-1.2.x 4dfa1334

2010-01-17 12:30:28

dhx

Details Diff
Remove duplicate checks that are performed in project_hierarchy_cache
Attach Issues:
mod - core/project_hierarchy_api.php Diff File

MantisBT: master b4581cdc

2010-01-17 12:30:28

dhx

Details Diff
Remove duplicate checks that are performed in project_hierarchy_cache
Attach Issues:
mod - core/project_hierarchy_api.php Diff File

MantisBT: master-1.2.x b9bd7394

2010-01-17 11:57:40

dhx

Details Diff
Fix 0011403: Bugnote ID not formatted correctly in history (view status)

When changing the view state of a bugnote, the history item added looks
something like:

Note View State: private: 214

Note that the bugnote ID 214 is not properly formatted. It should be
showing something like this instead:

Note View State: 0000214: private
Affected Issues
0011403
mod - core/history_api.php Diff File
mod - core/bugnote_api.php Diff File

MantisBT: master e7283356

2010-01-17 11:57:40

dhx

Details Diff
Fix 0011403: Bugnote ID not formatted correctly in history (view status)

When changing the view state of a bugnote, the history item added looks
something like:

Note View State: private: 214

Note that the bugnote ID 214 is not properly formatted. It should be
showing something like this instead:

Note View State: 0000214: private
Affected Issues
0011403
mod - core/bugnote_api.php Diff File
mod - core/history_api.php Diff File

MantisBT: master 14a00b72

2010-01-17 11:39:09

dhx

Details Diff
Issue 0011404: Record dropping of bug revisions in bug history

When dropping bug revisions (bugnotes, description, steps to reproduce
and additional information) we should be recording this event in the bug
history. This maintains an audit log of who and at what time revision
data was permanently deleted.

This commit also fixes an issue whereby links in the history were still
shown for bug revisions that had been dropped. Users would thus click a
link to come across a 'revision not found' error message.
Affected Issues
0011404
mod - core/bug_revision_api.php Diff File
mod - core/constant_inc.php Diff File
mod - core/history_api.php Diff File
mod - lang/strings_english.txt Diff File

MantisBT: master dac9d0aa

2010-01-17 11:32:56

dhx

Details Diff
Issue 0011405: Add link to bugnote revisions within bugnote display

For bugnotes that have been edited, revisions may exist. If they do (ie.
they haven't been dropped by someone with permission to do so) then we
can display a count of revisions and a link to the page where users can
view previous revisions of a bugnote.
Affected Issues
0011405
mod - lang/strings_english.txt Diff File
mod - bugnote_view_inc.php Diff File
mod - print_all_bug_page_word.php Diff File
mod - print_bugnote_inc.php Diff File

MantisBT: master da6c133f

2010-01-17 08:43:08

dhx

Details Diff
Issue 0010884: Improve granularity of bugnote permissions

Currently it's only possible to use a single
$g_bugnote_allow_user_edit_delete setting to turn ON or OFF the ability
for users to be able to edit/delete their own bugnotes.

This patch provides improvement to the granularity of bugnote
permissions to make the following possible:
1) Separate edit and delete permissions
2) Thresholds instead of boolean switches
3) Ability for users to change the view state of their own bugnotes

On the topic of view states, the $g_set_view_status_threshold setting
controls whether a user can make a bug or bug note private at the time
of reporting/posting. The existing $g_change_view_status_threshold
setting allows users to change the view state of any bug or bug note
after they've been reported/posted. This patch introduces
$g_bugnote_user_change_view_state_threshold which allows administrators
to give users the the ability to make their own bugnotes public or
private as they choose, at any time.

$g_bugnote_user_edit_threshold is a new setting that can be changed to
allow users the ability to edit their own bugnotes.
$g_bugnote_user_delete_threshold is a new setting that can be changed to
allow users the ability to delete their own bugnotes. You may be
wondering why there is a difference when a user could simply edit and
blank their bugnote. The answer lies with bugnote revisions and the
ability for users to see a revision history of each bug that has been
edited.

Many thanks to Chris Fitch for the original idea and an initial patch
from August 2009. This patch is a rewrite of his earlier work with a
number of additional changes and improvements.
Affected Issues
0010884
mod - config_defaults_inc.php Diff File
mod - lang/strings_english.txt Diff File
mod - bugnote_add.php Diff File
mod - manage_config_work_threshold_set.php Diff File
mod - bugnote_delete.php Diff File
mod - bugnote_update.php Diff File
mod - docbook/adminguide/en/page_descriptions.sgml Diff File
mod - docbook/adminguide/en/configuration.sgml Diff File
mod - core/bugnote_api.php Diff File
mod - bugnote_edit_page.php Diff File
mod - manage_config_work_threshold_page.php Diff File
mod - core/obsolete.php Diff File
mod - bugnote_set_view_state.php Diff File
mod - bugnote_view_inc.php Diff File
mod - bugnote_add_inc.php Diff File

MantisBT: master-1.2.x 2c8f64b0

2010-01-17 04:35:50

dhx

Details Diff
Fix 0004654: Preserve sort field and order when changing filter

Clicking on one of the alphabetical filters (A-Z, etc) would reset the
currently selected sort field and sort order. Additionally, toggling the
"Hide inactive" checkbox reset the filter to 'All' even if you had
something else selected at the time.
Affected Issues
0004654
mod - manage_user_page.php Diff File

MantisBT: master 391d3e80

2010-01-17 04:35:50

dhx

Details Diff
Fix 0004654: Preserve sort field and order when changing filter

Clicking on one of the alphabetical filters (A-Z, etc) would reset the
currently selected sort field and sort order. Additionally, toggling the
"Hide inactive" checkbox reset the filter to 'All' even if you had
something else selected at the time.
Affected Issues
0004654
mod - manage_user_page.php Diff File

MantisBT: master-1.2.x e8ae3806

2010-01-17 03:57:30

dhx

Details Diff
project_hierarchy_cache function shouldn't be called outside API

Caching of project hierarchies is a concept that should be internal to
project_hierarchy_api. External users of this API should not know or
have to care about caching.
Attach Issues:
mod - core/version_api.php Diff File
mod - core/print_api.php Diff File
mod - manage_proj_page.php Diff File
mod - core/category_api.php Diff File
mod - manage_proj_edit_page.php Diff File

MantisBT: master 443d28a2

2010-01-17 03:57:30

dhx

Details Diff
project_hierarchy_cache function shouldn't be called outside API

Caching of project hierarchies is a concept that should be internal to
project_hierarchy_api. External users of this API should not know or
have to care about caching.
Attach Issues:
mod - manage_proj_page.php Diff File
mod - core/version_api.php Diff File
mod - core/category_api.php Diff File
mod - manage_proj_edit_page.php Diff File
mod - core/print_api.php Diff File

MantisBT: master-1.2.x dd258c75

2010-01-17 03:49:40

dhx

Details Diff
Fix 0011402: Project hierarchy cache problem on manage_proj_edit_page.php

manage_proj_edit_page.php didn't cache project hierarchies with disabled
projects included. Thus errors relating to in_array() were seen when
attempting to edit a parent project when one of the sub-projects was
marked as being disabled.
Affected Issues
0011402
mod - manage_proj_edit_page.php Diff File
mod - core/project_hierarchy_api.php Diff File

MantisBT: master bf80e9ee

2010-01-17 03:49:40

dhx

Details Diff
Fix 0011402: Project hierarchy cache problem on manage_proj_edit_page.php

manage_proj_edit_page.php didn't cache project hierarchies with disabled
projects included. Thus errors relating to in_array() were seen when
attempting to edit a parent project when one of the sub-projects was
marked as being disabled.
Affected Issues
0011402
mod - core/project_hierarchy_api.php Diff File
mod - manage_proj_edit_page.php Diff File

MantisBT: master-1.2.x d6b2fd09

2010-01-17 03:00:03

dhx

Details Diff
Fix 0010818: MetaColumnNames ADOdb function may return bool value

The MetaColumnNames ADOdb function doesn't always return an array - it
could return a boolean value of false as well. Therefore before using
the result of a call to MetaColumnNames, we must first check that we've
got a valid array. ADOdb documentation of course doesn't mention this.
Affected Issues
0010818
mod - manage_user_page.php Diff File
mod - core/database_api.php Diff File

MantisBT: master 90d3d4db

2010-01-17 03:00:03

dhx

Details Diff
Fix 0010818: MetaColumnNames ADOdb function may return bool value

The MetaColumnNames ADOdb function doesn't always return an array - it
could return a boolean value of false as well. Therefore before using
the result of a call to MetaColumnNames, we must first check that we've
got a valid array. ADOdb documentation of course doesn't mention this.
Affected Issues
0010818
mod - manage_user_page.php Diff File
mod - core/database_api.php Diff File

MantisBT: master-1.2.x 9b1fbd77

2010-01-17 02:17:24

dhx

Details Diff
Fix 0011400: Update documentation of $g_view_configuration_threshold

Commit 5c727ba9ac508201434e7d5361297f367a206463 changed the default
value of $g_view_configuration_threshold from VIEWER to ADMINISTRATOR.
However, I forgot to update the documentation to reflect this change.

Thank you Victor for reminding me!

Note that this backport includes documentation of the configuration
view/set threshold options that were introduced in commit
fce04e6597310e9dd644612348354dc055e99dfa but weren't backported to the
1.2.x branch at that point of time.
Affected Issues
0011400
mod - docbook/adminguide/en/configuration.sgml Diff File

MantisBT: master e1d134e7

2010-01-17 02:17:24

dhx

Details Diff
Fix 0011400: Update documentation of $g_view_configuration_threshold

Commit 5c727ba9ac508201434e7d5361297f367a206463 changed the default
value of $g_view_configuration_threshold from VIEWER to ADMINISTRATOR.
However, I forgot to update the documentation to reflect this change.

Thank you Victor for reminding me!
Affected Issues
0011400
mod - docbook/adminguide/en/configuration.sgml Diff File

MantisBT: master e22eeacf

2010-01-15 14:03:33

dhx

Details Diff
Fix 0011395: show_queries_list should be a global option Affected Issues
0011395
mod - config_defaults_inc.php Diff File

MantisBT: master-1.2.x f3d5815f

2010-01-15 14:01:32

dhx

Details Diff
Fix 0011395: show_queries_list should be a global option Affected Issues
0011395
mod - config_defaults_inc.php Diff File

MantisBT: master-1.2.x 589ef8ff

2010-01-15 13:55:15

dhx

Details Diff
Fix 0011400: Increase default $g_view_configuration_threshold

By default, $g_view_configuration_threshold is currently set to
DEVELOPER. This option should really be changed to have a default of
ADMINISTRATOR, as the configuration of MantisBT can contain sensitive
information.

There won't be impact to current installations, as users at DEVELOPER
level have no links whatsoever in the UI to the adm_ and manage_ pages
of MantisBT.
Affected Issues
0011400
mod - config_defaults_inc.php Diff File

MantisBT: master 5c727ba9

2010-01-15 13:55:15

dhx

Details Diff
Fix 0011400: Increase default $g_view_configuration_threshold

By default, $g_view_configuration_threshold is currently set to
DEVELOPER. This option should really be changed to have a default of
ADMINISTRATOR, as the configuration of MantisBT can contain sensitive
information.

There won't be impact to current installations, as users at DEVELOPER
level have no links whatsoever in the UI to the adm_ and manage_ pages
of MantisBT.
Affected Issues
0011400
mod - config_defaults_inc.php Diff File
 First  Prev  1 2 3 ... 60 ... 120 ... 180 ... 240 ... 300 ... 357 358 359 360 361 362 363 ... 420 ... 480 ... 540 ... 600 ... 645 646 647  Next  Last