Search Changesets

MantisBT: master 5c91053e

2024-02-16 18:47

dregad


Details Diff
REST: /projects includes category status

Issue 0031017
Affected Issues
0031017
mod - api/soap/mc_project_api.php Diff File

MantisBT: master fc4c9462

2024-02-16 18:43

dregad


Details Diff
SOAP: only return enabled categories

mc_project_get_categories() should not return disabled categories.

Issue 0031017
Affected Issues
0031017
mod - api/soap/mantisconnect.wsdl Diff File
mod - api/soap/mc_project_api.php Diff File

MantisBT: master 856b7c6d

2024-02-16 18:36

dregad


Details Diff
New function mci_project_initial_checks()

Avoid duplicated code in
- mc_project_get_categories()
- mc_project_add_category()
- mc_project_delete_category()
mod - api/soap/mc_project_api.php Diff File

MantisBT: master 7ab9a6cf

2024-02-16 18:32

dregad


Details Diff
New function mci_project_get_versions()

Avoid duplicated code in
- mc_project_get_versions()
- mc_project_get_released_versions()
- mc_project_get_unreleased_versions()
mod - api/soap/mc_project_api.php Diff File

MantisBT: master ef8b79aa

2024-02-16 18:24

dregad


Details Diff
New function mci_project_get_row()

Avoid duplicated code in
- mc_projects_get_user_accessible
- mci_user_get_accessible_subprojects()
mod - api/soap/mc_api.php Diff File
mod - api/soap/mc_project_api.php Diff File

MantisBT: master 6b1fcc13

2024-02-16 18:15

dregad


Details Diff
PHPDoc
mod - api/soap/mc_project_api.php Diff File

MantisBT: master 3072c167

2024-02-16 18:13

dregad


Details Diff
Fix static analysis warnings
mod - api/soap/mc_project_api.php Diff File

MantisBT: master ff09c2ed

2024-02-16 12:23

dregad


Details Diff
Prevent disabling category if used as default

If the category being disabled is used as default_category_for_moves in
any project, then category_update() now fails with an error.

Issue 0031017
Affected Issues
0031017
mod - core/category_api.php Diff File

MantisBT: master c23ed60d

2024-02-16 12:14

dregad


Details Diff
Made category default error message more generic

Originally, the message was only about deleting a category that is set
as default for moves. This makes the message more generic, so it can
also be used in other scenarios such as update.
Made category default error message more generic

Originally, the message was only about deleting a category that is set
as default for moves. This makes the message more generic, so it can
also be used in other scenarios such as update.

The ERROR_CATEGORY_CANNOT_DELETE_DEFAULT constant was renamed to
ERROR_CATEGORY_CANNOT_UPDATE_DEFAULT to reflect the new semantics.

Issue 0031017
Affected Issues
0031017
mod - api/soap/mc_api.php Diff File
mod - core/category_api.php Diff File
mod - core/constant_inc.php Diff File
mod - lang/strings_arabic.txt Diff File
mod - lang/strings_belarusian_tarask.txt Diff File
mod - lang/strings_breton.txt Diff File
mod - lang/strings_bulgarian.txt Diff File
mod - lang/strings_catalan.txt Diff File
mod - lang/strings_chinese_simplified.txt Diff File
mod - lang/strings_chinese_traditional.txt Diff File
mod - lang/strings_czech.txt Diff File
mod - lang/strings_danish.txt Diff File
mod - lang/strings_dutch.txt Diff File
mod - lang/strings_english.txt Diff File
mod - lang/strings_french.txt Diff File
mod - lang/strings_galician.txt Diff File
mod - lang/strings_german.txt Diff File
mod - lang/strings_hebrew.txt Diff File
mod - lang/strings_hungarian.txt Diff File
mod - lang/strings_icelandic.txt Diff File
mod - lang/strings_interlingua.txt Diff File
mod - lang/strings_italian.txt Diff File
mod - lang/strings_japanese.txt Diff File
mod - lang/strings_korean.txt Diff File
mod - lang/strings_lithuanian.txt Diff File
mod - lang/strings_macedonian.txt Diff File
mod - lang/strings_norwegian_bokmal.txt Diff File
mod - lang/strings_occitan.txt Diff File
mod - lang/strings_polish.txt Diff File
mod - lang/strings_portuguese_brazil.txt Diff File
mod - lang/strings_portuguese_standard.txt Diff File
mod - lang/strings_romanian.txt Diff File
mod - lang/strings_russian.txt Diff File
mod - lang/strings_serbian.txt Diff File
mod - lang/strings_serbian_latin.txt Diff File
mod - lang/strings_slovak.txt Diff File
mod - lang/strings_spanish.txt Diff File
mod - lang/strings_swedish.txt Diff File
mod - lang/strings_swissgerman.txt Diff File
mod - lang/strings_tagalog.txt Diff File
mod - lang/strings_turkish.txt Diff File
mod - lang/strings_ukrainian.txt Diff File
mod - lang/strings_vietnamese.txt Diff File

MantisBT: master-2.26 e603b49e

2024-02-14 09:01

dsribouavong


Details Diff
Fix overflowing text in collapsed sidebar menu

Signed-off-by: Damien Regad <dregad@mantisbt.org>

Original commit rebased to master-2.26 branch
mod - css/ace-mantis.css Diff File

MantisBT: master d46c6a92

2024-02-13 10:47

dregad


Details Diff
Merge branch 'master-2.26'
mod - library/rssbuilder/class.ObjectIterator.inc.php Diff File
mod - library/rssbuilder/class.ObjectList.inc.php Diff File

MantisBT: master-2.26 7dcb81cd

2024-02-13 10:45

dregad


Details Diff
Revert "Fix Error when creating empty RSS feed on PHP 8"

This reverts commit 0e241f33687ce4af5ef483b7f3cbd2ffd8817838.
Affected Issues
0033634
mod - library/README.md Diff File
mod - library/rssbuilder/class.ObjectIterator.inc.php Diff File

MantisBT: master 60061f31

2024-02-13 10:43

dregad


Details Diff
Merge branch 'i33634-rssbuilder'
mod - library/README.md Diff File
mod - library/rssbuilder/class.ObjectIterator.inc.php Diff File

MantisBT: master-2.26 9a8f1277

2024-02-13 10:39

dregad


Details Diff
Fix Error when creating empty RSS feed on PHP 8

When the feed is empty, ObjectIterator::size() throws a TypeError
exception on PHP 8.0+ (and a Warning on PHP 7.2+) due to calling count()
on $this->objectlist->objects, which is null in this case.

Initializing the ObjectList::$objects property to an empty array ensures
this never happens.

File was converted to UTF-8 and trailing ?> removed.

Fixes 0033634
Affected Issues
0033634
mod - library/README.md Diff File
mod - library/rssbuilder/class.ObjectList.inc.php Diff File

MantisBT: master-2.26 0e241f33

2024-02-13 03:44

tm8544


Details Diff
Fix Error when creating empty RSS feed on PHP 8

When the feed is empty, ObjectIterator::size() throws a TypeError
exception on PHP 8.0+ (and a Warning on PHP 7.2+) due to calling count()
on $this->objectlist->objects, which is null in this case.

Fixes 0033634

Signed-off-by: Damien Regad <dregad@mantisbt.org>

- Rewrote original commit message
- Fixed whitespace
- Updated library\README.md
- Removed closing `?>` tag
Affected Issues
0033634
mod - library/README.md Diff File
mod - library/rssbuilder/class.ObjectIterator.inc.php Diff File

MantisBT: master e3f572c0

2024-02-12 11:49

dregad


Details Diff
Display warning if Issue has disabled category

Warning icon with descriptive tooltip is displayed when

- viewing an issue and allowed to edit it
- editing issue

Issue 0031017
Affected Issues
0031017
mod - bug_update_page.php Diff File
mod - bug_view_inc.php Diff File
mod - core/category_api.php Diff File
mod - lang/strings_english.txt Diff File

MantisBT: master ed41f512

2024-02-12 11:47

dregad


Details Diff
Only propose enabled categories

It should not be possible to select a disabled category

- when mass-updating issues
- as fallback when importing issues (XmlImportExport plugin)

Issue 0031017
Affected Issues
0031017
mod - bug_actiongroup_page.php Diff File
mod - plugins/XmlImportExport/pages/import.php Diff File

MantisBT: master 290f9886

2024-02-12 11:43

dregad


Details Diff
Fix category not found error when reporting bug

Regression introduced by 0f302a8d
mod - core/print_api.php Diff File

MantisBT: master 8996d431

2024-02-12 07:10

translatewiki.net


Details Diff
Localisation updates from https://translatewiki.net. [skip ci]
mod - lang/strings_chinese_simplified.txt Diff File

MantisBT: master b8d2f120

2024-02-11 19:22

dregad


Details Diff
Fix failing CategoryTest

To maintain backwards-compatibility, category_update() signature was
modified so the new $p_status parameter is not mandatory, and defaults
to null to keep the category's existing status.

Issue 0031017
Affected Issues
0031017
mod - core/category_api.php Diff File

MantisBT: master af14961f

2024-02-11 11:50

dregad


Details Diff
Keep current disabled category when editing issue

When an issue assigned to a disabled category is edited, the category
should be kept as-is unless the user specifically updated it.

Update print_category_option_list() to add the current category, but
label it as disabled so the user knows they should change it, and set
the disabled attribute on the option so it can't be re-selected once
changed.

Fixes 0031017
Affected Issues
0031017
mod - core/print_api.php Diff File
mod - lang/strings_english.txt Diff File

MantisBT: master 43c11309

2024-02-11 10:41

dregad


Details Diff
Use th instead of td for categories table header
mod - manage_proj_page.php Diff File

MantisBT: master 23c30980

2024-02-11 10:28

dregad


Details Diff
Schema update to set category.status default to 1

Fixes 0031017
Affected Issues
0031017
mod - admin/schema.php Diff File
mod - core/install_helper_functions_api.php Diff File

MantisBT: master 05c1639f

2024-02-11 10:20

dregad


Details Diff
Use enabled/disabled for category status

Since we currently only use a binary state (enabled/disabled) for the
status, we do not need to make things more complex than they have to be.

This simplifies @cas's original contribution by:
- using a checkbox for input instead of radio buttons
- display a check icon instead of relying on language strings in lists
- standardize on enabled/disabled terminology

This also fixes the "inverted logic" (status == 0 was previously treated
as enabled, which is the reverse of one would expect.

Fixes 0031017
Affected Issues
0031017
mod - bug_report_page.php Diff File
mod - bug_update_page.php Diff File
mod - core/category_api.php Diff File
mod - core/print_api.php Diff File
mod - lang/strings_english.txt Diff File
mod - manage_proj_cat_edit_page.php Diff File
mod - manage_proj_cat_update.php Diff File
mod - manage_proj_edit_page.php Diff File
mod - manage_proj_page.php Diff File

MantisBT: master cefd6643

2024-02-11 08:14

dregad


Details Diff
Use CATEGORY_STATUS_DISABLED constant instead of 0
mod - core/category_api.php Diff File
 First  Prev  1 2 3 4 5 6 7 8 ... 70 ... 140 ... 210 ... 280 ... 350 ... 420 ... 490 ... 560 ... 630 ... 700 ... 743 744 745  Next  Last