Search Changesets

MantisBT: master 827b098c

2017-04-23 02:24:26

vboctor

Details Diff
REST: Fix error when user can’t assign/handle issues
Attach Issues:
mod - api/soap/mc_issue_api.php Diff File

MantisBT: master 4377d17f

2017-04-23 02:02:44

vboctor

Details Diff
Fix soap test cases for ‘no category’ case
Attach Issues:
mod - api/soap/mc_api.php Diff File

MantisBT: master ec331713

2017-04-23 00:13:16

vboctor

Details Diff
SOAP: Fix unit tests that were based old behavior

- Don’t expect ETA fields if not enabled
- Don’t expect Project fields if not enabled
- Don’t expect undefined versions to be set on issue.
- `testUpdateWithRareFields()` was being skipped when time tracking is disabled, though it is unrelated.
- Don’t test profile/build/platform fields if disabled.
- Have default timestamp in bootstrap file to avoid failures in some dev/test envs.
Attach Issues:
mod - tests/bootstrap.php.sample Diff File
mod - tests/soap/IssueAddTest.php Diff File
mod - tests/soap/IssueUpdateTest.php Diff File

MantisBT: master 2d043629

2017-04-22 22:40:57

vboctor

Details Diff
REST: Mark `timelog` as `note` if time is hidden

If time tracking is not accessible, then return the note type as `note` instead of `timelog`.
Attach Issues:
mod - api/soap/mc_issue_api.php Diff File

MantisBT: master 9503e7ff

2017-04-22 22:27:28

vboctor

Details Diff
REST: Include version id in version references

Instead of just returning the name, also return the version id.
This is consistent with other fields like category, priority, etc.
If version is not found, return null. This also applies for SOAP API.
Attach Issues:
mod - api/soap/mc_api.php Diff File
mod - api/soap/mc_issue_api.php Diff File

MantisBT: master 309c66dd

2017-04-22 22:12:44

vboctor

Details Diff
API: Use due_date access check based on project

When creating/updating issues, check user project access level rather than global.
Attach Issues:
mod - api/soap/mc_issue_api.php Diff File

MantisBT: master 7b3126f3

2017-04-22 22:06:23

vboctor

Details Diff
REST: Implement `mci_get_version()` and use it

- Implement `mci_get_version()` similar to `mci_get_category()`
- Move `mci_get_category()` from `mc_issue_api.php` to `mc_api.php`.
- Change `mci_get_category()` to return null instead of array( ‘category’ => null )
in case of REST when category is not set.
- For SOAP if category is not set, return null from `mci_get_category()`.
Attach Issues:
mod - api/soap/mc_api.php Diff File
mod - api/soap/mc_issue_api.php Diff File

MantisBT: master 7982443f

2017-04-22 21:54:43

vboctor

Details Diff
REST: enum localization fixes

- Enum name should reflect english enum name.
- Fix php error due to referencing enum by localized name.
- Remove `mci_get_enum_element()` which is not needed.
Attach Issues:
mod - api/soap/mc_api.php Diff File
mod - api/soap/mc_enum_api.php Diff File

MantisBT: master 36d14785

2017-04-22 16:10:23

vboctor

Details Diff
REST: Add access and config checks for issue info
Attach Issues:
mod - api/soap/mc_issue_api.php Diff File

MantisBT: master e84e0f6b

2017-04-22 15:42:47

vboctor

Details Diff
REST: Update `mci_get_category()` to handle REST
Attach Issues:
mod - api/soap/mc_issue_api.php Diff File

MantisBT: master eec9a03f

2017-04-22 15:37:10

vboctor

Details Diff
REST: `mci_issue_data_as_array()` code cleanup

- Fix indentation
- Fix some ordering (more to do later).
Attach Issues:
mod - api/soap/mc_issue_api.php Diff File

MantisBT: master 709fbdef

2017-04-22 15:21:55

vboctor

Details Diff
REST: Extend get issue to return 1 or many

- Use consistent response payload when returning 1 or many. This changed the
payload when getting a single issue.
- Support pagination when returning multiple issues.
- Support returning multiple issues based on a `project_id`.
- Support returning multiple issues based on a filter id + `project_id`.
Attach Issues:
mod - api/rest/restcore/issues_rest.php Diff File

MantisBT: master fbf5cbb9

2017-04-22 15:18:57

vboctor

Details Diff
REST: Normalize issue when retrieving 1 or many

- Instead of having different code for preparing a single vs. multiple issue. Use one.
- Use an object rather than a string for version, target version, and fixed in version.
- Always check that user has access to view handler.
Attach Issues:
mod - api/soap/mc_issue_api.php Diff File

MantisBT: master 173c111d

2017-04-22 15:15:54

vboctor

Details Diff
REST: Improve formatting of notes

- If `attr` is empty don’t include it.
- If note is not of type `timelog` don’t return time_tracking minutes.
Attach Issues:
mod - api/soap/mc_issue_api.php Diff File

MantisBT: master 712ddde0

2017-04-22 15:14:41

vboctor

Details Diff
REST: Include status color along with status info
Attach Issues:
mod - api/soap/mc_enum_api.php Diff File

MantisBT: master a6497fec

2017-04-22 14:26:53

vboctor

Details Diff
Update issues formatting in REST API

- Use `created_at` rather than ‘date_submitted`
- Use `updated_at` rather than `last_updated`.
- Make `sticky` a boolean rather than a numeric string.
- Don’t include `sponsorship_total`
Attach Issues:
mod - api/soap/mc_issue_api.php Diff File

MantisBT: master cd4021e6

2017-04-22 14:24:45

vboctor

Details Diff
Include enum localized label in enum references
Attach Issues:
mod - api/soap/mc_enum_api.php Diff File

MantisBT: master 05977c0b

2017-04-22 04:15:19

vboctor

Details Diff
Fix error message when user can’t handle issues

The access denied reason was passed in instead of user id, causing error message
to show user id of 0 and no reason. The fix was to pass the user id then reason.

Also changed reason messages to not re-reference the user id, but just focus on reason.

Messages will look as follows:
`Access denied for vboctor. Reason: User does not have access right to handle issues.`

Fixes 0022762
Affected Issues
0022762
mod - api/soap/mc_issue_api.php Diff File

MantisBT: master f845b24e

2017-04-22 02:49:20

vboctor

Details Diff
Merge remote-tracking branch 'origin/master-2.3'
Attach Issues:
mod - core/current_user_api.php Diff File
mod - core/date_api.php Diff File

MantisBT: master f793714a

2017-04-20 01:35:47

translatewiki.net

Details Diff
Localisation updates from https://translatewiki.net.
Attach Issues:
mod - lang/strings_breton.txt Diff File
mod - lang/strings_bulgarian.txt Diff File
mod - lang/strings_french.txt Diff File
mod - lang/strings_greek.txt Diff File

Tools: master af7c4fab

2017-04-19 13:10:58

dregad

Details Diff
New restore issue script

Following accidental deletion of several issues, this script was written
to assist restoring individual issues including related records from a
database backup.

Issue #22747
Affected Issues
0022747
add - restore_issue.php Diff File

MantisBT: master-2.3 9c9297e2

2017-04-19 11:40:51

vboctor

Details Diff
Lost password email validation fix

This was caused when:
- anonymous authentication is OFF.
- email address is left empty.

This caused calling auth_get_current_user_id() when no user is authenticated
which causes user to get redirected to login page and then get directed to
lost password action page, which then complains that there is no valid form
security token.

The correct behavior is to prompt an error message that email address is invalid.

Fixes 0022746
Affected Issues
0022746
mod - core/current_user_api.php Diff File

MantisBT: master 90bab53d

2017-04-18 21:32:15

vboctor

Details Diff
Fix access denied loop when user not logged in

Fixes 0022740
Affected Issues
0022740
mod - core/authentication_api.php Diff File

MantisBT: master 3f7aa4b2

2017-04-18 21:19:06

vboctor

Details Diff
Fix broken signup

- Fix php error when user clicks signup.
- Revert change to `auth_can_change_password` custom function.

Fixes 0022744
Affected Issues
0022744
mod - core/authentication_api.php Diff File
mod - core/custom_function_api.php Diff File
mod - signup.php Diff File
mod - signup_page.php Diff File

MantisBT: master-2.3 dc9560f2

2017-04-18 17:00:37

cproensa

Details Diff
Fix missing line after revert in PR1093

A line was missing after applying the reverts contained in PR1093

Related Issue: 0022663
Affected Issues
0022663
mod - core/date_api.php Diff File
 First  Prev  1 2 3 ... 55 56 57 58 59 60 61 ... 70 ... 140 ... 210 ... 280 ... 350 ... 420 ... 490 ... 560 ... 630 ... 650 651 652  Next  Last