Search Changesets

MantisBT: master-1.3.x b933abcb

2017-04-12 08:29:01

dregad

Details Diff
db_get_table() also check suffix for legacy-style names

If $db_table_plugin_prefix contains 'mantis', db_get_table() function
will incorrectly process a plugin's tables as if they were legacy tables
(i.e. 'Mantis 1.2 style', with a 'mantis_' prefix).

If $db_table_suffix also is not set to '_table', then the generated table
name will be incorrect (e.g. with the Source Integration plugin,
changeset table will be generated as 'mantis_Source_ch_suffix' instead
of 'mantis_mantis_Source_changeset_suffix'), causing the installation by
plugin_upgrade() to fail and invalid tables to be created.

We now use a regex to check for legacy tables, verifying that it ends
with '_table' in addition to beginning with 'mantis_'. This basically
reverts commit 38bc02483eb58a3708e4f419bfa7c02b6c6900db (issue 0016038).

Note on performance: while preg_match() is slower than strpos(), it is
actually more efficient to use that, considering that we would need a
second function call to check for the suffix, as well as a substr() call
to extract the table name, while preg_match() does it all at once.

Fixes 0020168

Backported from master 4917320b2067f5797aa87e5772a820e6b5a177cc.
Affected Issues
0016038, 0020168
mod - core/database_api.php Diff File

MantisBT: master 6e60b691

2017-04-12 05:56:22

cproensa

Details Diff
Refactor filter storing in db

Create separate functions to
- filter_db_create_filter(): create a standard filter
- filter_set_project_filter(): store special case of "current" filter.

Remove filter_db_set_for_current_user() which had both the functionality
mixed.

Simplifies handling of how and when saving/loading filters in each scenario.
Attach Issues:
mod - core/filter_api.php Diff File
mod - core/user_api.php Diff File
mod - query_store.php Diff File
mod - search.php Diff File
mod - view_all_set.php Diff File

MantisBT: master 9b639e71

2017-04-11 18:52:16

cproensa

Details Diff
Remove obsolete comments
Attach Issues:
mod - view_all_set.php Diff File

MantisBT: master e49b9cbe

2017-04-11 13:08:06

cproensa

Details Diff
Remove usage of view_all_cookie

Tracking the current filter id in a cookie is not needed.
Filter cookies were replaced with database stored filters since 2004
Attach Issues:
mod - core/filter_api.php Diff File
mod - print_all_bug_page.php Diff File
mod - query_store.php Diff File
mod - query_store_page.php Diff File
mod - search.php Diff File
mod - view_all_set.php Diff File

MantisBT: master 4f2df23c

2017-04-11 09:00:09

cproensa

Details Diff
Remove filter_is_cookie_valid

This function is no longer needed.
Attach Issues:
mod - core/current_user_api.php Diff File
mod - core/filter_api.php Diff File

MantisBT: master 065f2daf

2017-04-11 05:06:33

cproensa

Details Diff
comments
Attach Issues:
mod - core/filter_api.php Diff File

MantisBT: master 9b5cbfb0

2017-04-11 04:53:34

cproensa

Details Diff
Remove functionality: serialized filter as parameter

current_user_get_bug_filter was reading for a gpc variable "filter",
which can represents a json encoded filter array
This means that this parameter would override the usual filter workflows
if present.
AFAIK, this is not used currently in mantis, and may be an old
implementation.

Keep the existing "filter" parameter as a numerical id, whcih point to
the token_id which holds a temporary filter
Attach Issues:
mod - core/current_user_api.php Diff File

MantisBT: master 989bc9e5

2017-04-11 04:06:42

cproensa

Details Diff
Refactor filter_draw_selection_area
Attach Issues:
mod - core/filter_api.php Diff File

MantisBT: master 1ef52ab9

2017-04-11 03:58:20

cproensa

Details Diff
Rename filter_db_get_filter
Attach Issues:
mod - core/filter_api.php Diff File
mod - query_store_page.php Diff File

MantisBT: master ed97f955

2017-04-11 02:52:06

syncguru

Details Diff
Fix rendering of on-page debug logs in modern ui

Fixes 0022672
Affected Issues
0021558, 0022672
mod - core/layout_api.php Diff File
mod - core/logging_api.php Diff File

MantisBT: master 7f31a490

2017-04-10 20:09:35

cproensa

Details Diff
Remove $g_cache_filter_db_serialized

The filter string cache is not needed, as those strings are part of the
filter db rows, and those are already cached.
Attach Issues:
mod - core/filter_api.php Diff File

MantisBT: master 5d9ecf10

2017-04-10 18:57:50

cproensa

Details Diff
Use new function filter_get()

Remove calls to low level filter loading, and use filter_get() instead.
Attach Issues:
mod - api/soap/mc_filter_api.php Diff File
mod - core/filter_api.php Diff File
mod - core/user_api.php Diff File
mod - issues_rss.php Diff File
mod - manage_filter_edit_page.php Diff File
mod - manage_filter_edit_update.php Diff File
mod - print_all_bug_page.php Diff File
mod - query_store.php Diff File
mod - return_dynamic_filters.php Diff File
mod - view_all_set.php Diff File
mod - view_filters_page.php Diff File

MantisBT: master eebfa6d7

2017-04-10 18:44:15

cproensa

Details Diff
Ensure filter_deserialize returns a valid array

Always run filter_ensure_valid_filter
Set the actual version in the array, as read from the serialized string.
Attach Issues:
mod - core/filter_api.php Diff File

MantisBT: master 65c16157

2017-04-10 18:28:11

cproensa

Details Diff
create filter_get

Create filter_get function to encapsulate the loading of a filter array
for a filter_id.
Attach Issues:
mod - core/filter_api.php Diff File

MantisBT: master fb44aad1

2017-04-10 17:32:00

cproensa

Details Diff
remove filter_cache_row

Remove filter_cache_row in favour of filter_get_row
Remove "trigger error" functionality from filter_cache_row, since it was
not used or already assumed by the callers.
Attach Issues:
mod - api/soap/mc_filter_api.php Diff File
mod - core/filter_api.php Diff File
mod - core/user_api.php Diff File
mod - manage_filter_edit_page.php Diff File
mod - manage_filter_edit_update.php Diff File
mod - return_dynamic_filters.php Diff File
mod - view_filters_page.php Diff File

MantisBT: master 558bb1e1

2017-04-10 17:06:35

cproensa

Details Diff
rename filter_db_get_queries
Attach Issues:
mod - core/filter_api.php Diff File
mod - manage_filter_page.php Diff File

MantisBT: master 11cd96e6

2017-04-10 16:38:26

cproensa

Details Diff
rename filter cache variables

add comments
Attach Issues:
mod - core/filter_api.php Diff File

MantisBT: master-2.3 757320b2

2017-04-10 10:14:11

José D. Grieco

Details Diff
Missing "echo" in date-picker-locale attrib in due date field Affected Issues
0022700
mod - bug_change_status_page.php Diff File

MantisBT: master-2.3 cfbc5e54

2017-04-10 08:17:14

dregad

Details Diff
Verify account only if a request is in progress

The account verification page should only proceed and allow updating the
user's profile (including resetting their password) when there is an
active activation token.

Fixes 0022690
Affected Issues
0022690
mod - verify.php Diff File

MantisBT: master-2.2 46880ef6

2017-04-10 08:17:14

dregad

Details Diff
Verify account only if a request is in progress

The account verification page should only proceed and allow updating the
user's profile (including resetting their password) when there is an
active activation token.

Fixes 0022690

Backported from cfbc5e54af6c2e9fc9ca7b72fa7b31aa284625f1
Affected Issues
0022690
mod - verify.php Diff File

MantisBT: master-1.3.x 14c61a8c

2017-04-10 08:17:14

dregad

Details Diff
Verify account only if a request is in progress

The account verification page should only proceed and allow updating the
user's profile (including resetting their password) when there is an
active activation token.

Fixes 0022690

Backported from cfbc5e54af6c2e9fc9ca7b72fa7b31aa284625f1
Affected Issues
0022690
mod - verify.php Diff File

MantisBT: master 8be89b7b

2017-04-10 01:22:04

translatewiki.net

Details Diff
Localisation updates from https://translatewiki.net.
Attach Issues:
mod - lang/strings_turkish.txt Diff File

MantisBT: master 1850aaef

2017-04-09 00:02:36

vboctor

Details Diff
Some minor tweaks Affected Issues
0004235
mod - css/status_config.php Diff File
mod - login_page.php Diff File
mod - login_password_page.php Diff File

MantisBT: master 6810b10e

2017-04-08 19:37:56

vboctor

Details Diff
Fixes for per user authentication method Affected Issues
0004235
mod - core/authentication_api.php Diff File
mod - core/classes/AuthFlags.class.php Diff File
mod - login_password_page.php Diff File

MantisBT: master f937d876

2017-04-08 19:09:15

vboctor

Details Diff
phpdoc for AuthFlags Affected Issues
0004235
mod - core/classes/AuthFlags.class.php Diff File
 First  Prev  1 2 3 ... 55 56 57 58 59 60 61 ... 120 ... 180 ... 240 ... 300 ... 360 ... 420 ... 480 ... 540 ... 600 ... 647 648 649  Next  Last