Search Changesets

MantisBT: master d46c6a92

2024-02-13 10:47

dregad


Details Diff
Merge branch 'master-2.26'
mod - library/rssbuilder/class.ObjectIterator.inc.php Diff File
mod - library/rssbuilder/class.ObjectList.inc.php Diff File

MantisBT: master-2.26 7dcb81cd

2024-02-13 10:45

dregad


Details Diff
Revert "Fix Error when creating empty RSS feed on PHP 8"

This reverts commit 0e241f33687ce4af5ef483b7f3cbd2ffd8817838.
Affected Issues
0033634
mod - library/README.md Diff File
mod - library/rssbuilder/class.ObjectIterator.inc.php Diff File

MantisBT: master 60061f31

2024-02-13 10:43

dregad


Details Diff
Merge branch 'i33634-rssbuilder'
mod - library/README.md Diff File
mod - library/rssbuilder/class.ObjectIterator.inc.php Diff File

MantisBT: master-2.26 9a8f1277

2024-02-13 10:39

dregad


Details Diff
Fix Error when creating empty RSS feed on PHP 8

When the feed is empty, ObjectIterator::size() throws a TypeError
exception on PHP 8.0+ (and a Warning on PHP 7.2+) due to calling count()
on $this->objectlist->objects, which is null in this case.

Initializing the ObjectList::$objects property to an empty array ensures
this never happens.

File was converted to UTF-8 and trailing ?> removed.

Fixes 0033634
Affected Issues
0033634
mod - library/README.md Diff File
mod - library/rssbuilder/class.ObjectList.inc.php Diff File

MantisBT: master-2.26 0e241f33

2024-02-13 03:44

tm8544


Details Diff
Fix Error when creating empty RSS feed on PHP 8

When the feed is empty, ObjectIterator::size() throws a TypeError
exception on PHP 8.0+ (and a Warning on PHP 7.2+) due to calling count()
on $this->objectlist->objects, which is null in this case.

Fixes 0033634

Signed-off-by: Damien Regad <dregad@mantisbt.org>

- Rewrote original commit message
- Fixed whitespace
- Updated library\README.md
- Removed closing `?>` tag
Affected Issues
0033634
mod - library/README.md Diff File
mod - library/rssbuilder/class.ObjectIterator.inc.php Diff File

MantisBT: master e3f572c0

2024-02-12 11:49

dregad


Details Diff
Display warning if Issue has disabled category

Warning icon with descriptive tooltip is displayed when

- viewing an issue and allowed to edit it
- editing issue

Issue 0031017
Affected Issues
0031017
mod - bug_update_page.php Diff File
mod - bug_view_inc.php Diff File
mod - core/category_api.php Diff File
mod - lang/strings_english.txt Diff File

MantisBT: master ed41f512

2024-02-12 11:47

dregad


Details Diff
Only propose enabled categories

It should not be possible to select a disabled category

- when mass-updating issues
- as fallback when importing issues (XmlImportExport plugin)

Issue 0031017
Affected Issues
0031017
mod - bug_actiongroup_page.php Diff File
mod - plugins/XmlImportExport/pages/import.php Diff File

MantisBT: master 290f9886

2024-02-12 11:43

dregad


Details Diff
Fix category not found error when reporting bug

Regression introduced by 0f302a8d
mod - core/print_api.php Diff File

MantisBT: master 8996d431

2024-02-12 07:10

translatewiki.net


Details Diff
Localisation updates from https://translatewiki.net. [skip ci]
mod - lang/strings_chinese_simplified.txt Diff File

MantisBT: master b8d2f120

2024-02-11 19:22

dregad


Details Diff
Fix failing CategoryTest

To maintain backwards-compatibility, category_update() signature was
modified so the new $p_status parameter is not mandatory, and defaults
to null to keep the category's existing status.

Issue 0031017
Affected Issues
0031017
mod - core/category_api.php Diff File

MantisBT: master af14961f

2024-02-11 11:50

dregad


Details Diff
Keep current disabled category when editing issue

When an issue assigned to a disabled category is edited, the category
should be kept as-is unless the user specifically updated it.

Update print_category_option_list() to add the current category, but
label it as disabled so the user knows they should change it, and set
the disabled attribute on the option so it can't be re-selected once
changed.

Fixes 0031017
Affected Issues
0031017
mod - core/print_api.php Diff File
mod - lang/strings_english.txt Diff File

MantisBT: master 43c11309

2024-02-11 10:41

dregad


Details Diff
Use th instead of td for categories table header
mod - manage_proj_page.php Diff File

MantisBT: master 23c30980

2024-02-11 10:28

dregad


Details Diff
Schema update to set category.status default to 1

Fixes 0031017
Affected Issues
0031017
mod - admin/schema.php Diff File
mod - core/install_helper_functions_api.php Diff File

MantisBT: master 05c1639f

2024-02-11 10:20

dregad


Details Diff
Use enabled/disabled for category status

Since we currently only use a binary state (enabled/disabled) for the
status, we do not need to make things more complex than they have to be.

This simplifies @cas's original contribution by:
- using a checkbox for input instead of radio buttons
- display a check icon instead of relying on language strings in lists
- standardize on enabled/disabled terminology

This also fixes the "inverted logic" (status == 0 was previously treated
as enabled, which is the reverse of one would expect.

Fixes 0031017
Affected Issues
0031017
mod - bug_report_page.php Diff File
mod - bug_update_page.php Diff File
mod - core/category_api.php Diff File
mod - core/print_api.php Diff File
mod - lang/strings_english.txt Diff File
mod - manage_proj_cat_edit_page.php Diff File
mod - manage_proj_cat_update.php Diff File
mod - manage_proj_edit_page.php Diff File
mod - manage_proj_page.php Diff File

MantisBT: master cefd6643

2024-02-11 08:14

dregad


Details Diff
Use CATEGORY_STATUS_DISABLED constant instead of 0
mod - core/category_api.php Diff File

MantisBT: master 4ee2eacc

2024-02-11 08:13

dregad


Details Diff
Whitespace
mod - core/category_api.php Diff File
mod - manage_proj_cat_edit_page.php Diff File
mod - manage_proj_cat_update.php Diff File

MantisBT: master 447a45ba

2024-02-11 08:12

dregad


Details Diff
Move constants and add comment
mod - core/constant_inc.php Diff File

MantisBT: master 0d884d29

2024-02-11 08:12

dregad


Details Diff
Update PHPDoc
mod - core/category_api.php Diff File
mod - core/print_api.php Diff File

MantisBT: master d348ea51

2024-02-11 07:11

dregad


Details Diff
Merge branch 'master-2.26'
mod - admin/install.php Diff File

MantisBT: master 1791605e

2024-02-11 06:03

dregad


Details Diff
Installer: catch RandomException

When the installer attempts to generate the Crypto Master Salt, if there
is no available randomness source, random_bytes() throws an exception
which was not caught, disrupting the installation procedure.

Refactoring the code to catch the exception, and display a meaningful
warning message to the admin, and add a comment in the generated config
file.

Note: it's a RandomException on PHP 8.2+, and plain Exception in older
PHP versions, so we catch the latter for now to ensure compatibility.

Fixes 33631
Affected Issues
0033631
mod - admin/install.php Diff File

MantisBT: master 309f35bd

2024-02-11 05:49

dregad


Details Diff
Installer: fix static analysis warnings
mod - admin/install.php Diff File

MantisBT: master dc8e59a8

2024-02-09 11:46

dregad


Details Diff
Travis: switch to focal distribution for builds

Fixes 0033623
Affected Issues
0033623
mod - .travis.yml Diff File

MantisBT: master 2a456554

2024-02-08 07:08

translatewiki.net


Details Diff
Localisation updates from https://translatewiki.net. [skip ci]
mod - lang/strings_chinese_traditional.txt Diff File
mod - lang/strings_interlingua.txt Diff File

MantisBT: master e8e41832

2024-02-03 17:12

dregad


Details Diff
Merge branch 'master-2.26'
mod - admin/check/check_database_inc.php Diff File
mod - admin/install.php Diff File
mod - docbook/Admin_Guide/en-US/Installation.xml Diff File

MantisBT: master fb497d03

2024-02-01 07:09

translatewiki.net


Details Diff
Localisation updates from https://translatewiki.net. [skip ci]
mod - lang/strings_occitan.txt Diff File
 First  Prev  1 2 3 4 5 6 7 8 9 ... 70 ... 140 ... 210 ... 280 ... 350 ... 420 ... 490 ... 560 ... 630 ... 700 ... 743 744 745  Next  Last