Search Changesets

MantisBT: master 751b3d35

2017-11-27 23:22:48

vboctor

Details Diff
Fix the call to `custom_field_set_value()`

Fixes 0023594
Affected Issues
0023594
mod - bug_report.php Diff File

MantisBT: master 7e7c6501

2017-11-27 02:05:53

translatewiki.net

Details Diff
Localisation updates from https://translatewiki.net.
Attach Issues:
mod - lang/strings_belarusian_tarask.txt Diff File
mod - lang/strings_chinese_simplified.txt Diff File
mod - plugins/MantisCoreFormatting/lang/strings_french.txt Diff File

MantisBT: master 8c573f63

2017-11-26 09:52:46

atrol

Details Diff
Minor performance and code enhancements of config functions

Fixes 0023969
Affected Issues
0023969
mod - core/config_api.php Diff File

MantisBT: master 3b3bcb1b

2017-11-24 19:24:35

vboctor

Details Diff
Use `If-Match` instead of `If-None-Match` for update/delete
Attach Issues:
mod - api/rest/restcore/issues_rest.php Diff File
mod - core/constant_inc.php Diff File

MantisBT: master 27102c48

2017-11-23 01:42:03

translatewiki.net

Details Diff
Localisation updates from https://translatewiki.net.
Attach Issues:
mod - lang/strings_belarusian_tarask.txt Diff File
mod - lang/strings_german.txt Diff File

MantisBT: master 8fbf5e59

2017-11-22 02:59:42

atrol

Details Diff
Correct access checks for readonly issues

Fixes 0023657
Affected Issues
0023657
mod - core/bug_api.php Diff File

MantisBT: master 54783df6

2017-11-20 13:55:43

atrol

Details Diff
Fix Manage Plugins UI for protected plugins

Fixes 0023658
Affected Issues
0023658
mod - manage_plugin_page.php Diff File

MantisBT: master 4e764084

2017-11-20 03:21:14

translatewiki.net

Details Diff
Localisation updates from https://translatewiki.net.
Attach Issues:
mod - lang/strings_belarusian_tarask.txt Diff File
mod - lang/strings_chinese_traditional.txt Diff File
mod - lang/strings_czech.txt Diff File
mod - lang/strings_french.txt Diff File
mod - lang/strings_urdu.txt Diff File
mod - plugins/MantisCoreFormatting/lang/strings_czech.txt Diff File
mod - plugins/MantisGraph/lang/strings_chinese_simplified.txt Diff File
mod - plugins/MantisGraph/lang/strings_czech.txt Diff File

MantisBT: master 4bd8891f

2017-11-19 03:58:13

vboctor

Details Diff
Remove `bug_hash` which is no longer used
Attach Issues:
mod - core/bug_api.php Diff File

MantisBT: master 7aa72aa6

2017-11-19 03:57:21

vboctor

Details Diff
Update hash calculation when updating issues

- Base etag calculation of hashing of output for get issue.

Fixes 0023653
Affected Issues
0023653
mod - api/rest/restcore/issues_rest.php Diff File

MantisBT: master c3729274

2017-11-19 03:34:49

vboctor

Details Diff
Update hash calculation for deletion of issues

Base calculation of hash for etag on output of get issues and compare with provided `If-None-Match`.

Fixes 0023650
Affected Issues
0023650
mod - api/rest/restcore/issues_rest.php Diff File

MantisBT: master 731be88f

2017-11-19 03:08:10

vboctor

Details Diff
Hash get issue output for etag

- Base the etag hash calculation on hash of the result json.
- Apply etag to get single issue or paginated output of multiple issues.

Fixes 0023648
Affected Issues
0023648
mod - api/rest/restcore/issues_rest.php Diff File
mod - api/soap/mc_api.php Diff File
mod - api/soap/mc_issue_api.php Diff File

MantisBT: master 46bbf31e

2017-11-18 03:14:28

vboctor

Details Diff
Remove unnecessary calculation of hash

Fixes 0023653
Affected Issues
0023653
mod - api/rest/restcore/issues_rest.php Diff File

MantisBT: master 00dec0b1

2017-11-18 02:55:15

vboctor

Details Diff
Validate `handler` only when being updated

Fixes 0023654
Affected Issues
0023654
mod - api/soap/mc_issue_api.php Diff File

MantisBT: master d7ec37d2

2017-11-18 02:52:51

vboctor

Details Diff
Return etag when getting issue that doesn’t exist

Fixes 0023648
Affected Issues
0023648
mod - api/rest/restcore/issues_rest.php Diff File

MantisBT: master cb2a453f

2017-11-18 02:52:17

vboctor

Details Diff
Leverage `If-None-Match` when updating issues

If `If-None-Match` is specified and it doesn’t match latest hash, then fail with `412 Precondition failed`.

Always return the updated `ETag` header.

Fixes 0023653
Affected Issues
0023653
mod - api/rest/restcore/issues_rest.php Diff File
mod - core/bug_api.php Diff File

MantisBT: master 4aec7f9a

2017-11-18 02:17:30

vboctor

Details Diff
Leverage If-None-Match when deleting issues

If client attempts to delete an issue that doesn’t exist or that was modified since issue was retrieved,
then fail with error `412 Precondition failed`.

Fixes 0023650
Affected Issues
0023650
mod - api/rest/restcore/issues_rest.php Diff File
mod - core/constant_inc.php Diff File

MantisBT: master df983732

2017-11-18 01:53:27

vboctor

Details Diff
Use `ETag` and `If-None-Match` when getting issues

When getting an issue, return an `ETag`, even if the issue doesn’t exist.

When request contains `If-None-Match` and hash matches, then return `304 Not Modified`.
The 304 response will be returned whether issue exists or not.

The hash depends on:
- a hasing version
- user id
- issue id
- issue last updated

Fixes 0023648
Affected Issues
0023648
mod - api/rest/restcore/issues_rest.php Diff File
mod - core/bug_api.php Diff File
mod - core/constant_inc.php Diff File

MantisBT: master 2fd81a3e

2017-11-17 08:46:24

atrol

Details Diff
Fix preview of non UTF-8 text attachments

Functionality of function htmlspecialchars depends on PHP version [1].

The change ensures that
- UTF-8 is used in any case
- Single non UTF-8 characters are replaced in the string
instead of replacing the whole string by an empty string

[1] www.php.net/manual/en/function.htmlspecialchars.php

Fixes 0023645
Affected Issues
0023645
mod - core/print_api.php Diff File

MantisBT: master c5868132

2017-11-17 01:35:05

vboctor

Details Diff
Command Pattern

Use Command Pattern to achieve the following:

- Re-using of business logic across Web UI, REST API, and SOAP API.
- Having commands that execute a specific intent e.g. assign, close, monitor rather than just update.
- Enable core code to hook into such commands to handle side effects like email messages.
- Enable plugins code to hook in such commands to modify changes, block the change, post to slack, etc.
- Use exceptions that can be surfaced to APIs or Web UI.
- Enable having a clean model using ADODB or some higher level ORM library that is used by commands.
Attach Issues:
add - core/commands/Command.php Diff File
add - core/commands/CommandException.php Diff File
add - core/commands/CommandFactory.php Diff File
add - core/commands/Context.php Diff File
add - core/commands/MonitorCommand.php Diff File

MantisBT: master 03cb5da8

2017-11-16 05:02:49

translatewiki.net

Details Diff
Localisation updates from https://translatewiki.net.
Attach Issues:
mod - lang/strings_belarusian_tarask.txt Diff File
mod - lang/strings_breton.txt Diff File

MantisBT: master 053dd6be

2017-11-15 17:08:19

atrol

Details Diff
Remove usage of deprecated each() function

each() has been deprecated as of PHP 7.2.0 [1]

[1] http://php.net/manual/en/function.each.php

Fixes 0023640
Affected Issues
0023640
mod - admin/check/check_php_inc.php Diff File
mod - core/config_api.php Diff File
mod - core/html_api.php Diff File
mod - core/print_api.php Diff File
mod - my_view_page.php Diff File

MantisBT: master-1.3.x d4a28e53

2017-11-15 17:08:19

atrol

Details Diff
Remove usage of deprecated each() function

each() has been deprecated as of PHP 7.2.0 [1]

[1] http://php.net/manual/en/function.each.php

Fixes 0023640
Backported from 053dd6becdeb29599fdf5fa1b48f82a6664a95f1

Conflicts:
my_view_page.php
Affected Issues
0023640
mod - admin/check/check_php_inc.php Diff File
mod - core/config_api.php Diff File
mod - core/html_api.php Diff File
mod - core/print_api.php Diff File
mod - my_view_page.php Diff File

MantisBT: master 1254f0dd

2017-11-15 08:45:37

atrol

Details Diff
Remove check for PHP version < 5.3.7

Issue 0023639
Affected Issues
0023639
mod - core/crypto_api.php Diff File

MantisBT: master 5f6292fb

2017-11-15 08:23:45

atrol

Details Diff
Remove finfo class existence checks

As of PHP >= 5.3.0 finfo class is available [1] and enabled by default [2]

[1] http://www.php.net/manual/en/class.finfo.php
[2] http://www.php.net/manual/en/fileinfo.installation.php

Removed all runtime checks but kept them in install/check to have an easy way to find the case where someone disabled the extension.

Issue 0023639
Affected Issues
0023639
mod - core/file_api.php Diff File
mod - core/utility_api.php Diff File
 First  Prev  1 2 3 ... 57 58 59 60 61 62 63 ... 70 ... 140 ... 210 ... 280 ... 350 ... 420 ... 490 ... 560 ... 630 ... 671 672 673  Next  Last