Search Changesets

MantisBT: master 6beb5283

2003-05-01 14:29

Julian Fitzell


Details Diff
Fix issue 0003163 with fix from AJCartmell <AJCartmell@ricardo.com>

* core/print_api.php
(print_view_bug_sort_link):
(print_view_bug_sort_link2):
- set the sort order to ASC if we are changing columns

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2168 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
Affected Issues
0003163
mod - core/print_api.php Diff File

MantisBT: master dcf595d5

2003-05-01 14:09

Julian Fitzell


Details Diff
Fix issue 0003162 with a fix given by AJCartmell <AJCartmell@ricardo.com>

* core/email_api.php
(email_send): use mail_priority config option when using phpMailer

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2167 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
Affected Issues
0003162
mod - core/email_api.php Diff File

MantisBT: master ca610f06

2003-04-24 00:26

vboctor


Details Diff
Fixed a typo and changed a general fix to a fix for a specific bug.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2166 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - doc/ChangeLog Diff File

MantisBT: master 685b65f9

2003-04-24 00:00

vboctor


Details Diff
Fix 0003120: Missing "Assign To" field on "Report Bug" screen.
Fix: Sometimes non-admin users are denied access to projects that they have
access for. This cause the project to revert back "All Projects" whenever the
user tries to set it to one of those private projects.

M core/access_api.php
- (access_cache_matrix): This function was not implemented and was not used.
Hence, removed.
- (access_cache_matrix_user): Some of the cache indices were used as returned
from the query without being converted to ints, and hence, were not found
later. This was causing a bug where non-admin users were denied access from
private projects.
- (access_cache_matrix_project): same fix as in access_cache_matrix_user.
- (access_has_project_level):
- Removed the use of hard-coded ADMINISTRATOR access level. The
private_project_threshold is not used.
- The handling for the case where a user was not added to a private project,
but had an access level greater or equal to private_project_threshold was not
handled correctly.
- (access_get_local_level): Convert the project id to an int before using it to
index the cache array. This is because 0001 can not be used to index 1.

M manage_user_proj_add.php
- Changed the required access to manage_user_threshold rather than
private_project_threshold. The access right that is need is to be able to
manage the users for the project, rather than access private projects.

M bug_report_advanced_page.php
- When the assign-to field was hidden, two spacer were added before the summary
field.

M set_project.php
- Added support to switch the current project in report bug pages without
jumping to main page.

M config_defaults_inc.php
- Removed a comment that claimed that $g_cookie_domain is not used while it is.

M core/gpc_api.php
- (gpc_clear_cookie): Added support for $p_domain parameter to be consistent
with gpc_set_cookie().

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2165 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
Affected Issues
0003120
mod - config_defaults_inc.php Diff File
mod - manage_user_proj_add.php Diff File
mod - core/gpc_api.php Diff File
mod - core/access_api.php Diff File
mod - set_project.php Diff File
mod - doc/ChangeLog Diff File
mod - bug_report_advanced_page.php Diff File

MantisBT: master 20937d36

2003-04-23 22:24

vboctor


Details Diff
Fix 0003111: Bug links in bugnotes do not contain the FQDN as they do in the full reference.

M core/string_api.php
- (string_get_bug_view_url_with_fqdn): Add this method that depends on the
implementation of string_get_bug_view_url() but prefixes it with $g_path.
- (string_process_bug_link): Changed to use string_get_bug_view_url_with_fqdn()
when no anchor is required.

M core/email_api.php
- (email_build_bug_message): Changed to use string_get_bug_view_url_with_fqdn().
- (email_bug_reminder): Changed to use string_get_bug_view_url_with_fqdn().

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2164 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
Affected Issues
0003111
mod - core/email_api.php Diff File
mod - doc/ChangeLog Diff File
mod - core/string_api.php Diff File

MantisBT: master 3d916f90

2003-04-23 19:03

Julian Fitzell


Details Diff
Remove temporary code now that we have parameterized errors. I parameterized all the error strings that were actually being used in
conjunction with error_parameters() at the moment

* core/error_api.php
(error_handler): remove temporary code that printed out raw parameters

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2163 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/error_api.php Diff File

MantisBT: master fa6037d1

2003-04-23 19:00

Julian Fitzell


Details Diff
Implement parameterized error messages. This allows us, for example to say "Bug 23 not found" instead of just "Bug not found".

Parameters are gven before triggering an error by calling error_parameters() (this function already existed in anticipation of this feature)
and the error strings are now passed through sprintf with those values.

I won't have much time to work on this in the next day or two so if anyone else wants to actually parameterize more of the error strings, feel
free.

* core/bug_api.php
(bug_cache_row): call error_parameters() before triggering an error
(bug_text_cache_row): ditto
(bug_ensure_exists): ditto

* core/error_api.php
(error_string): pass the error string through sprintf with a padded array
of error parameters (padded to prevent errors when too few parameters
are given)

* lang/strings_english.txt: parameterize three error strings as an
example

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2162 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/error_api.php Diff File
mod - doc/ChangeLog Diff File
mod - lang/strings_english.txt Diff File
mod - core/bug_api.php Diff File

MantisBT: master 7f202598

2003-04-23 18:17

Julian Fitzell


Details Diff
Improve the look of error pages

* core/error_api.php
(error_handler): make stuff prettier by using some formatting and hiding
more information in the basic error view
(error_proceed_url): new function that allows a page to provide a url to
proceed to after the error page. If not proceed url is given before
the error is triggered, a message telling the user to use the browser's
back button is given.

* lang/strings_english.txt: remove 'ERROR: ' from the error strings

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2161 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - lang/strings_english.txt Diff File
mod - core/error_api.php Diff File

MantisBT: master 3aff2711

2003-04-23 15:32

Julian Fitzell


Details Diff
Allow hyphens and spaces in usernames and put the regex used to validate them in a config option.

* config_defaults_inc.php
(user_login_valid_regex): new option giving a regex to use for validating
new login names

* core/user_api.php
(user_is_name_valid): use new config option (user_login_valid_regex) for
regular expression

* lang/strings_english.txt
(ERROR_USER_NAME_INVALID): add a sentence describing what the user name
limitations are

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2160 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
Affected Issues
0003183
mod - doc/ChangeLog Diff File
mod - lang/strings_english.txt Diff File
mod - config_defaults_inc.php Diff File
mod - core/user_api.php Diff File

MantisBT: master cd22e09e

2003-04-22 20:37

vboctor


Details Diff
Fix 0003155: Field 'date_added' (for attachments) not correctly printed in print_bug_page.php.

Thanks for ndeboer for the fix.

M print_bug_page.php
- Use UNIX_TIMESTAMP in the query for retrieving the attached file information.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2159 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
Affected Issues
0003155
mod - print_bug_page.php Diff File
mod - doc/ChangeLog Diff File

MantisBT: master 51ab53b2

2003-04-22 19:53

vboctor


Details Diff
Fix 0003143: Show a padlock instead of "p".

M manage_user_page.php
- Use the lock icon to highlight protected users.

M view_all_inc.php
- Use the lock icon to highlight the private bugs.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2158 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
Affected Issues
0003143
mod - doc/ChangeLog Diff File
mod - manage_user_page.php Diff File
mod - view_all_inc.php Diff File

MantisBT: master c2d87939

2003-04-22 11:42

Julian Fitzell


Details Diff
Fix a few bugs pointed out in issue 0002154 by bevindarkgun <bevindarkgun@yahoo.com>

* core/string_api.php
(html_strip_hrefs):
+ fix both regexes to use [^\>]*> instead of [^\"]*
+ make regex searches case insensitive to we pick up anchors with
A as well as a, etc

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2157 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
Affected Issues
0002154
mod - core/string_api.php Diff File

MantisBT: master 7eb11138

2003-04-22 02:50

vboctor


Details Diff
Add a lock image to be used for protected users and possibly for private bugs. This is not the image provided by 0003143

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2156 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
add - images/protected.gif Diff File

MantisBT: master aae86e27

2003-04-18 00:02

vboctor


Details Diff
M core/file_api.php
(file_delete_attachments): Modified to not connect to FTP server if number of attached files is 0.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2155 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/file_api.php Diff File

MantisBT: master 9d29c72a

2003-04-17 22:53

vboctor


Details Diff
Fix 0003140: attachment.png is corrupt in CVS.

A images/attachment.png
- Added attachment.png as binary rather than text.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2154 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
Affected Issues
0003140
add - images/attachment.png Diff File
mod - doc/ChangeLog Diff File

MantisBT: master 51370962

2003-04-17 22:50

vboctor


Details Diff
Remove attachment.png since it was added as a text file.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2153 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
rm - images/attachment.png Diff

MantisBT: master 2f457948

2003-04-17 02:25

vboctor


Details Diff
Fix 0003027: History summary a little bit too wide in emails.

M core/email_api.php
- Changed the field sizes used in formatting the history columns.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2152 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
Affected Issues
0003027
mod - doc/ChangeLog Diff File
mod - core/email_api.php Diff File

MantisBT: master 60e4f70d

2003-04-17 02:07

vboctor


Details Diff
Fix 0003121: When creating a bug that has custom fields, the values for the custom fields are not sent out in the email.

M core/bug_api.php
- (bug_create): Removed the call to email_new_bug().

M bug_report.php
- Added the call to email_new_bug() after finalising the process of adding the bug.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2151 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
Affected Issues
0003121
mod - core/bug_api.php Diff File
mod - doc/ChangeLog Diff File
mod - bug_report.php Diff File

MantisBT: master 393f471a

2003-04-17 01:48

vboctor


Details Diff
Fix 0003132: Email for feedback does not contain the last bugnote

M bug_update.php
- Change the update order to do the following:
- Set the custom field values
- Add the bug note
- Update the bug

This makes sure that when the bug_update() api sends an email it contains the
new custom field values as well as the last added bugnote.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2150 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
Affected Issues
0003132
mod - bug_update.php Diff File
mod - doc/ChangeLog Diff File

MantisBT: master a37b954b

2003-04-14 00:57

jlatour


Details Diff
Updated Slovak localisation, with thanks to Ondrej Jombik.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2149 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - lang/strings_slovak.txt Diff File

MantisBT: master 62bbd382

2003-04-12 08:49

jlatour


Details Diff
Updated Slovak localisation, with thanks to Ondrej Jombik.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2148 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - lang/strings_slovak.txt Diff File
mod - doc/ChangeLog Diff File

MantisBT: master 0e1120d7

2003-04-10 19:56

vboctor


Details Diff
Fix 0003124: view_bugs: a reporter has the drop-down box of actions, but doesn't
have the checkboxes.

M view_all_inc.php
- Show combo-box of actions only if at least one checkbox was displayed. It has
to be done this way, because in case of "All Projects" a different access check
is done for each row.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2147 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
Affected Issues
0003124
mod - doc/ChangeLog Diff File
mod - view_all_inc.php Diff File

MantisBT: master 864a56ef

2003-04-09 15:39

Julian Fitzell


Details Diff
* core/email_api.php
(email_send): don't manually put in a Return-path header since that is
generated by the MTAs along the way

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2146 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/email_api.php Diff File

MantisBT: master d0845314

2003-04-09 07:07

vboctor


Details Diff
Fix 0003076: Bug reports are added to the "wrong" project.

M bug_report.php
M bug_report_page.php
M bug_report_advanved_page.php
- Changed the report forms to send the project id, rather than the action page using the current id.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2145 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
Affected Issues
0003076
mod - doc/ChangeLog Diff File
mod - bug_report.php Diff File
mod - bug_report_advanced_page.php Diff File
mod - bug_report_page.php Diff File

MantisBT: master fa460dc2

2003-04-09 06:06

vboctor


Details Diff
Fix 0003115: manage_proj_cat_edit_page.php uses the wrong project id.

M manage_proj_cat_edit_page.php
- Change the call to print_assign_to_option_list() to send the project id.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2144 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
Affected Issues
0003115
mod - manage_proj_cat_edit_page.php Diff File
mod - doc/ChangeLog Diff File
 First  Prev  1 2 3 ... 70 ... 140 ... 210 ... 280 ... 350 ... 420 ... 490 ... 560 ... 630 ... 657 658 659 660 661 662 663 ... 700 ... 743 744 745  Next  Last