MantisBT: master b5ea0dd1

Author Committer Branch Timestamp Parent
dregad atrol master 2018-11-16 09:26:43 master 12dd3509
Affected Issues  0024976: Sidebar's collapsed state is not preserved
Changeset

Proper fix for duplicate 'sidebar' div ID

The initial attempt at fixing this issue [1] introduced a regression in
the persistence of the sidebar's collapse state.

Using a different ID for the toggle button or the sidebar div caused
other issues (e.g. malfunctioning hambuger menu on narrow screens, or
failure to save collapse state).

The root cause was a bug in the javascript code saving the sidebar's
state, which was referencing the toggle button's id instead of the
sidebar div's.

We now have ID 'sidebar' for the actual sidebar, and 'sidebar-btn' for
the toggle button, and the javascript has been modified accordingly.

Fixes 0024976

[1]: commit b7b914549fe8fbdf4ee4053f475031df9d6a4674

mod - core/layout_api.php Diff File
mod - js/common.js Diff File