0011381: Dependency Graph crash on circular parent child relationships

ID	Project	Category	View Status	Date Submitted	Last Update
0011381	mantisbt	relationships	public	2010-01-11 15:21	2020-03-15 15:23

Reporter	brianstv	Assigned To	dregad
Priority	normal	Severity	minor	Reproducibility	always
Status	closed	Resolution	fixed
Product Version	git trunk
Target Version	2.24.0	Fixed in Version	2.24.0

Summary	0011381: Dependency Graph crash on circular parent child relationships
Description	The Dependency Graph will return a blank page if you have 3 issues that are dependent on each other in a circular way.
Steps To Reproduce	Create 3 issues. Make issue 1 parent of issue 2 Make issue 2 parent of issue 3 Make issue 3 parent of issue 1 click on the Dependency Graph. Returns blank page, or download of 0 bytes from bug_relationship_graph.php depending on your browser.
Additional Information	This was caught in testing, not something that would normally be done.
Tags	No tags attached.

dregad 2019-09-21 20:17 developer ~0062875	PR https://github.com/mantisbt/mantisbt/pull/1567

dregad 2019-09-21 20:20 developer ~0062880	I could reproduce this with latest master, the page throws an application error due to invalid parameter type. The PR fixes the problem, as shown in attached screenshot circular.png (2,914 bytes) circular.png (2,914 bytes)

MantisBT: master f07fea0d 2019-09-21 16:10 dregad Details Diff	Fix circular dependencies in Relationship Graph In the case where we have a cycle in parent-child relationships (i.e. A -> B -> C -> A), the Relationship Graph fails with an INTERNAL APPLICATION ERROR - Argument 1 passed to relgraph_add_child() must be of type array, string given in core/relationship_graph_api.php line 427. The recursive call was passing the bug id instead of the bug list. Fixes 0011381		Affected Issues 0011381
	mod - core/relationship_graph_api.php		Diff File