|
|
I wonder if this is fixed by 0008957. |
|
|
|
Hello,
Any update on this?
Romain |
|
|
|
I Confirm that bug in Mantis MantisBT 2.15.0
When you change date variable $g_normal_date_format in config/config_inc.php
# --- date format settings --------
# date format strings defaults to ISO 8601 formatting
# go to http://www.php.net/manual/en/function.date.php
# for detailed instructions on date formatting
$g_normal_date_format = 'd/m/y H:i';
a bug occurs in the project version datepicker
To resolve that, we modified the file manage_proj_ver_edit_page.php
line 103 :
remplace string_attribute( date( config_get( 'normal_date_format' ), $t_version->date_order ) )
by string_attribute( date( "Y/m/d H:i", $t_version->date_order ) ) |
|
|
|
I can confirm that the bug is still in V2.22.0
JPKs solution works just perfect.
Only "real" quote-characters need to be used instead if the quot-html-stuff |
|
|
|
Attached you see the same server contacted from 2 different clients.
Date on right client totally spoiled.
Again, JPK's solution resolves that here. |
|
|
|
PR: https://github.com/mantisbt/mantisbt/pull/1587
@rolfiii I'd appreciate if you can test this PR and report back if it fixed the issue you are running into. |
|
|
|
Isn't the real problem, that the datepicker creates a format in the localized form, but version_api.php uses "strtotime", which only accepts english dates?
Fixed it for me:
/core/version_api.php b/core/version_api.php
remove
$t_value = strtotime( $p_value );
if( $t_value === false ) { ...
insert
$t_date = date_create_from_format( config_get( 'normal_date_format' ), $p_value );
if( $t_date === false ) {
throw new ClientException(
"Invalid date format '$p_value'",
ERROR_INVALID_DATE_FORMAT,
array( $p_value ) );
}
$t_value = $t_date->getTimestamp(); |
|
|
|
date_patch.txt (676 bytes)
diff --git a/core/version_api.php b/core/version_api.php
index 14b521d..036fa18 100644
--- a/core/version_api.php
+++ b/core/version_api.php
@@ -111,13 +111,14 @@ class VersionData {
if( $p_value == '' ) {
$t_value = date_get_null();
} else {
- $t_value = strtotime( $p_value );
- if( $t_value === false ) {
+ $t_date = date_create_from_format( config_get( 'normal_date_format' ), $p_value );
+ if( $t_date === false ) {
throw new ClientException(
"Invalid date format '$p_value'",
ERROR_INVALID_DATE_FORMAT,
array( $p_value ) );
}
+ $t_value = $t_date->getTimestamp();
}
}
}
|
|
|
|
Still there in 2.24.1, patch still works |
|
