PR https://github.com/mantisbt/mantisbt/pull/1323

@atrol I've targeted 2.13.0 because of the PHP 7.2 compatibility issue, but I let you decide if you want to merge it now to get the fix in quickly, or delay until 2.14.0 to get more test time with the new ADOdb (changes since 5.20.9 are fairly minor, but you never know)

@dregad I made some cursory tests (just MySQL) with different PHP versions (5.6, 7.1, 7.2) and did not encounter any problem until now.

But the ADOdb changes are not enough to get a full PHP 7.2 compatibility.
Not sure if you noticed that the Travis checks for PHP 7.2 still fail https://travis-ci.org/mantisbt/mantisbt/jobs/360416356

So on the one hand we don't have to rush to merge the PR, but on the other hand we should also be aware that Ubuntu 18.04 LTS will come with PHP 7.2 and will be released 26th April.

Not sure if you noticed that the Travis checks for PHP 7.2 still fail https://travis-ci.org/mantisbt/mantisbt/jobs/360416356

I did. Remaining errors are not related to ADOdb, but I didn't have time to look into the root cause.

Error Description: count(): Parameter must be an array or an object that implements Countable

Found this in .travis.yml

before_install:
  # If PHP >= 7.0, force use of PHPunit 5.7
  - if php -r "exit( (int)! version_compare( '$TRAVIS_PHP_VERSION', '7.0', '>=' ) );"; then mkdir -p ~/bin && wget -O ~/bin/phpunit https://phar.phpunit.de/phpunit-5.7.phar && chmod +x ~/bin/phpunit; fi

Seems we should use PHPunit 6 as PHP 7.2 is not supported in PHPunit 5, see https://phpunit.de

I did. Remaining errors are not related to ADOdb, but I didn't have time to look into the root cause.

Resolved after changes to fix 0024462