View Issue Details

IDProjectCategoryView StatusLast Update
0026840mantisbtpreferencespublic2020-04-29 17:01
Reporteratrol Assigned Toatrol  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Target Version2.25.0Fixed in Version2.25.0 
Summary0026840: Non existing field name os_version used where os_build should be used
Description

There are some places in source code where os_version is used as a field name.

The name is finally defined in class BugData

    protected $os_build = '';

and is sometimes deliveresd by

function columns_get_standard( $p_enabled_columns_only = true ) {
    $t_reflection = new ReflectionClass( 'BugData' );

but also sometimes as hardcoded strings in arrays.

TagsNo tags attached.

Relationships

related to 0026838 closedatrol OS build field not filled in viewing mode 

Activities

atrol

atrol

2020-04-01 15:24

developer   ~0063813

Last edited: 2020-04-01 15:25

View 2 revisions

As there would be conflicts with current master, and as this is not a regression, I decided to fix it in 2.25.0 but not 2.24.1.
I will provide a PR for master / 2.25.0 after 0026838 is merged to master-2.24 and master.

atrol

atrol

2020-04-03 11:42

developer   ~0063824

PR https://github.com/mantisbt/mantisbt/pull/1646

polzin

polzin

2020-04-28 04:32

reporter   ~0063922

@atrol Are you sure? See my note in https://mantisbt.org/bugs/view.php?id=26838#c63921

atrol

atrol

2020-04-29 15:07

developer   ~0063931

@polzin not sure if you read the discussion in the PR.

polzin

polzin

2020-04-29 17:01

reporter   ~0063934

@atrol, thanks for pointing me to the discussion in the PR. My point was that there are more examples, where the $t_issue[] name and the $t_flags[] name differ ( product_version/version, product_build/build, I guess thats all) and that the config names should not differ from the GUI. But if you thought about it, and find it better to harmoize the names in a different way, than I guess everything is okay.
Thanks for your work!

Related Changesets

MantisBT: master ea2a9613

2020-04-03 11:39:33

atrol

Details Diff
Use correct field name "os_build" instead of "os_version"

Fixes 0026840
Affected Issues
0026840
mod - bug_report_page.php Diff File
mod - bug_update_page.php Diff File
mod - config_defaults_inc.php Diff File
mod - docbook/Admin_Guide/en-US/config/fields.xml Diff File
mod - print_all_bug_options_inc.php Diff File

MantisBT: master 14517c7f

2020-04-06 09:50:45

atrol

Details Diff
Replace message os_version by os_build

Issue 0026840
Affected Issues
0026840
mod - account_prof_edit_page.php Diff File
mod - account_prof_menu_page.php Diff File
mod - bug_report_page.php Diff File
mod - bug_update_page.php Diff File
mod - bug_view_inc.php Diff File
mod - core/columns_api.php Diff File
mod - core/filter_form_api.php Diff File
mod - core/history_api.php Diff File
mod - lang/strings_english.txt Diff File
mod - print_all_bug_page_word.php Diff File

MantisBT: master 04ecd2b8

2020-04-06 09:54:07

atrol

Details Diff
Replace os-version by os-build in HTML code

Issue 0026840
Affected Issues
0026840
mod - account_prof_menu_page.php Diff File
mod - bug_view_inc.php Diff File

MantisBT: master 3d5a3655

2020-04-13 07:33:01

atrol

Details Diff
Check for usage of wrong field name "os_version"

Issue 0026840
Affected Issues
0026840
mod - admin/check/check_config_inc.php Diff File

Issue History

Date Modified Username Field Change
2020-04-01 15:00 atrol New Issue
2020-04-01 15:00 atrol Status new => assigned
2020-04-01 15:00 atrol Assigned To => atrol
2020-04-01 15:00 atrol Description Updated View Revisions
2020-04-01 15:00 atrol Relationship added related to 0026838
2020-04-01 15:20 atrol Target Version 2.24.1 => 2.25.0
2020-04-01 15:24 atrol Note Added: 0063813
2020-04-01 15:25 atrol Note Edited: 0063813 View Revisions
2020-04-03 11:42 atrol Note Added: 0063824
2020-04-13 14:22 atrol Changeset attached => MantisBT master ea2a9613
2020-04-13 14:22 atrol Changeset attached => MantisBT master 14517c7f
2020-04-13 14:22 atrol Changeset attached => MantisBT master 04ecd2b8
2020-04-13 14:22 atrol Changeset attached => MantisBT master 3d5a3655
2020-04-13 14:22 atrol Status assigned => resolved
2020-04-13 14:22 atrol Resolution open => fixed
2020-04-13 14:22 atrol Fixed in Version => 2.25.0
2020-04-28 04:32 polzin Note Added: 0063922
2020-04-29 15:07 atrol Note Added: 0063931
2020-04-29 17:01 polzin Note Added: 0063934