View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0033651 | mantisbt | ui | public | 2024-02-13 10:33 | 2024-02-20 16:58 |
Reporter | Alkante | Assigned To | dregad | ||
Priority | low | Severity | tweak | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 2.26.0 | ||||
Target Version | 2.26.1 | Fixed in Version | 2.26.1 | ||
Summary | 0033651: Overflowing text issue on sidebar menu | ||||
Description | There is a line break out of the box when the text is too long and the menu is collapsed. A similar issue also occurs on the expanded sidebar menu, when resolution is < 992px (details in 0033651:0068557). | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
PR https://github.com/mantisbt/mantisbt/pull/1967 @Alkante please review and test |
|
I developed an other solution for this issue, I adapted the width of the box if the text is too long. |
|
Do you want to submit your approach as a separate PR for comparison, or should I merge mine ? |
|
Yes I'd like to PR my approach. So I'll learn more about PR for later. |
|
OK, let me know if you need help. |
|
Thanks for the pull request. We now have 2 distinct solutions for the same problem so a decision is needed on which one to implement:
Personally, I visually I like 1 better because all menu items have the same size, but the code is more complex (javascript to add the tooltip when text is truncated), so 2 is an acceptable solution too. @atrol, @vboctor and anyone else, your opinion is welcome. |
|
I'd prefer option 2 :-) |
|
I prefer option 3 :-) If option 1 should be preferred, @dregad you would have to fix the JavaScript code. |
|
Strange, I'm sure the tooltip was working when I tested (which is confirmed by the screenshot in my PR https://github.com/mantisbt/mantisbt/pull/1967), although I did miss the console error. In any case, considering there seems to be a consensus for making the menu-text span wider, I'll just cancel my PR and won't bother with fixing that.
That's a good suggestion, I like it. I just noticed when testing @Alkante's PR https://github.com/mantisbt/mantisbt/pull/1968 that it does not completely fix the problem, which is still present in responsive mode with smaller resolutions. Slightly different but related, the text also overflows in responsive mode with an expanded sidebar. |
|
New PR https://github.com/mantisbt/mantisbt/pull/1969 implementing option 3 + additional fix mentioned in 0033651:0068557 |
|
MantisBT: master-2.26 e50fb20d 2024-02-18 11:31 Details Diff |
Fix overflowing text in sidebar menu Addresses 2 distinct issues: - collapsed menu - expanded menu with resolutions < 992px Fixes 0033651, PR https://github.com/mantisbt/mantisbt/pull/1969 |
Affected Issues 0033651 |
|
mod - css/ace-mantis.css | Diff File |