0034609: Redundant config settings $g_dot_tool and $g_neato_tool - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update

0034609	mantisbt	administration	public	2024-09-02 12:37	2024-09-07 13:06

Reporter	dregad	Assigned To	dregad
Priority	normal	Severity	minor	Reproducibility	N/A
Status	resolved	Resolution	fixed
Target Version	2.27.0	Fixed in Version	2.27.0

Summary	0034609: Redundant config settings $g_dot_tool and $g_neato_tool
Description	We do not really need 2 distinct configs to identify the GraphViz tools. A single configuration indicating where the library is installed is sufficient. The Graph class can dynamically build the execution path for the needed tool (dot or neato) by appending it to the path
Tags	No tags attached.

dregad 2024-09-02 18:47 developer ~0069151	PR https://github.com/mantisbt/mantisbt/pull/2024

atrol 2024-09-07 11:58 developer ~0069165	This breakes relationship graphs on Windows. To get it run, I had to add ".exe" `const TOOL_DOT = 'dot.exe'; const TOOL_NEATO = 'neato.exe'; const TOOL_CIRCO = 'circo.exe';`

dregad 2024-09-07 13:06 developer ~0069167	Graph class constructor was modified to add `.exe` extension when running on Windows.

MantisBT: master 3b73bef9 2023-09-29 12:58 dregad Details Diff	New $g_graphviz_path config Replaces $g_dot_tool and $g_neato_tool which are now obsolete. Define new constants in Graph class to specify the individual tool to use when instantiating the class; the graphviz tool path is built by the constructor. Adapted usage in relationship graph API and workflow graph. Updated documentation Fixes 0034609		Affected Issues 0034609
	mod - config_defaults_inc.php		Diff File
	mod - core/graphviz_api.php		Diff File
	mod - core/obsolete.php		Diff File
	mod - core/relationship_graph_api.php		Diff File
	mod - docbook/Admin_Guide/en-US/config/relationship.xml		Diff File
	mod - workflow_graph_img.php		Diff File
MantisBT: master b2f2471f 2023-09-30 13:15 dregad Details Diff	Store Graphviz tool name separately from path Add new tool_path() method to get the combined path + tool name. Fixes 0034609		Affected Issues 0034609
	mod - core/graphviz_api.php		Diff File
MantisBT: master 25bf40e9 2023-09-30 13:21 dregad Details Diff	Add admin check for Graphviz Verify that - the path is valid - the tools used by Graph class exist and are executable Fixes 0034609		Affected Issues 0034609
	mod - admin/check/check_display_inc.php		Diff File
	mod - admin/check/check_paths_inc.php		Diff File
MantisBT: master 32af908f 2024-09-07 12:25 dregad Details Diff	On Windows, GraphViz tools need '.exe' extension Regression introduced by 3b73bef981de2eb162165f9b4934d9e0c248ab32. Fixes 0034609		Affected Issues 0034609
	mod - core/graphviz_api.php		Diff File