0005549: Misc XHTML compliance fixes and more (patch) - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update
0005549	mantisbt	other	public	2005-05-01 00:00	2006-09-12 00:52

Reporter	ryandesign	Assigned To	ryandesign
Priority	normal	Severity	minor	Reproducibility	always
Status	closed	Resolution	fixed
Product Version	1.0.0a2
Fixed in Version	1.1.0a1

Summary	0005549: Misc XHTML compliance fixes and more (patch)
Description	A whole bunch of fixes to improve XHTML compliance and fix other simple minor bugs: Add XHTML doctype to all pages in Administration Add title to CSS generation tool Fix missing closing </div> in CSS generation tool Fix all <input> tags to autoclose Fix all <img> tags to autoclose Ensure that all occurrences of attributes multiple, selected and checked are written as multiple="multiple", selected="selected" and checked="checked" Remove incorrect backslashes in some tags in system_utils Fix "Refresh View" link in system_utils Add missing closing </body> and </html> tags to upgrade_warning Change all form method="POST" to method="post" Add missing closing </form> tag in upgrade_inc Remove extraneous closing </td> from manage_config_workflow_page Make all <script> tags use type="text/javascript" language="JavaScript" Rather than make separate tickets for each thing, as I started with 0005546 and 0005547, I did this all as one patch. If you'd prefer separate patches again in the future, just say so.
Tags	No tags attached.
Attached Files	various_html.patch (33,002 bytes) Index: bug_sponsorship_list_view_inc.php =================================================================== --- bug_sponsorship_list_view_inc.php (revision 12) +++ bug_sponsorship_list_view_inc.php (working copy) @@ -69,7 +69,7 @@ <tr class="row-1"> <td class="category" width="15%"><?php echo lang_get( 'sponsor_issue' ) ?></td> <td> - <form method="POST" action="bug_set_sponsorship.php"> + <form method="post" action="bug_set_sponsorship.php"> <?php echo sponsorship_get_currency() ?> <input type="hidden" name="bug_id" value="<?php echo $f_bug_id ?>" size="4" /> <input type="text" name="amount" value="<?php echo config_get( 'minimum_sponsorship_amount' ) ?>" size="4" /> Index: bug_file_upload_inc.php =================================================================== --- bug_file_upload_inc.php (revision 16) +++ bug_file_upload_inc.php (working copy) @@ -68,7 +68,7 @@ </div> <?php if ( ON == config_get( 'use_javascript' ) ) { ?> -<script type="text/javascript"> +<script type="text/javascript" language="JavaScript"> <!-- SetDiv( "upload_form", g_div_upload_form ); --> Index: query_store_page.php =================================================================== --- query_store_page.php (revision 12) +++ query_store_page.php (working copy) @@ -45,21 +45,21 @@ print lang_get( 'query_name' ) . ': '; ?> - <form method="POST" action="query_store.php"> - <input type="text" name="query_name"><br /> + <form method="post" action="query_store.php"> + <input type="text" name="query_name" /><br /> <?php if ( access_has_project_level( config_get( 'stored_query_create_shared_threshold' ) ) ) { - print '<input type="checkbox" name="is_public" value="on"> '; + print '<input type="checkbox" name="is_public" value="on" /> '; print lang_get( 'make_public' ); print '<br />'; } ?> <input type="checkbox" name="all_projects" value="on" <?php check_checked( ALL_PROJECTS == helper_get_current_project() ) ?> > <?php print lang_get( 'all_projects' ); ?><br /><br /> - <input type="submit" class="button" value="<?php print lang_get( 'save_query' ); ?>"> + <input type="submit" class="button" value="<?php print lang_get( 'save_query' ); ?>" /> </form> <form action="view_all_bug_page.php"> - <input type="submit" class="button" value="<?php print lang_get( 'go_back' ); ?>"> + <input type="submit" class="button" value="<?php print lang_get( 'go_back' ); ?>" /> </form> <?php echo '</div>'; Index: bug_report_advanced_page.php =================================================================== --- bug_report_advanced_page.php (revision 16) +++ bug_report_advanced_page.php (working copy) @@ -235,7 +235,7 @@ <?php echo lang_get( 'os_version' ) ?> </td> <td> - <input tabindex="8" type="text" name="os_build" size="16" maxlength="16" value="<?php echo $f_os_build ?>"> + <input tabindex="8" type="text" name="os_build" size="16" maxlength="16" value="<?php echo $f_os_build ?>" /> </td> </tr> Index: history_inc.php =================================================================== --- history_inc.php (revision 16) +++ history_inc.php (working copy) @@ -95,7 +95,7 @@ </div> <?php if ( ON == config_get( 'use_javascript' ) ) { ?> -<script type="text/JavaScript"> +<script type="text/javascript" language="JavaScript"> <!-- SetDiv( "history", g_div_history ); --> Index: view_filters_page.php =================================================================== --- view_filters_page.php (revision 16) +++ view_filters_page.php (working copy) @@ -30,7 +30,7 @@ ?> <body onload="SetInitialFocus();"> - <script language="Javascript"> + <script type="text/javascript" language="JavaScript"> <!-- function SetInitialFocus() { <?php Index: bugnote_view_inc.php =================================================================== --- bugnote_view_inc.php (revision 16) +++ bugnote_view_inc.php (working copy) @@ -175,7 +175,7 @@ </div> <?php if ( ON == config_get( 'use_javascript' ) ) { ?> -<script type="text/JavaScript"> +<script type="text/javascript" language="JavaScript"> <!-- SetDiv( "bugnotes", g_div_bugnotes ); --> Index: bug_monitor_list_view_inc.php =================================================================== --- bug_monitor_list_view_inc.php (revision 16) +++ bug_monitor_list_view_inc.php (working copy) @@ -81,7 +81,7 @@ </div> <?php if ( ON == config_get( 'use_javascript' ) ) { ?> -<script type="text/javascript"> +<script type="text/javascript" language="JavaScript"> <!-- SetDiv( "monitoring", g_div_monitoring ); --> Index: admin/upgrade_escaping.php =================================================================== --- admin/upgrade_escaping.php (revision 12) +++ admin/upgrade_escaping.php (working copy) @@ -16,6 +16,7 @@ $upgrade_set->add_items( include( 'upgrades/0_17_escaping_fixes_inc.php' ) ); ?> +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html> <head> <title> Mantis Administration - String Escaping Database Fixes </title> Index: admin/css/view_inc.php =================================================================== --- admin/css/view_inc.php (revision 11) +++ admin/css/view_inc.php (working copy) @@ -18,7 +18,7 @@ <option value="1">mantis</option> <option value="3">public</option> </select> - <input type="submit" value="Switch" class="small"> + <input type="submit" value="Switch" class="small" /> </td> </tr> </table> @@ -42,7 +42,7 @@ <a href="">Logout</a> </td> <td class="right"> - <input class="small" type="input" name="f_bug_id" size="6"><input class="small" type="submit" value="Jump"> + <input class="small" type="input" name="f_bug_id" size="6" /><input class="small" type="submit" value="Jump" /> </td> </tr> </table> @@ -66,7 +66,7 @@ <option value="1">mantis</option> <option value="3">public</option> </select> - <input type="submit" value="Switch" class="small"> + <input type="submit" value="Switch" class="small" /> </div> <div class="menu-left"> @@ -80,7 +80,7 @@ <a href="">Logout</a> </div> <div class="menu-right"> -  <input class="small" type="input" name="f_bug_id" size="6"><input class="small" type="submit" value="Jump"> +  <input class="small" type="input" name="f_bug_id" size="6" /><input class="small" type="submit" value="Jump" /> </div> <!-- News --> @@ -123,7 +123,7 @@ <tr> <td class="form-title" colspan="2"> <div class="left"><span class="bold">Edit Account</span></div> - <div class="right">[ Account ][ <a href="">Change Preferences</a> ][ <a href="">Manage Profiles</a> ]</a> + <div class="right">[ Account ][ <a href="">Change Preferences</a> ][ <a href="">Manage Profiles</a> ]</div> </td> </tr> <tr class="row-1"> @@ -131,7 +131,7 @@ Username: </td> <td width="75%"> - <input type="text" size="16" maxlength="32" name="f_username" value="prescience"> + <input type="text" size="16" maxlength="32" name="f_username" value="prescience" /> </td> </tr> <tr class="row-2"> @@ -139,7 +139,7 @@ Password: </td> <td> - <input type="password" size="32" maxlength="32" name="f_password"> + <input type="password" size="32" maxlength="32" name="f_password" /> </td> </tr> <tr class="row-1"> @@ -147,7 +147,7 @@ Confirm Password: </td> <td> - <input type="password" size="32" maxlength="32" name="f_password_confirm"> + <input type="password" size="32" maxlength="32" name="f_password_confirm" /> </td> </tr> <tr class="row-2"> @@ -155,7 +155,7 @@ Email: </td> <td> - <input type="text" size="32" maxlength="64" name="f_email" value="prescience@nowhere.com"> + <input type="text" size="32" maxlength="64" name="f_email" value="prescience@nowhere.com" /> </td> </tr> <tr class="row-1"> @@ -168,7 +168,7 @@ </tr> <tr> <td class="left"> - <input type="submit" value="Update User"> + <input type="submit" value="Update User" /> </td> <td>   @@ -237,7 +237,7 @@ </tr> <tr> <td bgcolor="<?php echo $g_new_color ?>"> - <input type="checkbox" name="f_bug_arr[]" value="0002500"> + <input type="checkbox" name="f_bug_arr[]" value="0002500" /> </td> <td class="center" bgcolor="<?php echo $g_new_color ?>"> </td> @@ -265,7 +265,7 @@ </tr> <tr> <td bgcolor="<?php echo $g_feedback_color ?>"> - <input type="checkbox" name="f_bug_arr[]" value="0002493"> + <input type="checkbox" name="f_bug_arr[]" value="0002493" /> </td> <td class="center" bgcolor="<?php echo $g_feedback_color ?>"> </td> @@ -289,7 +289,7 @@ </tr> <tr> <td bgcolor="<?php echo $g_acknowledged_color ?>"> - <input type="checkbox" name="f_bug_arr[]" value="0002416"> + <input type="checkbox" name="f_bug_arr[]" value="0002416" /> </td> <td class="center" bgcolor="<?php echo $g_acknowledged_color ?>"> </td> @@ -317,7 +317,7 @@ </tr> <tr> <td bgcolor="<?php echo $g_confirmed_color ?>"> - <input type="checkbox" name="f_bug_arr[]" value="0002177"> + <input type="checkbox" name="f_bug_arr[]" value="0002177" /> </td> <td class="center" bgcolor="<?php echo $g_confirmed_color ?>"> </td> @@ -345,7 +345,7 @@ </tr> <tr> <td bgcolor="<?php echo $g_assigned_color ?>"> - <input type="checkbox" name="f_bug_arr[]" value="0002478"> + <input type="checkbox" name="f_bug_arr[]" value="0002478" /> </td> <td class="center" bgcolor="<?php echo $g_assigned_color ?>"> </td> @@ -373,7 +373,7 @@ </tr> <tr> <td bgcolor="<?php echo $g_resolved_color ?>"> - <input type="checkbox" name="f_bug_arr[]" value="0001158"> + <input type="checkbox" name="f_bug_arr[]" value="0001158" /> </td> <td class="center" bgcolor="<?php echo $g_resolved_color ?>"> </td> @@ -401,7 +401,7 @@ </tr> <tr> <td bgcolor="<?php echo $g_closed_color ?>"> - <input type="checkbox" name="f_bug_arr[]" value="0002481"> + <input type="checkbox" name="f_bug_arr[]" value="0002481" /> </td> <td class="center" bgcolor="<?php echo $g_closed_color ?>"> </td> Index: admin/css/index.php =================================================================== --- admin/css/index.php (revision 12) +++ admin/css/index.php (working copy) @@ -4,8 +4,10 @@ header( "Location: index.php" ); } ?> +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html> <head> +<title> Mantis Administration - CSS Generation Tool </title> <?php include('css_inc.php'); ?> <style type="text/css"> input.css { font-family: courier new, courier, fixed; font-size: 8pt; } Index: admin/system_utils.php =================================================================== --- admin/system_utils.php (revision 12) +++ admin/system_utils.php (working copy) @@ -12,6 +12,7 @@ <?php require_once ( dirname( dirname( __FILE__ ) ) . DIRECTORY_SEPARATOR . 'core.php' ); ?> +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html> <head> <title>Mantis Administration - System Utilities</title> @@ -23,7 +24,7 @@ <tr class="top-bar"> <td class="links"> [ <a href="index.php">Back to Mantis Administration</a> ] - [ <a href="upgrade_escaping.php">Refresh view</a> ] + [ <a href="system_utils.php">Refresh view</a> ] </td> <td class="title"> System Utilities @@ -33,7 +34,7 @@ <br /><br /> <table width="80%" bgcolor="#222222" border="0" cellpadding="10" cellspacing="1"> - <tr><td bgcolor=\"#e8e8e8\" colspan=\"2\"><span class=\"title\">Upgrade Utilities</span></td></tr> + <tr><td bgcolor="#e8e8e8" colspan="2"><span class="title">Upgrade Utilities</span></td></tr> <!-- # Headings --> <tr bgcolor="#ffffff"><th width="70%">Description</th><th width="30%">Execute</th></tr> @@ -71,7 +72,7 @@ } ?> </SELECT> - <input type="submit" class="button" value="Copy" > + <input type="submit" class="button" value="Copy" /> </form> </center></td></tr> Index: admin/index.php =================================================================== --- admin/index.php (revision 12) +++ admin/index.php (working copy) @@ -1,3 +1,4 @@ +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html> <head> <title> Mantis Administration </title> Index: admin/move_db2disk.php =================================================================== --- admin/move_db2disk.php (revision 12) +++ admin/move_db2disk.php (working copy) @@ -151,6 +151,7 @@ } } ?> +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html> <head> <title>Mantis Administration - Move <?php echo $t_type ?> to Disk</title> Index: admin/upgrade_advanced.php =================================================================== --- admin/upgrade_advanced.php (revision 12) +++ admin/upgrade_advanced.php (working copy) @@ -22,6 +22,7 @@ $upgrade_set->add_items( include( 'upgrades/0_18_inc.php' ) ); $upgrade_set->add_items( include( 'upgrades/0_19_inc.php' ) ); ?> +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html> <head> <title> Mantis Administration - Database Upgrade </title> Index: admin/upgrade_warning.php =================================================================== --- admin/upgrade_warning.php (revision 11) +++ admin/upgrade_warning.php (working copy) @@ -9,6 +9,7 @@ # $Id: upgrade_warning.php,v 1.3 2004/01/11 07:16:09 vboctor Exp $ # -------------------------------------------------------- ?> +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html> <head> <title> Mantis Administration - Check Installation </title> @@ -44,3 +45,6 @@ </tr> </table> </div> + +</body> +</html> Index: admin/check.php =================================================================== --- admin/check.php (revision 12) +++ admin/check.php (working copy) @@ -106,6 +106,7 @@ $version = phpversion(); ?> +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html> <head> <title> Mantis Administration - Check Installation </title> Index: admin/copy_field.php =================================================================== --- admin/copy_field.php (revision 12) +++ admin/copy_field.php (working copy) @@ -17,6 +17,7 @@ $f_source_field_id = gpc_get_int( 'source_id' ); $f_dest_field = gpc_get( 'dest_id' ); ?> +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html> <head> <title> Mantis Administration - Copy Custom Fields to Built-in </title> Index: admin/upgrade_inc.php =================================================================== --- admin/upgrade_inc.php (revision 16) +++ admin/upgrade_inc.php (working copy) @@ -18,6 +18,7 @@ $result = @db_connect( config_get_global( 'hostname' ), config_get_global( 'db_username' ), config_get_global( 'db_password' ), config_get_global( 'database_name' ) ); if ( false == $result ) { ?> +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html> <head> <title> Mantis Administration - Upgrade Installation </title> @@ -272,7 +273,7 @@ } # Form - echo '<form method="POST" action="' . $_SERVER['PHP_SELF'] . '">'; + echo '<form method="post" action="' . $_SERVER['PHP_SELF'] . '">'; # Execute All Button echo "<input type=\"submit\" name=\"{$this->upgrade_file}_execute_all\" value=\"Execute All\" />"; @@ -361,6 +362,8 @@ # Print Selected Button echo "<input type=\"submit\" name=\"{$this->upgrade_file}_print_selected\" value=\"Print Selected\" />"; } + + echo '</form>'; } function output( $p_limit=null ) { Index: admin/upgrade_list.php =================================================================== --- admin/upgrade_list.php (revision 12) +++ admin/upgrade_list.php (working copy) @@ -1,3 +1,4 @@ +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html> <head> <title> Mantis Administration - Upgrade List </title> Index: admin/upgrade.php =================================================================== --- admin/upgrade.php (revision 16) +++ admin/upgrade.php (working copy) @@ -23,6 +23,7 @@ $upgrade_set->add_items( include( 'upgrades/0_19_inc.php' ) ); $upgrade_set->add_items( include( 'upgrades/1_00_inc.php' ) ); ?> +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html> <head> <title> Mantis Administration - Database Upgrade </title> Index: bug_actiongroup_page.php =================================================================== --- bug_actiongroup_page.php (revision 12) +++ bug_actiongroup_page.php (working copy) @@ -132,7 +132,7 @@ <br /> <div align="center"> -<form method="POST" action="bug_actiongroup.php"> +<form method="post" action="bug_actiongroup.php"> <input type="hidden" name="action" value="<?php echo string_attribute( $f_action ) ?>" /> <?php if ( $f_action === 'CUSTOM' ) { Index: view_all_inc.php =================================================================== --- view_all_inc.php (revision 16) +++ view_all_inc.php (working copy) @@ -46,14 +46,14 @@ # @@@ (thraxisp) this may want a browser check ( MS IE >= 5.0, Mozilla >= 1.0, Safari >=1.2, ...) if ( ( ON == config_get( 'dhtml_filters' ) ) && ( ON == config_get( 'use_javascript' ) ) ){ ?> - <script type="text/javascript"> + <script type="text/javascript" language="JavaScript"> <!-- var string_loading = '<?php echo lang_get( 'loading' );?>'; --> </script> - <script type="text/javascript" src="javascript/xmlhttprequest.js"></script> - <script type="text/javascript" src="javascript/addLoadEvent.js"></script> - <script type="text/javascript" src="javascript/dynamic_filters.js"></script> + <script type="text/javascript" language="JavaScript" src="javascript/xmlhttprequest.js"></script> + <script type="text/javascript" language="JavaScript" src="javascript/addLoadEvent.js"></script> + <script type="text/javascript" language="JavaScript" src="javascript/dynamic_filters.js"></script> <?php } ?> @@ -158,7 +158,7 @@ <td class="left" colspan="<?php echo $col_count-2; ?>"> <?php if ( $t_checkboxes_exist && ON == config_get( 'use_javascript' ) ) { - echo "<input type=\"checkbox\" name=\"all_bugs\" value=\"all\" onclick=\"checkall('bug_action', this.form.all_bugs.checked)\"><span class=\"small\">" . lang_get( 'select_all' ) . '</span>'; + echo "<input type=\"checkbox\" name=\"all_bugs\" value=\"all\" onclick=\"checkall('bug_action', this.form.all_bugs.checked)\" /><span class=\"small\">" . lang_get( 'select_all' ) . '</span>'; } if ( $t_checkboxes_exist ) { Index: core/html_api.php =================================================================== --- core/html_api.php (revision 16) +++ core/html_api.php (working copy) @@ -239,7 +239,7 @@ # (6a) Javascript... function html_head_javascript() { if ( ON == config_get( 'use_javascript' ) ) { - echo "\t" . '<script type="text/JavaScript" src="javascript/common.js">'; + echo "\t" . '<script type="text/javascript" language="JavaScript" src="javascript/common.js">'; echo '</script>' . "\n"; } } Index: core/custom_field_api.php =================================================================== --- core/custom_field_api.php (revision 12) +++ core/custom_field_api.php (working copy) @@ -1132,7 +1132,7 @@ } if ( $p_field_def['type'] == CUSTOM_FIELD_TYPE_MULTILIST ) { - echo '<select name="custom_field_' . $t_id . '[]" size="' . $t_list_size . '" multiple>'; + echo '<select name="custom_field_' . $t_id . '[]" size="' . $t_list_size . '" multiple="multiple">'; } else { echo '<select name="custom_field_' . $t_id . '" size="' . $t_list_size . '">'; } @@ -1140,7 +1140,7 @@ $t_selected_values = explode( '\|', $t_custom_field_value ); foreach( $t_values as $t_option ) { if( in_array( $t_option, $t_selected_values ) ) { - echo '<option value="' . $t_option . '" selected> ' . $t_option . '</option>'; + echo '<option value="' . $t_option . '" selected="selected"> ' . $t_option . '</option>'; } else { echo '<option value="' . $t_option . '">' . $t_option . '</option>'; } @@ -1153,9 +1153,9 @@ foreach( $t_values as $t_option ) { echo '<input type="checkbox" name="custom_field_' . $t_id . '[]"'; if( in_array( $t_option, $t_checked_values ) ) { - echo ' value="' . $t_option . '" checked> ' . $t_option . '  '; + echo ' value="' . $t_option . '" checked="checked" /> ' . $t_option . '  '; } else { - echo ' value="' . $t_option . '"> ' . $t_option . '  '; + echo ' value="' . $t_option . '" /> ' . $t_option . '  '; } } break; @@ -1169,7 +1169,7 @@ } else { echo ' maxlength="255"'; } - echo ' value="' . $t_custom_field_value .'"></input>'; + echo ' value="' . $t_custom_field_value .'" />'; break ; case CUSTOM_FIELD_TYPE_DATE: Index: core/filter_api.php =================================================================== --- core/filter_api.php (revision 16) +++ core/filter_api.php (working copy) @@ -2293,7 +2293,7 @@ if ( ( isset( $t_realname ) ) && ( $t_realname > "" ) && ( ON == config_get( 'show_realname' ) ) ){ $t_display_name = string_attribute( $t_realname ); } - PRINT '<option value="' . $t_id . '" SELECTED >' . $t_display_name . '</option>'; + PRINT '<option value="' . $t_id . '" selected="selected">' . $t_display_name . '</option>'; } else { ?> <option value="[any]" <?php check_selected( $t_filter['reporter_id'], META_FILTER_ANY ); ?>>[<?php echo lang_get( 'any' ) ?>]</option> @@ -2692,7 +2692,7 @@ $t_js_toggle_func = "toggle_custom_date_field_" . $p_field_id . "_controls" ; ?> - <script language="Javascript"> + <script type="text/javascript" language="JavaScript"> <!-- function <?php echo $t_js_toggle_func . "_start" ; ?>(disable) { document.filters.custom_field_<?php echo $p_field_id ; ?>_start_year.disabled = disable ; Index: core/relationship_api.php =================================================================== --- core/relationship_api.php (revision 16) +++ core/relationship_api.php (working copy) @@ -686,15 +686,15 @@ ?> <select name="<?php echo $p_select_name?>"> <?php if ($p_include_any) { ?> -<option value="any" <?php echo ( $p_default_rel_type == -1 ? ' selected' : '' ) ?>>[<?php echo lang_get( 'any' ) ?>]</option> +<option value="any" <?php echo ( $p_default_rel_type == -1 ? ' selected="selected"' : '' ) ?>>[<?php echo lang_get( 'any' ) ?>]</option> <?php } ?> -<option value="<?php echo BUG_RELATED ?>"<?php echo ( $p_default_rel_type == BUG_RELATED ? ' selected' : '' ) ?>><?php echo lang_get( 'related_to' ) ?></option> -<option value="<?php echo BUG_DEPENDANT ?>"<?php echo ( $p_default_rel_type == BUG_DEPENDANT ? ' selected' : '' ) ?>><?php echo lang_get( 'dependant_on' ) ?></option> -<option value="<?php echo BUG_BLOCKS ?>" <?php echo ( $p_default_rel_type == BUG_BLOCKS ? ' selected' : '' ) ?>><?php echo lang_get( 'blocks' ) ?></option> -<option value="<?php echo BUG_DUPLICATE ?>"<?php echo ( $p_default_rel_type == BUG_DUPLICATE ? ' selected' : '' ) ?>><?php echo lang_get( 'duplicate_of' ) ?></option> -<option value="<?php echo BUG_HAS_DUPLICATE ?>"<?php echo ( $p_default_rel_type == BUG_HAS_DUPLICATE ? ' selected' : '' ) ?>><?php echo lang_get( 'has_duplicate' ) ?></option> +<option value="<?php echo BUG_RELATED ?>"<?php echo ( $p_default_rel_type == BUG_RELATED ? ' selected="selected"' : '' ) ?>><?php echo lang_get( 'related_to' ) ?></option> +<option value="<?php echo BUG_DEPENDANT ?>"<?php echo ( $p_default_rel_type == BUG_DEPENDANT ? ' selected="selected"' : '' ) ?>><?php echo lang_get( 'dependant_on' ) ?></option> +<option value="<?php echo BUG_BLOCKS ?>" <?php echo ( $p_default_rel_type == BUG_BLOCKS ? ' selected="selected"' : '' ) ?>><?php echo lang_get( 'blocks' ) ?></option> +<option value="<?php echo BUG_DUPLICATE ?>"<?php echo ( $p_default_rel_type == BUG_DUPLICATE ? ' selected="selected"' : '' ) ?>><?php echo lang_get( 'duplicate_of' ) ?></option> +<option value="<?php echo BUG_HAS_DUPLICATE ?>"<?php echo ( $p_default_rel_type == BUG_HAS_DUPLICATE ? ' selected="selected"' : '' ) ?>><?php echo lang_get( 'has_duplicate' ) ?></option> </select> <?php } @@ -704,10 +704,10 @@ function relationship_list_box_for_cloned_bug( $p_default_rel_type = -1 ) { ?> <select name="rel_type"> -<option value="-1"<?php echo ( $p_default_rel_type == -1 ? ' selected' : '' ) ?>><?php echo lang_get( 'no_relationship' ) ?></option> -<option value="<?php echo BUG_RELATED ?>"<?php echo ( $p_default_rel_type == BUG_RELATED ? ' selected' : '' ) ?>><?php echo lang_get( 'related_to' ) ?></option> -<option value="<?php echo BUG_DEPENDANT ?>"<?php echo ( $p_default_rel_type == BUG_DEPENDANT ? ' selected' : '' ) ?>><?php echo lang_get( 'dependant_on' ) ?></option> -<option value="<?php echo BUG_BLOCKS ?>" <?php echo ( $p_default_rel_type == BUG_BLOCKS ? ' selected' : '' ) ?>><?php echo lang_get( 'blocks' ) ?></option> +<option value="-1"<?php echo ( $p_default_rel_type == -1 ? ' selected="selected"' : '' ) ?>><?php echo lang_get( 'no_relationship' ) ?></option> +<option value="<?php echo BUG_RELATED ?>"<?php echo ( $p_default_rel_type == BUG_RELATED ? ' selected="selected"' : '' ) ?>><?php echo lang_get( 'related_to' ) ?></option> +<option value="<?php echo BUG_DEPENDANT ?>"<?php echo ( $p_default_rel_type == BUG_DEPENDANT ? ' selected="selected"' : '' ) ?>><?php echo lang_get( 'dependant_on' ) ?></option> +<option value="<?php echo BUG_BLOCKS ?>" <?php echo ( $p_default_rel_type == BUG_BLOCKS ? ' selected="selected"' : '' ) ?>><?php echo lang_get( 'blocks' ) ?></option> </select> <?php } @@ -744,7 +744,7 @@ <tr class="row-1"> <td class="category"><?php echo lang_get( 'add_new_relationship' ) ?></td> <td><?php echo lang_get( 'this_bug' ) ?> - <form method="POST" action="bug_relationship_add.php"> + <form method="post" action="bug_relationship_add.php"> <input type="hidden" name="src_bug_id" value="<?php echo $p_bug_id ?>" size="4" /> <?php relationship_list_box( -1 ) ?> <input type="text" name="dest_bug_id" value="" maxlength="7" /> Index: core/collapse_api.php =================================================================== --- core/collapse_api.php (revision 16) +++ core/collapse_api.php (working copy) @@ -108,7 +108,7 @@ $g_open_collapse_section = false; if ( ON == config_get( 'use_javascript' ) ) { - echo '<script type="text/JavaScript"><!--'; + echo '<script type="text/javascript" language="JavaScript"><!--'; echo ' SetDiv( "', $p_name, '", g_div_', $p_name, ' );'; echo '--></script>'; Index: manage_config_workflow_page.php =================================================================== --- manage_config_workflow_page.php (revision 16) +++ manage_config_workflow_page.php (working copy) @@ -56,7 +56,7 @@ echo '<tr><td class="form-title" width="30%" rowspan="2">' . lang_get( 'current_status' ) . '</td>'; echo '<td class="form-title" style="text-align:center" colspan="' . ( count( $t_enum_status ) ) . '">' . lang_get( 'next_status' ) . '</td></tr>'; - echo "\n<tr></td>"; + echo "\n<tr>"; foreach( $t_enum_status as $t_status ) { $t_entry_array = explode_enum_arr( $t_status ); echo '<td class="form-title" style="text-align:center"> ' . get_enum_to_string( lang_get( 'status_enum_string' ), $t_entry_array[0] ) . ' </td>'; Index: print_all_bug_page.php =================================================================== --- print_all_bug_page.php (revision 12) +++ print_all_bug_page.php (working copy) @@ -139,7 +139,7 @@ "&export=$f_export" . "&show_flag=$t_show_flag" . '" ' . $t_icon[2] . '>' . - '<img src="' . $t_icon_path . $t_icon[3] . '" border="0" align="absmiddle" alt="' . $t_icon[4] . '"></a> '; + '<img src="' . $t_icon_path . $t_icon[3] . '" border="0" align="absmiddle" alt="' . $t_icon[4] . '" /></a> '; } ?> </td> Index: bugnote_add_inc.php =================================================================== --- bugnote_add_inc.php (revision 16) +++ bugnote_add_inc.php (working copy) @@ -79,7 +79,7 @@ </div> <?php if ( ON == config_get( 'use_javascript' ) ) { ?> -<script type="text/JavaScript"> +<script type="text/javascript" language="JavaScript"> <!-- SetDiv( "bugnote_add", g_div_bugnote_add ); --> Index: manage_custom_field_edit_page.php =================================================================== --- manage_custom_field_edit_page.php (revision 11) +++ manage_custom_field_edit_page.php (working copy) @@ -126,7 +126,7 @@ <?php echo lang_get( 'custom_field_advanced' ) ?> </td> <td> - <input type="checkbox" name="advanced" value="1" <?php check_checked( $t_definition['advanced'] ) ?>> + <input type="checkbox" name="advanced" value="1" <?php check_checked( $t_definition['advanced'] ) ?> /> </td> </tr> <tr <?php echo helper_alternate_class() ?>> @@ -134,7 +134,7 @@ <?php echo lang_get( 'custom_field_display_report' ) ?> </td> <td> - <input type="checkbox" name="display_report" value="1" <?php check_checked( $t_definition['display_report'] ) ?>> + <input type="checkbox" name="display_report" value="1" <?php check_checked( $t_definition['display_report'] ) ?> /> </td> </tr> <tr <?php echo helper_alternate_class() ?>> @@ -142,7 +142,7 @@ <?php echo lang_get( 'custom_field_display_update' ) ?> </td> <td> - <input type="checkbox" name="display_update" value="1" <?php check_checked( $t_definition['display_update'] ) ?>> + <input type="checkbox" name="display_update" value="1" <?php check_checked( $t_definition['display_update'] ) ?> /> </td> </tr> <tr <?php echo helper_alternate_class() ?>> @@ -150,7 +150,7 @@ <?php echo lang_get( 'custom_field_display_resolved' ) ?> </td> <td> - <input type="checkbox" name="display_resolved" value="1" <?php check_checked( $t_definition['display_resolved'] ) ?>> + <input type="checkbox" name="display_resolved" value="1" <?php check_checked( $t_definition['display_resolved'] ) ?> /> </td> </tr> <tr <?php echo helper_alternate_class() ?>> @@ -158,7 +158,7 @@ <?php echo lang_get( 'custom_field_display_closed' ) ?> </td> <td> - <input type="checkbox" name="display_closed" value="1" <?php check_checked( $t_definition['display_closed'] ) ?>> + <input type="checkbox" name="display_closed" value="1" <?php check_checked( $t_definition['display_closed'] ) ?> /> </td> </tr> <tr <?php echo helper_alternate_class() ?>> @@ -166,7 +166,7 @@ <?php echo lang_get( 'custom_field_require_report' ) ?> </td> <td> - <input type="checkbox" name="require_report" value="1" <?php check_checked( $t_definition['require_report'] ) ?>> + <input type="checkbox" name="require_report" value="1" <?php check_checked( $t_definition['require_report'] ) ?> /> </td> </tr> <tr <?php echo helper_alternate_class() ?>> @@ -174,7 +174,7 @@ <?php echo lang_get( 'custom_field_require_update' ) ?> </td> <td> - <input type="checkbox" name="require_update" value="1" <?php check_checked( $t_definition['require_update'] ) ?>> + <input type="checkbox" name="require_update" value="1" <?php check_checked( $t_definition['require_update'] ) ?> /> </td> </tr> <tr <?php echo helper_alternate_class() ?>> @@ -182,7 +182,7 @@ <?php echo lang_get( 'custom_field_require_resolved' ) ?> </td> <td> - <input type="checkbox" name="require_resolved" value="1" <?php check_checked( $t_definition['require_resolved'] ) ?>> + <input type="checkbox" name="require_resolved" value="1" <?php check_checked( $t_definition['require_resolved'] ) ?> /> </td> </tr> <tr <?php echo helper_alternate_class() ?>> @@ -190,7 +190,7 @@ <?php echo lang_get( 'custom_field_require_closed' ) ?> </td> <td> - <input type="checkbox" name="require_closed" value="1" <?php check_checked( $t_definition['require_closed'] ) ?>> + <input type="checkbox" name="require_closed" value="1" <?php check_checked( $t_definition['require_closed'] ) ?> /> </td> </tr> <tr> various_html.patch (33,002 bytes)

grangeway 2005-05-17 09:00 reporter ~0010156	Make all <script> tags use type="text/javascript" language="JavaScript" Doesn't this 'break' xhtml compliancy: From the XHTML DTD: <!-- script statements, which may include CDATA sections --> <!ELEMENT script (#PCDATA)> <!ATTLIST script id ID #IMPLIED charset %Charset; #IMPLIED type %ContentType; #REQUIRED src %URI; #IMPLIED defer (defer) #IMPLIED xml:space (preserve) #FIXED 'preserve' Where does the 'language' tag fit in ?

ryandesign 2006-03-09 08:19 reporter ~0012313	I have no objection to omitting the "language" part of the tag. I hadn't checked the DTD; it was just out of habit.

vboctor 2006-08-15 03:15 manager ~0013273	I've committed Ryan's patch as it is. Ryan, please revert the language="JavaScript" if it is not correct. Also feel free to fix the other XHTML issues and commit your changes directly.