|
|
It seems like email notifications are more suitable to the scenario you are mentioning. With RSS you may have an issue come to the top of the list due to more than one action, where the last is least important. However, with email notifications you will get an email per action. |
|
|
Actually, since I raised that bug, I've become more comfortable with the code, and I've made the change myself.
I added to config_inc.php
$g_rss_days_of_history = '5'
And to history_api.php:
--------------------
# Returns an HTML string containing the last n days of bug history in reverse date order
function history_get_history_string( $p_bug_id, $p_days, $p_user_id = null) {
$t_bug_history = history_get_events_array( $p_bug_id, $p_days, $p_user_id );
# get current date/time and modify to represent midnight last night
$t_now = getdate();
if( $t_now['mday'] <= $p_days ) {
$t_now['mon'] --;
$t_now['mday'] = cal_days_in_month(CAL_GREGORIAN , $t_now['mon'], $t_now['year']);
}
else {
$t_now['mday'] -= $p_days;
}
# now turn that into a unix timestamp
$t_cutoff = mktime ( 0, 0, 0, $t_now['mon'], $t_now['mday'], $t_now['year'] );
$t_history_string = "<br><br><b>Activity for last $p_days days:</b><table border=1>";
foreach ( array_reverse($t_bug_history) as $t_item ) {
$t_history_date = strtotime($t_item['date']);
if($t_history_date < $t_cutoff) {
continue;
}
$t_history_string .= "<tr>";
$t_history_string .= "<td>" . $t_item['date'] . "</td>";
$t_history_string .= "<td>" . $t_item['username'] . "</td>";
$t_history_string .= "<td>" . $t_item['note'] . "</td>";
$t_history_string .= "<td>" . $t_item['change'] . "</td>";
$t_history_string .= "</tr>";
}
$t_history_string .= "</table>";
return $t_history_string;
}
And to issues_rss.php:
$t_days_of_history = config_get( 'rss_days_of_history' );
$description = string_rss_links( $t_bug->description
. (history_get_history_string( $row['id'], $t_days_of_history)));
And it works a treat. Really, all I wanted was to know what had caused the bug to be included in the RSS feed, without having to open the bug link in the browser.
As an aside, I'd be happy to contribute this code somewhere, but I'm not sure how... |
|
|
I think this requirement is covered by the Timeline feature, introduced in 1.3, so I'm resolving this issue as "no change required".
Feel free to reopen the issue if you disagree. |
