Page 1 of 1

phpmailer - certificates

Posted: May 07, 2019 4:26 am
by Tomek
PHPMailer has options to sign mails with certifiacate, but mantis doesn´t support this option. Is this already planned? I think it is very small change.

Re: phpmailer - certificates

Posted: May 07, 2019 3:46 pm
by atrol
Tomek wrote:
May 07, 2019 4:26 am
Is this already planned?
Seems no, at least I did not find report for it at https://www.mantisbt.org/bugs
Tomek wrote:
May 07, 2019 4:26 am
I think it is very small change.
The best way would be to create a report for it and send a pull request with the change on https://github.com/mantisbt/mantisbt
Please make sure that your submissions adhere to our Coding Guidelines http://www.mantisbt.org/wiki/doku.php/m ... guidelines

Re: phpmailer - certificates

Posted: May 08, 2019 11:45 am
by Tomek
I would suggest in email_api.php at the end of section "case PHPMAILER_METHOD_SMTP:"

$t_mail->sign(config_get_global('cert_filename'), config_get_global('key_filename'), config_get_global('key_pass'), config_get_global('extracerts_filename '));

And in config_defaults_inc.php
/**
* Path to mail certification file
*
* @global string $g_cert_filename
*/
$g_cert_filename = '';

/**
* Path to mail private key file
*
* @global string $g_key_filename
*/
$g_key_filename = '';

/**
* mail private key pass
*
* @global string $g_key_pass
*/
$g_key_pass = '';

/**
* Path to mail extra certification file
*
* @global string $g_sign_extracerts_file
*/
$g_sign_extracerts_file = '';

Re: phpmailer - certificates

Posted: May 09, 2019 4:27 pm
by atrol
atrol wrote:
May 07, 2019 3:46 pm
The best way would be to create a report for it and send a pull request
Example for a similar request
https://www.mantisbt.org/bugs/view.php?id=23493
https://github.com/mantisbt/mantisbt/co ... bbbe987d63

Re: phpmailer - certificates

Posted: May 16, 2019 4:24 am
by atrol