Does Mantis detect 'Mid-Air collisions' when 2ppl edit a bug

Get help from other users here.

Moderators: Contributor, Developer

Post Reply
hmackiernan
Posts: 18
Joined: Feb 17, 2006 2:23 pm
Location: San Francisco, CA

Does Mantis detect 'Mid-Air collisions' when 2ppl edit a bug

Post by hmackiernan » Jan 12, 2007 2:26 pm

It was with dawning horror that I realized I don't *think* Mantis checks for this:

Alice opens defect 1234 in her browser and starts typing a bug note, and changes the state from FOO to BAR

Simultaneously, Bob opens defect 1234 and starts editing, adding his own bug note but *does not* change the state, leaving it at FOO

While Bob is working, Alice submits her changes (new bugnote, state FOO => BAR).

Then, Bob submits his changes which adds his new bugnote but which *changes the state back to FOO*

I've tested this in 1.0.6 and there does not appear to be any safeguard against it.

[Bugzilla does have this facility, incidentally, in the above scenario Bob would get a warning when he submits that the bug has changed since he started editing and giving him the option to plow ahead and clobber Alice's changes *or* get a new synthesis of his bug and alice's changes and reconcile them.]

Standard apology if this has been asked before but I didn't see it in any of the help or discussion fora and thanks in advance
hmackiernan/SF, CA

runner80
Posts: 13
Joined: Jan 23, 2007 5:29 am
Location: Dortmund, Germany

Problem with simultaneously editing of issues!

Post by runner80 » Jan 23, 2007 5:34 am

Hi,
has anybody found a solution to this issue? I encountered the same problem with simultaneously editing of bugs in Mantis. The system simply overwrites changes without warning.

I already searched the board for a solution but didn't found anything. Hope somebody can help me!

Regards
Patrick

PS: Using Mantis 1.0.1

vboctor
Site Admin
Posts: 1286
Joined: Feb 13, 2005 5:11 pm
Location: Redmond, Washington
Contact:

Post by vboctor » Jan 24, 2007 12:44 am

Mantis doesn't implement optimistic locking or any kind of locking for this scenario. I agree that Mantis should handle this scenario, but so far it wasn't a requested feature.

The solution to this problem would be to update the Issue Update form to send the last modified time to the bug_update.php script. The bug_update.php script should only update the issue if the issue still exists and the last modified time stamp didn't change.

In the case where the issue was deleted or update, an error message should be prompted. The user should be able to go back in order to copy and paste any data that he/she requires to preserve.

I would suggest reporting this issue in the bug tracker. If someone implements it, I would be happy to integrate the patch.

runner80
Posts: 13
Joined: Jan 23, 2007 5:29 am
Location: Dortmund, Germany

Post by runner80 » Jan 24, 2007 3:16 am

Thanks for the reply! Your described workaround is just the way I implemented it yesterday. Only the data isn't preserved yet. This is the next thing I wanted to do.

Patrick
There are only 10 types of people in the world: Those who understand binary, and those who don't.

vboctor
Site Admin
Posts: 1286
Joined: Feb 13, 2005 5:11 pm
Location: Redmond, Washington
Contact:

Post by vboctor » Jan 27, 2007 12:47 am

It would be great if you submit an issue to the bug tracker with the modified files and possibly the CVS patch in a zip file. This will allow us to put it faster into the code base.

bert.verbat
Posts: 1
Joined: Oct 11, 2018 2:42 am

Re: Does Mantis detect 'Mid-Air collisions' when 2ppl edit a bug

Post by bert.verbat » Oct 11, 2018 2:44 am

Hi,

has, in the mean while, some kind of locking been implemented? If so, where can I configure it?

Regards

Bert

atrol
Site Admin
Posts: 7301
Joined: Mar 26, 2008 4:37 pm
Location: Germany

Re: Does Mantis detect 'Mid-Air collisions' when 2ppl edit a bug

Post by atrol » Oct 11, 2018 3:28 am

There is no locking implemented, but starting in version 1.3.0 there is some kind of conflict detection.
You will get the following message if there is a conflict.
This issue has been updated by another user. Please return to the issue and submit your changes again.
Please use Search before posting and read the Manual

Post Reply