Please see this bug for error

This plugin allows you to report an issue in MantisBT by sending an email to a particular mail account

Moderators: Developer, Contributor

Post Reply
mushu
Posts: 360
Joined: 04 Jan 2017, 17:41

Please see this bug for error

Post by mushu »

Atrol won't move the bug to this forum as requested and says to contact author of "changes". Since the bug may still be due to code in the original Mantis codebase this is rather shortsighted, but hey, get what you pay for I suppose. Please see this bug: https://www.mantisbt.org/forums/viewtopic.php?t=27716
atrol
Site Admin
Posts: 8402
Joined: 26 Mar 2008, 21:37
Location: Germany

Re: Please see this bug for error

Post by atrol »

mushu wrote: 02 Mar 2022, 21:17 Atrol won't move the bug to this forum as requested and says to contact author of "changes". Since the bug may still be due to code in the original Mantis codebase this is rather shortsighted, but hey, get what you pay for I suppose. Please see this bug: https://www.mantisbt.org/forums/viewtopic.php?t=27716
???

The code you showed in the linked post is not related to the EmailReporing plugin.
It's not related to any plugin.
Plugins do not change any original source code of MantisBT.
The code snippets you showed are changes in original file core\email_api.php of MantisBT.
So there is no other way to contact the person who changed this file.
Please use Search before posting and read the Manual
mushu
Posts: 360
Joined: 04 Jan 2017, 17:41

Re: Please see this bug for error

Post by mushu »

The changes necessary to enable email message templating have to be made to core files. It is a very small additional code. The plugins system doesn't allow for that. The developers have said there is no desire to add templating code to enable this in the core program since not enough people have asked for it, however if nobody knows to ask for it then that is silly. It would require little code change to the base code to enable a nice template system for pretty emails. This was how cas had enabled the feature for the emailreporting plugin.
atrol
Site Admin
Posts: 8402
Joined: 26 Mar 2008, 21:37
Location: Germany

Re: Please see this bug for error

Post by atrol »

The forum where you posted this topic is used to support the EmailReporting plugin https://github.com/mantisbt-plugins/EmailReporting
Here you get superior support from user SL-Gundam for this plugin, but not for changes in MantisBT core or other plugins.
You are obviously talking about another plugin that was created by user cas.

If you want to have changed something in MantisBT standard core and have it maintained in long term by the MantisBT core team, the steps are
1. Create an issue at https://www.mantisbt.org/bugs
2. Create a pull request at https://github.com/mantisbt/mantisbt/pulls where you reference the created issue

After that, the changes will be discussed between the author of the pull request and the MantisBT core developers.
The changes must
- follow some rules https://www.mantisbt.org/wiki/doku.php/ ... guidelines
- be documented, must run on supported operating systems, supported databases, supported PHP versions, supported browsers, ...
- not introduce any security issues.
- ....

So if you or cas send a pull request, there is a chance to get something changed in the standard product.
Of course, this will be more than just a few lines, as some conceptual changes could be needed for a clean solution that works for all.

Independant from that, if you want to go on to use the current quick and dirty solution, you can maintain it in an easy way if there are newer MantisBT versions.
Create an own branch and use the power of Git to merge the changes.
Please use Search before posting and read the Manual
cas
Posts: 1642
Joined: 11 Mar 2006, 16:08
Contact:

Re: Please see this bug for error

Post by cas »

I will consider creating a pull request but before doing so, the issue around this application error 1802 needs to be resolved. Cannot reproduce this error till now :cry:
Post Reply