| *** dejalexander <dejalexander!~dejalexan@94-194-42-47.zone8.bethere.co.uk> has joined #mantisbt | 02:29 | |
| *** voldial <voldial!~user@ip72-200-111-224.tc.ph.cox.net> has joined #mantisbt | 02:32 | |
| voldial | Is there a link to donate to mantis dev? I was filling out a bug report in mantis for a client, and I wanted to put a link to where they can help fund the software. | 02:33 |
|---|---|---|
| voldial | I dont see one on the site. | 02:34 |
| *** kirillka <kirillka!~Miranda@195.242.142.17> has joined #mantisbt | 02:44 | |
| *** YamakasY <YamakasY!~yamakasy@62.58.32.94> has joined #mantisbt | 03:01 | |
| *** dejalexander <dejalexander!~dejalexan@94-194-42-47.zone8.bethere.co.uk> has quit IRC | 04:00 | |
| *** voldial <voldial!~user@ip72-200-111-224.tc.ph.cox.net> has quit IRC | 04:20 | |
| *** dejalexander <dejalexander!~dejalexan@dab-ell1-h-1-8.dab.02.net> has joined #mantisbt | 04:34 | |
| *** dejalexander <dejalexander!~dejalexan@dab-ell1-h-1-8.dab.02.net> has quit IRC | 04:50 | |
| *** YamakasY <YamakasY!~yamakasy@62.58.32.94> has quit IRC | 04:54 | |
| *** YamakasY <YamakasY!~yamakasy@62.58.32.94> has joined #mantisbt | 04:54 | |
| *** dejalexander <dejalexander!~dejalexan@82.71.191.125> has joined #mantisbt | 06:49 | |
| *** dejalexander <dejalexander!~dejalexan@82.71.191.125> has quit IRC | 07:27 | |
| *** kirillka <kirillka!~Miranda@195.242.142.17> has quit IRC | 08:42 | |
| GitHub | [mantisbt] dregad pushed 2 new commits to master-1.2.x: http://git.io/C64O8g | 09:36 |
| GitHub | mantisbt/master-1.2.x dae99d0 Damien Regad: Prevent plugin pages access when upgrade pending... | 09:36 |
| GitHub | mantisbt/master-1.2.x 568c5ea Damien Regad: Fix group actions not sending notifications... | 09:36 |
| *** dregad <dregad!~dregad@77-234.193-178.cust.bluewin.ch> has joined #mantisbt | 09:36 | |
| GitHub | [mantisbt] dregad pushed 23 new commits to master: http://git.io/mtXJVw | 09:54 |
| GitHub | mantisbt/master 7b483a8 Damien Regad: Dropping deprecated database API function db_query()... | 09:54 |
| GitHub | mantisbt/master d46001b Damien Regad: Fix error with PostgreSQL when filtering on date custom field... | 09:54 |
| GitHub | mantisbt/master 99fdb5b Damien Regad: Use variable to minimize array dereferencing | 09:54 |
| GitHub | [mantisbt] dregad pushed 6 new commits to master: http://git.io/qzicLg | 10:06 |
| GitHub | mantisbt/master 7fe9e02 Damien Regad: Revert "Add user to project when locking themselves out"... | 10:06 |
| GitHub | mantisbt/master 618ffb2 Damien Regad: Add user to project when locking themselves out... | 10:06 |
| GitHub | mantisbt/master 751b82f Damien Regad: Whitespace | 10:06 |
| GitHub | [mantisbt] vboctor pushed 1 new commit to master: http://git.io/MCZVcQ | 10:11 |
| GitHub | mantisbt/master 29b7e59 Victor Boctor: Fixes #16891: Update DisposableEmailChecker to v2 and change to submodule. | 10:11 |
| GitHub | [mantisbt] dregad pushed 1 new commit to master: http://git.io/xiYgRw | 10:29 |
| GitHub | mantisbt/master 12ddfae Damien Regad: Reintroduce submodule for securimage library... | 10:29 |
| GitHub | [mantisbt] dregad pushed 1 new commit to master: http://git.io/3Q5kxA | 10:34 |
| GitHub | mantisbt/master 51f6cae Damien Regad: Do not reauthenticate user when verifying signup... | 10:34 |
| GitHub | [mantisbt] dregad pushed 7 new commits to master: http://git.io/iBGFlA | 10:38 |
| GitHub | mantisbt/master fc13f29 Damien Regad: Notes on dynamic CSS not defining proper color class | 10:38 |
| GitHub | mantisbt/master 1ab1f47 Damien Regad: Fix system notice | 10:38 |
| GitHub | mantisbt/master 1c1fceb Damien Regad: Dynamic CSS: fix redirection to login page when not logged in | 10:38 |
| GitHub | [mantisbt] vboctor pushed 1 new commit to master: http://git.io/CRLyFg | 10:41 |
| GitHub | mantisbt/master 8db8537 Victor Boctor: Fixes #16871: Email notifications are sent with extra blank lines... | 10:41 |
| *** paul___ <paul___!ab21c458@gateway/web/freenode/ip.171.33.196.88> has joined #mantisbt | 10:41 | |
| * paul___ looks at dregad | 10:42 | |
| *** paul___ <paul___!ab21c458@gateway/web/freenode/ip.171.33.196.88> has quit IRC | 10:49 | |
| dregad | paulr what | 10:50 |
| *** paul___ <paul___!ab21c458@gateway/web/freenode/ip.171.33.196.88> has joined #mantisbt | 11:18 | |
| dregad | paul___ here goes Mr. Underscores again | 11:18 |
| dregad | what did you want | 11:18 |
| paul___ | yea, I was kinda assuming we'd have some process at end regarding merging or well ;) | 11:19 |
| paul___ | the db filterapi sql change i moaned about, I missed that pull request even existed | 11:19 |
| paul___ | so ok, my fault there | 11:20 |
| dregad | :) | 11:20 |
| paul___ | but it's obviously not been tested properly ;/ | 11:20 |
| paul___ | hence my, I'd kinda assumed we'd have some sort of final conclusion | 11:20 |
| paul___ | as opposed to "ask feedback, get feedback, merge" :P | 11:21 |
| dregad | you're referring to bug 16584 ? | 11:21 |
| paul___ | not sure - whatever one had the COALESCE(ISNULL)CAST stuff | 11:21 |
| paul___ | I took one look at the diff, saw the SQL change [ which I hadn't seen before] | 11:22 |
| paul___ | and thought I dont think that works | 11:22 |
| dregad | yea that's the one | 11:22 |
| paul___ | pasted it into mssql and went "it doesnt seem to work" | 11:22 |
| paul___ | given it was filter api | 11:22 |
| dregad | i can't test on mssql | 11:22 |
| dregad | don't have this platfor | 11:22 |
| dregad | m | 11:23 |
| paul___ | was that same patch that i'd commented on use of '{$table} which you said you'd remove, then did a grep of other source? | 11:23 |
| * dregad looks at his swiss cheese memory | 11:23 | |
| dregad | don't remember | 11:23 |
| paul___ | my memory for IT stuff is pretty good ;p | 11:23 |
| paul___ | like *annoyingly* good | 11:23 |
| dregad | so refresh mine | 11:24 |
| paul___ | anyway, posted a proposal about removing submodules, or if we want to keep them some options to make them easier to work with | 11:24 |
| paul___ | there was some patch to filter api | 11:24 |
| paul___ | where you'd changed | 11:24 |
| paul___ | $sql = 'SELECT * FROM ' . $table | 11:25 |
| paul___ | to | 11:25 |
| paul___ | "SELECT * FROM {$table} | 11:25 |
| paul___ | i'd commented we don't normally use that syntax | 11:25 |
| paul___ | you said you'd remove | 11:25 |
| dregad | ah yes i remember now | 11:25 |
| paul___ | then you followed up with you'd grepped source and found we use it in 3-4 other places | 11:26 |
| paul___ | I think I might have commented we should remove it from those 3-4 places and just never use | 11:26 |
| paul___ | at least, going back years, you've got the pedantic debate of whether "foo $bar" or 'foo' . $bar is faster or slower | 11:26 |
| paul___ | [I think in present world they ~same] | 11:27 |
| paul___ | in terms of {$table}, arguably, that goes if we update syntax | 11:27 |
| paul___ | i.e. 'dblayerv2' | 11:27 |
| paul___ | [Side note: I've held off commenting on your rename in plugins of db_query to db_query_bound - as it might be helpful doing what you've done, but long term, I'd like to get back to just db_query()) | 11:28 |
| * dregad agrees on ultimately renaming db_query_bound to db_query | 11:29 | |
| paul___ | when I first saw you doing that I was like "hmm, nooooo" | 11:30 |
| paul___ | but then i kinda figured it might actually make it *easier* | 11:30 |
| paul___ | as in theory, people fix queries now | 11:30 |
| paul___ | then rename function | 11:30 |
| paul___ | as they already using query params | 11:30 |
| paul___ | anyway, tbh, Iv'e had it with submodules | 11:30 |
| paul___ | fucking things just break git repostory | 11:30 |
| dregad | just takes some getting used to that's all | 11:32 |
| paul___ | tbh, I've found more things that break with them | 11:34 |
| paul___ | then problems they've "solved" | 11:35 |
| paul___ | read my post, but i see 3 options moving forwards: a) drop libraries completely, and use composer to pull them in b) store source in single repository c) keep them and setup a repostiory that contains the source of all submodules in a single repostiory and keep the two in sync | 11:36 |
| paul___ | Given we have like 4 libraries | 11:37 |
| paul___ | that change once in a blue moon | 11:37 |
| paul___ | it's actually more time consuming having to work out if any of the submodules have recently changed as they are NOT in git history | 11:37 |
| dregad | regarding the {$xxx} - i did reply to you https://github.com/mantisbt/mantisbt/pull/125#issuecomment-33397949 | 11:37 |
| dregad | and since you never responded i left it like that | 11:38 |
| paul___ | then the benefits you get of being able to link to the library | 11:38 |
| dregad | but i'm still fine with changing it if you want (or you can do it) | 11:38 |
| paul___ | TBH, I thought i'd replied - although I did note on one thing | 11:39 |
| paul___ | if you comment on a code file or something in a pull request it didn't seem to get pulled into the original request | 11:39 |
| dregad | yes it does | 11:40 |
| paul___ | i think maybe it didn't do it straight away or something | 11:40 |
| paul___ | anyway, tbh, I thought i replied | 11:41 |
| paul___ | but I might have looked | 11:41 |
| paul___ | seen it was mainly db code where we've used {$xxx} (as i think it's a new syntax you might started us using ;p) | 11:41 |
| paul___ | and then gone, in theory, if we update db code to do the "select * from {bug}" format, we could drop then | 11:42 |
| dregad | ok | 11:47 |
| dregad | anyway if you're not happy with the {$xxx} syntax feel free to change it | 11:48 |
| dregad | and regarding the broken mssql - not sure how to deal with that as i can't test | 11:48 |
| dregad | the sql I used is standard, so you'll have to tell me what MSSQL does not like about it | 11:49 |
| dregad | and even better propose an alternative | 11:50 |
| paul___ | As PostreSQL tries to add 0 to a string, it throws an error as it tries to operate on different data types. | 12:07 |
| paul___ | not sure I get that? | 12:07 |
| paul___ | hang on | 12:09 |
| paul___ | we've 'bumped' mysql requirements to use DECIMAL in the cast for dates | 12:09 |
| paul___ | but we use integer for dates in rest of mantis | 12:09 |
| paul___ | so surely we can cast to integer? ;/ | 12:10 |
| paul___ | and not bump mysql version | 12:10 |
| paul___ | ok, so original code works in mssql | 12:15 |
| paul___ | and mysql | 12:15 |
| paul___ | new code requires a version bump and works in pgsql+mysql, but not mssql | 12:15 |
| *** YamakasY <YamakasY!~yamakasy@62.58.32.94> has quit IRC | 12:17 | |
| paul___ | I'm kinda tempted to say revert that patch [so we avoid the forcing mysql version bump] | 12:18 |
| paul___ | and then work on working out what's actually sensible to do :) | 12:18 |
| paul___ | in fact, ignore that, as the version we've 'bumped to' is End Of LIfe | 12:20 |
| paul___ | so if anything we probably want to bump it to something higher ;p | 12:20 |
| dregad | yes, i went minimalistic | 12:49 |
| paul___ | anyway | 13:27 |
| paul___ | I need to get notifications done | 13:27 |
| paul___ | db layer done | 13:27 |
| paul___ | and stuff I wrote before merged | 13:27 |
| paul___ | so I stop getting pissed off whenever anyone does anything :) | 13:27 |
| *** giallu <giallu!~giallu@host159-185-dynamic.17-87-r.retail.telecomitalia.it> has joined #mantisbt | 15:57 | |
| *** giallu <giallu!~giallu@host159-185-dynamic.17-87-r.retail.telecomitalia.it> has quit IRC | 15:57 | |
| *** giallu <giallu!~giallu@fedora/giallu> has joined #mantisbt | 15:57 | |
| *** dejalexander <dejalexander!~dejalexan@94-194-42-47.zone8.bethere.co.uk> has joined #mantisbt | 16:19 | |
| *** BD-- <BD--!~BD-@78-20-185-231.access.telenet.be> has joined #mantisbt | 16:20 | |
| *** BD-- <BD--!~BD-@78-20-185-231.access.telenet.be> has quit IRC | 16:35 | |
| *** paul___ <paul___!ab21c458@gateway/web/freenode/ip.171.33.196.88> has quit IRC | 17:21 | |
| *** YamakasY <YamakasY!~yamakasy@g9179.upc-g.chello.nl> has joined #mantisbt | 18:01 | |
| *** giallu <giallu!~giallu@fedora/giallu> has quit IRC | 18:49 | |
| *** dejalexander <dejalexander!~dejalexan@94-194-42-47.zone8.bethere.co.uk> has quit IRC | 18:51 | |
| *** YamakasY <YamakasY!~yamakasy@g9179.upc-g.chello.nl> has quit IRC | 18:56 | |
| *** intripoon <intripoon!~quassel@manz-4db23ca1.pool.mediaWays.net> has joined #mantisbt | 21:25 | |
| *** intripoon_ <intripoon_!~quassel@manz-5f74b55b.pool.mediaWays.net> has quit IRC | 21:29 | |
| *** micahg <micahg!~micahg@ubuntu/member/micahg> has joined #mantisbt | 23:05 | |
| *** kirillka <kirillka!~Miranda@195.242.142.17> has joined #mantisbt | 23:57 | |
Generated by irclog2html.py 2.13.0 by Marius Gedminas - find it at mg.pov.lt!