0006244: Filter table has a little displacement in column - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update
0006244	mantisbt	filters	public	2005-09-13 13:16	2007-12-21 23:16

Reporter	docmarco	Assigned To	zakman
Priority	normal	Severity	tweak	Reproducibility	always
Status	closed	Resolution	fixed
Product Version	1.0.0rc2
Target Version	1.1.0	Fixed in Version	1.1.0a3

Summary	0006244: Filter table has a little displacement in column
Description	The table of the filters has a little displacement in the column next to "Use Date Filters", see the attached picture. Would be smarter if the column is just one line, like the other columns. Tested in IE6.
Tags	No tags attached.
Attached Files	edge.jpg (23,363 bytes) edge.jpg (23,363 bytes) filter_api.php.diff (2,359 bytes) --- D:/xampp/xampp/htdocs/mantis/core/filter_api.php Thu Dec 21 18:41:00 2006 +++ D:/xampp/xampp/htdocs/mantis_dev/core/filter_api.php Thu Mar 08 18:51:23 2007 @@ -1743,10 +1743,10 @@ <td class="small-caption" valign="top"> <a href="<?php PRINT $t_filters_url . 'sticky_issues'; ?>" id="sticky_issues_filter"><?php PRINT lang_get( 'sticky' ) ?>:</a> </td> - <td class="small-caption" valign="top"> + <td class="small-caption" valign="top" colspan="2"> <a href="<?php PRINT $t_filters_url . 'highlight_changed'; ?>" id="highlight_changed_filter"><?php PRINT lang_get( 'changed' ) ?>:</a> </td> - <td class="small-caption" valign="top" colspan="2"> + <td class="small-caption" valign="top"> <a href="<?php PRINT $t_filters_url . 'do_filter_by_date'; ?>" id="do_filter_by_date_filter"><?php PRINT lang_get( 'use_date_filters' ) ?>:</a> </td> <td class="small-caption" valign="top" colspan="2"> @@ -1781,11 +1781,11 @@ ?> <input type="hidden" name="sticky_issues" value="<?php echo $t_sticky_filter_state ? 'on' : 'off';?>" /> </td> - <td class="small-caption" valign="top" id="highlight_changed_filter_target"> + <td class="small-caption" valign="top" colspan="2" id="highlight_changed_filter_target"> <?php PRINT $t_filter['highlight_changed']; ?> <input type="hidden" name="highlight_changed" value="<?php echo $t_filter['highlight_changed'];?>" /> </td> - <td class="small-caption" valign="top" colspan="2" id="do_filter_by_date_filter_target"> + <td class="small-caption" valign="top" id="do_filter_by_date_filter_target"> <?php if ( ( ON == config_get( 'dhtml_filters' ) ) && ( ON == config_get( 'use_javascript' ) ) ){ ?> @@ -2096,10 +2096,10 @@ <?php if ( 'advanced' == $t_view_type ) { ?> - <td class="small-caption" valign="top"> + <td class="small-caption" valign="top" colspan="2"> <a href="<?php PRINT $t_filters_url . 'project_id'; ?>" id="project_id_filter"><?php PRINT lang_get( 'email_project' ) ?>:</a> </td> - <td class="small-caption" valign="top" colspan="2" id="project_id_filter_target"> + <td class="small-caption" valign="top" id="project_id_filter_target"> <?php $t_output = ''; if ( !is_array( $t_filter['project_id'] ) ) { filter_api.php.diff (2,359 bytes)

docmarco 2005-11-30 08:40 reporter ~0011671	This problem seems to be caused by the colspan="2" of the "category" column. Is it necessary to use a colspan of 2 for this column? The category column is never splitted by any other cells. Before I start investigating this any futher, does it have a certain reason?

stappel 2005-12-07 10:05 reporter ~0011725	both the `category` and the `product version` hand a colspan of 2. But on the last 2 lines it is applied to the `use date filters` column and not the `changed(hrs)` column. small change in filter_api.php: (< eq new) 1623c1623 < <td class="small-caption" valign="top" colspan="2"> `<td class="small-caption" valign="top">` 1626c1626 < <td class="small-caption" valign="top"> `<td class="small-caption" valign="top" colspan="2">` 1661c1661 < <td class="small-caption" valign="top" id="highlight_changed_filter_target" colspan="2"> `<td class="small-caption" valign="top" id="highlight_changed_filter_target">` 1665c1665 < <td class="small-caption" valign="top" id="do_filter_by_date_filter_target"> `<td class="small-caption" valign="top" id="do_filter_by_date_filter_target" colspan="2">`

exk72 2007-03-08 02:00 reporter ~0014137	patch against 1.1.0a2 and adds same fix to the advanced filters page