0006679: Attachment download always opens "Save As" dialog even when a .png

ID	Project	Category	View Status	Date Submitted	Last Update
0006679	mantisbt	other	public	2006-02-06 17:45	2006-09-12 00:52

Reporter	rkorte	Assigned To	thraxisp
Priority	normal	Severity	minor	Reproducibility	always
Status	closed	Resolution	fixed
Product Version	1.0.0
Fixed in Version	1.1.0a1

Summary	0006679: Attachment download always opens "Save As" dialog even when a .png
Description	Clicking on any attachment always forces the browser to open a "Save As" or "Open With" dialog even if the attachment is an image which can be displayed in the browser. This behavior changed from 0.19.2 to 1.0.0. Tested with FireFox 1.0.6 and latest Internet Explorer. It'd be better to let the browser decide how to handle it. I fixed this in the 1.0.0 code by removing the "attachment;" keyword from the http header "Content-Disposition" at line 79 of file_download.php. (This keyword was added for some reason between 0.19.2 and 1.0.0.) This bug may be related to 0006511.
Tags	No tags attached.

mlovell 2006-02-07 12:39 reporter ~0012108	On 1.0.0rc5, I modified our local file_download.php to change the disposition of file attachments: 79c79 < header( 'Content-Disposition: inline; filename="' . file_get_display_name( $v_filename ) . '"' ); `header( 'Content-Disposition: attachment; filename="' . file_get_display_name( $v_filename ) . '"' );` Is there any reason such a change is not safe?

ericb 2006-03-25 20:28 reporter ~0012412	mlovell, I'm also wondering if this modification is not safe. I made the same change on the chance that is it safe.

thraxisp 2006-03-27 21:06 reporter ~0012423	Fixed in CVS. config_defaults_inc.php -> 1.291 file_download.php -> 1.38

79c79
< header( 'Content-Disposition: inline; filename="' . file_get_display_name( $v_filename ) . '"' );