Relationship Graph

View IssueDependency GraphShow Summary
Relationship Graph
related to related to child of child of duplicate of duplicate of

View Issue Details

WikiRelated ChangesetsJump to Notes
IDProjectCategoryView StatusDate SubmittedLast Update
0007448mantisbtlocalizationpublic2006-09-17 06:132006-12-08 02:39
Reporterachumakov Assigned Toachumakov  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.0.5 
Fixed in Version1.1.0a2 
Summary0007448: [all lang] Unlocalizable text
Description

'Sponsor' button name in bug_sponsorship_list_view_inc.php is hard-coded and unlocalizable.

TagsNo tags attached.
Attached Files
sponsor_translation.patch (2,696 bytes)    
diff -u orig/account_sponsor_page.php ./account_sponsor_page.php
--- orig/account_sponsor_page.php	2005-07-23 19:09:52.000000000 +0000
+++ ./account_sponsor_page.php	2006-09-20 13:17:34.000000000 +0000
@@ -206,7 +206,7 @@
 		<td class="form-title" width="7%"><?php echo lang_get( 'fixed_in_version' ) ?></td>
 		<td class="form-title" width="10%"><?php echo lang_get( 'email_status' ) ?></td>
 		<td class="form-title" width="35%"><?php echo lang_get( 'email_summary' ) ?></td>
-		<td class="form-title" width="10%"><?php echo lang_get( 'sponsor' ) ?></td>
+		<td class="form-title" width="10%"><?php echo lang_get( 'sponsor_noun' ) ?></td>
 		<td class="form-title" width="10%"><?php echo lang_get( 'amount' ) ?></td>
 		<td class="form-title" width="10%"><?php echo lang_get( 'status' ) ?></td>
 	</tr>
diff -u orig/bug_sponsorship_list_view_inc.php ./bug_sponsorship_list_view_inc.php
--- orig/bug_sponsorship_list_view_inc.php	2006-09-20 08:25:48.000000000 +0000
+++ ./bug_sponsorship_list_view_inc.php	2006-09-20 13:16:12.000000000 +0000
@@ -49,7 +49,7 @@
 <table class="width100" cellspacing="1">
 	<tr>
 		<td width="50" rowspan="3">
-			<img src="images/dollars.gif" alt="<?php echo lang_get( 'sponsor' ) ?>" border="0" />
+			<img src="images/dollars.gif" alt="<?php echo lang_get( 'sponsor_verb' ) ?>" border="0" />
 		</td>
 		<td class="form-title" colspan="2">
 			<?php collapse_icon( 'sponsorship' ); ?>
@@ -75,7 +75,7 @@
 				<?php echo sponsorship_get_currency() ?>
 				<input type="hidden" name="bug_id" value="<?php echo $f_bug_id ?>" size="4" />
 				<input type="text" name="amount" value="<?php echo config_get( 'minimum_sponsorship_amount' )  ?>" size="4" />
-				<input type="submit" class="button" name="sponsor" value="<?php echo lang_get( 'sponsor' ) ?>" />
+				<input type="submit" class="button" name="sponsor" value="<?php echo lang_get( 'sponsor_verb' ) ?>" />
 			</form>
 		</td>
 	</tr>
Only in .: orig
Only in .: sponsor_translation.patch
diff -u orig/strings_english.txt ./strings_english.txt
--- orig/strings_english.txt	2006-08-12 12:04:14.000000000 +0000
+++ ./strings_english.txt	2006-09-20 13:19:08.000000000 +0000
@@ -447,7 +447,9 @@
 $s_own_sponsored = 'Issues You have Sponsored:';
 $s_issues_handled = 'Sponsored Issues You Have Been Assigned To:';
 $s_no_own_sponsored = 'You have not sponsored any issues.';
-$s_sponsor = 'Sponsor';
+$s_sponsor = 'Sponsor'; #for compatibility with older releases
+$s_sponsor_verb = 'Sponsor'; # like in 'Sponsor it!'
+$s_sponsor_noun = 'Sponsor'; # like in 'The sponsor of...'
 $s_amount = 'Amount';
 $s_total_owing = 'Total Owing';
 $s_total_paid = 'Total Paid';
sponsor_translation.patch (2,696 bytes)   

Relationships

Relationship GraphDependency Graph
has duplicate 0005538 closedachumakov Missing localization in bug_sponsorship_list_view_inc.php 

Activities

achumakov

achumakov

2006-09-20 05:23

reporter   ~0013418

Couldn't use $s_sponsor in buttons as
'sponsor' noun and 'to sponsor' verb are translated different way in Russian, most Slavic and some Western European languages/

Suggestion - apply coding guidelines like these:
use _noun and _verb postfixes in langfiles; retain original strings without postfix for compatibility with old releases

Same problem seems to exist in dozen other places - I could check it out if needed)

See patch
vboctor

vboctor

2006-09-21 22:35

manager   ~0013429

Since the existing one as a noun and is already localized, you may want to keep this as it is ($s_sponsor) and add a comment next to it that it is a noun and an example. You can then add $s_sponsor_verb. If you want to do both, then you will need to rename $s_sponsor to $s_sponsor_noun in all localization files.

Related Changesets

MantisBT: master 7ec8452c

2006-09-24 10:11

achumakov


Details Diff		 Sponsor message split fixing bug 0007448

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@4177 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9		 Affected Issues
0007448
mod - lang/strings_chinese_traditional_utf8.txt Diff File
mod - lang/strings_serbian.txt Diff File
mod - lang/strings_swedish.txt Diff File
mod - lang/strings_croatian.txt Diff File
mod - lang/strings_danish.txt Diff File
mod - lang/strings_french_canadian.txt Diff File
mod - lang/strings_portuguese_brazil.txt Diff File
mod - lang/strings_norwegian.txt Diff File
mod - lang/strings_polish.txt Diff File
mod - lang/strings_latvian.txt Diff File
mod - lang/strings_japanese_euc.txt Diff File
mod - lang/strings_french.txt Diff File
mod - lang/strings_english.txt Diff File
mod - lang/strings_bulgarian.txt Diff File
mod - lang/strings_ukrainian.txt Diff File
mod - lang/strings_czech.txt Diff File
mod - lang/strings_portuguese_standard.txt Diff File
mod - lang/strings_italian_utf8.txt Diff File
mod - lang/strings_chinese_simplified.txt Diff File
mod - lang/strings_lithuanian.txt Diff File
mod - lang/strings_russian.txt Diff File
mod - lang/strings_turkish.txt Diff File
mod - bug_sponsorship_list_view_inc.php Diff File
mod - lang/strings_japanese_sjis.txt Diff File
mod - lang/strings_hungarian.txt Diff File
mod - lang/strings_spanish.txt Diff File
mod - lang/strings_chinese_traditional.txt Diff File
mod - lang/strings_russian_utf8.txt Diff File
mod - lang/strings_catalan.txt Diff File
mod - lang/strings_slovak.txt Diff File
mod - lang/strings_italian.txt Diff File
mod - lang/strings_romanian.txt Diff File
mod - lang/strings_japanese_utf8.txt Diff File
mod - lang/strings_polish_utf8.txt Diff File
mod - lang/strings_korean_utf8.txt Diff File
mod - lang/strings_icelandic.txt Diff File
mod - lang/strings_german.txt Diff File
mod - lang/strings_chinese_simplified_utf8.txt Diff File
mod - lang/strings_slovene.txt Diff File
mod - lang/strings_estonian.txt Diff File
mod - lang/strings_dutch.txt Diff File
mod - lang/strings_korean.txt Diff File
mod - lang/strings_finnish.txt Diff File
mod - lang/strings_russian_koi8.txt Diff File