MantisBT: master-1.2.x c59ad8a6

Diff Back to Repository
Author Committer Branch Timestamp Parent
dhx dhx master-1.2.x 2009-11-23 07:21 master-1.2.x 2730f010
Affected Issues  0011272: Account Registration Message
Changeset

Cleanup use of ampersands in internally generated URLs

This should fix a number of bugs related to invalid links (created by
confusion about whether to use & or & in internal URLs). We should
only apply htmlspecialchars() or similar at output time, assuming we
want HTML output from Mantis. Internally, it is best to just use & to
separate arguments in GET HTTP URLs. There are still a few ugly bits of
code that haven't been updated because to do so would require extensive
rewriting in some sections. And in time, the print and html API is
probably going to be deprecated by use of a templating engine so there
is little point rewriting something that'll only get overhauled later.

This commit is the backport to the 1.2.x branch because it fixes a few
bugs here and there.

Conflicts:
main_page.php
mod - login_select_proj_page.php Diff File
mod - api/soap/mc_issue_api.php Diff File
mod - core/string_api.php Diff File
mod - project_page.php Diff File
mod - news_update.php Diff File
mod - main_page.php Diff File
mod - account_prefs_reset.php Diff File
mod - login.php Diff File
mod - core/user_api.php Diff File
mod - api/soap/mc_project_api.php Diff File
mod - core/print_api.php Diff File
mod - query_view_page.php Diff File
mod - manage_proj_delete.php Diff File
mod - core/relationship_api.php Diff File
mod - login_page.php Diff File
mod - login_anon.php Diff File
mod - core/html_api.php Diff File
mod - manage_user_delete.php Diff File
mod - manage_user_page.php Diff File
mod - core/file_api.php Diff File
mod - bug_view_inc.php Diff File
mod - roadmap_page.php Diff File
mod - manage_proj_page.php Diff File
mod - bug_actiongroup_ext.php Diff File
mod - manage_user_prune.php Diff File
mod - adm_config_report.php Diff File
mod - core/form_api.php Diff File
mod - print_all_bug_page_word.php Diff File
mod - print_all_bug_page.php Diff File
mod - bug_relationship_graph.php Diff File
mod - core/relationship_graph_api.php Diff File
mod - core/rss_api.php Diff File
mod - my_view_inc.php Diff File
mod - tag_update_page.php Diff File
mod - core/ajax_api.php Diff File
mod - view_filters_page.php Diff File
mod - verify.php Diff File
mod - bugnote_view_inc.php Diff File
mod - manage_proj_edit_page.php Diff File
mod - changelog_page.php Diff File
mod - print_bug_page.php Diff File
mod - core/columns_api.php Diff File
mod - core/tag_api.php Diff File
mod - core/filter_api.php Diff File
mod - set_project.php Diff File
mod - excel_xml_export.php Diff File