MantisBT: master 1cc269b5

Diff Back to Repository
Author Committer Branch Timestamp Parent
dregad dregad master 2020-04-20 12:57 master a0b18ec6
Changeset

Refactor following PR review

Based on @cproensa's suggestion, see
https://github.com/mantisbt/mantisbt/pull/1565#discussion_r329311690

Invalid Plugin classes changes:

  • Define a new InvalidDefinitionPlugin class for the case of missing
    required properties (name and version)
  • InvalidPlugin becomes a generic, base class for invalid plugins
  • Initialize with InvalidPlugin::setInvalidPlugin() method

MantisPlugin base class changes:

  • New properties $status (with related STATUS_xxx constants) and
    $status_message to MantisPlugin class
  • Method isValid() returns a loaded plugin's actual validity status
  • Method getInvalidPlugin() creates an InvalidPlugin object from the
    current plugin and initializes it with setInvalidPlugin().

Plugin API, management and admin checks page have been modified to
leverage the new class, properties and methods.
mod - admin/check/check_plugins_inc.php Diff File
add - core/classes/InvalidDefinitionPlugin.class.php Diff File
mod - core/classes/InvalidPlugin.class.php Diff File
mod - core/classes/MantisPlugin.class.php Diff File
mod - core/classes/MissingClassPlugin.class.php Diff File
mod - core/classes/MissingPlugin.class.php Diff File
mod - core/plugin_api.php Diff File
mod - manage_plugin_page.php Diff File
mod - manage_plugin_uninstall.php Diff File
mod - manage_plugin_upgrade.php Diff File