Changesets: MantisBT

master e32d09dd

2016-10-16 14:23

Carlos Proensa


Details Diff
Restore default.css

A blank line was modified by error
mod - css/default.css Diff File

master 38567574

2016-10-16 14:21

Carlos Proensa


Details Diff
Clean up & fixes for this branch

Fix issues, reported by @atrol in PR
mod - core/filter_form_api.php Diff File

master dc513292

2016-10-16 13:22

Carlos Proensa


Details Diff
Resolve conflicts between show and hide status

Remove some code from view_all_set.php that tried to normalize the
interaction between the show_status and hide_status properties.
These checks are now moved to filter_api, filter_ensure_valid_filter(),
and rewritten to do a better job when both options raise a conflict.

There are two cases:

1) When changing from simple to advanced filter, hide_status property no
longer applies. If it had a value set, normalize the new show_status
array to reflect the combination of both values

2) In simple filter, both properties may end in conflicting status
definition. Resolve the conflict by removin status that must be hidden
according to hide_status property. If the final result is that no status
is left, give preference to the original show_status setting and remove
hide_status.
mod - core/filter_api.php Diff File
mod - view_all_set.php Diff File

master 7e3790f8

2016-10-16 12:30

Carlos Proensa


Details Diff
Rewrite logic for filter query, show/hide status

Rewrite the logic to create the filter query for bug status, accounting
for both properties: show and hide status, in order to:

1) Simplify the logic to get the actual status to be shown

2) Allow to show multiple status ids as an array in a simple filter.
This array can exist when the filter is changed from advanced to simple.

Fixes: 0020624
mod - core/filter_api.php Diff File

master e5383a59

2016-10-16 10:16

Carlos Proensa


Details Diff
Fix use of view type property

Use the validated property, not the value received by gpc_get
mod - manage_filter_edit_page.php Diff File

master b388f8b4

2016-10-16 10:14

Carlos Proensa


Details Diff
Clean up unused variable
mod - core/filter_form_api.php Diff File

master c02a525b

2016-10-16 10:08

Carlos Proensa


Details Diff
Fix filter_gpc_get view type

Fix undeclared variable
mod - core/filter_api.php Diff File

master bf7fd0d2

2016-10-16 10:00

Carlos Proensa


Details Diff
Fix setting of default filter view_type
mod - core/filter_api.php Diff File

master-1.3.x f0337c15

2016-10-16 06:24

atrol


Details Diff
Correct documentation of option display_project_padding
mod - config_defaults_inc.php Diff File

master-1.3.x 6c95495c

2016-10-16 05:47

cproensa

Committer: vboctor


Details Diff
Prevent db errors for invalid bug/bugnote ids

Some db engines may throw an error if provided with an integer out of
the supported range for field type. As an example: pgsql.
This can happen when the user provides a number high enough as input in
several places. For example:
- Bug and bugnote linking, in texts that are processed by core formatting
plugin
- Bug jump quick access
- Bug id provided for a relation

The core formatting case is especially bad, because the bug page cannot
be rendered, always ending in a db error.

The fix is applied in bug_exists(), and bugnote_exists() functions,
which should fix most of said situations all through the applcation.

Fixes: 0021802
Affected Issues
0021802
mod - core/bug_api.php Diff File
mod - core/bugnote_api.php Diff File
mod - core/constant_inc.php Diff File
mod - core/string_api.php Diff File

master-1.3.x 332f3ddf

2016-10-15 08:57

cproensa

Committer: vboctor


Details Diff
Don't show reset option for disabled or protected users

Don't show the password reset option for disabled or protected users:
- Disabled users can't have email sent.
- Protected users must not have its password changed (and will show an
error anyway)

Fixes: 0021793
Affected Issues
0021793
mod - manage_user_edit_page.php Diff File

master-1.3.x bd510c66

2016-10-15 08:48

cproensa

Committer: vboctor


Details Diff
Don't send reset email for disabled users

Don't send email for password reset if the user is disabled.
Adds log messages to several failure conditions.
mod - core/email_api.php Diff File

master 8aae5b45

2016-10-14 19:26

Joel C. Llano

Committer: vboctor


Details Diff
Update Parsedown library to 1.6.0
mod - library/parsedown/Parsedown.php Diff File

master fc992f4e

2016-10-13 17:12

vboctor


Details Diff
Remove ‘bug_print_page_fields’ config option

Remove the unused configuration option and mark it obsolete.

Issue 0021727
Affected Issues
0021727
mod - config_defaults_inc.php Diff File
mod - core/obsolete.php Diff File
mod - docbook/Admin_Guide/en-US/config/fields.xml Diff File

master-1.3.x 4ee0da6e

2016-10-12 02:31

dregad


Details Diff
Let Error API capture E_USER_DEPRECATED by default

Following introduction of DEPRECATED error type in issue 0017837, it was
omitted to add E_USER_DEPRECATED to the list of error types captured by
default.

This prevented handling when error_reporting=0.

Follow-up on issue 0010966, cec454931df5a99d03ff22aabf8901648ff3d549
Fixes 0021795
Affected Issues
0010966, 0017837, 0021795
mod - core/error_api.php Diff File

master-1.3.x d7c92d77

2016-10-12 01:01

dregad


Details Diff
Documentation: minor fix in dev guide plugin section
mod - docbook/Developers_Guide/en-US/Plugins_Building.xml Diff File

master c1d04f92

2016-10-11 20:18

syncguru

Committer: vboctor


Details Diff
Hide 'View Issues' buttons in small screens

Fixes 0021794
Affected Issues
0021794
mod - my_view_inc.php Diff File

master a77e6760

2016-10-11 19:11

syncguru

Committer: vboctor


Details Diff
Fix sidebar menu toggle button for small screens

Fixes 0021754
Affected Issues
0021754
mod - core/layout_api.php Diff File

master 51c1b057

2016-10-09 10:24

Carlos Proensa


Details Diff
Remove use of global filter

filter_init() is not needed now that filter api functions dont rely on
global filter. These pages, also, should not alter current active filter
since may be using to query or edit a different filter than current one.
mod - manage_filter_edit_page.php Diff File
mod - return_dynamic_filters.php Diff File

master c885ef9f

2016-10-09 09:56

Carlos Proensa


Details Diff
Ensure filter is valid

The filter must be validated before use. Even if the filter was valid
when saved, new filter fields may have been created in the application
by the addition of plugin or custom fields.

With the addition of filter_ensure_valid_filter, the checking of
_view_type is not needed here, since it's already done in that function.
mod - manage_filter_edit_page.php Diff File
mod - return_dynamic_filters.php Diff File
mod - view_filters_page.php Diff File

master b287fcd7

2016-10-09 09:40

Carlos Proensa


Details Diff
Update new pages copyright comments
mod - core/filter_form_api.php Diff File
mod - manage_filter_delete.php Diff File
mod - manage_filter_edit_page.php Diff File
mod - manage_filter_edit_update.php Diff File
mod - manage_filter_page.php Diff File

master 04f96c2b

2016-10-09 07:29

Carlos Proensa


Details Diff
Rearrange some fields in filter box

Change the position of some fileds in the filter box:
- For main fields, keep first the most common fields.
- For main fields, move to the end fields that depends on project configuration to
be hidden or shown. This way fixed fields wont change their position
across different projects.
- Filter related fields (per-page, sort, etc), are shown with a
separator to other field groups. This also helps with the styling since their
orientation is horizontal.
- "per-page" has been moved to the filter-related fields group
- "note-by" has been moved to the main fields group.
mod - core/filter_form_api.php Diff File

master ccb0dda7

2016-10-09 07:10

Carlos Proensa


Details Diff
Move FilterBoxGridLayout fo filter_form_api.php

This class is specific of the filter form generation.
mod - core/filter_form_api.php Diff File
mod - core/html_api.php Diff File

master 46fddbcb

2016-10-09 06:56

Carlos Proensa


Details Diff
Rewrite filter box generation

Use TableGridLayout classes to generate a table of elements that are
dynamically accomodated over the available table space.
This avoids having empty cells in filter box if some fields are not
visible.
mod - core/filter_api.php Diff File
mod - core/filter_form_api.php Diff File
mod - manage_filter_edit_page.php Diff File
mod - view_filters_page.php Diff File

master 9170e568

2016-10-09 06:56

Carlos Proensa


Details Diff
Add filter parameter fo print_filter_ functions

Allow the use of print_filter_... functions to be used use with a
provided filter array, not only the global filter.
Fix phpdoc.
mod - core/filter_form_api.php Diff File
mod - return_dynamic_filters.php Diff File
 First  Prev  1 2 3 ... 70 ... 140 ... 196 197 198 199 200 201 202 ... 210 ... 280 ... 350 ... 420 ... 490 ... 560 ... 630 ... 700 ... 729 730 731  Next  Last