Source Control Integration

master e172eb2b 2016-10-17 15:47 Carlos Proensa Details Diff	Fix form field for column sort Use api functions and clean up code. Make the display of current column sorting work properly for according to the filter properties, and availabe visible sort fields.
	mod - core/filter_form_api.php	Diff File
master 5fdc37ad 2016-10-17 14:51 Carlos Proensa Details Diff	Clean up filter query ordering for sort colums Clean up the query generation for ordering clauses: - Some checks are removed as they are performed in ensure_valid_filter - New function to get the proper visible columns, which previously was done by ensure_valid_filter. - Clean some code by using the standard functions from column_api
	mod - core/filter_api.php	Diff File
master 5fd83d4b 2016-10-17 14:08 Carlos Proensa Details Diff	Rewrite filter_gpc_get sort columns Clean up the login for reading gpc_get for sorting columns. Defined a new behaviour: - Sorting columns that come from column headers: the selected column is pushed to the front of the sort list. This way we can have multiple columns sorted incrementally. At this moment, the limit for 2 columns remains in the filter form UI. - Sorting columns that come from the filter form. They replace all the columns in the sort list. The number of columns that can be set is still limited at 2 by the filter UI. Fixes: 0006732
	mod - core/filter_api.php	Diff File
master 2bf3b535 2016-10-17 09:43 Carlos Proensa Details Diff	Fix view_all_set for update and sort filter_gpc_get must be called with current filter, to add only incremental options. Otherwise, the fileds not present in the request would be defaulted.
	mod - view_all_set.php	Diff File
master fde62c31 2016-10-17 09:16 Carlos Proensa Details Diff	Rewrite filter validation for sort fields Rewrite the logic included in filter_ensure_valid_filter() for sorting fields, and supporting columns_api Filter validation now does: - Checks against all valid columns, not only accesible by current user/project. This allows validating a filter without dependencies on the runtime user or project selection. - Do not limit to 2 sort fields. This is a UI limitation, but it is still valid if the filter contains more correct fields. - Removes columns that can't be sorted. Fixes: 0021592 Additionally, some clean up and code has been added to columns_api, to support the filter_api changes
	mod - core/columns_api.php	Diff File
	mod - core/filter_api.php	Diff File
master-1.3.x bb6cbace 2016-10-17 07:16 dregad Details Diff	Whitespace
	mod - plugins/Gravatar/Gravatar.php	Diff File
master-1.3.x fa2e7171 2016-10-17 07:15 dregad Details Diff	Gravatar plugin: escape ampersands in URLs Fixes 0021804	Affected Issues 0021804
	mod - plugins/Gravatar/Gravatar.php	Diff File
master-1.3.x 51953723 2016-10-17 01:07 cproensa Committer: vboctor Details Diff	Use LOG_EMAIL instead of LOG_EMAIL_RECIPIENT
	mod - core/email_api.php	Diff File
master 0d00ae93 2016-10-16 16:06 syncguru Committer: vboctor Details Diff	Relocate inline JS code in graph plugin to separate file Fixes 0021669	Affected Issues 0021669
	add - plugins/MantisGraph/MantisGraph.js	Diff File
	mod - plugins/MantisGraph/MantisGraph.php	Diff File
	mod - plugins/MantisGraph/core/graph_api.php	Diff File
master 73867dce 2016-10-16 15:20 Carlos Proensa Details Diff	Fix setting of hide_status for timeline filter
	mod - core/timeline_api.php	Diff File
master e32d09dd 2016-10-16 14:23 Carlos Proensa Details Diff	Restore default.css A blank line was modified by error
	mod - css/default.css	Diff File
master 38567574 2016-10-16 14:21 Carlos Proensa Details Diff	Clean up & fixes for this branch Fix issues, reported by @atrol in PR
	mod - core/filter_form_api.php	Diff File
master dc513292 2016-10-16 13:22 Carlos Proensa Details Diff	Resolve conflicts between show and hide status Remove some code from view_all_set.php that tried to normalize the interaction between the show_status and hide_status properties. These checks are now moved to filter_api, filter_ensure_valid_filter(), and rewritten to do a better job when both options raise a conflict. There are two cases: 1) When changing from simple to advanced filter, hide_status property no longer applies. If it had a value set, normalize the new show_status array to reflect the combination of both values 2) In simple filter, both properties may end in conflicting status definition. Resolve the conflict by removin status that must be hidden according to hide_status property. If the final result is that no status is left, give preference to the original show_status setting and remove hide_status.
	mod - core/filter_api.php	Diff File
	mod - view_all_set.php	Diff File
master 7e3790f8 2016-10-16 12:30 Carlos Proensa Details Diff	Rewrite logic for filter query, show/hide status Rewrite the logic to create the filter query for bug status, accounting for both properties: show and hide status, in order to: 1) Simplify the logic to get the actual status to be shown 2) Allow to show multiple status ids as an array in a simple filter. This array can exist when the filter is changed from advanced to simple. Fixes: 0020624
	mod - core/filter_api.php	Diff File
master e5383a59 2016-10-16 10:16 Carlos Proensa Details Diff	Fix use of view type property Use the validated property, not the value received by gpc_get
	mod - manage_filter_edit_page.php	Diff File
master b388f8b4 2016-10-16 10:14 Carlos Proensa Details Diff	Clean up unused variable
	mod - core/filter_form_api.php	Diff File
master c02a525b 2016-10-16 10:08 Carlos Proensa Details Diff	Fix filter_gpc_get view type Fix undeclared variable
	mod - core/filter_api.php	Diff File
master bf7fd0d2 2016-10-16 10:00 Carlos Proensa Details Diff	Fix setting of default filter view_type
	mod - core/filter_api.php	Diff File
master-1.3.x f0337c15 2016-10-16 06:24 atrol Details Diff	Correct documentation of option display_project_padding
	mod - config_defaults_inc.php	Diff File
master-1.3.x 6c95495c 2016-10-16 05:47 cproensa Committer: vboctor Details Diff	Prevent db errors for invalid bug/bugnote ids Some db engines may throw an error if provided with an integer out of the supported range for field type. As an example: pgsql. This can happen when the user provides a number high enough as input in several places. For example: - Bug and bugnote linking, in texts that are processed by core formatting plugin - Bug jump quick access - Bug id provided for a relation The core formatting case is especially bad, because the bug page cannot be rendered, always ending in a db error. The fix is applied in bug_exists(), and bugnote_exists() functions, which should fix most of said situations all through the applcation. Fixes: 0021802	Affected Issues 0021802
	mod - core/bug_api.php	Diff File
	mod - core/bugnote_api.php	Diff File
	mod - core/constant_inc.php	Diff File
	mod - core/string_api.php	Diff File
master-1.3.x 332f3ddf 2016-10-15 08:57 cproensa Committer: vboctor Details Diff	Don't show reset option for disabled or protected users Don't show the password reset option for disabled or protected users: - Disabled users can't have email sent. - Protected users must not have its password changed (and will show an error anyway) Fixes: 0021793	Affected Issues 0021793
	mod - manage_user_edit_page.php	Diff File
master-1.3.x bd510c66 2016-10-15 08:48 cproensa Committer: vboctor Details Diff	Don't send reset email for disabled users Don't send email for password reset if the user is disabled. Adds log messages to several failure conditions.
	mod - core/email_api.php	Diff File
master 8aae5b45 2016-10-14 19:26 Joel C. Llano Committer: vboctor Details Diff	Update Parsedown library to 1.6.0
	mod - library/parsedown/Parsedown.php	Diff File
master fc992f4e 2016-10-13 17:12 vboctor Details Diff	Remove ‘bug_print_page_fields’ config option Remove the unused configuration option and mark it obsolete. Issue 0021727	Affected Issues 0021727
	mod - config_defaults_inc.php	Diff File
	mod - core/obsolete.php	Diff File
	mod - docbook/Admin_Guide/en-US/config/fields.xml	Diff File
master-1.3.x 4ee0da6e 2016-10-12 02:31 dregad Details Diff	Let Error API capture E_USER_DEPRECATED by default Following introduction of DEPRECATED error type in issue 0017837, it was omitted to add E_USER_DEPRECATED to the list of error types captured by default. This prevented handling when error_reporting=0. Follow-up on issue 0010966, cec454931df5a99d03ff22aabf8901648ff3d549 Fixes 0021795	Affected Issues 0010966, 0017837, 0021795
	mod - core/error_api.php	Diff File

Changesets: MantisBT