Changesets: MantisBT

master 85e1aa2a

2016-04-23 15:35

dregad


Details Diff
Tokenizer: fix syntax check under PHP7

In PHP >= 7, eval() throws a ParseError which we can catch and rethrow
as an Exception. Failure to do so causes Travis builds to fail [1]

[1] https://travis-ci.org/mantisbt/mantisbt/jobs/125235617#L877
mod - core/classes/Tokenizer.class.php Diff File
mod - tests/Mantis/ConfigParserTest.php Diff File

master 98d5a8d5

2016-04-23 14:43

vboctor


Details Diff
Handle placeholders in API for issues and notes
mod - api/soap/mc_issue_api.php Diff File
mod - core/bug_api.php Diff File
mod - core/bugnote_api.php Diff File
mod - core/mention_api.php Diff File
mod - tests/soap/AllTests.php Diff File
add - tests/soap/MentionTest.php Diff File

master 13a984c8

2016-04-23 09:04

vboctor


Details Diff
Send email notifications for user mentions

Instead of adding user to monitor list, send them email notifications
about being mentioned in an issue or issue note.
mod - core/bugnote_api.php Diff File
mod - core/email_api.php Diff File
mod - core/mention_api.php Diff File
mod - lang/strings_english.txt Diff File
mod - plugins/MantisCoreFormatting/MantisCoreFormatting.php Diff File

master e11cac7f

2016-04-23 04:09

dregad


Details Diff
Add PHPDoc blocks
mod - tests/Mantis/ConfigParserTest.php Diff File

master e071978a

2016-04-23 04:03

dregad


Details Diff
Fix Parser for OFF constant

We need to use a strict comparison, otherwise process_scalar() throws
an exception instead of returning the constant's value.
mod - core/classes/ConfigParser.class.php Diff File

master a55cb58c

2016-04-23 04:00

dregad


Details Diff
Add test cases to cover various error cases

- syntax error
- extra tokens (both ignore and error)
- invalid token
- undefined constant

More exceptions handling test cases
mod - tests/Mantis/ConfigParserTest.php Diff File

master db05b481

2016-04-23 03:48

dregad


Details Diff
Remove redundant assertion

It is not necessary to test against both the 1st parsing result and the
reference array, since we already know they are equal.
mod - tests/Mantis/ConfigParserTest.php Diff File

master b942dff6

2016-04-23 03:46

dregad


Details Diff
Export the parsed array, not the result of eval()

Bug in cproensa's original commit.
mod - tests/Mantis/ConfigParserTest.php Diff File

master ff2eb166

2016-04-23 03:43

dregad


Details Diff
Put all array test code in a single method
mod - tests/Mantis/ConfigParserTest.php Diff File

master 58d74b34

2016-04-23 03:39

dregad


Details Diff
Use method to generate 'original input' message
mod - tests/Mantis/ConfigParserTest.php Diff File

master 03513dd2

2016-04-23 03:37

dregad


Details Diff
No need for json and serialize test assertions

Since the parser gives us a native PHP variable, it is not necessary
to perform assertions with json_encode() and serialize().
mod - tests/Mantis/ConfigParserTest.php Diff File

master dc96f5a4

2016-04-23 03:27

dregad


Details Diff
Add and improve test cases

- scalar types
- multidimentional arrays
- use of constants
- whitespace other than space (tab, cr, lf)

Reorder and regroup tests cases, add comments.
mod - tests/Mantis/ConfigParserTest.php Diff File

master d95a0976

2016-04-23 03:04

dregad


Details Diff
Uncomment tests marked as failing in TODOs
mod - tests/Mantis/ConfigParserTest.php Diff File

master 21d6b020

2016-04-23 03:02

dregad


Details Diff
Update test case template comment
mod - tests/Mantis/ConfigParserTest.php Diff File

master 3ba1a743

2016-04-23 03:01

dregad


Details Diff
Move test cases initialization to dedicated method

Makes code easier to read, moving all the init code to the bottom of the
file.

Also call parent class' constructor.
mod - tests/Mantis/ConfigParserTest.php Diff File

master 584537ae

2016-04-23 02:54

dregad


Details Diff
Use new addCase() method

Also rename 'test_correct_syntax' property to 'cases'.
mod - tests/Mantis/ConfigParserTest.php Diff File

master 3304c32b

2016-04-23 02:49

dregad


Details Diff
Fix cproensa's unit tests to use ConfigParser class
mod - tests/Mantis/ConfigParserTest.php Diff File

master 8d8e4804

2016-04-23 01:33

dregad


Details Diff
Remove debugging code
mod - adm_config_set.php Diff File
mod - core/classes/ConfigParser.class.php Diff File

master 4569bdc7

2016-04-23 01:25

dregad


Details Diff
Use parse() method for scalar types

Avoids direct calls to constant_replace().
mod - adm_config_set.php Diff File

master 22b3a684

2016-04-23 01:08

dregad


Details Diff
Improve error messages
mod - core/classes/ConfigParser.class.php Diff File
mod - core/classes/Tokenizer.class.php Diff File
mod - lang/strings_english.txt Diff File

master fa8ed997

2016-04-23 01:06

dregad


Details Diff
ConfigParser: add option to ignore extra tokens

Prior to this, parse() method would always throw an exception when
additional code is found after the first token.
mod - adm_config_set.php Diff File
mod - core/classes/ConfigParser.class.php Diff File

master dabb160e

2016-04-22 20:19

vboctor


Details Diff
Move mentions settings to reminders section
mod - config_defaults_inc.php Diff File
mod - docbook/Admin_Guide/en-US/config/misc.xml Diff File
mod - docbook/Admin_Guide/en-US/config/reminders.xml Diff File

master 3bb856ef

2016-04-22 09:25

dregad


Details Diff
Move constant_replace() to ConfigParser class as static method
mod - adm_config_set.php Diff File
mod - core/classes/ConfigParser.class.php Diff File

master 9d782478

2016-04-22 09:08

dregad


Details Diff
Move Tokenizer and Parser to core class files
mod - adm_config_set.php Diff File
add - core/classes/ConfigParser.class.php Diff File
add - core/classes/Tokenizer.class.php Diff File

master da3d2be7

2016-04-22 08:45

cproensa

Committer: dregad


Details Diff
Only cache visible plugin columns

On issues view/print/export, a call is made to all MantisColumn plugin
objects to cache the list of issues.

This call is now done only for those columns that are part of the
user column selection.

Fixes 0020854

Signed-off-by: Damien Regad <dregad@mantisbt.org>
Affected Issues
0020854
mod - core/columns_api.php Diff File
mod - csv_export.php Diff File
mod - excel_xml_export.php Diff File
mod - print_all_bug_page.php Diff File
mod - view_all_inc.php Diff File
 First  Prev  1 2 3 ... 70 ... 140 ... 210 ... 219 220 221 222 223 224 225 ... 280 ... 350 ... 420 ... 490 ... 560 ... 630 ... 700 ... 729 730 731  Next  Last