Changesets: MantisBT

master 6373a3cf

2015-12-29 04:14

dregad


Details Diff
Code formatting for InsertData steps
mod - admin/schema.php Diff File

master 1b054551

2015-12-29 03:37

dregad


Details Diff
Update and improve comments

- improve header
- move 1.2.0rc2 marker to proper location
- other minor changes
mod - admin/schema.php Diff File

master bfaec506

2015-12-29 03:35

dregad


Details Diff
Unset local variables at end of schema definition
mod - admin/schema.php Diff File

master 29898e34

2015-12-29 01:27

dregad


Details Diff
Move installer_db_now() to install API
mod - admin/schema.php Diff File
mod - core/install_helper_functions_api.php Diff File

master 65165ae7

2015-12-29 01:25

dregad


Details Diff
Remove unused function (dead code)

db_null_date() function is defined in install_helper_functions_api.php
mod - admin/schema.php Diff File

master 6685a18a

2015-12-29 01:21

dregad


Details Diff
Define table creation options globally

Instead of specifying table creation options (eg. MySQL engine or
PostgreSQL 'WITHOUT OID') individually for each table, we define the
options globally and use the variable in the CreateTableSQL statements.
mod - admin/schema.php Diff File

master 1397e3a3

2015-12-29 00:31

dregad


Details Diff
Use '"' for all create/alter table/columns strings

Makes the code more readable by reducing the need for escaping within
strings.

This change also fixes SQL syntax errors in upgrade steps 4 and 43,
caused by referencing '$t_notnull' within a single-quoted string
(regression introduced by b78f966e013d494ea27d92bba39d797a1266b7b7).
mod - admin/schema.php Diff File

master 7c2ad6e5

2015-12-28 23:57

dregad


Details Diff
Apply consistent code layout to schema.php
mod - admin/schema.php Diff File

master 50c3db52

2015-12-27 23:43

dregad


Details Diff
Coding guidelines
mod - admin/install.php Diff File

master 6dce29ac

2015-12-26 14:26

dregad


Details Diff
Coding guidelines
mod - admin/check/check_database_inc.php Diff File

master 65066a3a

2015-12-26 14:25

dregad


Details Diff
Code cleanup

Defining the regex to match Mantis tables only once before entering the
table checks loops.

Avoids code duplication, uses one less variable and avoids a string
concatenation in each loop iteration.
mod - admin/check/check_database_inc.php Diff File

master 739f0d9e

2015-12-26 14:14

dregad


Details Diff
Fix incorrect EOL date for PostgreSQL 9.4
mod - admin/check/check_database_inc.php Diff File

master f6114ca9

2015-12-26 14:14

dregad


Details Diff
Admin check: update MySQL 5.7 release date

MySQL 5.7 reached General Availability on 21-Oct-2015 with 5.7.9.
mod - admin/check/check_database_inc.php Diff File

master 5348d790

2015-12-26 14:11

dregad


Details Diff
Admin check: fail if DB default collation is not UTF-8

Fixes 0020427
Affected Issues
0020427
mod - admin/check/check_database_inc.php Diff File

master c24cb7be

2015-12-26 14:04

dregad


Details Diff
Fix typo in admin check message
mod - admin/check/check_database_inc.php Diff File

master 8148a3d8

2015-12-26 14:02

dregad


Details Diff
Admin check: fix MySQL UTF-8 collation check

MySQL 5.5.3 introduced the 'utf8mb4' character which allows storage of
up to 4-byte unicode characters (utf8 only allows 3 bytes) [1].

As a consequence, the current check for collation beginning with 'utf8_'
returns false if the collation is utf8mb4.

This adds a new check_api check_is_collation_utf8() function to ensure
consistent checking of collation, and removes the underscore from the
comparison string.

Fixes 0020426

[1] https://dev.mysql.com/doc/refman/5.5/en/charset-unicode-utf8mb4.html
Affected Issues
0020426
mod - admin/check/check_api.php Diff File
mod - admin/check/check_database_inc.php Diff File

master b5c53a31

2015-12-26 13:39

dregad


Details Diff
Admin check: fix system notice with mysql drivers

With ADOdb 5.20.2, the mysql and mysqli drivers properly handle
associative fetch mode case, and consistently return lowercase column
names as per ADODB_ASSOC_CASE setting in database API.

We therefore no longer need to differentiate processing between the 2
drivers.

Minimum ADOdb version has been bumped accordingly.

Fixes 0020365
Affected Issues
0020365
mod - admin/check/check_database_inc.php Diff File
mod - core/constant_inc.php Diff File

master 0b972949

2015-12-26 13:32

dregad


Details Diff
Update ADOdb library to 5.20.2

This is a prerequisite to fix issue 0020365.
Affected Issues
0020365, 0020467
mod - library/README.md Diff File
mod - library/adodb Diff File

master-1.3.x f233869f

2015-12-25 08:03

cproensa


Details Diff
Rewrite export_xml_export

Rewrite most of the Excel export procedure
to benefit from new filter_api query
functions.
Read bugs directly from query result in
blocks, to keep memory usage within limits.
mod - excel_xml_export.php Diff File

master-1.3.x 8629ae04

2015-12-25 06:58

cproensa


Details Diff
Rewrite export_CSV

Rewrite most of the CSV export procedure
to benefit from new filter_api query
functions.
Read bugs directly from query result in
blocks, to keep memory usage within limits.
mod - csv_export.php Diff File

master-1.3.x 2f16c5f2

2015-12-25 05:17

cproensa


Details Diff
Refactor filter_get_bug_rows

Separate into different functions:
1) build query clauses
2) execute the query (without processing)
3) manage pagination and row cache

(3) is the previous entry point, so functional
compatibility is preserved.
(1,2) Will allow to get bug rows and process
them directly to skip pagination and cache.
mod - core/filter_api.php Diff File

master 7927c275

2015-12-23 09:32

atrol

Committer: dregad


Details Diff
Implement a white list of options accessible via SOAP API

This is a safer approach than the previous blacklist method, which
could potentially allow confidential information disclosure if a config
were added or renamed without a matching change in config_is_private()
function.

Fixes 0020277

Original commit modified: comments and commit message wording.

Signed-off-by: Damien Regad <dregad@mantisbt.org>
Affected Issues
0020277
mod - config_defaults_inc.php Diff File
mod - core/config_api.php Diff File
mod - docbook/Admin_Guide/en-US/config/settings.xml Diff File

master f3f75728

2015-12-23 08:00

atrol


Details Diff
Correct description of option $g_global_settings
mod - docbook/Admin_Guide/en-US/config/settings.xml Diff File

master-1.2.x 228e0a08

2015-12-23 07:57

atrol


Details Diff
Correct description of option $g_global_settings
mod - docbook/administration_guide/en/configuration.sgml Diff File

master-1.2.x 3d0c69c1

2015-12-23 05:25

dregad


Details Diff
Travis: squelch PHP built-in server's output

Improves readability of the build's log by removing unnecessary noise.
mod - scripts/travis_before_script.sh Diff File
 First  Prev  1 2 3 ... 70 ... 140 ... 210 ... 245 246 247 248 249 250 251 ... 280 ... 350 ... 420 ... 490 ... 560 ... 630 ... 700 ... 746 747 748  Next  Last