Changesets: MantisBT

master-1.2.x 7c88a1ce

2014-06-03 14:31

dregad


Details Diff
Travis: use port 8080 instead of 80

Fixes build errors with PHP built-in web server. By using port 8080, we
no longer need to use sudo since it's only needed for port 80.

This a backport from master branch, and includes the revert of commit
9315a7398328125578efdd189a443bb11313968a.
mod - scripts/travis_before_script.sh Diff File

master 75371387

2014-06-03 14:22

dregad


Details Diff
Revert "Travis: only use Apache as web server"

This reverts commit 41bb73fd16eb717c17ec7d0c5609de38b0d612fd.

Conflicts:
scripts/travis_before_script.sh
mod - scripts/travis_before_script.sh Diff File

master fb8ddcad

2014-06-03 14:12

dregad


Details Diff
Remove extract() call on untrusted input

As per recommendation in PHP manual http://php.net/extract, drop use of
extract() on input from $_FILE superglobal.

Porting 085a82e173dd0dff355620213243e10078cc11d6 to master
mod - proj_doc_update.php Diff File

master-1.2.x f1b55135

2014-06-03 14:12

dregad


Details Diff
Remove extract() call on untrusted input

As per recommendation in PHP manual http://php.net/extract, drop use of
extract() on input from $_FILE superglobal.
mod - proj_doc_update.php Diff File

master 3b584404

2014-06-03 07:54

dregad


Details Diff
Add HTML5 email validation method (as default)

As per grangeway's suggestion in pull request 172, we are now using an
HTML5 specification-compliant regex to validate e-mail addresses by
default instead of PHP method.

Issue 0017275, 0017279
Affected Issues
0017275, 0017279
mod - config_defaults_inc.php Diff File
mod - core/constant_inc.php Diff File
mod - core/email_api.php Diff File
mod - docbook/Admin_Guide/en-US/config/email.xml Diff File

master 300da83e

2014-06-03 07:17

dregad


Details Diff
Upgrade PHPMailer to 5.2.8

This implements the HTML5-spec email validation pattern, which is what
we will be using with validateAddress() as per discussion in pull
request https://github.com/mantisbt/mantisbt/pull/172.

See changelog.md for full details
mod - library/README.libs Diff File
mod - library/phpmailer Diff File

master 6c29fff9

2014-06-03 04:08

dregad


Details Diff
Add error param when updating project doc with empty title

Added missing error_parameter() call so that when attempting to update
an existing project document with an empty Title, the error message
indicates which field is required.

Fixes 0017407

Porting 0bea0a0faa14b822e7706a71c3ab7fdd6fad5a13 to master
Affected Issues
0017407
mod - proj_doc_update.php Diff File

master-1.2.x 76da88a3

2014-06-03 04:08

dregad


Details Diff
Add error param when updating project doc with empty title

Added missing error_parameter() call so that when attempting to update
an existing project document with an empty Title, the error message
indicates which field is required.

Fixes 0017407
Affected Issues
0017407
mod - proj_doc_update.php Diff File

master 319d45b5

2014-06-03 03:59

dregad


Details Diff
Allow update of existing project document

Prior to this, it was impossible to update a document's title or
description without uploading a new file, as MantisBT would trigger an
error.

Fixes 0017405

Porting a0539b7e32c7dc8301518d857efb887aa43072bc to master
Affected Issues
0017405
mod - proj_doc_update.php Diff File

master-1.2.x 7ffceea8

2014-06-03 03:59

dregad


Details Diff
Allow update of existing project document

Prior to this, it was impossible to update a document's title or
description without uploading a new file, as MantisBT would trigger an
error.

Fixes 0017405
Affected Issues
0017405
mod - proj_doc_update.php Diff File

master 36e85011

2014-06-02 08:42

mantishub


Details Diff
Addressing misc timeline review comments.
mod - css/default.css Diff File
mod - my_view_page.php Diff File

master dba6143f

2014-06-02 08:38

mantishub


Details Diff
Fix handling for disabled avatars.
mod - core/timeline_api.php Diff File
mod - css/default.css Diff File

master da26a55a

2014-06-02 08:19

mantishub


Details Diff
Add missing lang_get() to timeline_inc.php
mod - core/timeline_inc.php Diff File

master b36ac41d

2014-06-02 02:38

dregad


Details Diff
Fix absolute URLs issue with 'User Documentation' link

This resolves the issue with absolute URLs specified in $g_manual_url
becoming relative on project documentation pages.

Following discussions in the pull request [1], the solution implements
additional logic in the print_doc_menu() function that checks whether
the provided URL is absolute or relative (based on presence of an URL
scheme):
- if relative, makes sure the local path exists
- if yes, build absolute URL using helper_mantis_url()
- if not, fall back to the online manual on
http://www.mantisbt.org/documentation.php
- if absolute, uses the URL as-is without check

Since this is currently the only use case for absolute URLs with
helper_mantis_url() and the documentation feature is deprecated, it made
more sense to have the logic in print_doc_menu() rather than creating a
new API function.

Fixes 0016995

[1] https://github.com/mantisbt/mantisbt/pull/144
Affected Issues
0016995
mod - config_defaults_inc.php Diff File
mod - core/html_api.php Diff File

master 506088e1

2014-06-02 00:41

Damien Regad


Details Diff
Various plugin-related fixes and enhancements

- Check that a plugin is loaded when accessing its pages to prevent
errors
- Improved error messages
- Simplified handling of MantisCore pseudo-plugin
- Remove direct access to $g_plugin_cache global variable
- Improved plugin file validation regex
- No re-registration of previously registered plugins
- Fixed data type issues in plugin API
- Various code cleanup and whitespace fixes

Fixes 0017359, 0017366, 0017368
Affected Issues
0017359, 0017366, 0017368
mod - core/constant_inc.php Diff File
mod - core/plugin_api.php Diff File
mod - core/print_api.php Diff File
mod - lang/strings_english.txt Diff File
mod - manage_plugin_page.php Diff File
mod - plugin.php Diff File
mod - plugin_file.php Diff File

master cfe0935f

2014-06-01 22:20

mantishub


Details Diff
Added user date_created index for user creation events.
mod - admin/schema.php Diff File

master b71827e2

2014-06-01 22:20

mantishub


Details Diff
Add bug_history date modified index.
mod - admin/schema.php Diff File

master d3b9efd8

2014-06-01 22:10

mantishub


Details Diff
Remove todo from timeline_inc.php.
mod - core/timeline_inc.php Diff File

master e4af7c3e

2014-06-01 22:09

mantishub


Details Diff
Move timeline api to core/timeline_api.php.
add - core/timeline_api.php Diff File
mod - core/timeline_inc.php Diff File

master c3fcaba4

2014-06-01 22:05

mantishub


Details Diff
Move strings to lang files and use lang_get().
mod - core/timeline_inc.php Diff File
mod - lang/strings_english.txt Diff File

master 53b2fd9b

2014-06-01 22:00

mantishub


Details Diff
Move Timeline styles to default.css.
mod - css/default.css Diff File
mod - my_view_page.php Diff File

timeline 1f7b13f0

2014-06-01 18:05

mantishub


Details Diff
Timeline feature preview
add - core/timeline_inc.php Diff File
mod - my_view_page.php Diff File

master d508493a

2014-06-01 13:04

Paul Richards


Details Diff
Fix 0016570: Page content is forgotten when user clicks [Back] button

By default we disable $g_allow_browser_cache in all circumstances.

The config value is commented out in config_defaults.inc.php. In fact, thraxisp
added the config option in 2005 in the commented out state.

It would appear the DHX re-ordered this call when implemented require_api
- see:

https://github.com/mantisbt/mantisbt/commit/2d5455cce290531359a55d353010258c6f3f6f34

The above code is only in 1.3 and not in the 1.2 series, so the above fix should
be safe to apply.

We probably need to consider whether we actually want to remove this configuration option

After all, it's a configuration option we've probably never had anyone use in 5 years
so I expect that the value of it is rather....
Affected Issues
0016570
mod - bug_change_status_page.php Diff File
mod - bug_report_page.php Diff File
mod - bug_update_page.php Diff File

mantishub-1.3.x-20150418_1638 4863b1f2

2014-05-31 20:15

Victor Boctor


Details Diff
Added support for impersonation through url with token.
mod - core/authentication_api.php Diff File
mod - login.php Diff File
mod - login_page.php Diff File

master cabacdc2

2014-05-31 14:59

Paul Richards


Details Diff
Fix: adm_config_report.php filtering does not check config option is valid

I've left this throwing ERROR_GENERIC as the only time this should be able
to be hit is if we have invalid input to start with.
Affected Issues
0017889
mod - adm_config_report.php Diff File
 First  Prev  1 2 3 ... 70 ... 140 ... 210 ... 277 278 279 280 281 282 283 ... 350 ... 420 ... 490 ... 560 ... 630 ... 700 ... 729 730 731  Next  Last