Source Control Integration

master ddc78c91 2014-07-16 09:44 dregad Details Diff	Init $g_display_errors with dev settings on localhost When the server name is localhost/127.0.0.1, we automatically set $g_display_error to the recommended development values, i.e. - E_USER_ERROR => DISPLAY_ERROR_HALT - E_WARNING => DISPLAY_ERROR_HALT - E_ALL => DISPLAY_ERROR_INLINE Issue 0017501	Affected Issues 0017501
	mod - config_defaults_inc.php	Diff File
	mod - docbook/Admin_Guide/en-US/Configuration.xml	Diff File
master a388d6fa 2014-07-16 08:39 dregad Details Diff	Fix 0017506: type mismatch error in news edit page	Affected Issues 0017506
	mod - news_edit_page.php	Diff File
master c3a00c28 2014-07-16 08:29 dregad Details Diff	Fix missing button on "Workflow Thresholds" page Regression introduced by ee1b1c959ff4cf8458aa901fdbe6c13e0571a9b8 Fixes 0017507	Affected Issues 0017507
	mod - manage_config_work_threshold_page.php	Diff File
master 7543abe2 2014-07-16 08:08 dregad Details Diff	Fix PHP notice in admin index page The error is caused by incorrect regex in ADOdb library. See https://github.com/ADOdb/ADOdb/issues/16 Fix was applied by cherry-picking commit from upstream master branch https://github.com/ADOdb/ADOdb/commit/701798f02ad2f06f7bba9e3922a2f6a9d8f05918	Affected Issues 0017508, 0019635
	mod - library/README.libs	Diff File
	mod - library/adodb	Diff File
master 3d9f73d5 2014-07-16 07:39 dregad Details Diff	Fix application error 203 when reporting new issue There was a missing '"' in function print_category_option_list(). Regression introduced by ee1b1c959ff4cf8458aa901fdbe6c13e0571a9b8. Fixes 0017512	Affected Issues 0017512
	mod - core/print_api.php	Diff File
master 76f82ef5 2014-07-16 07:09 dregad Details Diff	Fix E_RECOVERABLE_ERROR in category API category_sort_rows_by_project() is called in 2 steps: 1. with a project id in 1st param to set the "preferred" project (and 2nd param null) 2. with 2 arrays containing category details Because of this behavior, the 'array' type hint can't be used on the first parameter as it throws an error when initializing the sort in category_get_all_rows(). Regression introduced by 5458f7020999317b35f403fa2a0e477d6182ec12 Fixes 0017515	Affected Issues 0017515
	mod - core/category_api.php	Diff File
master d74fe227 2014-07-15 12:21 Paul Richards Details Diff	DB Casts within history api. For better compatibilty across the db layers and types, cast the parameters appropriately
	mod - core/history_api.php	Diff File
master 81c9a274 2014-07-14 15:07 Paul Richards Details Diff	Fix missed global variables
	mod - core/filter_api.php	Diff File
	mod - manage_config_work_threshold_set.php	Diff File
master e8f1057b 2014-07-14 15:02 Paul Richards Details Diff	Remove inbuilt php long arrays PHP Long arrays are deprecated and removed in php 5.4. We already check both $_SERVER and $GLOBALS so there's no need to check for $QUERY_STRING itself.
	mod - api/soap/mantisconnect.php	Diff File
master 9ba4fe9d 2014-07-14 15:00 Paul Richards Committer: dregad Details Diff	Remove obsolete helper_alternate_colors() function The helper_alternate_colors function used to add odd/even classes to HTML elements, but dhx worked to remove these in 1.3. Related functions were already removed, however this function was missed.	Affected Issues 0016471
	mod - core/helper_api.php	Diff File
	mod - print_all_bug_page.php	Diff File
master 4109134d 2014-07-14 14:52 Paul Richards Details Diff	Update commit following Damien's comments.
	mod - config_defaults_inc.php	Diff File
	mod - core/database_api.php	Diff File
master e7708cb2 2014-07-14 14:41 Paul Richards Details Diff	The value stored in the config table may be a string, boolean, or integer. For better compatibility across the db layers, we should always cast this to a string, to match the underlying data type.
	mod - core/config_api.php	Diff File
master 12a7f834 2014-07-14 14:32 Paul Richards Details Diff	Fix moving of attachments to allow both directions (db<>disk) This basically builds on the work Damien did before. In addition, tidy up the file api for later merging into the new db layer and fix support (;() for oracle in the soap api for file handling.
	mod - admin/move_attachments.php	Diff File
	mod - admin/move_attachments_page.php	Diff File
	mod - admin/system_utils.php	Diff File
	mod - api/soap/mc_file_api.php	Diff File
	mod - core/file_api.php	Diff File
master 5d980dbf 2014-07-14 14:16 Paul Richards Details Diff	Fix db_get_table calls in move attachments pages
	mod - admin/move_attachments.php	Diff File
	mod - admin/move_attachments_page.php	Diff File
master d4fdefa2 2014-07-14 14:14 Paul Richards Details Diff	remove most references to (unused) document_files_prefix config setting
	mod - api/soap/mc_file_api.php	Diff File
	mod - config_defaults_inc.php	Diff File
	mod - core/file_api.php	Diff File
	mod - docbook/Admin_Guide/en-US/Configuration.xml	Diff File
master 17ff24f9 2014-07-14 14:10 Paul Richards Details Diff	Use crypto API as random number source to generate filenames Whilst I can't really see anyone being able to do anything useful with this, instead of using a seed (of time() + bug ID), which could be predicatable. We instead use our complex random string routines that dhx added. In addition, I've fixed the comment on file_generate_unique_name to state it returns 32 characters and not 64 characters. I did consider whether to fix the code to match the comment, but in this case, it would seem to be likely to be less problematic to stick with the shorter string. In addition, I've dropped the 'file_generate_name' function, in favour of just having a single function to generate a unique name. Even the while() loop in the generate_unique_name function seems somewhat excessive: current downside: it's an extra DB query - given we could prepend the seed (bug_id), add an _ and the chances of md5() generating a collision is probably fairly low.
	mod - admin/move_attachments.php	Diff File
	mod - api/soap/mc_file_api.php	Diff File
	mod - core/file_api.php	Diff File
master 9dfc5fb6 2014-07-14 14:07 Paul Richards Details Diff	Store config entries json encoded Store collapse tokens as json encoded Store MantisGraph tokens as json encoded Store Filters json encoded	Affected Issues 0017809
	mod - adm_config_report.php	Diff File
	mod - admin/schema.php	Diff File
	mod - api/soap/mc_api.php	Diff File
	mod - api/soap/mc_filter_api.php	Diff File
	mod - config_defaults_inc.php	Diff File
	mod - core/collapse_api.php	Diff File
	mod - core/config_api.php	Diff File
	mod - core/current_user_api.php	Diff File
	mod - core/filter_api.php	Diff File
	mod - core/install_helper_functions_api.php	Diff File
	mod - core/user_api.php	Diff File
	mod - manage_config_columns_set.php	Diff File
	mod - plugins/MantisGraph/pages/summary_graph_bycategory.php	Diff File
	mod - plugins/MantisGraph/pages/summary_graph_bycategory_pct.php	Diff File
	mod - plugins/MantisGraph/pages/summary_graph_bypriority.php	Diff File
	mod - plugins/MantisGraph/pages/summary_graph_bypriority_mix.php	Diff File
	mod - plugins/MantisGraph/pages/summary_graph_bypriority_pct.php	Diff File
	mod - plugins/MantisGraph/pages/summary_graph_byresolution.php	Diff File
	mod - plugins/MantisGraph/pages/summary_graph_byresolution_mix.php	Diff File
	mod - plugins/MantisGraph/pages/summary_graph_byresolution_pct.php	Diff File
	mod - plugins/MantisGraph/pages/summary_graph_byseverity.php	Diff File
	mod - plugins/MantisGraph/pages/summary_graph_byseverity_mix.php	Diff File
	mod - plugins/MantisGraph/pages/summary_graph_byseverity_pct.php	Diff File
	mod - plugins/MantisGraph/pages/summary_graph_bystatus.php	Diff File
	mod - plugins/MantisGraph/pages/summary_graph_bystatus_pct.php	Diff File
	mod - plugins/MantisGraph/pages/summary_graph_imp_category.php	Diff File
	mod - plugins/MantisGraph/pages/summary_graph_imp_priority.php	Diff File
	mod - plugins/MantisGraph/pages/summary_graph_imp_resolution.php	Diff File
	mod - plugins/MantisGraph/pages/summary_graph_imp_severity.php	Diff File
	mod - plugins/MantisGraph/pages/summary_graph_imp_status.php	Diff File
	mod - print_all_bug_page.php	Diff File
	mod - search.php	Diff File
	mod - view_all_set.php	Diff File
master 8807988a 2014-07-14 12:28 atrol Details Diff	Fix regression in test_langs.php Commit 78cee358 added file Web.config to plugins and lang folder. test_langs.php treated the file as a plugin folder and a language file.
	mod - admin/test_langs.php	Diff File
master fd4c97b0 2014-07-14 03:54 atrol Details Diff	Added missing semicolon
	mod - news_update.php	Diff File
master d79e6ba1 2014-07-14 01:42 dregad Details Diff	Revert inadvertant update of ADOdb submodule In ee1b1c959ff4cf8458aa901fdbe6c13e0571a9b8
	mod - library/adodb	Diff File
master a188b042 2014-07-13 17:29 Rafik Robeal Details Diff	Prevent scaling when editing on mobile
	mod - core/layout_api.php	Diff File
master ea26186c 2014-07-13 15:41 Paul Richards Details Diff	Remove legacy code following nusoap removal
	mod - api/soap/mc_api.php	Diff File
master 51259444 2014-07-13 15:30 Paul Richards Details Diff	Fix usage of db_query_bound Pass all parameters in as arguments in user_api.
	mod - core/user_api.php	Diff File
master ac49ad89 2014-07-13 15:01 Paul Richards Details Diff	Backport from DB API changes functionality to set table name. This would allow the use of the new syntax i.e.: -$t_query = 'SELECT COUNT() AS unused_user_count FROM ' . $t_user_table . ' +$t_query = 'SELECT COUNT() AS unused_user_count FROM {user} Whilst still allowing use of the old syntax, to give developers and plugin authors the opportunity to start migrating code to the new syntax ready for the 2.x. By doing this, it also helps us extend the life of 1.3 - as it stands, if we release test versions of mantis with the new DB layer about within a month of the final 1.3 release as previously agreed, we could reach the stage where we have support issues from our side for the 1.3 release.
	mod - config_defaults_inc.php	Diff File
	mod - core/database_api.php	Diff File
master 07c6605b 2014-07-13 14:41 Paul Richards Details Diff	Code Standards/PHP Doc improvements Improvements to code base to follow coding standards, and improve phpdoc validation from PHP Codesniffer rules
	mod - api/soap/mc_file_api.php	Diff File
	mod - api/soap/mc_tag_api.php	Diff File

Changesets: MantisBT