Changesets: MantisBT

master-1.2.x c0d9b81a

2014-05-07 07:28

dregad


Details Diff
Remove use of deprecated pattern modifier in string_insert_hrefs()

string_insert_hrefs() relied on PREG_REPLACE_EVAL ('e') pattern modifier
for preg_replace() to apply rtrim() function to subpatterns.

In PHP 5.5, this feature has been deprecated for security reasons [1] so
we rely on preg_replace_callback() instead.

Fixes 0017292

Backporting the fix from master branch, replacing the closure with an
anonymous function for compatibility with PHP < 5.3.

[1] http://php.net/reference.pcre.pattern.modifiers.php#reference.pcre.pattern.modifiers.eval
Affected Issues
0017292
mod - core/string_api.php Diff File

master 2926132b

2014-05-07 05:26

dregad


Details Diff
Fix query execution error in user_get_accessible_subprojects()

Because of missing '!' operator, the parameters array did not have
enough values for the query when $p_show_disabled = true.

Regression introduced by 927706b3311407712ee16b9be71f56a974683d73
mod - core/user_api.php Diff File

master 7e2993db

2014-05-07 04:20

dregad


Details Diff
Document ability to display status on bug_report_page.php

Fix for issue 0014678 omitted to amend the comment block in
config_defaults_inc.php as well as the documentation.

Fixes 0017289
Affected Issues
0014678, 0017289
mod - config_defaults_inc.php Diff File
mod - docbook/Admin_Guide/en-US/Configuration.xml Diff File

master-1.2.x abe0cd2e

2014-05-07 04:20

dregad


Details Diff
Document ability to display status on bug_report_page.php

Fix for issue 0014678 omitted to amend the comment block in
config_defaults_inc.php as well as the documentation.

Fixes 0017289
Affected Issues
0014678, 0017289
mod - config_defaults_inc.php Diff File
mod - docbook/administration_guide/en/configuration.sgml Diff File

master-1.2.x 05839373

2014-05-02 07:10

dregad


Details Diff
Travis before script: use PORT variable (align with master)
mod - scripts/travis_before_script.sh Diff File

master 6bac6a85

2014-05-02 07:07

dregad


Details Diff
Travis before script: PORT was defined but not used
mod - scripts/travis_before_script.sh Diff File

master d7e42128

2014-05-02 06:40

dregad


Details Diff
Add handling for E_DEPRECATED error type
mod - core/error_api.php Diff File

master 9b12561e

2014-05-02 06:38

dregad


Details Diff
Print backtrace when show_detailed_errors == ON
mod - core/error_api.php Diff File

master 4d4dadd4

2014-05-02 06:31

dregad


Details Diff
Don't fall through web-specific error handling

If a non-critical error occurs and we continue code execution as
configured in $g_display_errors, the web-specific handling should not be
executed.
mod - core/error_api.php Diff File

master 9e420ba8

2014-05-02 06:22

dregad


Details Diff
Only print message if error type is configured to do so

If display method == DISPLAY_ERROR_NONE, don't print anything.
mod - core/error_api.php Diff File

master 3b7c225e

2014-05-02 06:18

dregad


Details Diff
Only exit if error type is configured to HALT

Makes CLI script behave like the web app
mod - core/error_api.php Diff File

master 1323805e

2014-05-02 06:16

dregad


Details Diff
Exit with an error code of 1

This allows the calling script to respond in an appropriate manner in
case an error occurs.
mod - core/error_api.php Diff File

master 987b6adc

2014-05-02 06:15

dregad


Details Diff
Separate error type from description with colon

This makes the error message look more like standard PHP errors.
mod - core/error_api.php Diff File

master 6e2e8a67

2014-05-02 06:11

dregad


Details Diff
Provide a description for unknown error types
mod - core/error_api.php Diff File

master 4d8aa439

2014-05-01 18:12

mantishub


Details Diff
Fixes 0017246: Date custom fields can't store dates pre-1970. - part 2 Affected Issues
0017246
mod - core/custom_field_api.php Diff File

master 55585f4d

2014-05-01 15:08

dregad


Details Diff
Travis before_script add DB_TYPE

Since PHP >= 5.5 has deprecated mysql driver, we use mysqli instead
mod - scripts/travis_before_script.sh Diff File

master-1.2.x 48f0fb23

2014-05-01 15:08

dregad


Details Diff
Travis before_script add DB_TYPE

Since PHP >= 5.5 has deprecated mysql driver, we use mysqli instead
mod - scripts/travis_before_script.sh Diff File

master 41bb73fd

2014-05-01 14:50

dregad


Details Diff
Travis: only use Apache as web server

Workaround for build errors with PHP built-in web server since
30-Apr-2014 [1].

[1] https://github.com/travis-ci/travis-ci/issues/2235
mod - scripts/travis_before_script.sh Diff File

master-1.2.x 9315a739

2014-05-01 14:50

dregad


Details Diff
Travis: only use Apache as web server

Workaround for build errors with PHP built-in web server since
30-Apr-2014 [1].

[1] https://github.com/travis-ci/travis-ci/issues/2235

Cherry-picked from master.
Conflicts:
scripts/travis_before_script.sh
mod - scripts/travis_before_script.sh Diff File

master 2da37dbb

2014-05-01 14:17

Paul Richards


Details Diff
Fixes 0008207 mantis_project_hierarchy_table allows duplicate rows

This fixes a possible issue where the project hierarchy table can contain duplicate entries, by adding a unique index on the table
Affected Issues
0008207
mod - admin/schema.php Diff File
mod - core/install_helper_functions_api.php Diff File

master ada8c392

2014-05-01 14:01

dregad


Details Diff
Fix 0019628: add logging to email_is_valid() Affected Issues
0019628
mod - core/email_api.php Diff File

master 2eebb746

2014-05-01 13:46

dregad


Details Diff
Allow choice of email validation method

Following implementation of 50d235ad101f61a6c6888316e827fd225ad4b9cd the
validation of email addresses was done by PHPMailer::validateAddress()
instead of filter_var() with FILTER_SANITIZE_EMAIL to allow RFC5322-
compliant emails like 'user@domain' that are rejected by PHP's method
which only accepts 'user@domain.tld'.

However, these 'top-level-domain-only' addresses are often considered as
invalid by SMTP servers but there is a strong use-case for them in
intranet environments.

To enable both scenarios, this commit introduces new constants for
$g_validate_email, allowing the admin to pick whether they want
validation using the PHP method (default) or strict RFC5322.

Backwards compatibility is maintained because EMAIL_VALIDATE_PHP == ON,
and validation can still be disabled with OFF.
mod - config_defaults_inc.php Diff File
mod - core/constant_inc.php Diff File
mod - core/email_api.php Diff File
mod - docbook/Admin_Guide/en-US/config/email.xml Diff File

adodb 5c568d2e

2014-04-30 14:56

dregad


Details Diff
db_query_bound() $arr_parms defaults to false instead of null

This is is to align the parameter's type to what ADOdb expects - in
v5.19 the Execute() method was modified to perform a strict type check
on the parameter, causing database errors when it receives 'null' if
there are no parameters to the query being executed.

Fixes 0013713
mod - core/database_api.php Diff File
mod - core/project_hierarchy_api.php Diff File
mod - core/summary_api.php Diff File
mod - core/user_api.php Diff File

master f779e3d4

2014-04-30 11:42

rombert

Committer: dregad


Details Diff
SOAP API: apply access control to mci_account_get_array_by_id

The access controls are the same as the ones applied by
view_user_page.php, with the single addition of making the info
available if the user requests their own information.

This preserves the behaviour of the mc_login method call.

Fixes 0017243 (leak of user personal information)

Signed-off-by: Damien Regad <dregad@mantisbt.org>
Affected Issues
0017243
mod - api/soap/mc_account_api.php Diff File

master-1.2.x f001e06c

2014-04-30 11:42

rombert

Committer: dregad


Details Diff
SOAP API: apply access control to mci_account_get_array_by_id

The access controls are the same as the ones applied by
view_user_page.php, with the single addition of making the info
available if the user requests their own information.

This preserves the behaviour of the mc_login method call.

Fixes 0017243 (leak of user personal information)

Signed-off-by: Damien Regad <dregad@mantisbt.org>
Affected Issues
0017243
mod - api/soap/mc_account_api.php Diff File
 First  Prev  1 2 3 ... 70 ... 140 ... 210 ... 280 ... 282 283 284 285 286 287 288 ... 350 ... 420 ... 490 ... 560 ... 630 ... 700 ... 729 730 731  Next  Last