Changesets: MantisBT

master ee3e36c8

2014-05-30 14:22

Damien Regad


Details Diff
Coding guidelines
mod - manage_plugin_page.php Diff File

master 44f6f69a

2014-05-30 14:19

Damien Regad


Details Diff
Simplify code to list installed plugins
mod - manage_plugin_page.php Diff File

master c892b7f4

2014-05-30 14:14

Damien Regad


Details Diff
Remove unnecessary MantisCore-specific code

Using the new plugin_get_force_installed() function (which always
returns 'MantisCore') allows simplification of several plugin API, as
they no longer require specific code to handle the pseudo plugin.
mod - core/plugin_api.php Diff File

master 3da96c65

2014-05-30 14:12

Damien Regad


Details Diff
New API to return list of force-installed plugins
mod - core/plugin_api.php Diff File

master 08f126be

2014-05-30 13:42

Damien Regad


Details Diff
Fix data type issues in plugin API

- enabled and protected are boolean
- priority is int

The type cast before assignment ensures we don't get type mismatch
errors in check_selected/check_checked functions, since DB api seems to
return these fields as strings.
mod - core/plugin_api.php Diff File
mod - core/print_api.php Diff File

master b8a4d7c2

2014-05-30 13:36

Damien Regad


Details Diff
Do not register previously registered plugins

It may happen that a plugin listed as enabled in the plugin table is in
fact already registered with MantisBT if that plugin is also listed as
force_installed in the configuration.

In that case, re-registering it basically 'unprotects' it, and
manage_plugin_page.php displays an Uninstall action even though the
plugin can't actually be uninstalled.
mod - core/plugin_api.php Diff File

master acdd2dfa

2014-05-30 01:31

Paul Richards


Details Diff
Code standard / PHPdoc fixes.

This will be the last batch of these as there's more useful stuff to do :)
mod - account_page.php Diff File
mod - admin/check/check_display_inc.php Diff File
mod - admin/email_queue.php Diff File
mod - admin/install.php Diff File
mod - admin/test_langs.php Diff File
mod - admin/upgrade_unattended.php Diff File
mod - api/soap/mc_api.php Diff File
mod - api/soap/mc_enum_api.php Diff File
mod - api/soap/mc_filter_api.php Diff File
mod - api/soap/mc_issue_api.php Diff File
mod - api/soap/mc_issue_attachment_api.php Diff File
mod - api/soap/mc_project_api.php Diff File
mod - api/soap/mc_project_attachment_api.php Diff File
mod - api/soap/mc_user_profile_api.php Diff File
mod - bug_actiongroup.php Diff File
mod - bug_actiongroup_add_note_inc.php Diff File
mod - bug_actiongroup_attach_tags_inc.php Diff File
mod - bug_actiongroup_page.php Diff File
mod - bug_file_upload_inc.php Diff File
mod - bug_report.php Diff File
mod - bug_report_page.php Diff File
mod - bug_view_advanced_page.php Diff File
mod - bug_view_page.php Diff File
mod - bugnote_add.php Diff File
mod - bugnote_view_inc.php Diff File
mod - changelog_page.php Diff File
mod - config_defaults_inc.php Diff File
mod - core.php Diff File
mod - core/authentication_api.php Diff File
mod - core/bug_api.php Diff File
mod - core/category_api.php Diff File
mod - core/cfdefs/cfdef_standard.php Diff File
mod - core/classes/MantisEnum.class.php Diff File
mod - core/classes/MantisFilter.class.php Diff File
mod - core/classes/MantisFormattingPlugin.class.php Diff File
mod - core/classes/MantisPlugin.class.php Diff File
mod - core/columns_api.php Diff File
mod - core/compress_api.php Diff File
mod - core/config_api.php Diff File
mod - core/constant_inc.php Diff File
mod - core/csv_api.php Diff File
mod - core/current_user_api.php Diff File
mod - core/custom_field_api.php Diff File
mod - core/custom_function_api.php Diff File
mod - core/database_api.php Diff File
mod - core/date_api.php Diff File
mod - core/email_api.php Diff File
mod - core/error_api.php Diff File
mod - core/excel_api.php Diff File
mod - core/file_api.php Diff File
mod - core/filter_api.php Diff File
mod - core/form_api.php Diff File
mod - core/gpc_api.php Diff File
mod - core/helper_api.php Diff File
mod - core/history_api.php Diff File
mod - core/html_api.php Diff File
mod - core/http_api.php Diff File
mod - core/install_helper_functions_api.php Diff File
mod - core/json_api.php Diff File
mod - core/lang_api.php Diff File
mod - core/logging_api.php Diff File
mod - core/plugin_api.php Diff File
mod - core/prepare_api.php Diff File
mod - core/print_api.php Diff File
mod - core/project_api.php Diff File
mod - core/rss_api.php Diff File
mod - core/session_api.php Diff File
mod - core/sponsorship_api.php Diff File
mod - core/string_api.php Diff File
mod - core/summary_api.php Diff File
mod - core/tag_api.php Diff File
mod - core/tokens_api.php Diff File
mod - core/user_api.php Diff File
mod - core/user_pref_api.php Diff File
mod - core/utility_api.php Diff File
mod - core/version_api.php Diff File
mod - excel_xml_export.php Diff File
mod - issues_rss.php Diff File
mod - login_page.php Diff File
mod - login_select_proj_page.php Diff File
mod - logout_page.php Diff File
mod - manage_columns_inc.php Diff File
mod - manage_proj_edit_page.php Diff File
mod - manage_tags_page.php Diff File
mod - manage_user_edit_page.php Diff File
mod - manage_user_page.php Diff File
mod - my_view_inc.php Diff File
mod - news_rss.php Diff File
mod - permalink_page.php Diff File
mod - plugins/MantisCoreFormatting/MantisCoreFormatting.php Diff File
mod - plugins/MantisGraph/core/Period.php Diff File
mod - plugins/MantisGraph/core/graph_api.php Diff File
mod - plugins/MantisGraph/pages/bug_graph_bycategory.php Diff File
mod - plugins/MantisGraph/pages/bug_graph_bystatus.php Diff File
mod - plugins/MantisGraph/pages/bug_graph_page.php Diff File
mod - plugins/XmlImportExport/ImportXml.php Diff File
mod - plugins/XmlImportExport/ImportXml/Issue.php Diff File
mod - plugins/XmlImportExport/pages/export.php Diff File
mod - plugins/XmlImportExport/pages/import.php Diff File
mod - plugins/XmlImportExport/pages/import_action.php Diff File
mod - print_all_bug_page.php Diff File
mod - print_all_bug_page_word.php Diff File
mod - print_bug_page.php Diff File
mod - proj_doc_add_page.php Diff File
mod - proj_doc_edit_page.php Diff File
mod - query_store.php Diff File
mod - roadmap_page.php Diff File
mod - search.php Diff File
mod - tag_attach.php Diff File
mod - tests/Mantis/EnumTest.php Diff File
mod - tests/Mantis/StringTest.php Diff File
mod - tests/TestConfig.php Diff File
mod - tests/soap/EnumTest.php Diff File
mod - tests/soap/FilterTest.php Diff File
mod - tests/soap/IssueAddTest.php Diff File
mod - tests/soap/IssueHistoryTest.php Diff File
mod - tests/soap/IssueMonitorTest.php Diff File
mod - tests/soap/IssueNoteTest.php Diff File
mod - tests/soap/IssueUpdateTest.php Diff File
mod - tests/soap/SoapBase.php Diff File
mod - tests/soap/TagTest.php Diff File
mod - tests/soap/UserTest.php Diff File
mod - view_all_set.php Diff File
mod - view_filters_page.php Diff File

master 1951b823

2014-05-29 06:00

grangeway


Details Diff
Merge pull request 0000185 from grangeway/17380

Fix: 0017380: IIS: add web.config to deny access to config/
add - config/Web.config Diff File
add - core/Web.config Diff File
add - doc/Web.config Diff File
add - lang/Web.config Diff File
add - library/Web.config Diff File
add - packages/Web.config Diff File
add - plugins/.htaccess Diff File
add - plugins/Web.config Diff File
add - scripts/.htaccess Diff File
add - scripts/Web.config Diff File

master 78cee358

2014-05-29 05:59

Paul Richards


Details Diff
Fix 0017380: IIS: add web.config to deny access to config/ Affected Issues
0014538, 0017380
add - config/Web.config Diff File
add - core/Web.config Diff File
add - doc/Web.config Diff File
add - lang/Web.config Diff File
add - library/Web.config Diff File
add - packages/Web.config Diff File
add - plugins/.htaccess Diff File
add - plugins/Web.config Diff File
add - scripts/.htaccess Diff File
add - scripts/Web.config Diff File

master d233c9df

2014-05-29 05:05

grangeway


Details Diff
Merge pull request #183 from grangeway/17377

Fix 0017377: Reduce unneeded global Variables: g_libraries_included
Affected Issues
0017377
mod - core.php Diff File

master 35ad2b52

2014-05-29 05:02

grangeway


Details Diff
Merge pull request 0000184 from grangeway/17378

Fix 0017378: Reduce unneeded global Variables: g_api_included
Affected Issues
0017378
mod - core.php Diff File

master 44285cf9

2014-05-29 04:59

Paul Richards


Details Diff
Fix 0017377: Reduce unneeded global Variables: g_libraries_included Affected Issues
0017377
mod - core.php Diff File

master 86b476b9

2014-05-29 04:56

grangeway


Details Diff
Merge pull request 0000192 from grangeway/copy_field

Fix: 0017385: Removal of copy_fields utility
rm - admin/copy_field.php Diff
mod - admin/system_utils.php Diff File

master c0159d70

2014-05-29 04:55

grangeway


Details Diff
Merge pull request 0000186 from grangeway/17381

Fix 0017381: Provide additional random number generators
Affected Issues
0017381
mod - core/crypto_api.php Diff File

master e334d99c

2014-05-28 14:50

grangeway


Details Diff
Merge pull request #200 from grangeway/phpdoc4

Ensure Mantis source passes PHPDoc Validation
mod - adm_config_delete.php Diff File
mod - adm_config_report.php Diff File
mod - adm_config_set.php Diff File
mod - adm_permissions_report.php Diff File
mod - admin/check/index.php Diff File
mod - admin/schema.php Diff File
mod - admin/test_icons.php Diff File
mod - admin/test_langs.php Diff File
mod - admin/upgrade_unattended.php Diff File
mod - api/soap/mc_account_api.php Diff File
mod - api/soap/mc_api.php Diff File
mod - api/soap/mc_config_api.php Diff File
mod - api/soap/mc_custom_field_api.php Diff File
mod - api/soap/mc_file_api.php Diff File
mod - api/soap/mc_filter_api.php Diff File
mod - api/soap/mc_issue_api.php Diff File
mod - api/soap/mc_issue_attachment_api.php Diff File
mod - api/soap/mc_project_api.php Diff File
mod - api/soap/mc_project_attachment_api.php Diff File
mod - api/soap/mc_tag_api.php Diff File
mod - api/soap/mc_user_profile_api.php Diff File
mod - bug_actiongroup_add_note_inc.php Diff File
mod - bug_update_page.php Diff File
mod - core.php Diff File
mod - core/bug_api.php Diff File
mod - core/cfdefs/cfdef_standard.php Diff File
mod - core/classes/MantisColumn.class.php Diff File
mod - core/classes/MantisCorePlugin.class.php Diff File
mod - core/classes/MantisCoreWikiPlugin.class.php Diff File
mod - core/classes/MantisEnum.class.php Diff File
mod - core/classes/MantisFilter.class.php Diff File
mod - core/classes/MantisFormattingPlugin.class.php Diff File
mod - core/classes/MantisPlugin.class.php Diff File
mod - core/classes/MantisWikiPlugin.class.php Diff File
mod - core/columns_api.php Diff File
mod - core/csv_api.php Diff File
mod - core/current_user_api.php Diff File
mod - core/custom_function_api.php Diff File
mod - core/database_api.php Diff File
mod - core/error_api.php Diff File
mod - core/event_api.php Diff File
mod - core/excel_api.php Diff File
mod - core/filter_api.php Diff File
mod - core/install_helper_functions_api.php Diff File
mod - core/json_api.php Diff File
mod - core/php_api.php Diff File
mod - core/plugin_api.php Diff File
mod - core/print_api.php Diff File
mod - core/relationship_api.php Diff File
mod - core/relationship_graph_api.php Diff File
mod - core/string_api.php Diff File
mod - core/tag_api.php Diff File
mod - core/url_api.php Diff File
mod - core/user_api.php Diff File
mod - core/user_pref_api.php Diff File
mod - core/utility_api.php Diff File
mod - core/version_api.php Diff File
mod - csv_export.php Diff File
mod - jump_to_bug.php Diff File
mod - login_page.php Diff File
mod - manage_config_email_page.php Diff File
mod - manage_config_work_threshold_page.php Diff File
mod - manage_config_workflow_page.php Diff File
mod - manage_plugin_page.php Diff File
mod - plugins/MantisCoreFormatting/pages/config.php Diff File
mod - plugins/MantisCoreFormatting/pages/config_edit.php Diff File
mod - plugins/MantisGraph/core/graph_api.php Diff File
mod - plugins/MantisGraph/pages/config.php Diff File
mod - plugins/MantisGraph/pages/config_edit.php Diff File
mod - plugins/XmlImportExport/ImportXml.php Diff File
mod - plugins/XmlImportExport/ImportXml/Issue.php Diff File
mod - roadmap_page.php Diff File
mod - scripts/send_emails.php Diff File
mod - tests/AllTests.php Diff File
mod - tests/Mantis/EnumTest.php Diff File
mod - tests/Mantis/HelperTest.php Diff File
mod - tests/Mantis/StringTest.php Diff File
mod - tests/TestConfig.php Diff File
mod - tests/soap/AllTests.php Diff File
mod - tests/soap/AttachmentTest.php Diff File
mod - tests/soap/CategoryTest.php Diff File
mod - tests/soap/CompressionTest.php Diff File
mod - tests/soap/EnumTest.php Diff File
mod - tests/soap/FilterTest.php Diff File
mod - tests/soap/IssueAddTest.php Diff File
mod - tests/soap/IssueHistoryTest.php Diff File
mod - tests/soap/IssueMonitorTest.php Diff File
mod - tests/soap/IssueNoteTest.php Diff File
mod - tests/soap/IssueUpdateTest.php Diff File
mod - tests/soap/LoginTest.php Diff File
mod - tests/soap/ProjectTest.php Diff File
mod - tests/soap/RelationshipTest.php Diff File
mod - tests/soap/SoapBase.php Diff File
mod - tests/soap/TagTest.php Diff File
mod - tests/soap/UserTest.php Diff File
mod - tests/soap/VersionTest.php Diff File
mod - tests/test_config_get_set.php Diff File
mod - view_all_inc.php Diff File

master dc8ee9f8

2014-05-28 14:33

Paul Richards


Details Diff
Ensure Mantis source passes PHPDoc Validation
mod - adm_config_delete.php Diff File
mod - adm_config_report.php Diff File
mod - adm_config_set.php Diff File
mod - adm_permissions_report.php Diff File
mod - admin/check/index.php Diff File
mod - admin/schema.php Diff File
mod - admin/test_icons.php Diff File
mod - admin/test_langs.php Diff File
mod - admin/upgrade_unattended.php Diff File
mod - api/soap/mc_account_api.php Diff File
mod - api/soap/mc_api.php Diff File
mod - api/soap/mc_config_api.php Diff File
mod - api/soap/mc_custom_field_api.php Diff File
mod - api/soap/mc_file_api.php Diff File
mod - api/soap/mc_filter_api.php Diff File
mod - api/soap/mc_issue_api.php Diff File
mod - api/soap/mc_issue_attachment_api.php Diff File
mod - api/soap/mc_project_api.php Diff File
mod - api/soap/mc_project_attachment_api.php Diff File
mod - api/soap/mc_tag_api.php Diff File
mod - api/soap/mc_user_profile_api.php Diff File
mod - bug_actiongroup_add_note_inc.php Diff File
mod - bug_update_page.php Diff File
mod - core.php Diff File
mod - core/bug_api.php Diff File
mod - core/cfdefs/cfdef_standard.php Diff File
mod - core/classes/MantisColumn.class.php Diff File
mod - core/classes/MantisCorePlugin.class.php Diff File
mod - core/classes/MantisCoreWikiPlugin.class.php Diff File
mod - core/classes/MantisEnum.class.php Diff File
mod - core/classes/MantisFilter.class.php Diff File
mod - core/classes/MantisFormattingPlugin.class.php Diff File
mod - core/classes/MantisPlugin.class.php Diff File
mod - core/classes/MantisWikiPlugin.class.php Diff File
mod - core/columns_api.php Diff File
mod - core/csv_api.php Diff File
mod - core/current_user_api.php Diff File
mod - core/custom_function_api.php Diff File
mod - core/database_api.php Diff File
mod - core/error_api.php Diff File
mod - core/event_api.php Diff File
mod - core/excel_api.php Diff File
mod - core/filter_api.php Diff File
mod - core/install_helper_functions_api.php Diff File
mod - core/json_api.php Diff File
mod - core/php_api.php Diff File
mod - core/plugin_api.php Diff File
mod - core/print_api.php Diff File
mod - core/relationship_api.php Diff File
mod - core/relationship_graph_api.php Diff File
mod - core/string_api.php Diff File
mod - core/tag_api.php Diff File
mod - core/url_api.php Diff File
mod - core/user_api.php Diff File
mod - core/user_pref_api.php Diff File
mod - core/utility_api.php Diff File
mod - core/version_api.php Diff File
mod - csv_export.php Diff File
mod - jump_to_bug.php Diff File
mod - login_page.php Diff File
mod - manage_config_email_page.php Diff File
mod - manage_config_work_threshold_page.php Diff File
mod - manage_config_workflow_page.php Diff File
mod - manage_plugin_page.php Diff File
mod - plugins/MantisCoreFormatting/pages/config.php Diff File
mod - plugins/MantisCoreFormatting/pages/config_edit.php Diff File
mod - plugins/MantisGraph/core/graph_api.php Diff File
mod - plugins/MantisGraph/pages/config.php Diff File
mod - plugins/MantisGraph/pages/config_edit.php Diff File
mod - plugins/XmlImportExport/ImportXml.php Diff File
mod - plugins/XmlImportExport/ImportXml/Issue.php Diff File
mod - roadmap_page.php Diff File
mod - scripts/send_emails.php Diff File
mod - tests/AllTests.php Diff File
mod - tests/Mantis/EnumTest.php Diff File
mod - tests/Mantis/HelperTest.php Diff File
mod - tests/Mantis/StringTest.php Diff File
mod - tests/TestConfig.php Diff File
mod - tests/soap/AllTests.php Diff File
mod - tests/soap/AttachmentTest.php Diff File
mod - tests/soap/CategoryTest.php Diff File
mod - tests/soap/CompressionTest.php Diff File
mod - tests/soap/EnumTest.php Diff File
mod - tests/soap/FilterTest.php Diff File
mod - tests/soap/IssueAddTest.php Diff File
mod - tests/soap/IssueHistoryTest.php Diff File
mod - tests/soap/IssueMonitorTest.php Diff File
mod - tests/soap/IssueNoteTest.php Diff File
mod - tests/soap/IssueUpdateTest.php Diff File
mod - tests/soap/LoginTest.php Diff File
mod - tests/soap/ProjectTest.php Diff File
mod - tests/soap/RelationshipTest.php Diff File
mod - tests/soap/SoapBase.php Diff File
mod - tests/soap/TagTest.php Diff File
mod - tests/soap/UserTest.php Diff File
mod - tests/soap/VersionTest.php Diff File
mod - tests/test_config_get_set.php Diff File
mod - view_all_inc.php Diff File

master 45b2de86

2014-05-27 11:25

grangeway


Details Diff
Merge pull request #197 from grangeway/phpdoc2

PHPdoc Validation Improvements
mod - core/bugnote_api.php Diff File
mod - core/category_api.php Diff File
mod - core/cfdefs/cfdef_standard.php Diff File
mod - core/classes/MantisColumn.class.php Diff File
mod - core/classes/MantisCorePlugin.class.php Diff File
mod - core/classes/MantisCoreWikiPlugin.class.php Diff File
mod - core/classes/MantisFilter.class.php Diff File
mod - core/classes/MantisFormattingPlugin.class.php Diff File
mod - core/classes/MantisPlugin.class.php Diff File
mod - core/classes/MantisWikiPlugin.class.php Diff File
mod - core/columns_api.php Diff File
mod - core/config_api.php Diff File
mod - core/file_api.php Diff File
mod - core/filter_api.php Diff File
mod - core/form_api.php Diff File
mod - core/html_api.php Diff File
mod - core/plugin_api.php Diff File
mod - core/project_api.php Diff File
mod - core/session_api.php Diff File
mod - core/string_api.php Diff File
mod - core/summary_api.php Diff File
mod - core/tag_api.php Diff File
mod - core/version_api.php Diff File

master 3bfc2d3f

2014-05-27 11:05

grangeway


Details Diff
Merge pull request #193 from grangeway/16955

Fix: 0016955: Uncaught Error: Syntax error, unrecognized expression: [:...
Affected Issues
0016955
mod - javascript/bugFilter.js Diff File

master fbcb0faf

2014-05-27 11:01

Paul Richards


Details Diff
PHPdoc Validation Improvements

Once our php doc validates successfully across the code base,
it would be good to start seeing us review and improve the content
mod - core/bugnote_api.php Diff File
mod - core/category_api.php Diff File
mod - core/cfdefs/cfdef_standard.php Diff File
mod - core/classes/MantisColumn.class.php Diff File
mod - core/classes/MantisCorePlugin.class.php Diff File
mod - core/classes/MantisCoreWikiPlugin.class.php Diff File
mod - core/classes/MantisFilter.class.php Diff File
mod - core/classes/MantisFormattingPlugin.class.php Diff File
mod - core/classes/MantisPlugin.class.php Diff File
mod - core/classes/MantisWikiPlugin.class.php Diff File
mod - core/columns_api.php Diff File
mod - core/config_api.php Diff File
mod - core/file_api.php Diff File
mod - core/filter_api.php Diff File
mod - core/form_api.php Diff File
mod - core/html_api.php Diff File
mod - core/plugin_api.php Diff File
mod - core/project_api.php Diff File
mod - core/session_api.php Diff File
mod - core/string_api.php Diff File
mod - core/summary_api.php Diff File
mod - core/tag_api.php Diff File
mod - core/version_api.php Diff File

master 13c20964

2014-05-27 00:50

Paul Richards


Details Diff
Fix: Email processing occurs in the wrong order.

The purpose of the email queue is to allow batch processing emails to speed up web page response.

Our aim should be to ensure the email table is as close to empty at all times,
(if cron jobs are not used, we try to clear the table at the end of the web page request)

Therefore:

a) There's no need to define a custom sort order for the table. In the ideal world, where the table is empty, the sort order is going to be irrelevant

b) Emails should be sent in the order they are generated. Therefore, they should always be processed in ASCending order.

After this, I plan on looking at how we handle emails that previously errored to ensure that users are notified of problems in some way, and we avoid performance issues, as email troubleshooting is one of our more popular support issues with end users
mod - core/email_queue_api.php Diff File

master e2e27cec

2014-05-27 00:08

grangeway


Details Diff
Merge pull request 0000194 from grangeway/typo

Fix duplicate ;
mod - api/soap/mc_project_api.php Diff File
mod - bugnote_view_inc.php Diff File
mod - core/file_api.php Diff File
mod - file_download.php Diff File

master 4a0eea8e

2014-05-26 23:52

Paul Richards


Details Diff
Fix duplicate ;
mod - api/soap/mc_project_api.php Diff File
mod - bugnote_view_inc.php Diff File
mod - core/file_api.php Diff File
mod - file_download.php Diff File

master 41042ba0

2014-05-26 22:33

Damien Regad


Details Diff
Remove "with MantisBT" from ERROR_PLUGIN_NOT_REGISTERED
mod - lang/strings_english.txt Diff File

master c76f2dbc

2014-05-26 16:37

Paul Richards


Details Diff
Fix: 0016955: Uncaught Error: Syntax error, unrecognized expression: [:input Affected Issues
0016955
mod - javascript/bugFilter.js Diff File

master 2b627313

2014-05-26 13:09

Paul Richards


Details Diff
Fix: 0017385: Removal of copy_fields utility

This is a follow up pull request following the mantisbt-dev mailing list discussion in april regarding removing the copy_field's utility.
rm - admin/copy_field.php Diff
mod - admin/system_utils.php Diff File
 First  Prev  1 2 3 ... 70 ... 140 ... 210 ... 280 ... 296 297 298 299 300 301 302 ... 350 ... 420 ... 490 ... 560 ... 630 ... 700 ... 746 747 748  Next  Last