Changesets: MantisBT

master 65965bbf

2014-01-27 05:22

vboctor


Details Diff
Fixes 0016849: Drop FTP support. Affected Issues
0016849
mod - api/soap/mc_file_api.php Diff File
mod - config_defaults_inc.php Diff File
mod - core/bug_api.php Diff File
mod - core/config_api.php Diff File
mod - core/constant_inc.php Diff File
mod - core/file_api.php Diff File
mod - core/obsolete.php Diff File
mod - core/print_api.php Diff File
mod - docbook/Admin_Guide/en-US/Configuration.xml Diff File
mod - docbook/Admin_Guide/en-US/Page_Descriptions.xml Diff File
mod - file_download.php Diff File
mod - lang/strings_english.txt Diff File
mod - proj_doc_update.php Diff File

master 50d235ad

2014-01-27 01:13

dregad


Details Diff
Revert of "Use PHP's own email validation routines"

This partially reverts commit 4235a08618da1d66b44337867b72f4fdea633dc0
which introduced a regression.

The PHP email validation rejects valid e-mail addresses with the form
user@hostname [1]. The PHPMailer accepts these, and furthermore it makes
sense to rely on the validation routine provided by the library we use
to send our emails.

[1] https://bugs.php.net/bug.php?id=49576
mod - core/email_api.php Diff File

master 86d30ed0

2014-01-27 01:05

dregad


Details Diff
Whitespace [skip ci]

Remove blank lines added in a6a3a136bd05df52f1ea4dd906230ac9ae9d9cad
mod - core/print_api.php Diff File

master 840c1c1f

2014-01-26 10:48

Paul Richards


Details Diff
Code Guidelines: Fix naming of variable '$result' to $t_result
mod - adm_config_report.php Diff File
mod - admin/copy_field.php Diff File
mod - admin/install.php Diff File
mod - admin/test_email.php Diff File
mod - admin/test_langs.php Diff File
mod - admin/upgrade_unattended.php Diff File
mod - api/soap/mc_api.php Diff File
mod - api/soap/mc_file_api.php Diff File
mod - api/soap/mc_issue_api.php Diff File
mod - api/soap/mc_project_api.php Diff File
mod - bug_reminder.php Diff File
mod - core/authentication_api.php Diff File
mod - core/bug_api.php Diff File
mod - core/bugnote_api.php Diff File
mod - core/category_api.php Diff File
mod - core/config_api.php Diff File
mod - core/custom_field_api.php Diff File
mod - core/database_api.php Diff File
mod - core/email_api.php Diff File
mod - core/email_queue_api.php Diff File
mod - core/error_api.php Diff File
mod - core/file_api.php Diff File
mod - core/filter_api.php Diff File
mod - core/helper_api.php Diff File
mod - core/history_api.php Diff File
mod - core/news_api.php Diff File
mod - core/print_api.php Diff File
mod - core/profile_api.php Diff File
mod - core/project_api.php Diff File
mod - core/project_hierarchy_api.php Diff File
mod - core/relationship_api.php Diff File
mod - core/sponsorship_api.php Diff File
mod - core/summary_api.php Diff File
mod - core/tag_api.php Diff File
mod - core/user_api.php Diff File
mod - core/user_pref_api.php Diff File
mod - core/version_api.php Diff File
mod - excel_xml_export.php Diff File
mod - file_download.php Diff File
mod - lost_pwd.php Diff File
mod - manage_user_proj_delete.php Diff File
mod - manage_user_prune.php Diff File
mod - manage_user_update.php Diff File
mod - plugins/MantisGraph/core/graph_api.php Diff File
mod - plugins/XmlImportExport/XmlImportExport.php Diff File
mod - print_all_bug_options_inc.php Diff File
mod - print_all_bug_options_reset.php Diff File
mod - print_all_bug_options_update.php Diff File
mod - print_all_bug_page.php Diff File
mod - print_all_bug_page_word.php Diff File
mod - print_bugnote_inc.php Diff File
mod - proj_doc_delete.php Diff File
mod - proj_doc_edit_page.php Diff File
mod - proj_doc_page.php Diff File
mod - proj_doc_update.php Diff File
mod - summary_page.php Diff File

master 3a8474fd

2014-01-26 02:11

Paul Richards


Details Diff
Remove Unused Variables from Mantis Core
mod - bug_actiongroup_update_severity_inc.php Diff File
mod - core/bug_api.php Diff File
mod - core/bug_group_action_api.php Diff File
mod - core/bugnote_api.php Diff File
mod - core/collapse_api.php Diff File
mod - core/columns_api.php Diff File
mod - core/config_api.php Diff File
mod - core/current_user_api.php Diff File
mod - core/custom_field_api.php Diff File
mod - core/database_api.php Diff File
mod - core/error_api.php Diff File
mod - core/file_api.php Diff File
mod - core/filter_api.php Diff File
mod - core/helper_api.php Diff File
mod - core/history_api.php Diff File
mod - core/html_api.php Diff File
mod - core/install_helper_functions_api.php Diff File
mod - core/print_api.php Diff File
mod - core/profile_api.php Diff File
mod - core/project_api.php Diff File
mod - core/relationship_api.php Diff File
mod - core/session_api.php Diff File
mod - core/string_api.php Diff File
mod - core/summary_api.php Diff File
mod - core/tag_api.php Diff File
mod - core/user_api.php Diff File
mod - core/utility_api.php Diff File
mod - manage_config_email_page.php Diff File
mod - print_all_bug_options_inc.php Diff File

master 56ed4e56

2014-01-24 13:57

dregad


Details Diff
Travis: remove notification to mantisbt-cvs list [skip ci]
mod - .travis.yml Diff File

master-1.2.x cd4847a5

2014-01-24 13:57

dregad


Details Diff
Travis: remove notification to mantisbt-cvs list [skip ci]
mod - .travis.yml Diff File

master 0cdb1487

2014-01-24 13:08

Paul Richards


Details Diff
Remove unused variables from current_user_get_bug_filter
mod - core/current_user_api.php Diff File

master 518470e4

2014-01-24 12:52

Paul Richards


Details Diff
PHPdoc Update
mod - core/current_user_api.php Diff File

master-1.2.x b72fdaeb

2014-01-24 10:07

siebrand


Details Diff
Localisation updates from https://translatewiki.net.
mod - lang/strings_belarusian_tarask.txt Diff File
mod - lang/strings_korean.txt Diff File
mod - lang/strings_macedonian.txt Diff File
mod - plugins/MantisGraph/lang/strings_belarusian_tarask.txt Diff File

master a6a3a136

2014-01-21 05:58

vboctor


Details Diff
Revert "Fixes 0016833: Remove show_avatar_threshold config option."

This reverts commit 3715bfade978933f0c99fdf1b1f4304f607afc2c.
Affected Issues
0016833
mod - config_defaults_inc.php Diff File
mod - core/obsolete.php Diff File
mod - core/print_api.php Diff File
mod - docbook/Admin_Guide/en-US/Configuration.xml Diff File

master 4ef130e5

2014-01-18 16:16

vboctor


Details Diff
Fix layout for bug note avatar and move it to the left side

The text next to the avatar in the bug notes was being pushed under the avatar. This change fixes that and moves the avatar to the left of the text which is more standard with other conventions. As we add avatars elsewhere in MantisBT, they will also be on the left side.
mod - bugnote_view_inc.php Diff File
mod - css/default.css Diff File

master ac2943d5

2014-01-18 15:16

vboctor


Details Diff
Fix formatting of 'upload files' label on bug_report_page.
mod - bug_report_page.php Diff File

master 896f775f

2014-01-18 04:47

dregad


Details Diff
Prevent plugin pages access when upgrade pending

If a plugin's code has been upgraded, but the schema is still on the old
version, the plugin is effectively disabled (i.e. its entry points are
not displayed). However, it was still possible to access individual
pages directly, which could lead to errors.

This commit adds an extra check in plugin.php which triggers an error
when the plugin needs to be upgraded.

Fixes 0016706
Affected Issues
0016706
mod - plugin.php Diff File
mod - lang/strings_english.txt Diff File
mod - core/constant_inc.php Diff File

master-1.2.x dae99d0f

2014-01-18 04:47

dregad


Details Diff
Prevent plugin pages access when upgrade pending

If a plugin's code has been upgraded, but the schema is still on the old
version, the plugin is effectively disabled (i.e. its entry points are
not displayed). However, it was still possible to access individual
pages directly, which could lead to errors.

This commit adds an extra check in plugin.php which triggers an error
when the plugin needs to be upgraded.

Fixes 0016706
Affected Issues
0016706
mod - plugin.php Diff File
mod - lang/strings_english.txt Diff File
mod - core/constant_inc.php Diff File

master 7d768276

2014-01-17 11:24

Paul Richards

Committer: dregad


Details Diff
Fix CVE-2014-1609: SQL injection vulnerabilities

Additional cases of db_query() instead of db_query_bound() usage,
potentially allowing SQL injection attacks due to unsanitized use of
parameters within the query.

This includes vboctor's 2 comments.

Fixes 0016880

Signed-off-by: Damien Regad <dregad@mantisbt.org>
Affected Issues
0016880
mod - admin/db_stats.php Diff File
mod - api/soap/mc_project_api.php Diff File
mod - core/news_api.php Diff File
mod - core/summary_api.php Diff File
mod - plugins/MantisGraph/core/graph_api.php Diff File
mod - plugins/MantisGraph/pages/bug_graph_bycategory.php Diff File
mod - plugins/MantisGraph/pages/bug_graph_bystatus.php Diff File
mod - proj_doc_page.php Diff File

master 3be86ce3

2014-01-17 11:24

Paul Richards

Committer: dregad


Details Diff
Fix CVE-2014-1608: mc_issue_attachment_get SQL injection

Use of db_query() instead of db_query_bound() allowed SQL injection
attacks due to unsanitized use of parameters within the query when using
the SOAP API mc_issue_attachment_get.

This issue was reported by e-mail by Andrea Barisani from oCERT, on
behalf of Martin Herfurt <martin.herfurt@nruns.com>, a security
researcher at n.runs professionals GmbH, who discovered the issue
during an audit at a customer's site.

Fixes 0016879

Signed-off-by: Damien Regad <dregad@mantisbt.org>
Affected Issues
0016879
mod - api/soap/mc_file_api.php Diff File

master-1.2.x 7efe0175

2014-01-17 11:24

Paul Richards

Committer: dregad


Details Diff
Fix CVE-2014-1609: SQL injection vulnerabilities

Additional cases of db_query() instead of db_query_bound() usage,
potentially allowing SQL injection attacks due to unsanitized use of
parameters within the query.

This includes vboctor's 2 comments.

Fixes 0016880

Signed-off-by: Damien Regad <dregad@mantisbt.org>

Conflicts:
admin/db_stats.php
plugins/MantisGraph/pages/bug_graph_bycategory.php
plugins/MantisGraph/pages/bug_graph_bystatus.php
proj_doc_page.php
Affected Issues
0016880
mod - admin/db_stats.php Diff File
mod - api/soap/mc_project_api.php Diff File
mod - core/news_api.php Diff File
mod - core/summary_api.php Diff File
mod - plugins/MantisGraph/core/graph_api.php Diff File
mod - plugins/MantisGraph/pages/bug_graph_bycategory.php Diff File
mod - plugins/MantisGraph/pages/bug_graph_bystatus.php Diff File
mod - proj_doc_page.php Diff File

master-1.2.x 00b4c170

2014-01-17 11:24

Paul Richards

Committer: dregad


Details Diff
Fix CVE-2014-1608: mc_issue_attachment_get SQL injection

Use of db_query() instead of db_query_bound() allowed SQL injection
attacks due to unsanitized use of parameters within the query when using
the SOAP API mc_issue_attachment_get.

This issue was reported by e-mail by Andrea Barisani from oCERT, on
behalf of Martin Herfurt <martin.herfurt@nruns.com>, a security
researcher at n.runs professionals GmbH, who discovered the issue
during an audit at a customer's site.

Fixes 0016879

Signed-off-by: Damien Regad <dregad@mantisbt.org>

Conflicts:
api/soap/mc_file_api.php
Affected Issues
0016879
mod - api/soap/mc_file_api.php Diff File

master f4521251

2014-01-17 11:18

Paul Richards

Committer: dregad


Details Diff
When logging to page, send emails early

This allows logs to include all email log entries

Original code from https://github.com/mantisbt/mantisbt/pull/113
Signed-off-by: Damien Regad <dregad@mantisbt.org>
mod - core/logging_api.php Diff File

master d233a9da

2014-01-17 11:18

Paul Richards

Committer: dregad


Details Diff
Fix SOAP API not sending e-mails

Fixes regression introduced by cea405ccf228fd2c6ac694574a74e87396b14f1f.
Emails are now sent at the end of the SOAP call.

Fixes 0017458

Original code form https://github.com/mantisbt/mantisbt/pull/113
Signed-off-by: Damien Regad <dregad@mantisbt.org>
Affected Issues
0017458
mod - api/soap/mantisconnect.php Diff File

master 0ee5e937

2014-01-13 08:35

Paul Richards


Details Diff
remove duplicate install_do_nothing
mod - core/install_helper_functions_api.php Diff File

master 124906a3

2014-01-13 08:07

Paul Richards


Details Diff
Port a potential database corruption fix in the installer to 1.x from 2.x branch.

When converting dates, abort if the old value has already been converted to an integer from a database timestamp.
This avoids potentially wiping out dates quietly within the database.
mod - core/install_helper_functions_api.php Diff File

master 03c5a5d1

2014-01-13 07:30

Paul Richards


Details Diff
Replace email_* calls with raw email_generic calls. This is to try and make a shorter patchset in a bit ;) Affected Issues
0019984
mod - api/soap/mc_issue_api.php Diff File
mod - bug_report.php Diff File
mod - bug_update.php Diff File
mod - core/bug_api.php Diff File
mod - core/bugnote_api.php Diff File
mod - core/email_api.php Diff File
mod - core/sponsorship_api.php Diff File

master 3715bfad

2014-01-13 06:21

vboctor


Details Diff
Fixes 0016833: Remove show_avatar_threshold config option. Affected Issues
0016833
mod - config_defaults_inc.php Diff File
mod - core/obsolete.php Diff File
mod - core/print_api.php Diff File
mod - docbook/Admin_Guide/en-US/Configuration.xml Diff File
 First  Prev  1 2 3 ... 80 ... 160 ... 240 ... 315 316 317 318 319 320 321 ... 400 ... 480 ... 560 ... 640 ... 720 ... 753 754 755  Next  Last