Source Control Integration

master 123bdbec 2012-10-03 23:49 dregad Details Diff	Whitespace fixes
	mod - plugins/MantisGraph/pages/bug_graph_page.php	Diff File
master-1.2.x 07ab07ed 2012-10-03 23:49 dregad Details Diff	Whitespace fixes
	mod - manage_plugin_page.php	Diff File
	mod - plugins/MantisGraph/pages/bug_graph_page.php	Diff File
master abd079bc 2012-10-03 22:47 dregad Details Diff	Custom fields names in Excel export were converted to lower case This was not happening in other export functions; the root cause was inconsistent code to output the column headers in the excel API. Function excel_get_titles_row() now relies on column_get_title() to retrieve the custom fields default name, same as standard columns, and in line with CSV export. Fixes 0014772	Affected Issues 0014772
	mod - core/excel_api.php	Diff File
master-1.2.x 2c6a8a4a 2012-10-03 22:47 dregad Details Diff	Custom fields names in Excel export were converted to lower case This was not happening in other export functions; the root cause was inconsistent code to output the column headers in the excel API. Function excel_get_titles_row() now relies on column_get_title() to retrieve the custom fields default name, same as standard columns, and in line with CSV export. Fixes 0014772	Affected Issues 0014772
	mod - core/excel_api.php	Diff File
master ece19746 2012-10-03 22:41 dregad Details Diff	Whitespace fixes
	mod - core/excel_api.php	Diff File
master-1.2.x 4f3c49e8 2012-10-03 22:41 dregad Details Diff	Whitespace fixes
	mod - core/excel_api.php	Diff File
master 0f23864b 2012-10-02 21:15 dregad Details Diff	Use object properties instead of bug_get_field() calls
	mod - bug_change_status_page.php	Diff File
master-1.2.x 791fbd93 2012-10-02 21:15 dregad Details Diff	Use object properties instead of bug_get_field() calls
	mod - bug_change_status_page.php	Diff File
master 1c74849c 2012-10-02 20:45 dregad Details Diff	Improve custom fields error messages Introduce an additional 'Invalid Custom Field property' error message that includes the name(s) of the properties which failed validation when attempting to update the custom field. Note: skip error message number 1305 to maintain forward-compatibility with constants as they are defined in master branch Fixes 0014767	Affected Issues 0014767
	mod - core/constant_inc.php	Diff File
	mod - core/custom_field_api.php	Diff File
	mod - lang/strings_english.txt	Diff File
master-1.2.x d8d3409a 2012-10-02 20:45 dregad Details Diff	Improve custom fields error messages Introduce an additional 'Invalid Custom Field property' error message that includes the name(s) of the properties which failed validation when attempting to update the custom field. Note: skip error message number 1305 to maintain forward-compatibility with constants as they are defined in master branch Fixes 0014767	Affected Issues 0014767
	mod - core/constant_inc.php	Diff File
	mod - core/custom_field_api.php	Diff File
	mod - lang/strings_english.txt	Diff File
master 274f9f13 2012-10-02 04:31 dregad Details Diff	Don't display custom fields from disabled projects in view issues page SQL for ALL_PROJECTS in custom_field_get_linked_ids() function was modified to filter out disabled projects. Thanks to vibe972 who originally submitted a patch for this on Github. Original commit was rewritten due to changes made to the API. Fixes 0014764	Affected Issues 0014764
	mod - core/custom_field_api.php	Diff File
master-1.2.x 24f39711 2012-10-02 04:31 dregad Details Diff	Don't display custom fields from disabled projects in view issues page SQL for ALL_PROJECTS in custom_field_get_linked_ids() function was modified to filter out disabled projects. Thanks to vibe972 who originally submitted a patch for this on Github. Original commit was rewritten due to changes made to the API. Fixes 0014764	Affected Issues 0014764
	mod - core/custom_field_api.php	Diff File
master da782868 2012-10-02 04:28 dregad Details Diff	Custom fields api - optimize and use db_query_bound Replaces all uses of db_query() by db_query_bound() in the API. Some SQL queries were rewritten in a cleaner and more efficient way. custom_field_update() was greatly simplified by use of a foreach loop instead of nearly identical code blocks for processing of each field to update. Fixes 0014765, 0014766	Affected Issues 0014765, 0014766
	mod - core/custom_field_api.php	Diff File
master-1.2.x 6e53cd26 2012-10-02 04:28 dregad Details Diff	Custom fields api - optimize and use db_query_bound Replaces all uses of db_query() by db_query_bound() in the API. Some SQL queries were rewritten in a cleaner and more efficient way. custom_field_update() was greatly simplified by use of a foreach loop instead of nearly identical code blocks for processing of each field to update. Fixes 0014765, 0014766	Affected Issues 0014765, 0014766
	mod - core/custom_field_api.php	Diff File
master-1.2.x 2157f62c 2012-10-02 02:19 siebrand Details Diff	Localisation updates from http://translatewiki.net.
	mod - lang/strings_arabic.txt	Diff File
	mod - lang/strings_belarusian_tarask.txt	Diff File
	mod - lang/strings_breton.txt	Diff File
	mod - lang/strings_chinese_simplified.txt	Diff File
	mod - lang/strings_chinese_traditional.txt	Diff File
	mod - lang/strings_dutch.txt	Diff File
	mod - lang/strings_french.txt	Diff File
	mod - lang/strings_galician.txt	Diff File
	mod - lang/strings_german.txt	Diff File
	mod - lang/strings_italian.txt	Diff File
	mod - lang/strings_japanese.txt	Diff File
	mod - lang/strings_macedonian.txt	Diff File
	mod - lang/strings_norwegian_bokmal.txt	Diff File
	mod - lang/strings_polish.txt	Diff File
	mod - lang/strings_portuguese_standard.txt	Diff File
	mod - lang/strings_serbian.txt	Diff File
	mod - lang/strings_serbian_latin.txt	Diff File
	mod - lang/strings_spanish.txt	Diff File
	mod - lang/strings_swissgerman.txt	Diff File
	mod - plugins/MantisCoreFormatting/lang/strings_belarusian_tarask.txt	Diff File
	mod - plugins/MantisCoreFormatting/lang/strings_chinese_simplified.txt	Diff File
	mod - plugins/MantisCoreFormatting/lang/strings_chinese_traditional.txt	Diff File
	mod - plugins/MantisCoreFormatting/lang/strings_japanese.txt	Diff File
	mod - plugins/MantisCoreFormatting/lang/strings_norwegian_bokmal.txt	Diff File
	mod - plugins/MantisCoreFormatting/lang/strings_serbian.txt	Diff File
	mod - plugins/MantisCoreFormatting/lang/strings_serbian_latin.txt	Diff File
	mod - plugins/MantisGraph/lang/strings_belarusian_tarask.txt	Diff File
	mod - plugins/MantisGraph/lang/strings_chinese_simplified.txt	Diff File
	mod - plugins/MantisGraph/lang/strings_chinese_traditional.txt	Diff File
	mod - plugins/MantisGraph/lang/strings_japanese.txt	Diff File
	mod - plugins/MantisGraph/lang/strings_norwegian_bokmal.txt	Diff File
	mod - plugins/MantisGraph/lang/strings_serbian.txt	Diff File
	mod - plugins/MantisGraph/lang/strings_serbian_latin.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_arabic.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_belarusian_tarask.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_breton.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_chinese_simplified.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_chinese_traditional.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_french.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_galician.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_german.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_italian.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_japanese.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_macedonian.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_norwegian_bokmal.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_polish.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_portuguese_standard.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_serbian.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_serbian_latin.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_spanish.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_swissgerman.txt	Diff File
master 935c106f 2012-10-01 22:56 dregad Details Diff	Fixes 0014756: mismatched types passed on to check_selected() When trying to report an issue in a setup having subprojects, and no specific project is selected (current project = 'All projects'), an error is triggered in check_selected() due to mismatched types. Statically casting the project_id as string to solve the problem. Thanks to phyllisl for detecting and proposing a solution to this issue.	Affected Issues 0014756
	mod - core/print_api.php	Diff File
master 136cb85c 2012-10-01 22:56 dregad Details Diff	Whitespace and coding guidelines fixes
	mod - core/print_api.php	Diff File
master 2856c64e 2012-10-01 22:28 dregad Details Diff	Fix 0014757: Header text overlaps bottom div border Happened in manage_proj_edit_page.php when there were no subprojects for the project being edited. Added an else clause and an empty 'br' div to clear the float so that the surrounding div flows properly including the h2 element.	Affected Issues 0014757
	mod - manage_proj_edit_page.php	Diff File
master-2.0.x 70ad551b 2012-09-29 04:07 Paul Richards Details Diff	Store mantis config settings as an object instead of hundreds of global variables
	mod - admin/install.php	Diff File
	mod - config_defaults_inc.php	Diff File
	mod - core.php	Diff File
	mod - core/config_api.php	Diff File
	mod - core/session_api.php	Diff File
master 756a944e 2012-09-26 15:04 Bill Stidham Committer: Damien Regad Details Diff	Fix issue in tag api with odbc_mssql driver This branch of code was put into place to handle a deficiency in the odbc_mssql driver that doesn't allow for bound subqueries. This is not needed for the other mssql drivers, yet using db_is_mssql() returns true for all mssql drivers so code is indiscriminately executed for other drivers. $t_params[] init was changed because it only needs to be set once. It is needed for the query in the mssql condition block for the first query only to grab the list of tags that aren't specific to this bug. Afterwards in the second query, $t_params needs to be null or it results in the database returning an error due to no '?' replacements. Therefore, after running the first query, we need to set this to null. If the condition fails and the dbtype is not mssql (or 'odbc_mssql') then $t_params is already set. Note: the multiple query setup in the "true" condition is a really bad way to do this. I'm not going to mess with it, however, since the tag count probably won't get too high in any general scenario. Fixes 0014774 Signed-off-by: Damien Regad <damien.regad@merckgroup.com> Note, this was simply checked for syntax errors and compliance with coding guidelines as I don't have access to an MSSQL setup.	Affected Issues 0014774
	mod - core/tag_api.php	Diff File
master-1.2.x 32ba1160 2012-09-26 15:04 Bill Stidham Committer: Damien Regad Details Diff	Fix issue in tag api with odbc_mssql driver This branch of code was put into place to handle a deficiency in the odbc_mssql driver that doesn't allow for bound subqueries. This is not needed for the other mssql drivers, yet using db_is_mssql() returns true for all mssql drivers so code is indiscriminately executed for other drivers. $t_params[] init was changed because it only needs to be set once. It is needed for the query in the mssql condition block for the first query only to grab the list of tags that aren't specific to this bug. Afterwards in the second query, $t_params needs to be null or it results in the database returning an error due to no '?' replacements. Therefore, after running the first query, we need to set this to null. If the condition fails and the dbtype is not mssql (or 'odbc_mssql') then $t_params is already set. Note: the multiple query setup in the "true" condition is a really bad way to do this. I'm not going to mess with it, however, since the tag count probably won't get too high in any general scenario. Fixes 0014774 Signed-off-by: Damien Regad <damien.regad@merckgroup.com> Note, this was simply checked for syntax errors and compliance with coding guidelines as I don't have access to an MSSQL setup.	Affected Issues 0014774
	mod - core/tag_api.php	Diff File
master 65793390 2012-09-26 13:07 dregad Details Diff	Fix 0014748: XML Parsing Error in print_all_bug_page_word.php When printing a bug with inline image attachments, an XML parsing error was triggered due to lack of html encoding of the image's URL.	Affected Issues 0014748
	mod - print_all_bug_page_word.php	Diff File
master 999854e5 2012-09-26 05:38 dregad Details Diff	Streamline $g_path definition Simplify the code by replacing uses of ternary operator with switch statement and removing unnecessary variable assignments. We now also cover the (admittedly unlikely) scenario where the temporary path is empty, to ensure we always generate a valid path that includes a trailing '/'.
	mod - config_defaults_inc.php	Diff File
master-1.2.x 78821cbb 2012-09-26 05:38 dregad Details Diff	Streamline $g_path definition Simplify the code by replacing uses of ternary operator with switch statement and removing unnecessary variable assignments. We now also cover the (admittedly unlikely) scenario where the temporary path is empty, to ensure we always generate a valid path that includes a trailing '/'.
	mod - config_defaults_inc.php	Diff File
master 2b5d6621 2012-09-26 05:20 dregad Details Diff	Remove invalid chars from displayed string per XML specification Strict XHTML requires that data comply with XML 1.0 specification [1], which only allows a subset of the UTF-8 charset. Function string_html_specialchars() has been modified to remove from the string to print, any character which is not in the defined range Char ::= #x9 \| #xA \| #xD \| [#x20-#xD7FF] \| [#xE000-#xFFFD] \| [#x10000-#x10FFFF] Fixes 0014744 [1] http://www.w3.org/TR/xml/	Affected Issues 0014744
	mod - core/string_api.php	Diff File

Changesets: MantisBT