Changesets: MantisBT

master-1.2.x 5b491868

2012-09-14 22:32

rombert


Details Diff
Fix 0006809: 0005598: Using an 'Or' filter logic Affected Issues
0006809
mod - config_filter_defaults_inc.php Diff File
mod - core/constant_inc.php Diff File
mod - core/filter_api.php Diff File
mod - lang/strings_english.txt Diff File
mod - view_all_set.php Diff File

master 9b39286b

2012-09-14 21:10

rombert


Details Diff
Allow selecting any user with privileges when filtering by bug note
reporter

Fix based on patch attached by frodgers at
http://www.mantisbt.org/bugs/view.php?id=9725 .

Fixes 0009725: Filter on "Note By" by a reporter
Affected Issues
0009725
mod - core/filter_api.php Diff File
mod - core/print_api.php Diff File

master-1.2.x b3d05226

2012-09-14 21:10

rombert


Details Diff
Allow selecting any user with privileges when filtering by bug note
reporter

Fix based on patch attached by frodgers at
http://www.mantisbt.org/bugs/view.php?id=9725 .

Fixes 0009725: Filter on "Note By" by a reporter
Affected Issues
0009725
mod - core/filter_api.php Diff File
mod - core/print_api.php Diff File

master 42c982dc

2012-09-12 23:59

dregad


Details Diff
Last updated date not bumped when group-changing custom field

When updating a custom field via selection in view_all_bug_page.php and
subsequent submit on bug_actiongroup_page.php, the custom field and
history are properly updated, but the issue's last updated date was not
bumped.

Fixes 0014706
Affected Issues
0014706
mod - bug_actiongroup.php Diff File

master-1.2.x 1a2f2ab2

2012-09-12 23:59

dregad


Details Diff
Last updated date not bumped when group-changing custom field

When updating a custom field via selection in view_all_bug_page.php and
subsequent submit on bug_actiongroup_page.php, the custom field and
history are properly updated, but the issue's last updated date was not
bumped.

Fixes 0014706
Affected Issues
0014706
mod - bug_actiongroup.php Diff File

master-1.2.x 9cb272a3

2012-09-12 22:20

dregad


Details Diff
Documentation: revised admin guide Custom Functions section

Includes a couple comments corrections in custom_function_api.php.
mod - core/custom_function_api.php Diff File
mod - docbook/administration_guide/en/customizing_mantis.sgml Diff File

master a0e4b9bc

2012-09-12 22:20

dregad


Details Diff
Documentation: revised admin guide Custom Functions section

Includes a couple comments corrections in custom_function_api.php.
mod - core/custom_function_api.php Diff File
mod - docbook/Admin_Guide/en-US/Customizing.xml Diff File

master 2d815440

2012-09-12 04:48

dregad


Details Diff
Don't send email notices for a bug to which users have no access

Prior to this, users without viewer access to a bug could potentially
receive email notifications for it. This could happen in case of
permissions changes, or if an issue is moved to another project with
different access rights.

Added an access level check to exclude users who don't have at least
VIEWER privilege to the bug.

Fixes 0014704
Affected Issues
0014704
mod - core/email_api.php Diff File

master-1.2.x 2cc83ca9

2012-09-12 04:48

dregad


Details Diff
Don't send email notices for a bug to which users have no access

Prior to this, users without viewer access to a bug could potentially
receive email notifications for it. This could happen in case of
permissions changes, or if an issue is moved to another project with
different access rights.

Added an access level check to exclude users who don't have at least
VIEWER privilege to the bug.

Fixes 0014704
Affected Issues
0014704
mod - core/email_api.php Diff File

master cfa022bc

2012-09-10 01:56

dregad


Details Diff
User with access to single project defaults to it, not all projects

Since 1.2, if a user has access to only one project, the project
selection box at top right isn't shown. This was causing issues as new
users accounts have 'All projects' as their default:

- user can't report issues (no link for all projects)
- categories displayed are prefixed with [project]

Until this commit, users had to define their (single) project as default
using preferences to work around the problem; this is no longer needed.

Function html_login_info() now sets the current project as appropriate
if user has only access to a single one, and also defines that as the
default.

The account preferences page has also been modified to only include 'All
projects' in the selection list when user has more than one project
available.

Fixes 0009826, 0014268
Affected Issues
0009826, 0014268, 0016337
mod - account_prefs_inc.php Diff File
mod - core/html_api.php Diff File

master-1.2.x b1a1bbae

2012-09-10 01:56

dregad


Details Diff
User with access to single project defaults to it, not all projects

Since 1.2, if a user has access to only one project, the project
selection box at top right isn't shown. This was causing issues as new
users accounts have 'All projects' as their default:

- user can't report issues (no link for all projects)
- categories displayed are prefixed with [project]

Until this commit, users had to define their (single) project as default
using preferences to work around the problem; this is no longer needed.

Function html_login_info() now sets the current project as appropriate
if user has only access to a single one, and also defines that as the
default.

The account preferences page has also been modified to only include 'All
projects' in the selection list when user has more than one project
available.

Fixes 0009826, 0014268
Affected Issues
0009826, 0014268, 0016337
mod - account_prefs_inc.php Diff File
mod - core/html_api.php Diff File

master 87c74234

2012-09-09 23:20

dregad


Details Diff
Missing project override in project edit page

This is causing the config_get() calls to return the option for the
default project instead of the one being edited, which is potentially
incorrect.

Fixes 0014701
Affected Issues
0014701
mod - manage_proj_edit_page.php Diff File

master-1.2.x e536cbcd

2012-09-09 23:20

dregad


Details Diff
Missing project override in project edit page

This is causing the config_get() calls to return the option for the
default project instead of the one being edited, which is potentially
incorrect.

Fixes 0014701
Affected Issues
0014701
mod - manage_proj_edit_page.php Diff File

master b6e90223

2012-09-09 21:27

JGuilbaud

Committer: Damien Regad


Details Diff
Hide file upload path on project edit page if storage is DB

The upload_file_path config option is not needed when attachments are
stored in DB, and displaying it is confusing to user.

Fixes 0014700

Original patch updated to comply with coding guidelines

Signed-off-by: Damien Regad <damien.regad@merckgroup.com>
Affected Issues
0014700
mod - manage_proj_edit_page.php Diff File

master-1.2.x 7aa07d86

2012-09-09 21:27

JGuilbaud

Committer: Damien Regad


Details Diff
Hide file upload path on project edit page if storage is DB

The upload_file_path config option is not needed when attachments are
stored in DB, and displaying it is confusing to user.

Fixes 0014700

Original patch updated to comply with coding guidelines

Signed-off-by: Damien Regad <damien.regad@merckgroup.com>
Affected Issues
0014700
mod - manage_proj_edit_page.php Diff File

master-1.2.x 27b4f79f

2012-09-08 00:58

siebrand


Details Diff
Localisation updates from http://translatewiki.net.
mod - lang/strings_czech.txt Diff File
mod - lang/strings_finnish.txt Diff File
mod - lang/strings_french.txt Diff File
mod - lang/strings_japanese.txt Diff File
mod - lang/strings_polish.txt Diff File
mod - lang/strings_tagalog.txt Diff File
mod - lang/strings_vietnamese.txt Diff File

master-1.2.x 6e18aaa7

2012-09-01 00:26

siebrand


Details Diff
Localisation updates from http://translatewiki.net.
mod - lang/strings_arabic.txt Diff File
mod - lang/strings_breton.txt Diff File
mod - lang/strings_french.txt Diff File
mod - lang/strings_galician.txt Diff File
mod - lang/strings_german.txt Diff File
mod - lang/strings_hebrew.txt Diff File
mod - lang/strings_interlingua.txt Diff File
mod - lang/strings_italian.txt Diff File
mod - lang/strings_japanese.txt Diff File
mod - lang/strings_macedonian.txt Diff File
mod - lang/strings_serbian.txt Diff File
mod - lang/strings_serbian_latin.txt Diff File
mod - lang/strings_spanish.txt Diff File
mod - lang/strings_swedish.txt Diff File
mod - lang/strings_tagalog.txt Diff File

master-1.2.x 6a7db340

2012-08-31 03:38

dregad


Details Diff
Fix SQL error when sorting by custom field containing special char

Incorrect behavior is due to unnecessarily escaping of special chars by
calling db_prepare_string() on the custom field's name before attempting
to retrieve it's id with custom_field_get_id_from_name(). This causes a
double-escaping which prevents a match.

Even though this is not strictly necessary to fix the issue at hand,
this commit also replaces db_query() call by db_query_bound() in
custom_field_get_id_from_name().

Fixes 0012170
Affected Issues
0012170, 0015264
mod - core/custom_field_api.php Diff File
mod - core/filter_api.php Diff File

master-1.2.x b5abce1f

2012-08-31 03:37

dregad


Details Diff
Improve comments for custom field length check

Function custom_field_get_id_from_name() contains code to check for
truncated custom fields names. This dates back to when the history
table's field_name column was only 32 chars long, whereas the custom
field's size is 64.

Even though the history's field_name size has been increased to 64 since
1.1.0a4 (see issue 0008002), the check must be maintained to ensure
compatibility with upgraded legacy systems.

The fix ce3450aaabbd9d9feceb03d77d4358f195e7d966 implemented in master
branch cannot be applied here as it contains a schema update. Instead,
comments have been reworded and obsolete reference to old schema
removed.

Fixes 0014650
Affected Issues
0008002, 0014650
mod - core/custom_field_api.php Diff File
mod - core/history_api.php Diff File

master 9344b945

2012-08-31 03:34

dregad


Details Diff
Fix SQL error when sorting by custom field containing special char

Incorrect behavior is due to unnecessarily escaping of special chars by
calling db_prepare_string() on the custom field's name before attempting
to retrieve it's id with custom_field_get_id_from_name(). This causes a
double-escaping which prevents a match.

Even though this is not strictly necessary to fix the issue at hand,
this commit also replaces db_query() call by db_query_bound() in
custom_field_get_id_from_name().

Fixes 0012170
Affected Issues
0012170
mod - core/custom_field_api.php Diff File
mod - core/filter_api.php Diff File

master ce3450aa

2012-08-31 03:17

dregad


Details Diff
Add upgrade step to replace truncated custom field names in history

Function custom_field_get_id_from_name() contained code to check for
truncated custom fields names. This dates back to when the history
table's field_name column was only 32 chars long, whereas the custom
field's size is 64.

The history's field_name size has been increased to 64 since 1.1.0a4
(see issue 0008002), so the check has been removed from the code and
replaced by an upgrade step (calling new install helper function
install_update_history_long_custom_fields(), which converts legacy
history entries storing truncated custom field names by their expanded
full name.

Fixes 0014650
Affected Issues
0008002, 0014650
mod - admin/schema.php Diff File
mod - core/custom_field_api.php Diff File
mod - core/history_api.php Diff File
mod - core/install_helper_functions_api.php Diff File

master-1.2.x df691e9a

2012-08-31 02:58

dregad


Details Diff
Install helper api - new function install_set_log_queries()

The new function is used by install/upgrade callback functions to ensure
that only the relevant queries are logged. This avoids code duplication
in each function.

Backported to admin/install_functions.php from master
mod - admin/install_functions.php Diff File

master 33f3216a

2012-08-31 02:58

dregad


Details Diff
Install helper api - new function install_set_log_queries()

The new function is used by install/upgrade callback functions to ensure
that only the relevant queries are logged. This avoids code duplication
in each function.
mod - core/install_helper_functions_api.php Diff File

master de887844

2012-08-31 02:58

dregad


Details Diff
Whitespace changes
mod - core/custom_field_api.php Diff File

master-1.2.x fe539b00

2012-08-31 02:47

dregad


Details Diff
Add optional param to columns_get_standard() to return all columns

The default behavior is to exclude the fields which are not "active" due
to config settings. The new parameter lets caller override that to
return all standard columns (ie. excluding custom fields).
mod - core/columns_api.php Diff File
 First  Prev  1 2 3 ... 70 ... 140 ... 210 ... 280 ... 343 344 345 346 347 348 349 350 ... 420 ... 490 ... 560 ... 630 ... 700 ... 729 730 731  Next  Last