Source Control Integration

master cfa022bc 2012-09-10 01:56 dregad Details Diff	User with access to single project defaults to it, not all projects Since 1.2, if a user has access to only one project, the project selection box at top right isn't shown. This was causing issues as new users accounts have 'All projects' as their default: - user can't report issues (no link for all projects) - categories displayed are prefixed with [project] Until this commit, users had to define their (single) project as default using preferences to work around the problem; this is no longer needed. Function html_login_info() now sets the current project as appropriate if user has only access to a single one, and also defines that as the default. The account preferences page has also been modified to only include 'All projects' in the selection list when user has more than one project available. Fixes 0009826, 0014268	Affected Issues 0009826, 0014268, 0016337
	mod - account_prefs_inc.php	Diff File
	mod - core/html_api.php	Diff File
master-1.2.x e536cbcd 2012-09-09 23:20 dregad Details Diff	Missing project override in project edit page This is causing the config_get() calls to return the option for the default project instead of the one being edited, which is potentially incorrect. Fixes 0014701	Affected Issues 0014701
	mod - manage_proj_edit_page.php	Diff File
master 87c74234 2012-09-09 23:20 dregad Details Diff	Missing project override in project edit page This is causing the config_get() calls to return the option for the default project instead of the one being edited, which is potentially incorrect. Fixes 0014701	Affected Issues 0014701
	mod - manage_proj_edit_page.php	Diff File
master-1.2.x 7aa07d86 2012-09-09 21:27 JGuilbaud Committer: Damien Regad Details Diff	Hide file upload path on project edit page if storage is DB The upload_file_path config option is not needed when attachments are stored in DB, and displaying it is confusing to user. Fixes 0014700 Original patch updated to comply with coding guidelines Signed-off-by: Damien Regad <damien.regad@merckgroup.com>	Affected Issues 0014700
	mod - manage_proj_edit_page.php	Diff File
master b6e90223 2012-09-09 21:27 JGuilbaud Committer: Damien Regad Details Diff	Hide file upload path on project edit page if storage is DB The upload_file_path config option is not needed when attachments are stored in DB, and displaying it is confusing to user. Fixes 0014700 Original patch updated to comply with coding guidelines Signed-off-by: Damien Regad <damien.regad@merckgroup.com>	Affected Issues 0014700
	mod - manage_proj_edit_page.php	Diff File
master-1.2.x 27b4f79f 2012-09-08 00:58 siebrand Details Diff	Localisation updates from http://translatewiki.net.
	mod - lang/strings_czech.txt	Diff File
	mod - lang/strings_finnish.txt	Diff File
	mod - lang/strings_french.txt	Diff File
	mod - lang/strings_japanese.txt	Diff File
	mod - lang/strings_polish.txt	Diff File
	mod - lang/strings_tagalog.txt	Diff File
	mod - lang/strings_vietnamese.txt	Diff File
master-1.2.x 6e18aaa7 2012-09-01 00:26 siebrand Details Diff	Localisation updates from http://translatewiki.net.
	mod - lang/strings_arabic.txt	Diff File
	mod - lang/strings_breton.txt	Diff File
	mod - lang/strings_french.txt	Diff File
	mod - lang/strings_galician.txt	Diff File
	mod - lang/strings_german.txt	Diff File
	mod - lang/strings_hebrew.txt	Diff File
	mod - lang/strings_interlingua.txt	Diff File
	mod - lang/strings_italian.txt	Diff File
	mod - lang/strings_japanese.txt	Diff File
	mod - lang/strings_macedonian.txt	Diff File
	mod - lang/strings_serbian.txt	Diff File
	mod - lang/strings_serbian_latin.txt	Diff File
	mod - lang/strings_spanish.txt	Diff File
	mod - lang/strings_swedish.txt	Diff File
	mod - lang/strings_tagalog.txt	Diff File
master-1.2.x 6a7db340 2012-08-31 03:38 dregad Details Diff	Fix SQL error when sorting by custom field containing special char Incorrect behavior is due to unnecessarily escaping of special chars by calling db_prepare_string() on the custom field's name before attempting to retrieve it's id with custom_field_get_id_from_name(). This causes a double-escaping which prevents a match. Even though this is not strictly necessary to fix the issue at hand, this commit also replaces db_query() call by db_query_bound() in custom_field_get_id_from_name(). Fixes 0012170	Affected Issues 0012170, 0015264
	mod - core/custom_field_api.php	Diff File
	mod - core/filter_api.php	Diff File
master-1.2.x b5abce1f 2012-08-31 03:37 dregad Details Diff	Improve comments for custom field length check Function custom_field_get_id_from_name() contains code to check for truncated custom fields names. This dates back to when the history table's field_name column was only 32 chars long, whereas the custom field's size is 64. Even though the history's field_name size has been increased to 64 since 1.1.0a4 (see issue 0008002), the check must be maintained to ensure compatibility with upgraded legacy systems. The fix ce3450aaabbd9d9feceb03d77d4358f195e7d966 implemented in master branch cannot be applied here as it contains a schema update. Instead, comments have been reworded and obsolete reference to old schema removed. Fixes 0014650	Affected Issues 0008002, 0014650
	mod - core/custom_field_api.php	Diff File
	mod - core/history_api.php	Diff File
master 9344b945 2012-08-31 03:34 dregad Details Diff	Fix SQL error when sorting by custom field containing special char Incorrect behavior is due to unnecessarily escaping of special chars by calling db_prepare_string() on the custom field's name before attempting to retrieve it's id with custom_field_get_id_from_name(). This causes a double-escaping which prevents a match. Even though this is not strictly necessary to fix the issue at hand, this commit also replaces db_query() call by db_query_bound() in custom_field_get_id_from_name(). Fixes 0012170	Affected Issues 0012170
	mod - core/custom_field_api.php	Diff File
	mod - core/filter_api.php	Diff File
master ce3450aa 2012-08-31 03:17 dregad Details Diff	Add upgrade step to replace truncated custom field names in history Function custom_field_get_id_from_name() contained code to check for truncated custom fields names. This dates back to when the history table's field_name column was only 32 chars long, whereas the custom field's size is 64. The history's field_name size has been increased to 64 since 1.1.0a4 (see issue 0008002), so the check has been removed from the code and replaced by an upgrade step (calling new install helper function install_update_history_long_custom_fields(), which converts legacy history entries storing truncated custom field names by their expanded full name. Fixes 0014650	Affected Issues 0008002, 0014650
	mod - admin/schema.php	Diff File
	mod - core/custom_field_api.php	Diff File
	mod - core/history_api.php	Diff File
	mod - core/install_helper_functions_api.php	Diff File
master 33f3216a 2012-08-31 02:58 dregad Details Diff	Install helper api - new function install_set_log_queries() The new function is used by install/upgrade callback functions to ensure that only the relevant queries are logged. This avoids code duplication in each function.
	mod - core/install_helper_functions_api.php	Diff File
master-1.2.x df691e9a 2012-08-31 02:58 dregad Details Diff	Install helper api - new function install_set_log_queries() The new function is used by install/upgrade callback functions to ensure that only the relevant queries are logged. This avoids code duplication in each function. Backported to admin/install_functions.php from master
	mod - admin/install_functions.php	Diff File
master de887844 2012-08-31 02:58 dregad Details Diff	Whitespace changes
	mod - core/custom_field_api.php	Diff File
master 9f57d943 2012-08-31 02:47 dregad Details Diff	Add optional param to columns_get_standard() to return all columns The default behavior is to exclude the fields which are not "active" due to config settings. The new parameter lets caller override that to return all standard columns (ie. excluding custom fields).
	mod - core/columns_api.php	Diff File
master-1.2.x fe539b00 2012-08-31 02:47 dregad Details Diff	Add optional param to columns_get_standard() to return all columns The default behavior is to exclude the fields which are not "active" due to config settings. The new parameter lets caller override that to return all standard columns (ie. excluding custom fields).
	mod - core/columns_api.php	Diff File
master 6aaf95d0 2012-08-30 23:10 dregad Details Diff	Fix system notice in manage_user_page.php Removed comments left by 93eb540134203400824233fc30ed10385d7c3f98
	mod - manage_user_page.php	Diff File
master 2cf83981 2012-08-30 11:22 rombert Details Diff	Add user_set_fields function Affects 0014673: LDAP login performs unnecessary SQL updates Conflicts: core/user_api.php
	mod - core/user_api.php	Diff File
master bb676ff4 2012-08-30 11:11 rombert Details Diff	ldap_api: use only one SQL call to update user profile Fixes 0014673: LDAP login performs unnecessary SQL updates	Affected Issues 0014673
	mod - core/ldap_api.php	Diff File
master-1.2.x ab63d69a 2012-08-30 11:11 rombert Details Diff	ldap_api: use only one SQL call to update user profile Fixes 0014673: LDAP login performs unnecessary SQL updates	Affected Issues 0014673
	mod - core/ldap_api.php	Diff File
master-1.2.x 9c75204d 2012-08-30 11:08 rombert Details Diff	Add user_set_fields function Affects 0014673: LDAP login performs unnecessary SQL updates
	mod - core/user_api.php	Diff File
master-1.2.x a8f5420c 2012-08-30 07:08 dregad Details Diff	Re-indent complex if statement for better readability
	mod - bug_update.php	Diff File
master-1.2.x a7f9febe 2012-08-30 06:52 dregad Details Diff	Restrict $g_allow_reporter_* to users with reporter access Prior to this, if a user reported an issue and then their access level was downgraded to "viewer", they would no longer be able to add bugnotes to the issue. However, config option $g_allow_reporter_reopen would still let them reopen it, and likewise for $g_allow_reporter_upload to attach files and $g_allow_reporter_close. Fixes 0011782	Affected Issues 0011782
	mod - bug_update.php	Diff File
	mod - core/access_api.php	Diff File
	mod - core/bug_group_action_api.php	Diff File
	mod - core/file_api.php	Diff File
	mod - core/html_api.php	Diff File
master 15062f8f 2012-08-30 02:00 Damien Regad Details Diff	John Lim's reverted changes Code optimization / consistency update by dregad were reverted to original state - e-mail sent to John on 30-Aug-2012 to ask why
	mod - library/adodb/datadict/datadict-postgres.inc.php	Diff File
master c18e3021 2012-08-30 01:54 Damien Regad Details Diff	Revised code and additional fixes from John Lim
	mod - library/adodb/datadict/datadict-postgres.inc.php	Diff File

Changesets: MantisBT