Source Control Integration

master-2.0.x 23812e64 2012-08-18 04:24 Paul Richards Details Diff	remove unused variable
	mod - core/filter_api.php	Diff File
master-2.0.x c28f13cf 2012-08-18 04:18 Paul Richards Details Diff	fix phpdoc types
	mod - core/sponsorship_api.php	Diff File
master-2.0.x 9cb2e085 2012-08-18 04:17 Paul Richards Details Diff	optimise: remove unused count()
	mod - core/classes/MantisEnum.class.php	Diff File
master-2.0.x cf618b6b 2012-08-18 04:17 Paul Richards Details Diff	remove trailing closing php ?> braket
	mod - bug_stick.php	Diff File
master-1.2.x 6e29c1eb 2012-08-17 04:16 dregad Details Diff	Bugnote '~' processing may produce error if bug does not exist This error case is a bit far-fetched, and should normally not occur unless there is some data corruption. If referencing an existing bugnote whose parent bug is not in the database, the callback function cannot retrieve the project_id, so error 403 is triggered. The callback functions have also been reformatted for better readability Fixes 0012580	Affected Issues 0012580
	mod - core/string_api.php	Diff File
master 79fc861e 2012-08-17 04:16 dregad Details Diff	Bugnote '~' processing may produce error if bug does not exist This error case is a bit far-fetched, and should normally not occur unless there is some data corruption. If referencing an existing bugnote whose parent bug is not in the database, the callback function cannot retrieve the project_id, so error 403 is triggered. The callback functions have also been reformatted for better readability Fixes 0012580	Affected Issues 0012580
	mod - core/string_api.php	Diff File
master-1.2.x 83fb71b5 2012-08-16 22:49 dregad Details Diff	Do not skip e-mail validation if $g_login_method != LDAP Prior to this, function email_is_valid() always returned true when $g_use_ldap_email = ON, even if $g_login_method != LDAP. Even though this is not an usual case (when not using LDAP, the other LDAP-related configuration options should be left to their default values), this causes the actual validation to be skipped which could lead to email sending errors. Fixes 0014632	Affected Issues 0014632
	mod - core/email_api.php	Diff File
master 86abb9cc 2012-08-16 22:49 dregad Details Diff	Do not skip e-mail validation if $g_login_method != LDAP Prior to this, function email_is_valid() always returned true when $g_use_ldap_email = ON, even if $g_login_method != LDAP. Even though this is not an usual case (when not using LDAP, the other LDAP-related configuration options should be left to their default values), this causes the actual validation to be skipped which could lead to email sending errors. Fixes 0014632	Affected Issues 0014632
	mod - core/email_api.php	Diff File
master-1.2.x 6987b4ad 2012-08-16 22:41 dregad Details Diff	Fix 0014631: Consistent email validation PHPMailer uses filter_var() to check for an e-mail validity; this function treats single-domain e-mail addresses (e.g. user@localhost) as invalid. However, Mantis API function email_is_valid() relies on a custom regex to validate e-mails, which does accept such addresses. As a consequence, we accept addresses to which we are unable to send messages. To avoid this problem, we now rely on PHPMailer::ValidateAddress() method to ensure that any email we store can be sent PHPMailer.	Affected Issues 0014631
	mod - core/email_api.php	Diff File
master a38858a3 2012-08-16 22:41 dregad Details Diff	Fix 0014631: Consistent email validation PHPMailer uses filter_var() to check for an e-mail validity; this function treats single-domain e-mail addresses (e.g. user@localhost) as invalid. However, Mantis API function email_is_valid() relies on a custom regex to validate e-mails, which does accept such addresses. As a consequence, we accept addresses to which we are unable to send messages. To avoid this problem, we now rely on PHPMailer::ValidateAddress() method to ensure that any email we store can be sent PHPMailer.	Affected Issues 0014631
	mod - core/email_api.php	Diff File
master-1.2.x 4ff0a958 2012-08-16 21:35 dregad Details Diff	Fix 0014630: Improved logging for emails Prior to this, several e-mail related events were not reported at all, making troubleshooting of issues difficult. The following cases are now logged: * sending of queued messages (email_send_all) * errors thrown by PHPMailer * reminder emails (email_bug_reminder) - fixes 0009368 * deletion of records from the email queue In addition, admin/email_queue.php was modified to print a formatted date instead of a numeric timestamp.	Affected Issues 0009368, 0014630
	mod - admin/email_queue.php	Diff File
	mod - core/email_api.php	Diff File
	mod - core/email_queue_api.php	Diff File
master 6e27e969 2012-08-16 21:35 dregad Details Diff	Fix 0014630: Improved logging for emails Prior to this, several e-mail related events were not reported at all, making troubleshooting of issues difficult. The following cases are now logged: * sending of queued messages (email_send_all) * errors thrown by PHPMailer * reminder emails (email_bug_reminder) - fixes 0009368 * deletion of records from the email queue In addition, admin/email_queue.php was modified to print a formatted date instead of a numeric timestamp.	Affected Issues 0009368, 0014630
	mod - admin/email_queue.php	Diff File
	mod - core/email_api.php	Diff File
	mod - core/email_queue_api.php	Diff File
master-1.2.x 8c81d4ca 2012-08-16 04:32 dregad Details Diff	Upgrade PHPMailer from 5.1 to 5.2.1 Version 5.2.1 (January 16, 2012) * Closed several bugs * Performance improvements * MsgHTML() now returns the message as required. * New method: GetSentMIMEMessage() (returns full copy of sent message) Version 5.2 (July 19, 2011) * protected MIME body and header * better DKIM DNS Resource Record support * better aly handling * htmlfilter class added to extras * moved to Apache Extras Fixes 0012562	Affected Issues 0011115, 0012562
	mod - library/README.libs	Diff File
	mod - library/phpmailer/README	Diff File
	mod - library/phpmailer/class.phpmailer.php	Diff File
	mod - library/phpmailer/class.pop3.php	Diff File
	mod - library/phpmailer/class.smtp.php	Diff File
	mod - library/phpmailer/language/phpmailer.lang-br.php	Diff File
	mod - library/phpmailer/language/phpmailer.lang-ca.php	Diff File
	mod - library/phpmailer/language/phpmailer.lang-cz.php	Diff File
	mod - library/phpmailer/language/phpmailer.lang-de.php	Diff File
	mod - library/phpmailer/language/phpmailer.lang-dk.php	Diff File
	mod - library/phpmailer/language/phpmailer.lang-es.php	Diff File
	mod - library/phpmailer/language/phpmailer.lang-fi.php	Diff File
	mod - library/phpmailer/language/phpmailer.lang-fo.php	Diff File
	mod - library/phpmailer/language/phpmailer.lang-fr.php	Diff File
	mod - library/phpmailer/language/phpmailer.lang-hu.php	Diff File
	mod - library/phpmailer/language/phpmailer.lang-it.php	Diff File
	mod - library/phpmailer/language/phpmailer.lang-ja.php	Diff File
	mod - library/phpmailer/language/phpmailer.lang-nl.php	Diff File
	mod - library/phpmailer/language/phpmailer.lang-no.php	Diff File
	mod - library/phpmailer/readme_mantis.txt	Diff File
master a4f644c9 2012-08-16 04:32 dregad Details Diff	Upgrade PHPMailer from 5.1 to 5.2.1 Version 5.2.1 (January 16, 2012) * Closed several bugs * Performance improvements * MsgHTML() now returns the message as required. * New method: GetSentMIMEMessage() (returns full copy of sent message) Version 5.2 (July 19, 2011) * protected MIME body and header * better DKIM DNS Resource Record support * better aly handling * htmlfilter class added to extras * moved to Apache Extras Fixes 0012562	Affected Issues 0011115, 0012562
	mod - library/README.libs	Diff File
	mod - library/phpmailer/README	Diff File
	mod - library/phpmailer/class.phpmailer.php	Diff File
	mod - library/phpmailer/class.pop3.php	Diff File
	mod - library/phpmailer/class.smtp.php	Diff File
	mod - library/phpmailer/readme_mantis.txt	Diff File
master 3b4ea93d 2012-08-15 19:56 dregad Details Diff	Maintain old behavior for default gravatar icons This is a follow up commit for 06b7b96f19834e30d5beaaa2dcb97e4e7f49a28e that ensures installations using $g_show_avatar = ON maintain the same behavior as before. In other words, setting the config to ON is equivalent to 'identicon'. Fixes 0014032	Affected Issues 0014032
	mod - config_defaults_inc.php	Diff File
	mod - core/user_api.php	Diff File
	mod - docbook/Admin_Guide/en-US/Configuration.xml	Diff File
master-1.2.x fd20db77 2012-08-15 19:56 dregad Details Diff	Maintain old behavior for default gravatar icons This is a follow up commit for f710546a49e67cc6d014c46013269415b46a181e that ensures installations using $g_show_avatar = ON maintain the same behavior as before. In other words, setting the config to ON is equivalent to 'identicon'. Fixes 0014032	Affected Issues 0014032
	mod - config_defaults_inc.php	Diff File
	mod - core/user_api.php	Diff File
	mod - docbook/administration_guide/en/configuration.sgml	Diff File
master-1.2.x f710546a 2012-08-15 01:32 dregad Details Diff	Allow custom default avatar icons Following implementation of 0013992, it was no longer possible for administrators to define a custom default avatar, as Mantis forced use of Gravatar's 'identicon'. This commit reintroduces that functionality, and allows use of either one of Gravatar's default images or a custom one (identified by an URL), through appropriate configuration of $g_show_avatar. Fixes 0014032	Affected Issues 0014032
	mod - config_defaults_inc.php	Diff File
	mod - core/print_api.php	Diff File
	mod - core/user_api.php	Diff File
	mod - docbook/administration_guide/en/configuration.sgml	Diff File
master 06b7b96f 2012-08-15 01:32 dregad Details Diff	Allow custom default avatar icons Following implementation of 0013992, it was no longer possible for administrators to define a custom default avatar, as Mantis forced use of Gravatar's 'identicon'. This commit reintroduces that functionality, and allows use of either one of Gravatar's default images or a custom one (identified by an URL), through appropriate configuration of $g_show_avatar. Fixes 0014032	Affected Issues 0014032
	mod - config_defaults_inc.php	Diff File
	mod - core/print_api.php	Diff File
	mod - core/user_api.php	Diff File
	mod - docbook/Admin_Guide/en-US/Configuration.xml	Diff File
master-2.0.x ac184b16 2012-08-14 12:02 Paul Richards Details Diff	remove a bunch of unused variables
	mod - core/custom_field_api.php	Diff File
	mod - core/database_api.php	Diff File
	mod - core/file_api.php	Diff File
	mod - core/helper_api.php	Diff File
	mod - core/install_helper_functions_api.php	Diff File
	mod - core/ldap_api.php	Diff File
	mod - core/news_api.php	Diff File
	mod - core/print_api.php	Diff File
	mod - core/relationship_api.php	Diff File
	mod - core/version_api.php	Diff File
	mod - manage/config_email_page.php	Diff File
	mod - manage/config_workflow_page.php	Diff File
master-2.0.x c8751848 2012-08-14 11:39 Paul Richards Details Diff	remove null assigment left over from removal of db_date functionality
	mod - bug_report.php	Diff File
master-2.0.x 6e1f87aa 2012-08-14 11:36 Paul Richards Details Diff	Fix - missing echo statement in error message
	mod - core/filter_api.php	Diff File
master-2.0.x 1cd45e38 2012-08-14 11:26 Paul Richards Details Diff	correct MantisBT capitalisation
	mod - account_manage_columns_page.php	Diff File
master-2.0.x 8b2f3db1 2012-08-14 11:21 Paul Richards Details Diff	use config variable where appropriate instead of hard coding for hyperlink
	mod - my_view_inc.php	Diff File
master-2.0.x 79271123 2012-08-14 11:20 Paul Richards Details Diff	add obsoleted variable
	mod - core/obsolete.php	Diff File
master-2.0.x 326bc81a 2012-08-14 11:20 Paul Richards Details Diff	initial start at re-organising config defaults
	mod - config_defaults_inc.php	Diff File

Changesets: MantisBT